)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2aeafe4800aae9e438a9405dba621ae8b8472239","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1556b37d_0a5c0b60","updated":"2023-06-08 09:49:06.000000000","message":"I guess you don\u0027t have to touch template files for cinder-volume and manila-share, because these are not deployed in cell controllers","commit_id":"0fd3b843180828fcc4ee4c4016d335a2693d7503"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6e88a97245a7f6a768516fc9f420c53d1379a5a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"80c0e329_64db9beb","updated":"2023-06-09 13:05:41.000000000","message":"Previous comments have note been addressed. Storage services should not be included because they are not deployed on CellController nodes.","commit_id":"4c1a6e62ad460df86e1a899dce39eb7aba779884"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d0de919f632e807e403317fd7a293a764631472a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51010a87_da32f512","updated":"2023-06-12 11:49:13.000000000","message":"...and oslo_messaging_notify_cell_node_names on the puppet side also?","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3b0d03d6b5fd04589523c57c885b4019b968ece6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9445ce72_c11aafaf","updated":"2023-06-12 11:48:37.000000000","message":"comparing this to the similar puppet logic https://codesearch.opendev.org/?q\u003doslo_messaging_rpc_cell_node_names\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d\n\nAre we missing the similar fix for the neutron service(s)?\nAnd do we miss the galera part of the proposed changes on the puppet side as well?","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"8caee9d8d96498fc6011f3adb16e2ef0f7de955f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e3096d5d_dd617942","updated":"2023-06-12 17:12:56.000000000","message":"recheck","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1032fdc6a25c11b591b7e0d2ab0aff14c65e1232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae161f86_7dbe06c3","in_reply_to":"51010a87_da32f512","updated":"2023-06-12 12:00:21.000000000","message":"please disregard the neutron service concern, we don\u0027t have to provide special treatments for nova and neutron in regard of oslo_messaging_rpc_cell_node_names, because in t-h-t it is covered in its dedicated rabbitmq-messaging-* services.\n\nBut the concerns galera, and notifications (missing on the puppet side?), and for cinder (not needed here) remain","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6b6fca412710e4e2ab7ed510625186d7eb88429e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f13d8c7e_1a698b98","updated":"2023-06-18 04:35:34.000000000","message":"lgtm from a storage perspective, though I\u0027m only voting +1 because the patch doesn\u0027t actually touch storage templates. I can up my vote to +2 if that\u0027s required to move things along, just let me know.","commit_id":"e6044fea398f30840c8193eaf1117b5bf7f3d950"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"2cef9e52c07c1e12ec299824756cde584603fed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"820afe62_76659c94","updated":"2023-06-29 08:31:27.000000000","message":"recheck timeout","commit_id":"e6044fea398f30840c8193eaf1117b5bf7f3d950"}],"deployment/cinder/cinder-backup-pacemaker-puppet.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2231f951651fde6cf499e2d2123a5557a096c04f","unresolved":true,"context_lines":[{"line_number":353,"context_line":"            - name: set cinder_backup upgrade node facts in a single-node environment"},{"line_number":354,"context_line":"              set_fact:"},{"line_number":355,"context_line":"                cinder_backup_short_node_names_upgraded: \"{{ cinder_backup_short_node_names }}\""},{"line_number":356,"context_line":"                cinder_backup_node_names_upgraded: \"{{ cinder_backup_node_names if nova_additional_cell \u003d\u003d false else cinder_backup_cell_node_names }}\""},{"line_number":357,"context_line":"                cacheable: no"},{"line_number":358,"context_line":"              when: groups[\u0027cinder_backup\u0027] | length \u003c\u003d 1"},{"line_number":359,"context_line":"            - name: set cinder_backup upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bea6d6fd_fbd46b43","line":356,"updated":"2023-06-08 13:32:33.000000000","message":"It\u0027s not clear to me how nova cells has anything to do with storage services like cinder-backup. Do nova cells affect everything running on Controller nodes?\n\nThis patch touches the pcmk THT for cinder-backup and manila-share. If these templates need to be updated, then what about the cinder-volume service\u0027s pcmk template?\n\nUPDATE: \n\nI just read Takashi\u0027s comment, and what he said about nova cell controllers tsuggests that none of the 3 storage services should be affected (cinder-backup, cinder-volume, manila-share).\n\nYou can see the services aren\u0027t listed in role/CellController.yaml","commit_id":"0fd3b843180828fcc4ee4c4016d335a2693d7503"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f8a4a6002c9b85485cc09c1a784c018ae8611523","unresolved":true,"context_lines":[{"line_number":353,"context_line":"            - name: set cinder_backup upgrade node facts in a single-node environment"},{"line_number":354,"context_line":"              set_fact:"},{"line_number":355,"context_line":"                cinder_backup_short_node_names_upgraded: \"{{ cinder_backup_short_node_names }}\""},{"line_number":356,"context_line":"                cinder_backup_node_names_upgraded: \"{{ cinder_backup_node_names if nova_additional_cell \u003d\u003d false else cinder_backup_cell_node_names }}\""},{"line_number":357,"context_line":"                cacheable: no"},{"line_number":358,"context_line":"              when: groups[\u0027cinder_backup\u0027] | length \u003c\u003d 1"},{"line_number":359,"context_line":"            - name: set cinder_backup upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d0cbb576_fabe5c88","line":356,"in_reply_to":"9bd080cc_deb35b03","updated":"2023-06-15 11:26:53.000000000","message":"Thanks! @Juan, so the cinder part of this change is not needed, apparently. How was it blocking FFU in the first place?","commit_id":"0fd3b843180828fcc4ee4c4016d335a2693d7503"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"646cc5fbf62fab0c340ade2235d42e223fa1e754","unresolved":true,"context_lines":[{"line_number":353,"context_line":"            - name: set cinder_backup upgrade node facts in a single-node environment"},{"line_number":354,"context_line":"              set_fact:"},{"line_number":355,"context_line":"                cinder_backup_short_node_names_upgraded: \"{{ cinder_backup_short_node_names }}\""},{"line_number":356,"context_line":"                cinder_backup_node_names_upgraded: \"{{ cinder_backup_node_names if nova_additional_cell \u003d\u003d false else cinder_backup_cell_node_names }}\""},{"line_number":357,"context_line":"                cacheable: no"},{"line_number":358,"context_line":"              when: groups[\u0027cinder_backup\u0027] | length \u003c\u003d 1"},{"line_number":359,"context_line":"            - name: set cinder_backup upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee43f80a_7d5d0887","line":356,"in_reply_to":"bea6d6fd_fbd46b43","updated":"2023-06-12 12:01:21.000000000","message":"@John, WDYT?","commit_id":"0fd3b843180828fcc4ee4c4016d335a2693d7503"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"b61d439e8f8dc2ffa6d044d78d9623e911173832","unresolved":true,"context_lines":[{"line_number":353,"context_line":"            - name: set cinder_backup upgrade node facts in a single-node environment"},{"line_number":354,"context_line":"              set_fact:"},{"line_number":355,"context_line":"                cinder_backup_short_node_names_upgraded: \"{{ cinder_backup_short_node_names }}\""},{"line_number":356,"context_line":"                cinder_backup_node_names_upgraded: \"{{ cinder_backup_node_names if nova_additional_cell \u003d\u003d false else cinder_backup_cell_node_names }}\""},{"line_number":357,"context_line":"                cacheable: no"},{"line_number":358,"context_line":"              when: groups[\u0027cinder_backup\u0027] | length \u003c\u003d 1"},{"line_number":359,"context_line":"            - name: set cinder_backup upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fe3dc2e_d2a08838","line":356,"in_reply_to":"d0cbb576_fabe5c88","updated":"2023-06-15 14:14:48.000000000","message":"I certainly don\u0027t want to block things if somehow the storage services are affected by this issue on FFU. If they are, then I don\u0027t understand why cinder-backup would be affected but not cinder-volume (which also runs under pcmk). If one cinder service is affected then I would expect both to the affected. But if storage services are not impacting FFU, and it\u0027s OK to remove them from this patch, then I would expect manila-share could also be removed.","commit_id":"0fd3b843180828fcc4ee4c4016d335a2693d7503"},{"author":{"_account_id":18002,"name":"John Fulton","email":"fulton@redhat.com","username":"fultonj"},"change_message_id":"cdcdb6729bb3c4c69c11016119523680e53464f5","unresolved":true,"context_lines":[{"line_number":353,"context_line":"            - name: set cinder_backup upgrade node facts in a single-node environment"},{"line_number":354,"context_line":"              set_fact:"},{"line_number":355,"context_line":"                cinder_backup_short_node_names_upgraded: \"{{ cinder_backup_short_node_names }}\""},{"line_number":356,"context_line":"                cinder_backup_node_names_upgraded: \"{{ cinder_backup_node_names if nova_additional_cell \u003d\u003d false else cinder_backup_cell_node_names }}\""},{"line_number":357,"context_line":"                cacheable: no"},{"line_number":358,"context_line":"              when: groups[\u0027cinder_backup\u0027] | length \u003c\u003d 1"},{"line_number":359,"context_line":"            - name: set cinder_backup upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9bd080cc_deb35b03","line":356,"in_reply_to":"ee43f80a_7d5d0887","updated":"2023-06-13 21:37:28.000000000","message":"I think Alan raises a valid point.","commit_id":"0fd3b843180828fcc4ee4c4016d335a2693d7503"}],"deployment/database/mysql-pacemaker-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"754148cbdecce18e22aafb17eec8fbca8b20a3f9","unresolved":true,"context_lines":[{"line_number":601,"context_line":"            - cluster_recreate|bool"},{"line_number":602,"context_line":"          block:"},{"line_number":603,"context_line":"            - set_fact:"},{"line_number":604,"context_line":"                mysql_node_names_list: \"{{ mysql_node_names if nova_additional_cell \u003d\u003d false else mysql_cell_node_names }}\""},{"line_number":605,"context_line":"            - name: set mysql upgrade node facts in a single-node environment"},{"line_number":606,"context_line":"              set_fact:"},{"line_number":607,"context_line":"                mysql_short_node_names_upgraded: \"{{ mysql_short_node_names }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d3366e70_798dc326","line":604,"updated":"2023-06-12 11:44:14.000000000","message":"nit: if nova_additional_cell|bool","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"cc04593645b92b32ae6797ea60d174c0a5787b8f","unresolved":true,"context_lines":[{"line_number":601,"context_line":"            - cluster_recreate|bool"},{"line_number":602,"context_line":"          block:"},{"line_number":603,"context_line":"            - set_fact:"},{"line_number":604,"context_line":"                mysql_node_names_list: \"{{ mysql_node_names if nova_additional_cell \u003d\u003d false else mysql_cell_node_names }}\""},{"line_number":605,"context_line":"            - name: set mysql upgrade node facts in a single-node environment"},{"line_number":606,"context_line":"              set_fact:"},{"line_number":607,"context_line":"                mysql_short_node_names_upgraded: \"{{ mysql_short_node_names }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"68b88734_4553d303","line":604,"in_reply_to":"d3366e70_798dc326","updated":"2023-06-21 09:20:13.000000000","message":"perhaps better:\n\n  mysql_node_names_list: \"{{ (nova_additional_cell | bool) | ternary(mysql_cell_node_names, mysql_node_names) }}\"","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"}],"deployment/rabbitmq/rabbitmq-messaging-notify-pacemaker-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a1255840cbeee634cab596a811e1c4e306e6c2bc","unresolved":true,"context_lines":[{"line_number":430,"context_line":"            - name: set oslo_messaging_notify upgrade node facts in a single-node environment"},{"line_number":431,"context_line":"              set_fact:"},{"line_number":432,"context_line":"                oslo_messaging_notify_short_node_names_upgraded: \"{{ oslo_messaging_notify_short_node_names }}\""},{"line_number":433,"context_line":"                oslo_messaging_notify_node_names_upgraded: \"{{ oslo_messaging_notify_node_names if nova_additional_cell \u003d\u003d false else oslo_messaging_notify_cell_node_names }}\""},{"line_number":434,"context_line":"                cacheable: no"},{"line_number":435,"context_line":"              when: groups[\u0027oslo_messaging_notify\u0027] | length \u003c\u003d 1"},{"line_number":436,"context_line":"            - name: set oslo_messaging_notify upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"80d8b778_21253a7e","line":433,"updated":"2023-06-12 12:05:12.000000000","message":"so, this logic seems missing on the puppet side of the things [0]\n\n[0] https://codesearch.opendev.org/?q\u003d_cell_node_names\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c5c28443044003f46c56c2f83373de6edbf07b6f","unresolved":false,"context_lines":[{"line_number":430,"context_line":"            - name: set oslo_messaging_notify upgrade node facts in a single-node environment"},{"line_number":431,"context_line":"              set_fact:"},{"line_number":432,"context_line":"                oslo_messaging_notify_short_node_names_upgraded: \"{{ oslo_messaging_notify_short_node_names }}\""},{"line_number":433,"context_line":"                oslo_messaging_notify_node_names_upgraded: \"{{ oslo_messaging_notify_node_names if nova_additional_cell \u003d\u003d false else oslo_messaging_notify_cell_node_names }}\""},{"line_number":434,"context_line":"                cacheable: no"},{"line_number":435,"context_line":"              when: groups[\u0027oslo_messaging_notify\u0027] | length \u003c\u003d 1"},{"line_number":436,"context_line":"            - name: set oslo_messaging_notify upgrade node facts from the limit option"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e9a45715_f9b6b34c","line":433,"in_reply_to":"80d8b778_21253a7e","updated":"2023-06-15 11:27:47.000000000","message":"this alothough should be a subject of future changes, if required","commit_id":"401f696a65f99f4ce6c17d2dc7f9e7c970a2d974"}]}