)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2612c9350926912e2581fc242df37c0cddb1bd0d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[Train Only] Run glance cron only when glance cache is enabled."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance db purge was added after train, so without glance cache, the"},{"line_number":10,"context_line":"glance cron has nothing to execute and just fail at start."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2024555"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8c1e4b1d_e63078d1","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":57},"updated":"2023-06-27 01:25:17.000000000","message":"my understanding is that cron can start, but only healthcheck fails, but that would not be a big problem here.","commit_id":"3758df618bfe9d4d3824f3f37b698c46ae6e2933"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"9495e15b6565582d09fb4dd1030a504a75644990","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[Train Only] Run glance cron only when glance cache is enabled."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Glance db purge was added after train, so without glance cache, the"},{"line_number":10,"context_line":"glance cron has nothing to execute and just fail at start."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2024555"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"70649bb0_4f6b868b","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":57},"in_reply_to":"8c1e4b1d_e63078d1","updated":"2023-07-13 09:02:19.000000000","message":"Not sure what\u0027s the idea here.  Eventually we have a failed service, so removing that failure seems like the right thing to do, no ?","commit_id":"3758df618bfe9d4d3824f3f37b698c46ae6e2933"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"33b8bda4c4d6921c3972d55380e608d3ed030c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d374eba8_0a49cc5e","updated":"2023-06-23 18:58:49.000000000","message":"I verified this in a local env:\n\n1. Deployed stock train THT and reproduced the problem (glance_api_cron container is running, but with no cron jobs)\n2. Applied this patch, performed stack update and confirmed the glance_api_cron container has been removed\n3. Enabled glance cache (GlanceCacheEnabled: true), stack update, confirmed the glance_api_cron container is running again, with proper cron jobs defined:\n\n[root@standalone ~]# podman exec -ti glance_api_cron cat /var/spool/cron/glance\n# HEADER: This file was autogenerated at 2023-06-23 18:45:15 +0000 by puppet.\n# HEADER: While it can still be managed manually, it is definitely not recommended.\n# HEADER: Note particularly that the comments starting with \u0027Puppet Name\u0027 should\n# HEADER: not be deleted, as doing so could cause duplicate cron jobs.\n# Puppet Name: glance-cache-cleaner\nPATH\u003d/bin:/usr/bin:/usr/sbin\n1 0 * * * glance-cache-cleaner\n# Puppet Name: glance-cache-pruner\nPATH\u003d/bin:/usr/bin:/usr/sbin\n*/30 * * * * glance-cache-pruner","commit_id":"3758df618bfe9d4d3824f3f37b698c46ae6e2933"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"fbee549fc41831f9254d55fd41f864a5eb8361d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"30207347_254a6693","updated":"2023-06-23 19:38:36.000000000","message":"Verified in a job for change  https://review.opendev.org/c/openstack/tripleo-upgrade/+/763247 with depends-on pointing to this change. No glance api cron in systemctl output after deployment with cache disabled. https://zuul.opendev.org/t/openstack/build/ca316e67f2f04cf789da17511f514b55/log/logs/undercloud/var/log/extra/systemctl-tripleo-before_ovn_controller_update.txt","commit_id":"3758df618bfe9d4d3824f3f37b698c46ae6e2933"}]}