)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"93ad2b6ea07de0d61066e100e35f4d59566c90c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0aa2bfdc_ab1c8e04","updated":"2023-09-19 08:41:43.000000000","message":"Handful of adjustments could be made to improve the code quality.\nOtherwise I see this as an important adjustment to the existing procedure.","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"}],"container_config_scripts/monitoring/collectd_check_health.py":[{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"93ad2b6ea07de0d61066e100e35f4d59566c90c5","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    o, e \u003d proc.communicate()"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        if packaging.version.parse(o.decode().strip()) \u003e\u003d packaging.version.parse(\"4.0.0\"):"},{"line_number":65,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Healthcheck.Status}\""},{"line_number":68,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e35c528_643999f5","line":65,"updated":"2023-09-19 08:41:43.000000000","message":"This is masking a builtin function.[0] Please choose a different name.\n\n[0]https://docs.python.org/3.8/library/functions.html?highlight\u003dformat#format","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"c6500f6e1df0871687eaa880e16205cd89f8f2c6","unresolved":true,"context_lines":[{"line_number":62,"context_line":"    o, e \u003d proc.communicate()"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        if packaging.version.parse(o.decode().strip()) \u003e\u003d packaging.version.parse(\"4.0.0\"):"},{"line_number":65,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Healthcheck.Status}\""},{"line_number":68,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"e3436279_efce6a96","line":65,"in_reply_to":"2e35c528_643999f5","updated":"2023-09-19 08:49:50.000000000","message":"Ok, fair enough. Will chan","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"12e5a8c7abceeade86b86d5e355b3af2e1520449","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    o, e \u003d proc.communicate()"},{"line_number":63,"context_line":"    try:"},{"line_number":64,"context_line":"        if packaging.version.parse(o.decode().strip()) \u003e\u003d packaging.version.parse(\"4.0.0\"):"},{"line_number":65,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Healthcheck.Status}\""},{"line_number":68,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fef3e457_180d543e","line":65,"in_reply_to":"e3436279_efce6a96","updated":"2023-09-19 09:07:04.000000000","message":"Done","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"93ad2b6ea07de0d61066e100e35f4d59566c90c5","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Healthcheck.Status}\""},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # keep podman-4.0.0+ format in case of version decoding error"},{"line_number":70,"context_line":"        format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1625a7bb_be8634c5","line":68,"updated":"2023-09-19 08:41:43.000000000","message":"Perhaps this should only catch `InvalidVersion`? Since that\u0027s the one that should be raised if there is a decoding error. We should really try catch only the most specific error.\n\nhttps://packaging.pypa.io/en/stable/version.html#packaging.version.parse","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"c6500f6e1df0871687eaa880e16205cd89f8f2c6","unresolved":true,"context_lines":[{"line_number":65,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Healthcheck.Status}\""},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # keep podman-4.0.0+ format in case of version decoding error"},{"line_number":70,"context_line":"        format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa510aa_33a7d5a3","line":68,"in_reply_to":"1625a7bb_be8634c5","updated":"2023-09-19 08:49:50.000000000","message":"This is not catching only invalid version, but also decoding errors. Basically this is a failover for cases when anything fails.","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"},{"author":{"_account_id":32926,"name":"Jiri Podivin","display_name":"jpodivin","email":"jpodivin@redhat.com","username":"jpodivin"},"change_message_id":"c58682bc084e0f2e8999d096651a6a0ebb3547bf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            format \u003d BASE_FORMAT + \"healthy: .State.Healthcheck.Status}\""},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # keep podman-4.0.0+ format in case of version decoding error"},{"line_number":70,"context_line":"        format \u003d BASE_FORMAT + \"healthy: .State.Health.Status}\""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"392bac24_7908858a","line":68,"in_reply_to":"3fa510aa_33a7d5a3","updated":"2023-09-19 09:12:03.000000000","message":"Ack","commit_id":"6af219ccf0bb4d6999fd9d1f317e1a762695ed17"}]}