)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"6c289c74fcd54e7659618078ebcee0418281eb35","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Golovatiuk \u003csgolovat@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-31 20:58:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run podman login after podman install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Perform podman login after podman install"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: rhbz#2235621"},{"line_number":12,"context_line":"Change-Id: Iecc8fcb2d1cfe44cc3aa5892e07947f5e33668f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b17ef00c_3630e3b1","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":41},"updated":"2023-09-01 08:29:23.000000000","message":"This does a whole lot more than that!\n\nA good commit message tells us, in summary, both what and why. If you can provide a short summary of what the current problem is and how this solves it then it makes reviewers lives easier (they don\u0027t have to trawl through a BZ) and it also maintains a history (in git) that lives into the future (even if BZ dies).","commit_id":"0f665e761af3b96fd0604056d7728086fb7efed5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"d155d47454ff5e6fd869804521f95fdf9b7a86b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Golovatiuk \u003csgolovat@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-31 20:58:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run podman login after podman install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Perform podman login after podman install"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: rhbz#2235621"},{"line_number":12,"context_line":"Change-Id: Iecc8fcb2d1cfe44cc3aa5892e07947f5e33668f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e46cd4c9_d3e1020c","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":41},"in_reply_to":"060e4c7d_5d666801","updated":"2023-09-04 10:43:34.000000000","message":"Done","commit_id":"0f665e761af3b96fd0604056d7728086fb7efed5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3636a553fd91ce1d1be55573a580f5e58b19bf00","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergii Golovatiuk \u003csgolovat@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-08-31 20:58:26 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Run podman login after podman install"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Perform podman login after podman install"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: rhbz#2235621"},{"line_number":12,"context_line":"Change-Id: Iecc8fcb2d1cfe44cc3aa5892e07947f5e33668f9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"060e4c7d_5d666801","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":41},"in_reply_to":"b17ef00c_3630e3b1","updated":"2023-09-04 10:39:46.000000000","message":"done","commit_id":"0f665e761af3b96fd0604056d7728086fb7efed5"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"78efc823ba2ca10a50d985616786ac2331ce9741","unresolved":true,"context_lines":[{"line_number":20,"context_line":"  shell: \"{{ tripleo_container_cli }} pull {{ tripleo_container_image }}\""},{"line_number":21,"context_line":"  when:"},{"line_number":22,"context_line":"    - tripleo_container_pull_image | bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from tripleo ansible tripleo_container_tag role. It does pull without"},{"line_number":25,"context_line":"authentication. It doesn\u0027t fail in deployment as deployment tasks do"},{"line_number":26,"context_line":"\"podman login\" beforehand."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"0564bdf0_2d2f2b83","line":23,"updated":"2023-09-08 11:18:42.000000000","message":"FTR, Arx said\n\u003e because we dump the variables, and one of those is the commit message, it\u0027s assuming that {{ }} is a jinja template","commit_id":"60811bd76d2a747dfb95b69cacded1fc7c7cdb6b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"222cfa9dea0cbbecfafdd08a79b07d147bc45088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d87ee004_3fd2abb1","updated":"2023-09-01 14:51:49.000000000","message":"I see the following in https://rhos-ci-staging-jenkins.lab.eng.tlv2.redhat.com/view/DFG/view/upgrades/view/ffu/job/DFG-upgrades-ffu-17.1-9.2-passed_phase2-from-16.2-rhel-8.4-passed_phase2-3cont_3hci-ipv4-ovs_dvr_full_holser/4/\n\n\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.055955 | 52540002-3182-56ac-4072-000000000b35 |     TIMING | Run podman login | computehci-1 | 0:01:21.691831 | 0.05s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.146106 | 52540002-3182-56ac-4072-0000000016d1 |       TASK | Perform container registry login(s) with podman\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.167813 | 52540002-3182-56ac-4072-0000000016d1 |       TASK | Perform container registry login(s) with podman\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.192459 | 52540002-3182-56ac-4072-000000000ec9 |       TASK | Enable podman.socket service\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.203909 | 52540002-3182-56ac-4072-0000000013d4 |     TIMING | tripleo_upgrade_hiera : ensure tripleo-upgrade hiera file exists | controller-1 | 0:01:21.839735 | 0.17s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.206487 | 52540002-3182-56ac-4072-0000000016d1 |     TIMING | tripleo_podman : Perform container registry login(s) with podman | computehci-0 | 0:01:21.842361 | 0.06s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.208110 | 52540002-3182-56ac-4072-000000001464 |         OK | create the directory for hiera file | controller-2\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.209522 | 52540002-3182-56ac-4072-000000001464 |     TIMING | tripleo_upgrade_hiera : create the directory for hiera file | controller-2 | 0:01:21.845395 | 0.31s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.210945 | 52540002-3182-56ac-4072-0000000016d1 |     TIMING | tripleo_podman : Perform container registry login(s) with podman | computehci-1 | 0:01:21.846821 | 0.04s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.232747 | cc6ecab7-be74-462c-a0ac-6f16548529a3 |   INCLUDED | /usr/share/ansible/roles/tripleo_upgrade_hiera/tasks/create-tripleo-upgrade-file.yml | controller-1\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.257146 | 52540002-3182-56ac-4072-000000000b37 |       TASK | Stop snmp service\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.277035 | 52540002-3182-56ac-4072-000000000b37 |       TASK | Stop snmp service\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.305764 | 52540002-3182-56ac-4072-0000000017de |       TASK | create the directory for hiera file\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.334163 | 52540002-3182-56ac-4072-000000001465 |       TASK | check if the upgrade file exists.\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.345576 | 52540002-3182-56ac-4072-000000000ec9 |    SKIPPED | Enable podman.socket service | computehci-2\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.348306 | 52540002-3182-56ac-4072-000000000ec9 |     TIMING | tripleo_podman : Enable podman.socket service | computehci-2 | 0:01:21.984138 | 0.15s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.372497 | 52540002-3182-56ac-4072-000000000b35 |       TASK | Run podman login\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.407943 | 52540002-3182-56ac-4072-000000000b35 |     TIMING | Run podman login | computehci-2 | 0:01:22.043802 | 0.03s\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.468491 | 52540002-3182-56ac-4072-0000000016d1 |       TASK | Perform container registry login(s) with podman\n2023-09-01 14:30:51 | 2023-09-01 14:30:51.503466 | 52540002-3182-56ac-4072-0000000016d1 |     TIMING | tripleo_podman : Perform container registry login(s) with podman | computehci-2 | 0:01:22.139317 | 0.03s\n\nSo Run podman login happened","commit_id":"0f665e761af3b96fd0604056d7728086fb7efed5"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3636a553fd91ce1d1be55573a580f5e58b19bf00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2dbcc77e_2837e3ee","updated":"2023-09-04 10:39:46.000000000","message":"recheck","commit_id":"22d1d6fdf9e778173a84d8f96585d0c4a3c76a78"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"4136a6773f3c6b22e8f007bd5cb2f657199779e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7148e6dd_26c0e9e8","updated":"2023-09-04 17:06:30.000000000","message":"recheck","commit_id":"7684d3cf725b3217f4381541d8c86764952bef01"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"856bf8e688e835fde2d9b68348df4b063aeade2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f6810f24_0a30342f","updated":"2023-09-08 09:20:50.000000000","message":"recheck","commit_id":"f64568a034435f8a913a4a153572d8ad05951305"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"106261a88635d497b3c8009c27226a1833a7feb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4bfb97ff_07b64002","updated":"2023-09-08 12:34:54.000000000","message":"recheck","commit_id":"b50855069da925a48400688257f2d2cedf6593e4"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"dd038f3548c662619595727f98a11c9a3b07e371","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7c39e615_2a458a77","updated":"2023-09-08 12:34:53.000000000","message":"recheck","commit_id":"b50855069da925a48400688257f2d2cedf6593e4"}],"deployment/podman/podman-baremetal-ansible.yaml":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"24b5cc216e1ec83dba6049f8fa595a8487576208","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                dest: /etc/hosts"},{"line_number":192,"context_line":"                line: \"{{ undercloud_hosts_entries | join(\u0027\u0027) }}\""},{"line_number":193,"context_line":"                state: present"},{"line_number":194,"context_line":"        - name: Run podman install"},{"line_number":195,"context_line":"          when:"},{"line_number":196,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":197,"context_line":"          block: *install_and_configure_podman"},{"line_number":198,"context_line":"        - name: system_upgrade_prepare step 2"},{"line_number":199,"context_line":"          tags:"},{"line_number":200,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"88843546_a58e2535","line":197,"range":{"start_line":194,"start_character":0,"end_line":197,"end_character":46},"updated":"2023-09-01 15:32:44.000000000","message":"This is changing when it\u0027s run - is that intentional?\n\nThe previous tasks were run during step 1 because they were part of the conditional block. This change takes them out of the conditional block. IIUC this means that they will run during *all* steps?","commit_id":"22d1d6fdf9e778173a84d8f96585d0c4a3c76a78"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"04244aa206d8e555e7e1cbe8d2efeb766cd2685b","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                dest: /etc/hosts"},{"line_number":192,"context_line":"                line: \"{{ undercloud_hosts_entries | join(\u0027\u0027) }}\""},{"line_number":193,"context_line":"                state: present"},{"line_number":194,"context_line":"        - name: Run podman install"},{"line_number":195,"context_line":"          when:"},{"line_number":196,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":197,"context_line":"          block: *install_and_configure_podman"},{"line_number":198,"context_line":"        - name: system_upgrade_prepare step 2"},{"line_number":199,"context_line":"          tags:"},{"line_number":200,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f17656fa_55f9bb9a","line":197,"range":{"start_line":194,"start_character":0,"end_line":197,"end_character":46},"in_reply_to":"635001f3_81c53c95","updated":"2023-09-04 10:42:59.000000000","message":"overcloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/Controller/upgrade_tasks_step1.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/Controller/upgrade_tasks.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/Controller/host_prep_tasks.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/ComputeHCI/upgrade_tasks_step1.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/ComputeHCI/upgrade_tasks.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/ComputeHCI/host_prep_tasks.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/ComputeHCIRHEL8/upgrade_tasks_step1.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/ComputeHCIRHEL8/upgrade_tasks.yaml\novercloud-deploy/qe-Cloud-0/config-download/qe-Cloud-0/ComputeHCIRHEL8/host_prep_tasks.yaml\n\nI don\u0027t see that task is added to step2 or later","commit_id":"22d1d6fdf9e778173a84d8f96585d0c4a3c76a78"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"3636a553fd91ce1d1be55573a580f5e58b19bf00","unresolved":true,"context_lines":[{"line_number":191,"context_line":"                dest: /etc/hosts"},{"line_number":192,"context_line":"                line: \"{{ undercloud_hosts_entries | join(\u0027\u0027) }}\""},{"line_number":193,"context_line":"                state: present"},{"line_number":194,"context_line":"        - name: Run podman install"},{"line_number":195,"context_line":"          when:"},{"line_number":196,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":197,"context_line":"          block: *install_and_configure_podman"},{"line_number":198,"context_line":"        - name: system_upgrade_prepare step 2"},{"line_number":199,"context_line":"          tags:"},{"line_number":200,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"635001f3_81c53c95","line":197,"range":{"start_line":194,"start_character":0,"end_line":197,"end_character":46},"in_reply_to":"88843546_a58e2535","updated":"2023-09-04 10:39:46.000000000","message":"As far as I can see the block is still under step 1.","commit_id":"22d1d6fdf9e778173a84d8f96585d0c4a3c76a78"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"d155d47454ff5e6fd869804521f95fdf9b7a86b4","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                dest: /etc/hosts"},{"line_number":192,"context_line":"                line: \"{{ undercloud_hosts_entries | join(\u0027\u0027) }}\""},{"line_number":193,"context_line":"                state: present"},{"line_number":194,"context_line":"        - name: Run podman install"},{"line_number":195,"context_line":"          when:"},{"line_number":196,"context_line":"            - step|int \u003d\u003d 1"},{"line_number":197,"context_line":"          block: *install_and_configure_podman"},{"line_number":198,"context_line":"        - name: system_upgrade_prepare step 2"},{"line_number":199,"context_line":"          tags:"},{"line_number":200,"context_line":"            - never"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"36e2523c_fc75b73b","line":197,"range":{"start_line":194,"start_character":0,"end_line":197,"end_character":46},"in_reply_to":"f17656fa_55f9bb9a","updated":"2023-09-04 10:43:34.000000000","message":"Ack","commit_id":"22d1d6fdf9e778173a84d8f96585d0c4a3c76a78"}]}