)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"81a984f4b628f13ee82b846470bc0db4422976f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bb96b82f_838c19c3","updated":"2023-09-13 07:04:20.000000000","message":"recheck","commit_id":"26e46d86b33d4ae08e204f71752fbad019fd4526"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"79e7d4860e484e825ba7057f93c664b409e87104","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cbfb9f09_68e4d4ec","updated":"2023-09-12 13:39:16.000000000","message":"recheck","commit_id":"26e46d86b33d4ae08e204f71752fbad019fd4526"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"96182b19c74f9862bf1e447e9f33709b10209fde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4bf55039_b9ba32a2","updated":"2023-10-04 07:01:16.000000000","message":"recheck","commit_id":"d1eb856eb8c68367c2fc2760916f633808023383"},{"author":{"_account_id":22954,"name":"Juan Badia Payno","email":"jbadiapa@redhat.com","username":"jbadiapa"},"change_message_id":"dcc81106d2593175757ca72062f8cc19397c0d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0399cce7_4ac51546","updated":"2023-10-09 10:12:28.000000000","message":"recheck","commit_id":"92636e1aea2793aaa0f1ce74bece5ba02bc65842"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"d529fcc72c307d5a6e9da3ad6e7bb407e105639b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"926c3bea_278df09e","updated":"2023-10-05 12:57:29.000000000","message":"recheck","commit_id":"92636e1aea2793aaa0f1ce74bece5ba02bc65842"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"53ff481aae2d6e331702d0de38f52186cb947630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b7d0ae30_6f4de0c4","updated":"2023-10-20 10:47:57.000000000","message":"Please check when conditional in line https://review.opendev.org/c/openstack/tripleo-heat-templates/+/893919/13/deployment/nova/nova-modular-libvirt-container-puppet.yaml#1054","commit_id":"45cb4a45e8de8c1fc6451994a3d43ab9e00a03b8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f5c114182d61c70b64a302826883c4716e9dd0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7da08635_6974ad6f","updated":"2023-10-25 11:43:44.000000000","message":"Beside the regex_escape question, this LGTM. The list_concat one is certainly just for my own education.","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"62060436ff7e28b4f4da5673f5801c43e6f74cc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d900f0d8_620d6746","updated":"2023-10-25 12:55:49.000000000","message":"the escape mechanism for \"/\" in image\u0027s name could be the same on both file (|regex_escape on one and \"|\" on the other) with a favor of the regex_escape one. So if one more iteration is needed somehow that would be nice to include it.\n\nBeside this, no blocker.","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"}],"deployment/deprecated/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f5c114182d61c70b64a302826883c4716e9dd0a","unresolved":true,"context_lines":[{"line_number":966,"context_line":"                network: {get_param: [ServiceNetMap, NovaLibvirtNetwork]}"},{"line_number":967,"context_line":"                type: node"},{"line_number":968,"context_line":"      upgrade_tasks:"},{"line_number":969,"context_line":"        list_concat:"},{"line_number":970,"context_line":"          - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":971,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":972,"context_line":"              block: \u0026nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"61195e9e_102520a0","line":969,"range":{"start_line":969,"start_character":8,"end_line":969,"end_character":19},"updated":"2023-10-25 11:43:44.000000000","message":"Why list_concat here ?","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"}],"deployment/nova/nova-modular-libvirt-container-puppet.yaml":[{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"53ff481aae2d6e331702d0de38f52186cb947630","unresolved":true,"context_lines":[{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1057,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"07c97ea0_2f1ecc1a","line":1054,"range":{"start_line":1054,"start_character":26,"end_line":1054,"end_character":44},"updated":"2023-10-20 10:47:57.000000000","message":"Shouldn\u0027t it  be old_virtlogd_image.stdout !\u003d virtlogd_image as in sed command above","commit_id":"45cb4a45e8de8c1fc6451994a3d43ab9e00a03b8"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"d42c8bb6a55c46e44a140296b1d5c2f49317855f","unresolved":false,"context_lines":[{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1057,"context_line":"          when: step|int \u003d\u003d 1"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"e0ff1eed_f475fd6c","line":1054,"range":{"start_line":1054,"start_character":26,"end_line":1054,"end_character":44},"in_reply_to":"07c97ea0_2f1ecc1a","updated":"2023-10-23 09:48:56.000000000","message":"Done","commit_id":"45cb4a45e8de8c1fc6451994a3d43ab9e00a03b8"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f5c114182d61c70b64a302826883c4716e9dd0a","unresolved":true,"context_lines":[{"line_number":1050,"context_line":"                    register: old_virtlogd_image"},{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7b5202aa_c2121c5a","line":1053,"range":{"start_line":1053,"start_character":84,"end_line":1053,"end_character":85},"updated":"2023-10-25 11:43:44.000000000","message":"And there ?","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"0f5c114182d61c70b64a302826883c4716e9dd0a","unresolved":true,"context_lines":[{"line_number":1050,"context_line":"                    register: old_virtlogd_image"},{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8d80662d_f6a94bee","line":1053,"range":{"start_line":1053,"start_character":63,"end_line":1053,"end_character":64},"updated":"2023-10-25 11:43:44.000000000","message":"Missing \"| regex_escape()\" here ?","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"3ab9ee3079df6ec56f5f90549965c83faa9815a0","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                    register: old_virtlogd_image"},{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"694aeed6_1e69527c","line":1053,"range":{"start_line":1053,"start_character":84,"end_line":1053,"end_character":85},"in_reply_to":"7b5202aa_c2121c5a","updated":"2023-10-25 12:42:19.000000000","message":"Done","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"3ab9ee3079df6ec56f5f90549965c83faa9815a0","unresolved":true,"context_lines":[{"line_number":1050,"context_line":"                    register: old_virtlogd_image"},{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dcb6acda_24817265","line":1053,"range":{"start_line":1053,"start_character":63,"end_line":1053,"end_character":64},"in_reply_to":"8d80662d_f6a94bee","updated":"2023-10-25 12:42:19.000000000","message":"solved by using | instead of / do you thinkg regex_escape is still needed?","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"62060436ff7e28b4f4da5673f5801c43e6f74cc9","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                    register: old_virtlogd_image"},{"line_number":1051,"context_line":"                  - name: Switch running image to new image in wrapper script"},{"line_number":1052,"context_line":"                    shell: |"},{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - name: nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"58975a81_09e109dc","line":1053,"range":{"start_line":1053,"start_character":63,"end_line":1053,"end_character":64},"in_reply_to":"dcb6acda_24817265","updated":"2023-10-25 12:55:49.000000000","message":"yeah, that certainly would work until we get \"|\" in the images\u0027 name.  Never going to happen, right. Anyway not a blocker I guess.","commit_id":"e103a57404ec111f7c4d7a2cbb3f8d6942435084"}],"deployment/undercloud/.undercloud-upgrade.yaml.swp":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"ceb3a341cf52417c94923fdca72e701e7fb1bc9a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"933582a8_af84ad8d","side":"PARENT","updated":"2023-09-06 13:45:47.000000000","message":"Please remove this file","commit_id":"5bf77a85ba90d27886bd8dab3f76abcea116400d"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"6480bcf53918b7c42cfaa3896588bd95247f8715","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31dca954_d0c29182","side":"PARENT","in_reply_to":"933582a8_af84ad8d","updated":"2023-10-25 10:39:49.000000000","message":"Done","commit_id":"5bf77a85ba90d27886bd8dab3f76abcea116400d"}]}