)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"731293ba9473e6faf8500bb439caf02d06321782","unresolved":true,"context_lines":[{"line_number":10,"context_line":"leapp inhibits in check_nfs actor. Unfortunately we cannot remove actor"},{"line_number":11,"context_line":"or disable it (at least for now). We introduce mounts at step5 which"},{"line_number":12,"context_line":"comes after leapp upgrade as post system upgrade tasks."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: rhbz#2237743"},{"line_number":15,"context_line":"Change-Id: I6deab809c88639cc00cd6497dec462ca667c636b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"81333aa2_db75f919","line":13,"updated":"2023-09-15 11:13:11.000000000","message":"Could you add  Co-Authored-By: Oliver Walsh \u003cowalsh@redhat.com\u003e please?","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[{"line_number":10,"context_line":"leapp inhibits in check_nfs actor. Unfortunately we cannot remove actor"},{"line_number":11,"context_line":"or disable it (at least for now). We introduce mounts at step5 which"},{"line_number":12,"context_line":"comes after leapp upgrade as post system upgrade tasks."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: rhbz#2237743"},{"line_number":15,"context_line":"Change-Id: I6deab809c88639cc00cd6497dec462ca667c636b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba60737c_946bc62c","line":13,"in_reply_to":"81333aa2_db75f919","updated":"2023-09-15 11:22:20.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"402b0591f0304776cb71b3a2cef49d410626c90e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"52961d48_18b365c9","updated":"2023-09-15 09:23:47.000000000","message":"I had already pushed changes - https://review.opendev.org/c/openstack/tripleo-heat-templates/+/894938/4..5\nNeed a lot more than just glance.","commit_id":"f906926f8d44d146eebb020d477a9ce6671ce795"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"854335298dd31f0466937e2e6acaa3356663a810","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f163bee3_ea4162df","in_reply_to":"52961d48_18b365c9","updated":"2023-09-15 11:32:36.000000000","message":"Done","commit_id":"f906926f8d44d146eebb020d477a9ce6671ce795"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d89ce823_309f9be7","updated":"2023-09-15 11:22:20.000000000","message":"-W while I test this","commit_id":"d061d192b74884f58a4e42d941a667ce8f118753"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"06d4ea086e25f72a51cb31262561176f87611267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a768466e_ccbba4ea","updated":"2023-09-19 13:15:13.000000000","message":"I can approve this if everyone\u0027s happy with their test results.","commit_id":"1efdcde888d03c198e918e7bf0ac8c75499ed47e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3df6bcb70be4c87e0da56c0cd092351e99796be9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1a4be159_ba074de5","updated":"2023-09-15 15:30:43.000000000","message":"I\u0027m very glad to read the results of (presumably manual) tests. The patch looks good, but I\u0027ll be much more encouraged to upvote if I see positive test results. It\u0027s a complex scenario, and I\u0027m not in a position to do my own tests.","commit_id":"1efdcde888d03c198e918e7bf0ac8c75499ed47e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"466f874829d3ebb48da6361fe20abc444e1c28f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1f1a901d_44ff98d2","updated":"2023-09-15 15:26:19.000000000","message":"Works for glance nfs at least:\nPLAY [Upgrade tasks for step 3] ************************************************\n[WARNING]: conditional statements should not include jinja2 templating\ndelimiters such as {{ }} or {% %}. Found: \u0027{{ playbook_dir }}/{{\n_task_file_path }}\u0027 is exists\n2023-09-15 14:19:37.384273 | 0a580a82-00b3-f550-64d7-00000000002a |     TIMING | include_tasks | controller-1 | 0:00:24.602075 | 0.04s\n2023-09-15 14:19:37.466776 | 84f3f34f-af2a-48e3-bb07-28f0b16b8dfc |   INCLUDED | /home/cloud-admin/work/nbbhd4h686h599h94h55fh56dh6ch5b9h64fh69h78h656h8bh67ch5h5bbh66chb7h574h584h5hc5h5bdh544h557h68fh567h686h98h94h66cq/playbooks/tripleo-ansible/Controller/upgrade_tasks_step3.yaml | controller-1\n2023-09-15 14:19:37.491500 | 0a580a82-00b3-f550-64d7-000000000269 |       TASK | fix grub entries to have name start with GRUB_\n2023-09-15 14:19:37.916425 | 0a580a82-00b3-f550-64d7-000000000269 |         OK | fix grub entries to have name start with GRUB_ | controller-1\n2023-09-15 14:19:37.917330 | 0a580a82-00b3-f550-64d7-000000000269 |     TIMING | fix grub entries to have name start with GRUB_ | controller-1 | 0:00:25.135127 | 0.43s\n2023-09-15 14:19:37.927401 | 0a580a82-00b3-f550-64d7-00000000026a |       TASK | fix grub entries in append statement\n2023-09-15 14:19:38.229093 | 0a580a82-00b3-f550-64d7-00000000026a |         OK | fix grub entries in append statement | controller-1\n2023-09-15 14:19:38.229738 | 0a580a82-00b3-f550-64d7-00000000026a |     TIMING | fix grub entries in append statement | controller-1 | 0:00:25.447546 | 0.30s\n2023-09-15 14:19:38.238656 | 0a580a82-00b3-f550-64d7-000000000272 |       TASK | Unmount and remove NFS glance entry\n2023-09-15 14:19:38.777801 | 0a580a82-00b3-f550-64d7-000000000272 |    CHANGED | Unmount and remove NFS glance entry | controller-1\n2023-09-15 14:19:38.778524 | 0a580a82-00b3-f550-64d7-000000000272 |     TIMING | Unmount and remove NFS glance entry | controller-1 | 0:00:25.996330 | 0.54s\n2023-09-15 14:19:38.785225 | 0a580a82-00b3-f550-64d7-000000000273 |       TASK | Unmount and remove NFS glance-staging entry\n2023-09-15 14:19:38.827350 | 0a580a82-00b3-f550-64d7-000000000273 |    SKIPPED | Unmount and remove NFS glance-staging entry | controller-1\n2023-09-15 14:19:38.827722 | 0a580a82-00b3-f550-64d7-000000000273 |     TIMING | Unmount and remove NFS glance-staging entry | controller-1 | 0:00:26.045537 | 0.04s\n...\n...\n2023-09-15 14:30:07.930603 | 0a580a82-00b3-f550-64d7-000000000320 |       TASK | reboot to perform the upgrade\n2023-09-15 14:41:10.679934 | 0a580a82-00b3-f550-64d7-000000000320 |    CHANGED | reboot to perform the upgrade | controller-1\n2023-09-15 14:41:10.681034 | 0a580a82-00b3-f550-64d7-000000000320 |     TIMING | reboot to perform the upgrade | controller-1 | 0:21:57.898837 | 662.75s\n\nPLAY [Upgrade tasks for step 5] ************************************************\n[WARNING]: conditional statements should not include jinja2 templating\ndelimiters such as {{ }} or {% %}. Found: \u0027{{ playbook_dir }}/{{\n_task_file_path }}\u0027 is exists\n2023-09-15 14:41:10.763065 | 0a580a82-00b3-f550-64d7-000000000030 |     TIMING | include_tasks | controller-1 | 0:21:57.980868 | 0.04s\n2023-09-15 14:41:10.800599 | b751f41b-89a0-42d7-bcc0-3a17774ba27b |   INCLUDED | /home/cloud-admin/work/nbbhd4h686h599h94h55fh56dh6ch5b9h64fh69h78h656h8bh67ch5h5bbh66chb7h574h584h5hc5h5bdh544h557h68fh567h686h98h94h66cq/playbooks/tripleo-ansible/Controller/upgrade_tasks_step5.yaml | controller-1\n2023-09-15 14:41:10.813964 | 0a580a82-00b3-f550-64d7-000000000373 |       TASK | Mount NFS on host\n2023-09-15 14:41:11.576917 | 0a580a82-00b3-f550-64d7-000000000373 |    CHANGED | Mount NFS on host | controller-1\n2023-09-15 14:41:11.577307 | 0a580a82-00b3-f550-64d7-000000000373 |     TIMING | Mount NFS on host | controller-1 | 0:21:58.795123 | 0.76s\n2023-09-15 14:41:11.583132 | 0a580a82-00b3-f550-64d7-000000000374 |       TASK | Mount Node Staging Location\n2023-09-15 14:41:11.616746 | 0a580a82-00b3-f550-64d7-000000000374 |    SKIPPED | Mount Node Staging Location | controller-1\n2023-09-15 14:41:11.617052 | 0a580a82-00b3-f550-64d7-000000000374 |     TIMING | Mount Node Staging Location | controller-1 | 0:21:58.834872 | 0.03s","commit_id":"1efdcde888d03c198e918e7bf0ac8c75499ed47e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"b51958ce652906f031dd44b8eb5068ad0b210b45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9aa1020c_3ab28c87","updated":"2023-09-21 11:19:43.000000000","message":"recheck","commit_id":"1efdcde888d03c198e918e7bf0ac8c75499ed47e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"9191585e8fa6ac0b974a3c3635029eb8233a5c36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ab1390cf_ae275f59","in_reply_to":"1a4be159_ba074de5","updated":"2023-09-19 14:48:42.000000000","message":"It\u0027s automated, default OSPdO FFU env uses NFS as the Glance backend. Doesn\u0027t cover Cinder or Nova though.","commit_id":"1efdcde888d03c198e918e7bf0ac8c75499ed47e"}],"deployment/cinder/cinder-common-container-puppet.yaml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"615b5d4eb50bf4310c0c3bdb07a17943cf6f6ff1","unresolved":true,"context_lines":[{"line_number":367,"context_line":"      tags:"},{"line_number":368,"context_line":"        - never"},{"line_number":369,"context_line":"        - system_upgrade"},{"line_number":370,"context_line":"        - system_upgrade_prepare"},{"line_number":371,"context_line":"        - system_upgrade_nfsmounts"},{"line_number":372,"context_line":"      when:"},{"line_number":373,"context_line":"        - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"823b326e_6fd96ff9","line":370,"updated":"2023-09-15 11:12:10.000000000","message":"should be system_upgrade_run. in that case it will be removed just before leapp upgrade. It\u0027s way short period than between operators execution of \"openstack overcloud upgrade prepare\" and \"openstack overcloud upgrade run\"","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[{"line_number":367,"context_line":"      tags:"},{"line_number":368,"context_line":"        - never"},{"line_number":369,"context_line":"        - system_upgrade"},{"line_number":370,"context_line":"        - system_upgrade_prepare"},{"line_number":371,"context_line":"        - system_upgrade_nfsmounts"},{"line_number":372,"context_line":"      when:"},{"line_number":373,"context_line":"        - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"990c5aba_a7bb65f6","line":370,"in_reply_to":"823b326e_6fd96ff9","updated":"2023-09-15 11:22:20.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"615b5d4eb50bf4310c0c3bdb07a17943cf6f6ff1","unresolved":true,"context_lines":[{"line_number":370,"context_line":"        - system_upgrade_prepare"},{"line_number":371,"context_line":"        - system_upgrade_nfsmounts"},{"line_number":372,"context_line":"      when:"},{"line_number":373,"context_line":"        - step|int \u003d\u003d 4"},{"line_number":374,"context_line":"        - upgrade_leapp_enabled"},{"line_number":375,"context_line":"      block:"},{"line_number":376,"context_line":"        - name: Unmount cinder\u0027s image conversion NFS share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d2ae2cac_3e3523b9","line":373,"updated":"2023-09-15 11:12:10.000000000","message":"should be step_3 of system_upgrade_run","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[{"line_number":370,"context_line":"        - system_upgrade_prepare"},{"line_number":371,"context_line":"        - system_upgrade_nfsmounts"},{"line_number":372,"context_line":"      when:"},{"line_number":373,"context_line":"        - step|int \u003d\u003d 4"},{"line_number":374,"context_line":"        - upgrade_leapp_enabled"},{"line_number":375,"context_line":"      block:"},{"line_number":376,"context_line":"        - name: Unmount cinder\u0027s image conversion NFS share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ebe2f940_75d7d06d","line":373,"in_reply_to":"d2ae2cac_3e3523b9","updated":"2023-09-15 11:22:20.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"}],"deployment/glance/glance-api-container-puppet.yaml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"9f7fbe3c39652b3463be83d28c6c86269701a002","unresolved":true,"context_lines":[{"line_number":902,"context_line":"          tags:"},{"line_number":903,"context_line":"            - never"},{"line_number":904,"context_line":"            - system_upgrade"},{"line_number":905,"context_line":"            - system_upgrade_prepare"},{"line_number":906,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":907,"context_line":"          when:"},{"line_number":908,"context_line":"            - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f5ecbd6a_fd055b34","line":905,"updated":"2023-09-15 11:11:15.000000000","message":"should be system_upgrade_run. in that case it will be removed just before leapp upgrade. It\u0027s way short period than between operators execution of \"openstack overcloud upgrade prepare\" and \"openstack overcloud upgrade run\"","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[{"line_number":902,"context_line":"          tags:"},{"line_number":903,"context_line":"            - never"},{"line_number":904,"context_line":"            - system_upgrade"},{"line_number":905,"context_line":"            - system_upgrade_prepare"},{"line_number":906,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":907,"context_line":"          when:"},{"line_number":908,"context_line":"            - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"0fbf7f1c_df990f84","line":905,"in_reply_to":"f5ecbd6a_fd055b34","updated":"2023-09-15 11:22:20.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"157c74fc2dbe1d7d77167831d402a7ad298c2d82","unresolved":true,"context_lines":[{"line_number":906,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":907,"context_line":"          when:"},{"line_number":908,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":909,"context_line":"            - upgrade_leapp_enabled"},{"line_number":910,"context_line":"          block:"},{"line_number":911,"context_line":"            - name: Unmount and remove NFS glance entry"},{"line_number":912,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e271fac4_2867118b","line":909,"updated":"2023-09-15 11:06:29.000000000","message":"let\u0027s use step 3","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"854335298dd31f0466937e2e6acaa3356663a810","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":907,"context_line":"          when:"},{"line_number":908,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":909,"context_line":"            - upgrade_leapp_enabled"},{"line_number":910,"context_line":"          block:"},{"line_number":911,"context_line":"            - name: Unmount and remove NFS glance entry"},{"line_number":912,"context_line":"              vars:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6c6be44a_1e22edbf","line":909,"in_reply_to":"e271fac4_2867118b","updated":"2023-09-15 11:32:36.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"}],"deployment/gnocchi/gnocchi-api-container-puppet.yaml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"9f7fbe3c39652b3463be83d28c6c86269701a002","unresolved":true,"context_lines":[{"line_number":473,"context_line":"          tags:"},{"line_number":474,"context_line":"            - never"},{"line_number":475,"context_line":"            - system_upgrade"},{"line_number":476,"context_line":"            - system_upgrade_prepare"},{"line_number":477,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":478,"context_line":"          when:"},{"line_number":479,"context_line":"            - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4c2487af_898abddc","line":476,"updated":"2023-09-15 11:11:15.000000000","message":"should be system_upgrade_run. in that case it will be removed just before leapp upgrade. It\u0027s way short period than between operators execution of \"openstack overcloud upgrade prepare\" and \"openstack overcloud upgrade run\"","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[{"line_number":473,"context_line":"          tags:"},{"line_number":474,"context_line":"            - never"},{"line_number":475,"context_line":"            - system_upgrade"},{"line_number":476,"context_line":"            - system_upgrade_prepare"},{"line_number":477,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":478,"context_line":"          when:"},{"line_number":479,"context_line":"            - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"e3d491a7_427a844c","line":476,"in_reply_to":"4c2487af_898abddc","updated":"2023-09-15 11:22:20.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"157c74fc2dbe1d7d77167831d402a7ad298c2d82","unresolved":true,"context_lines":[{"line_number":476,"context_line":"            - system_upgrade_prepare"},{"line_number":477,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":478,"context_line":"          when:"},{"line_number":479,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":480,"context_line":"            - upgrade_leapp_enabled"},{"line_number":481,"context_line":"          block:"},{"line_number":482,"context_line":"            - name: Unmount Gnocchi NFS share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"79b3cc2d_8b43c420","line":479,"updated":"2023-09-15 11:06:29.000000000","message":"let\u0027s use step 3","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"854335298dd31f0466937e2e6acaa3356663a810","unresolved":false,"context_lines":[{"line_number":476,"context_line":"            - system_upgrade_prepare"},{"line_number":477,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":478,"context_line":"          when:"},{"line_number":479,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":480,"context_line":"            - upgrade_leapp_enabled"},{"line_number":481,"context_line":"          block:"},{"line_number":482,"context_line":"            - name: Unmount Gnocchi NFS share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f71cf4c7_2494cc02","line":479,"in_reply_to":"79b3cc2d_8b43c420","updated":"2023-09-15 11:32:36.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"157c74fc2dbe1d7d77167831d402a7ad298c2d82","unresolved":true,"context_lines":[{"line_number":1735,"context_line":"            state: removed"},{"line_number":1736,"context_line":"          failed_when: false"},{"line_number":1737,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":1738,"context_line":"        - name: system_upgrade_prepare step 4 remove nova-compute nfs mounts"},{"line_number":1739,"context_line":"          tags:"},{"line_number":1740,"context_line":"            - never"},{"line_number":1741,"context_line":"            - system_upgrade"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9d404273_dcb6fea2","line":1738,"updated":"2023-09-15 11:06:29.000000000","message":"nova-compute pre system_upgrade tasks sounds better. WDYT?","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"854335298dd31f0466937e2e6acaa3356663a810","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"            state: removed"},{"line_number":1736,"context_line":"          failed_when: false"},{"line_number":1737,"context_line":"          when: step|int \u003d\u003d 2"},{"line_number":1738,"context_line":"        - name: system_upgrade_prepare step 4 remove nova-compute nfs mounts"},{"line_number":1739,"context_line":"          tags:"},{"line_number":1740,"context_line":"            - never"},{"line_number":1741,"context_line":"            - system_upgrade"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f6bcdec_0b6903f3","line":1738,"in_reply_to":"9d404273_dcb6fea2","updated":"2023-09-15 11:32:36.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"9f7fbe3c39652b3463be83d28c6c86269701a002","unresolved":true,"context_lines":[{"line_number":1739,"context_line":"          tags:"},{"line_number":1740,"context_line":"            - never"},{"line_number":1741,"context_line":"            - system_upgrade"},{"line_number":1742,"context_line":"            - system_upgrade_prepare"},{"line_number":1743,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":1744,"context_line":"          when:"},{"line_number":1745,"context_line":"            - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"c41d434c_98c79014","line":1742,"updated":"2023-09-15 11:11:15.000000000","message":"should be system_upgrade_run. in that case it will be removed just before leapp upgrade. It\u0027s way short period than between operators execution of \"openstack overcloud upgrade prepare\" and \"openstack overcloud upgrade run\"","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a9eb753cb3c61ce6ad195808ac1387dc868ec017","unresolved":false,"context_lines":[{"line_number":1739,"context_line":"          tags:"},{"line_number":1740,"context_line":"            - never"},{"line_number":1741,"context_line":"            - system_upgrade"},{"line_number":1742,"context_line":"            - system_upgrade_prepare"},{"line_number":1743,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":1744,"context_line":"          when:"},{"line_number":1745,"context_line":"            - step|int \u003d\u003d 4"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5244370d_dbeddfa7","line":1742,"in_reply_to":"c41d434c_98c79014","updated":"2023-09-15 11:22:20.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"157c74fc2dbe1d7d77167831d402a7ad298c2d82","unresolved":true,"context_lines":[{"line_number":1742,"context_line":"            - system_upgrade_prepare"},{"line_number":1743,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":1744,"context_line":"          when:"},{"line_number":1745,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":1746,"context_line":"            - upgrade_leapp_enabled"},{"line_number":1747,"context_line":"          block:"},{"line_number":1748,"context_line":"            - name: Unmount Nova NFS Share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8b13d0ed_7b822d5c","line":1745,"updated":"2023-09-15 11:06:29.000000000","message":"let\u0027s use step 3","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"854335298dd31f0466937e2e6acaa3356663a810","unresolved":false,"context_lines":[{"line_number":1742,"context_line":"            - system_upgrade_prepare"},{"line_number":1743,"context_line":"            - system_upgrade_nfsmounts"},{"line_number":1744,"context_line":"          when:"},{"line_number":1745,"context_line":"            - step|int \u003d\u003d 4"},{"line_number":1746,"context_line":"            - upgrade_leapp_enabled"},{"line_number":1747,"context_line":"          block:"},{"line_number":1748,"context_line":"            - name: Unmount Nova NFS Share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a216639f_9af93a03","line":1745,"in_reply_to":"8b13d0ed_7b822d5c","updated":"2023-09-15 11:32:36.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"157c74fc2dbe1d7d77167831d402a7ad298c2d82","unresolved":true,"context_lines":[{"line_number":1753,"context_line":"                state: absent"},{"line_number":1754,"context_line":"                fstype: nfs4"},{"line_number":1755,"context_line":"              when: nfs_backend_enable|bool"},{"line_number":1756,"context_line":"        - name: system_upgrade_run step 5 nova-compute system upgrade firstboot tasks"},{"line_number":1757,"context_line":"          tags:"},{"line_number":1758,"context_line":"            - never"},{"line_number":1759,"context_line":"            - system_upgrade"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"92530619_3261b1ff","line":1756,"updated":"2023-09-15 11:06:29.000000000","message":"nova-compute post system_upgrade tasks sounds better. WDYT?","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"854335298dd31f0466937e2e6acaa3356663a810","unresolved":false,"context_lines":[{"line_number":1753,"context_line":"                state: absent"},{"line_number":1754,"context_line":"                fstype: nfs4"},{"line_number":1755,"context_line":"              when: nfs_backend_enable|bool"},{"line_number":1756,"context_line":"        - name: system_upgrade_run step 5 nova-compute system upgrade firstboot tasks"},{"line_number":1757,"context_line":"          tags:"},{"line_number":1758,"context_line":"            - never"},{"line_number":1759,"context_line":"            - system_upgrade"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"f1c65f8a_ef50c60e","line":1756,"in_reply_to":"92530619_3261b1ff","updated":"2023-09-15 11:32:36.000000000","message":"Done","commit_id":"e8e60c235e386232bb089d8b3b4aa2fa174aef0e"}],"deployment/tripleo-packages/tripleo-packages-baremetal-puppet.yaml":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0cb6f7b581f9fe730314a749edbcc7bfdcc43a48","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    description: \u003e"},{"line_number":37,"context_line":"      URI that specifies the staging location to use when importing images"},{"line_number":38,"context_line":"    type: string"},{"line_number":39,"context_line":"  GlanceNfsEnabled:"},{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"    description: \u003e"},{"line_number":42,"context_line":"      When using GlanceBackend \u0027file\u0027, mount NFS share for image storage."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"36a0f667_6b7091de","line":39,"updated":"2023-09-13 16:37:05.000000000","message":"missing type","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c0432e49b606f68ea536f73d32fafb8d5a7929a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    description: \u003e"},{"line_number":37,"context_line":"      URI that specifies the staging location to use when importing images"},{"line_number":38,"context_line":"    type: string"},{"line_number":39,"context_line":"  GlanceNfsEnabled:"},{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"    description: \u003e"},{"line_number":42,"context_line":"      When using GlanceBackend \u0027file\u0027, mount NFS share for image storage."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1da918eb_94e5ddbf","line":39,"in_reply_to":"36a0f667_6b7091de","updated":"2023-09-14 15:02:05.000000000","message":"Done","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"d0b0597940de9d3bf01f881a66c9eb1a1e0ca667","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    description: \u003e"},{"line_number":37,"context_line":"      URI that specifies the staging location to use when importing images"},{"line_number":38,"context_line":"    type: string"},{"line_number":39,"context_line":"  GlanceNfsEnabled:"},{"line_number":40,"context_line":"    default: false"},{"line_number":41,"context_line":"    description: \u003e"},{"line_number":42,"context_line":"      When using GlanceBackend \u0027file\u0027, mount NFS share for image storage."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93467ff9_61ac3366","line":39,"in_reply_to":"36a0f667_6b7091de","updated":"2023-09-14 17:12:06.000000000","message":"fixed in next PR. Thanks","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"002aefff9ad0db67a22f9909026c928bfa2bc42a","unresolved":true,"context_lines":[{"line_number":418,"context_line":"                test_command: \u003e-"},{"line_number":419,"context_line":"                  source /etc/os-release; [ \"${VERSION_ID%.*}\" -ge \"8\" ] \u0026\u0026 systemctl is-system-running | grep -qE \"running|degraded\" || exit 1"},{"line_number":420,"context_line":"                post_reboot_delay: \"{{ upgrade_leapp_post_reboot_delay }}\""},{"line_number":421,"context_line":"            - name: Mount NFS on host"},{"line_number":422,"context_line":"              vars:"},{"line_number":423,"context_line":"                nfs_backend_enabled: {get_param: GlanceNfsEnabled}"},{"line_number":424,"context_line":"                glance_netapp_nfs_enabled: {get_param: GlanceNetappNfsEnabled}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d2c1a102_367d4725","line":421,"updated":"2023-09-13 17:38:52.000000000","message":"won\u0027t this run on all hosts, not just the controllers?","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c0432e49b606f68ea536f73d32fafb8d5a7929a7","unresolved":false,"context_lines":[{"line_number":418,"context_line":"                test_command: \u003e-"},{"line_number":419,"context_line":"                  source /etc/os-release; [ \"${VERSION_ID%.*}\" -ge \"8\" ] \u0026\u0026 systemctl is-system-running | grep -qE \"running|degraded\" || exit 1"},{"line_number":420,"context_line":"                post_reboot_delay: \"{{ upgrade_leapp_post_reboot_delay }}\""},{"line_number":421,"context_line":"            - name: Mount NFS on host"},{"line_number":422,"context_line":"              vars:"},{"line_number":423,"context_line":"                nfs_backend_enabled: {get_param: GlanceNfsEnabled}"},{"line_number":424,"context_line":"                glance_netapp_nfs_enabled: {get_param: GlanceNetappNfsEnabled}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"471be671_74b26e54","line":421,"in_reply_to":"d2c1a102_367d4725","updated":"2023-09-14 15:02:05.000000000","message":"Done","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"002aefff9ad0db67a22f9909026c928bfa2bc42a","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                nfs_share: \"{{ glance_nfs_share if (glance_nfs_share) else netapp_share_location }}\""},{"line_number":428,"context_line":"                nfs_options: {get_param: GlanceNfsOptions}"},{"line_number":429,"context_line":"              mount:"},{"line_number":430,"context_line":"                name: /var/lib/glance/images"},{"line_number":431,"context_line":"                state: mounted"},{"line_number":432,"context_line":"                fstype: nfs"},{"line_number":433,"context_line":"                src: \"{{nfs_share}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d8d09761_f413ec2b","line":430,"updated":"2023-09-13 17:38:52.000000000","message":"need similar for /var/lib/nova/instances on computes","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c0432e49b606f68ea536f73d32fafb8d5a7929a7","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                nfs_share: \"{{ glance_nfs_share if (glance_nfs_share) else netapp_share_location }}\""},{"line_number":428,"context_line":"                nfs_options: {get_param: GlanceNfsOptions}"},{"line_number":429,"context_line":"              mount:"},{"line_number":430,"context_line":"                name: /var/lib/glance/images"},{"line_number":431,"context_line":"                state: mounted"},{"line_number":432,"context_line":"                fstype: nfs"},{"line_number":433,"context_line":"                src: \"{{nfs_share}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8cfacf32_1e2c8edf","line":430,"in_reply_to":"870cd7f0_1c2c6a5b","updated":"2023-09-14 15:02:05.000000000","message":"Done","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"0e4b4595b870853c32abf9fc7ed3cd45c87fc22c","unresolved":true,"context_lines":[{"line_number":427,"context_line":"                nfs_share: \"{{ glance_nfs_share if (glance_nfs_share) else netapp_share_location }}\""},{"line_number":428,"context_line":"                nfs_options: {get_param: GlanceNfsOptions}"},{"line_number":429,"context_line":"              mount:"},{"line_number":430,"context_line":"                name: /var/lib/glance/images"},{"line_number":431,"context_line":"                state: mounted"},{"line_number":432,"context_line":"                fstype: nfs"},{"line_number":433,"context_line":"                src: \"{{nfs_share}}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"870cd7f0_1c2c6a5b","line":430,"in_reply_to":"d8d09761_f413ec2b","updated":"2023-09-13 17:44:56.000000000","message":"and glance_staging","commit_id":"baedfea9d2d3467332ab5f543099ed7465f3270f"}]}