)]}'
{"deployment/ceilometer/ceilometer-agent-central-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0d90a539911ef13c9bd089b607477519ca179317","unresolved":true,"context_lines":[{"line_number":120,"context_line":"            central_namespace: true"},{"line_number":121,"context_line":"            ceilometer::agent::polling::tenant_name_discovery: {get_param: CeilometerEnableTenantDiscovery}"},{"line_number":122,"context_line":"            ceilometer::cache::enabled: {get_param: CeilometerEnableCaching}"},{"line_number":123,"context_line":"            ceilometer::cache::backend: {get_param: CeilometerCachingBackend}"},{"line_number":124,"context_line":"      service_config_settings:"},{"line_number":125,"context_line":"        map_merge:"},{"line_number":126,"context_line":"          - get_attr: [CeilometerServiceBase, role_data, service_config_settings]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5778d74e_260d47ce","line":123,"updated":"2023-10-12 11:53:06.000000000","message":"is setting just those sufficient?\nan established pattern for other services looks different.\nSee for example https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/heat/heat-base-puppet.yaml#L232","commit_id":"8849439a1989f654e9fb3ad8c499bf7729015f45"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f00f0caf401fbc0832e3c1ee505a24fe2006e9e8","unresolved":true,"context_lines":[{"line_number":120,"context_line":"            central_namespace: true"},{"line_number":121,"context_line":"            ceilometer::agent::polling::tenant_name_discovery: {get_param: CeilometerEnableTenantDiscovery}"},{"line_number":122,"context_line":"            ceilometer::cache::enabled: {get_param: CeilometerEnableCaching}"},{"line_number":123,"context_line":"            ceilometer::cache::backend: {get_param: CeilometerCachingBackend}"},{"line_number":124,"context_line":"      service_config_settings:"},{"line_number":125,"context_line":"        map_merge:"},{"line_number":126,"context_line":"          - get_attr: [CeilometerServiceBase, role_data, service_config_settings]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c39edfe7_f10c1a20","line":123,"in_reply_to":"5778d74e_260d47ce","updated":"2023-10-12 11:55:04.000000000","message":"oh, it sits in the base config, it seems\nhttps://opendev.org/openstack/tripleo-heat-templates/src/branch/master/deployment/ceilometer/ceilometer-base-container-puppet.yaml#L115\n\nif we include it, maybe adjusts the cache settings there?","commit_id":"8849439a1989f654e9fb3ad8c499bf7729015f45"},{"author":{"_account_id":32240,"name":"Yadnesh Kulkarni","email":"yadnesh_kulkarni@proton.me","username":"ykulkarn"},"change_message_id":"dc25c921b8fdf871ee9f75b6133da7081b3a60fd","unresolved":true,"context_lines":[{"line_number":120,"context_line":"            central_namespace: true"},{"line_number":121,"context_line":"            ceilometer::agent::polling::tenant_name_discovery: {get_param: CeilometerEnableTenantDiscovery}"},{"line_number":122,"context_line":"            ceilometer::cache::enabled: {get_param: CeilometerEnableCaching}"},{"line_number":123,"context_line":"            ceilometer::cache::backend: {get_param: CeilometerCachingBackend}"},{"line_number":124,"context_line":"      service_config_settings:"},{"line_number":125,"context_line":"        map_merge:"},{"line_number":126,"context_line":"          - get_attr: [CeilometerServiceBase, role_data, service_config_settings]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"16380a2c_4083b11b","line":123,"in_reply_to":"c39edfe7_f10c1a20","updated":"2023-10-12 12:16:01.000000000","message":"Thank for the review. You are pointing to the code that came from patch https://review.opendev.org/c/openstack/tripleo-heat-templates/+/855126 ? What do you think of backporting that to wallaby ? And this can be abandoned.\n\nAlong with that I would also have to backport https://review.opendev.org/c/openstack/puppet-tripleo/+/855125 to wallaby.","commit_id":"8849439a1989f654e9fb3ad8c499bf7729015f45"}]}