)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"a01f368f81c849ca20fc4a9faf4ca6fca7dbad9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"de1bb4d0_d3160897","updated":"2023-10-26 12:39:46.000000000","message":"we need to add the .gitignore or the rpm rebuild would fail.","commit_id":"3b050315bc9b37315d9863546c311fdef763fba7"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"125b8af9210d3a966ea6b9fe0dc9241ab8c4ae8c","unresolved":true,"context_lines":[{"line_number":883,"context_line":"          command:"},{"line_number":884,"context_line":"            list_join:"},{"line_number":885,"context_line":"            - \u0027 \u0027"},{"line_number":886,"context_line":"            - - /usr/bin/nova-compute"},{"line_number":887,"context_line":"              - get_attr: [NovaLogging, cmd_extra_args]"},{"line_number":888,"context_line":"          config_files:"},{"line_number":889,"context_line":"            - source: \"/var/lib/kolla/config_files/src/*\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"82dc1397_49254ac7","line":886,"updated":"2023-10-26 11:04:19.000000000","message":"this revert back to the orginal logic form https://review.opendev.org/c/openstack/tripleo-heat-templates/+/564024/8/docker/services/nova-compute.yaml#b128\n\nthis was a merge conflict since the seperate delay start script does not exist in train","commit_id":"f50e79da795fb5aacacd3ec4057483aa6df682e7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d226df8eb9df35e03f79b344add944d179d0bce5","unresolved":true,"context_lines":[{"line_number":69,"context_line":"    type: json"},{"line_number":70,"context_line":"    tags:"},{"line_number":71,"context_line":"      - role_specific"},{"line_number":72,"context_line":"  EnableInstanceHA:"},{"line_number":73,"context_line":"    default: false"},{"line_number":74,"context_line":"    description: Whether to enable an Instance Ha configurarion or not."},{"line_number":75,"context_line":"                 This setup requires the Compute role to have the"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"86a6d158_6a14aba9","line":72,"updated":"2023-10-26 13:02:01.000000000","message":"We could also move it to deprecated sections. That would generate a warning as un used parameter in Heat (which we cannot remove, even tho it does nothing now). Mostly pointless, as there ain\u0027t gonna be a new release of tripleo in foreseen future. Just a nit","commit_id":"3b050315bc9b37315d9863546c311fdef763fba7"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d226df8eb9df35e03f79b344add944d179d0bce5","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"conditions:"},{"line_number":724,"context_line":"  insecure_registry_is_empty: {equals : [{get_param: DockerInsecureRegistryAddress}, []]}"},{"line_number":725,"context_line":"  enable_instance_ha: {equals: [{get_param: EnableInstanceHA}, true]}"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"  use_tls_for_live_migration:"},{"line_number":728,"context_line":"    and:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a10b4a2f_0f7324d8","line":725,"updated":"2023-10-26 13:02:01.000000000","message":"please also remove this","commit_id":"3b050315bc9b37315d9863546c311fdef763fba7"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"746df431b4ecb24c8d801f8aeb5e83a86a1d41e6","unresolved":true,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"conditions:"},{"line_number":724,"context_line":"  insecure_registry_is_empty: {equals : [{get_param: DockerInsecureRegistryAddress}, []]}"},{"line_number":725,"context_line":"  enable_instance_ha: {equals: [{get_param: EnableInstanceHA}, true]}"},{"line_number":726,"context_line":""},{"line_number":727,"context_line":"  use_tls_for_live_migration:"},{"line_number":728,"context_line":"    and:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"31756368_06ac037c","line":725,"in_reply_to":"a10b4a2f_0f7324d8","updated":"2023-10-26 13:05:11.000000000","message":"I am going to keep changes to a minimum and try to match the wallaby revert as much as possible. If you think we should remove or change other bits we can do that in another review imho.","commit_id":"3b050315bc9b37315d9863546c311fdef763fba7"}]}