)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"fe92ea0c29974128d55b7c2c595904a81338b3fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c687b8c_a354781f","updated":"2023-11-07 06:01:34.000000000","message":"recheck","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cf54cafa_59aa97ae","updated":"2023-11-08 06:33:18.000000000","message":"I have updated the patch as per your comments, Thanks for the review.","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"89bad5aa6c8f0f07eeab43bd55131c45404a2fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba6d528e_bacb035d","updated":"2023-11-17 05:16:25.000000000","message":"recheck","commit_id":"bf3519ef138129ef853ad8c1c0d8a02747ad1d45"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"269e3745d11fd4eedf92ac93cb78c38a7b988045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"be689ef0_6f929997","updated":"2023-11-22 13:41:16.000000000","message":"CI failure looks valid\nhttps://b49a1a6bd7022e637e55-03d448e06513a4e4bb78797852449f92.ssl.cf1.rackcdn.com/900152/5/check/tripleo-ci-centos-9-standalone/cf41906/logs/undercloud/home/zuul/standalone_deploy.log\n\nFileNotFoundError: [Errno 2] No such file or directory: \u0027/home/zuul/tripleo-deploy/tripleo-heat-installer-templates/deployment/deprecated/nova/nova-libvirt-common.yaml\u0027","commit_id":"88e4315a6d201f352e9e6b7d1119c12f5fb66c80"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7077f82a1cdcf3f67f35925832b88b18e04b0054","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f0cacb51_0131337b","updated":"2023-11-21 12:51:36.000000000","message":"I\u0027ve addressed remaining concerns in the uploaded revision","commit_id":"88e4315a6d201f352e9e6b7d1119c12f5fb66c80"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"364cbe3f8e8035adfd2b9965556535689ef2f40d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8655014a_4b7bcad3","updated":"2023-11-29 13:58:45.000000000","message":"CI failure looks valid\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f6c/900152/7/check/tripleo-ci-centos-9-containers-multinode/f6ca4ae/logs/undercloud/home/zuul/overcloud_deploy.log\n\n2023-11-23 17:59:35 | 2023-11-23 17:59:35.469 50599 ERROR openstack [-] Failed to deploy: ERROR: \"outputs\" must contain a map of output maps. Found a [\u003cclass \u0027list\u0027\u003e] instead","commit_id":"493b6f601c238bf1beb8d8d00a2dd44a7e97b511"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cf06b41cb249b729a516c268227a0974f573241c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d0bff472_f2a3063d","updated":"2023-11-30 16:10:08.000000000","message":"Done","commit_id":"e21992c8f239d7945c0643c3a33c2feffae4acd5"},{"author":{"_account_id":35491,"name":"Roberto Alfieri","display_name":"Roberto Alfieri","email":"ralfieri@redhat.com","username":"ralfieri"},"change_message_id":"f715625108ae61f53ace193141d5e009d52e3205","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"57796948_88ce87da","updated":"2023-12-03 10:36:58.000000000","message":"There\u0027s a typo in the systemd ini file definition.","commit_id":"cba8721dcaaa8deb70e8a1254fcab10dbd955745"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"6417444cf6e13eb17904cfe621a235ada4d4d6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"70af940b_083b01dd","updated":"2023-12-01 17:09:15.000000000","message":"tested the package download on updadte, its installation on next boot, the package install service activation logic, and machined registration of the started VMs afterwards:\n\n[zuul@standalone ~]$ sudo machinectl list\nMACHINE                  CLASS SERVICE      OS VERSION ADDRESSES\nqemu-1-instance-00000001 vm    libvirt-qemu -  -       -  \n\nthe last bit is to test the service deactivation logic after the next update.\n\nThere is a missing bit I think. We need to remove the downloaded packages as the poststart hook, as we do not want this package reinstalled each time we reboot node","commit_id":"cba8721dcaaa8deb70e8a1254fcab10dbd955745"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"43f28c2cd60e0e61f86c01c063c7078538450f03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0def4cdd_effc2665","in_reply_to":"57796948_88ce87da","updated":"2023-12-04 13:48:22.000000000","message":"Done","commit_id":"cba8721dcaaa8deb70e8a1254fcab10dbd955745"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"43f28c2cd60e0e61f86c01c063c7078538450f03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a9730d27_1bd62b37","in_reply_to":"70af940b_083b01dd","updated":"2023-12-04 13:48:22.000000000","message":"done","commit_id":"cba8721dcaaa8deb70e8a1254fcab10dbd955745"},{"author":{"_account_id":30126,"name":"Luca Miccini","email":"lmiccini@redhat.com","username":"lmiccini2"},"change_message_id":"ee381b59cbaa4464621d44c41afc40c013d5c291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"82f9c672_d03598a8","updated":"2023-12-07 06:18:51.000000000","message":"FYI https://bugs.launchpad.net/tripleo/+bug/2045852 I think we may want to move these tasks to update_tasks (or maybe let\u0027s make it so it doesn\u0027t fail hard if there are no repos available?)","commit_id":"d3dd8cd55e7a446983e729e113860b5870c08e24"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f75b64ea52eae0147983bb1b8959a8434bf4e4a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a9202d86_f273dd68","updated":"2023-12-05 14:15:53.000000000","message":"PTAL, it\u0027s good to go","commit_id":"d3dd8cd55e7a446983e729e113860b5870c08e24"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a693cf7cfc7a02c9e042315e30c1c3b7a34adec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"6885715c_87c8a609","updated":"2023-12-04 16:13:00.000000000","message":"tested this on my env","commit_id":"d3dd8cd55e7a446983e729e113860b5870c08e24"}],"deployment/deprecated/nova/nova-libvirt-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"8557c704faf17a12ed0af7e2032f560f4ac93233","unresolved":true,"context_lines":[{"line_number":1001,"context_line":"                      sed -i -e \u0027s/{{ old_virtlogd_image.stdout | regex_escape() }}/{{ virtlogd_image | regex_escape() }}/\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1002,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1003,"context_line":"      update_tasks:"},{"line_number":1004,"context_line":"        - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1005,"context_line":"        - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1006,"context_line":"            when: step|int \u003d\u003d 1"},{"line_number":1007,"context_line":"            block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"badac48c_a6d69d5b","line":1004,"updated":"2023-11-07 13:41:03.000000000","message":"this should use list_concat:","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"                      sed -i -e \u0027s/{{ old_virtlogd_image.stdout | regex_escape() }}/{{ virtlogd_image | regex_escape() }}/\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1002,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1003,"context_line":"      update_tasks:"},{"line_number":1004,"context_line":"        - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1005,"context_line":"        - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1006,"context_line":"            when: step|int \u003d\u003d 1"},{"line_number":1007,"context_line":"            block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"59a5331a_d0cd743d","line":1004,"in_reply_to":"04439d8c_c3399bd0","updated":"2023-11-08 06:33:18.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ef150edea6f961bf00d0f463b396803d70dfb7b9","unresolved":true,"context_lines":[{"line_number":1001,"context_line":"                      sed -i -e \u0027s/{{ old_virtlogd_image.stdout | regex_escape() }}/{{ virtlogd_image | regex_escape() }}/\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1002,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1003,"context_line":"      update_tasks:"},{"line_number":1004,"context_line":"        - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1005,"context_line":"        - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1006,"context_line":"            when: step|int \u003d\u003d 1"},{"line_number":1007,"context_line":"            block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"04439d8c_c3399bd0","line":1004,"in_reply_to":"badac48c_a6d69d5b","updated":"2023-11-07 13:42:09.000000000","message":"see https://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/wallaby/deployment/cinder/cinder-backup-container-puppet.yaml#L279","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c222db57a3e19674a916b619353d70a257432a1f","unresolved":true,"context_lines":[{"line_number":1002,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1003,"context_line":"      update_tasks:"},{"line_number":1004,"context_line":"        list_concat:"},{"line_number":1005,"context_line":"          - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1006,"context_line":"          - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1007,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":1008,"context_line":"              block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2bf79267_21e30d16","line":1005,"updated":"2023-11-08 12:56:47.000000000","message":"this probably should be wrapped with {}, see the cinder example I\u0027ve linked earlier","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb298c6cb26c15275b10f0c04672df65cfb93325","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1003,"context_line":"      update_tasks:"},{"line_number":1004,"context_line":"        list_concat:"},{"line_number":1005,"context_line":"          - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1006,"context_line":"          - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1007,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":1008,"context_line":"              block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"663bd447_9e3b71e9","line":1005,"in_reply_to":"2bf79267_21e30d16","updated":"2023-11-21 12:44:52.000000000","message":"Done","commit_id":"aec8fa242d642090bef967623247925642cdcbea"}],"deployment/nova/nova-compute-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"af9101f7d7e608c649db2a13fcca7e598a3f3406","unresolved":true,"context_lines":[{"line_number":1534,"context_line":"                  content: |"},{"line_number":1535,"context_line":"                    [Unit]"},{"line_number":1536,"context_line":"                    Description:Install systemd container package on system reboot"},{"line_number":1537,"context_line":"                    Before\u003dfinal.target"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"                    [Service]"},{"line_number":1540,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/systemd-container*"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff282817_a62cd9af","line":1537,"updated":"2023-11-07 13:59:22.000000000","message":"Please add After\u003dvirt-guest-shutdown.target","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[{"line_number":1534,"context_line":"                  content: |"},{"line_number":1535,"context_line":"                    [Unit]"},{"line_number":1536,"context_line":"                    Description:Install systemd container package on system reboot"},{"line_number":1537,"context_line":"                    Before\u003dfinal.target"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"                    [Service]"},{"line_number":1540,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/systemd-container*"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"335d1b2b_cb5f2de2","line":1537,"in_reply_to":"ff282817_a62cd9af","updated":"2023-11-08 06:33:18.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"52f1fa4afcf0afed7bb4e5a3612910741d7cbedd","unresolved":true,"context_lines":[{"line_number":1537,"context_line":"                    Before\u003dfinal.target"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"                    [Service]"},{"line_number":1540,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/systemd-container*"},{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"                    [Install]"},{"line_number":1543,"context_line":"                    WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ef5f5bbd_a2ce4aa2","line":1540,"updated":"2023-11-07 13:52:10.000000000","message":"please add a task to select the most recent one from other packages fetched earlier","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[{"line_number":1537,"context_line":"                    Before\u003dfinal.target"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"                    [Service]"},{"line_number":1540,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/systemd-container*"},{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"                    [Install]"},{"line_number":1543,"context_line":"                    WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"35ab97ff_5151a10f","line":1540,"in_reply_to":"c162f5b8_4527aa9e","updated":"2023-11-08 06:33:18.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"7ad071dcd9a7fc3c6bb77340eacd9853c9d7c635","unresolved":true,"context_lines":[{"line_number":1537,"context_line":"                    Before\u003dfinal.target"},{"line_number":1538,"context_line":""},{"line_number":1539,"context_line":"                    [Service]"},{"line_number":1540,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/systemd-container*"},{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"                    [Install]"},{"line_number":1543,"context_line":"                    WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c162f5b8_4527aa9e","line":1540,"in_reply_to":"ef5f5bbd_a2ce4aa2","updated":"2023-11-07 13:53:43.000000000","message":"also this needs an install, like:\n\n              - name:  enable install-systemd-container on compute reboot/shutdown\n                systemd:\n                  name: install-systemd-container\n                  enabled: true\n                  daemon_reload: true","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0b6578d4d2cbca681f92bd7a8530efbdd62109ae","unresolved":true,"context_lines":[{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"                    [Install]"},{"line_number":1543,"context_line":"                    WantedBy\u003dfinal.target"},{"line_number":1544,"context_line":"                when: not is_systemd_container_package"},{"line_number":1545,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1546,"context_line":"                copy:"},{"line_number":1547,"context_line":"                  dest: /etc/systemd/system/virt-guest-shutdown.target"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"214fe178_603a3ad1","line":1544,"updated":"2023-11-07 14:01:05.000000000","message":"when: not is_systemd_container_package.changed","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"                    [Install]"},{"line_number":1543,"context_line":"                    WantedBy\u003dfinal.target"},{"line_number":1544,"context_line":"                when: not is_systemd_container_package"},{"line_number":1545,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"},{"line_number":1546,"context_line":"                copy:"},{"line_number":1547,"context_line":"                  dest: /etc/systemd/system/virt-guest-shutdown.target"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a36949d_2f17e5a8","line":1544,"in_reply_to":"214fe178_603a3ad1","updated":"2023-11-08 06:33:18.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c222db57a3e19674a916b619353d70a257432a1f","unresolved":true,"context_lines":[{"line_number":1529,"context_line":"                  check_mode: true"},{"line_number":1530,"context_line":"                register: is_systemd_container_package"},{"line_number":1531,"context_line":"              - name: get latest package from downloaded package versions"},{"line_number":1532,"context_line":"                command: ls -1t /var/tmp/systemd-container* | head -1"},{"line_number":1533,"context_line":"                register: latest_systemd_container_package"},{"line_number":1534,"context_line":"              - name: Install systemd-container package on reboot"},{"line_number":1535,"context_line":"                copy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"88c17447_2988eeef","line":1532,"updated":"2023-11-08 12:56:47.000000000","message":"I\u0027m not sure piping works with the ansible command module, but the shell one","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb298c6cb26c15275b10f0c04672df65cfb93325","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"                  check_mode: true"},{"line_number":1530,"context_line":"                register: is_systemd_container_package"},{"line_number":1531,"context_line":"              - name: get latest package from downloaded package versions"},{"line_number":1532,"context_line":"                command: ls -1t /var/tmp/systemd-container* | head -1"},{"line_number":1533,"context_line":"                register: latest_systemd_container_package"},{"line_number":1534,"context_line":"              - name: Install systemd-container package on reboot"},{"line_number":1535,"context_line":"                copy:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"867e01e3_a2f93f85","line":1532,"in_reply_to":"88c17447_2988eeef","updated":"2023-11-21 12:44:52.000000000","message":"Done","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c222db57a3e19674a916b619353d70a257432a1f","unresolved":true,"context_lines":[{"line_number":1541,"context_line":"                    After\u003dvirt-guest-shutdown.target"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"                    [Service]"},{"line_number":1544,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/{{ latest_systemd_container_package }}"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"                    [Install]"},{"line_number":1547,"context_line":"                    WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"447e98bb_fe82cd7c","line":1544,"updated":"2023-11-08 12:56:47.000000000","message":"latest_systemd_container_package.stdout","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb298c6cb26c15275b10f0c04672df65cfb93325","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"                    After\u003dvirt-guest-shutdown.target"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"                    [Service]"},{"line_number":1544,"context_line":"                    ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/{{ latest_systemd_container_package }}"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"                    [Install]"},{"line_number":1547,"context_line":"                    WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0128266b_a64fe097","line":1544,"in_reply_to":"447e98bb_fe82cd7c","updated":"2023-11-21 12:44:52.000000000","message":"Done","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c222db57a3e19674a916b619353d70a257432a1f","unresolved":true,"context_lines":[{"line_number":1548,"context_line":"                when: not is_systemd_container_package.changed"},{"line_number":1549,"context_line":"              - name: enable install-systemd-container on compute reboot/shutdown"},{"line_number":1550,"context_line":"                systemd:"},{"line_number":1551,"context_line":"                  name: install-systemd-container"},{"line_number":1552,"context_line":"                  enabled: true"},{"line_number":1553,"context_line":"                  daemon_reload: true"},{"line_number":1554,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"40cd5225_ca934591","line":1551,"updated":"2023-11-08 12:56:47.000000000","message":"let\u0027s make sure this unit becomes disabled and masked in case the package is already installed","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"80a70a11222dc46db8250d483324de2e6ba72426","unresolved":false,"context_lines":[{"line_number":1548,"context_line":"                when: not is_systemd_container_package.changed"},{"line_number":1549,"context_line":"              - name: enable install-systemd-container on compute reboot/shutdown"},{"line_number":1550,"context_line":"                systemd:"},{"line_number":1551,"context_line":"                  name: install-systemd-container"},{"line_number":1552,"context_line":"                  enabled: true"},{"line_number":1553,"context_line":"                  daemon_reload: true"},{"line_number":1554,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ee466d36_ff681697","line":1551,"in_reply_to":"1d1a526b_485c1bdd","updated":"2023-11-21 12:51:45.000000000","message":"Done","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"a6a3e4443711b6b4ae599e2d8a359a0a2ee3869a","unresolved":true,"context_lines":[{"line_number":1548,"context_line":"                when: not is_systemd_container_package.changed"},{"line_number":1549,"context_line":"              - name: enable install-systemd-container on compute reboot/shutdown"},{"line_number":1550,"context_line":"                systemd:"},{"line_number":1551,"context_line":"                  name: install-systemd-container"},{"line_number":1552,"context_line":"                  enabled: true"},{"line_number":1553,"context_line":"                  daemon_reload: true"},{"line_number":1554,"context_line":"              - name: Making sure virt-guest-shutdown.target is present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1d1a526b_485c1bdd","line":1551,"in_reply_to":"40cd5225_ca934591","updated":"2023-11-08 13:27:07.000000000","message":"I\u0027ve tested this with a snippet\n\n\t- hosts: localhost\n\t  gather_facts: false\n\t  connection: local\n\t  tasks:\n\t- name: check systemd-container package installed or not\n\t  package:\n\t\tname: (some package name)\n\t\tstate: present\n\t  check_mode: true\n\t  register: is_systemd_container_package\n\t- debug:\n\t\tmsg: \"Create\u0026install unit\"\n\t  when: is_systemd_container_package.changed\n\t- debug:\n\t\tmsg: \"Uninstall unit\"\n\t  when: not is_systemd_container_package.changed\n\nWhile we have an inverted logic here...\nSo, the create\u0026install actions should only happen when \n\n  is_systemd_container_package.changed\n  \nand it should uninstall the unit when\n\n  not is_systemd_container_package.changed","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f78935a65fcf27b08fb25c320860bde2d3a2fb8f","unresolved":true,"context_lines":[{"line_number":1490,"context_line":"              resume_guests_state_on_host_boot_enabled: {get_attr: [RoleParametersValue, value, resume_guests_state_on_host_boot]}"},{"line_number":1491,"context_line":"          - name: install libvirt-guests systemd unit file (docker)"},{"line_number":1492,"context_line":"            when:"},{"line_number":1493,"context_line":"              - resume_guests_state_on_host_boot_enabled|bool"},{"line_number":1494,"context_line":"              - container_cli \u003d\u003d \u0027docker\u0027"},{"line_number":1495,"context_line":"            block:"},{"line_number":1496,"context_line":"              - name: libvirt-guests unit to stop nova_compute container before shutdown VMs"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"dfc56cb7_7da8edad","line":1493,"updated":"2023-11-29 16:34:23.000000000","message":"the added tasks are unrelated to this feature flag, so should be moved out of the block scope","commit_id":"5d642b5b8555963e1b45732194536dfad09f7f78"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"ce56a28587e1088159b317aebb5cca4dd62448cd","unresolved":false,"context_lines":[{"line_number":1490,"context_line":"              resume_guests_state_on_host_boot_enabled: {get_attr: [RoleParametersValue, value, resume_guests_state_on_host_boot]}"},{"line_number":1491,"context_line":"          - name: install libvirt-guests systemd unit file (docker)"},{"line_number":1492,"context_line":"            when:"},{"line_number":1493,"context_line":"              - resume_guests_state_on_host_boot_enabled|bool"},{"line_number":1494,"context_line":"              - container_cli \u003d\u003d \u0027docker\u0027"},{"line_number":1495,"context_line":"            block:"},{"line_number":1496,"context_line":"              - name: libvirt-guests unit to stop nova_compute container before shutdown VMs"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"4131fe05_d61b5724","line":1493,"in_reply_to":"dfc56cb7_7da8edad","updated":"2023-11-29 16:55:50.000000000","message":"Done","commit_id":"5d642b5b8555963e1b45732194536dfad09f7f78"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cf06b41cb249b729a516c268227a0974f573241c","unresolved":false,"context_lines":[{"line_number":1502,"context_line":"                [Unit]"},{"line_number":1503,"context_line":"                Description:Install systemd container package on system reboot"},{"line_number":1504,"context_line":"                Before\u003dfinal.target"},{"line_number":1505,"context_line":"                After\u003dtripleo-container-shutdown.service"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"                [Service]"},{"line_number":1508,"context_line":"                ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/{{ latest_systemd_container_package.stdout }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7ae2662b_10a89cfd","line":1505,"updated":"2023-11-30 16:10:08.000000000","message":"we cannot use virt-guest-shutdown.target as it is conditionally created","commit_id":"e21992c8f239d7945c0643c3a33c2feffae4acd5"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"61102f421ff87dd2c2641c1043e28881de5ea101","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"                After\u003dtripleo-container-shutdown.service"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"                [Service]"},{"line_number":1508,"context_line":"                ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/{{ latest_systemd_container_package.stdout }}"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"                [Install]"},{"line_number":1511,"context_line":"                WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"50559c5f_357d8963","line":1508,"updated":"2023-12-01 16:32:03.000000000","message":"we might need to enable this service and use the ExecStop instead","commit_id":"c7454ea3700ac4bce968037cfbea6eb85029aefc"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e4cdfef949b5a5281b7c25e3c4c67c5dbadb412d","unresolved":true,"context_lines":[{"line_number":1505,"context_line":"                After\u003dtripleo-container-shutdown.service"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"                [Service]"},{"line_number":1508,"context_line":"                ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/{{ latest_systemd_container_package.stdout }}"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"                [Install]"},{"line_number":1511,"context_line":"                WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ce59a53f_5d7ed3e6","line":1508,"in_reply_to":"50559c5f_357d8963","updated":"2023-12-01 16:58:05.000000000","message":"I couldn\u0027t make this working during my local testing, so I changed the install-on-shtdown to install-on-next-boot","commit_id":"c7454ea3700ac4bce968037cfbea6eb85029aefc"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"4319f8128acd69001cfbcfb7c6ec97c16e2b443a","unresolved":false,"context_lines":[{"line_number":1505,"context_line":"                After\u003dtripleo-container-shutdown.service"},{"line_number":1506,"context_line":""},{"line_number":1507,"context_line":"                [Service]"},{"line_number":1508,"context_line":"                ExecStart\u003d/usr/bin/rpm -ivh /var/tmp/{{ latest_systemd_container_package.stdout }}"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"                [Install]"},{"line_number":1511,"context_line":"                WantedBy\u003dfinal.target"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e1fbfeda_a625aea7","line":1508,"in_reply_to":"ce59a53f_5d7ed3e6","updated":"2023-12-04 13:48:33.000000000","message":"Done","commit_id":"c7454ea3700ac4bce968037cfbea6eb85029aefc"},{"author":{"_account_id":35491,"name":"Roberto Alfieri","display_name":"Roberto Alfieri","email":"ralfieri@redhat.com","username":"ralfieri"},"change_message_id":"f715625108ae61f53ace193141d5e009d52e3205","unresolved":true,"context_lines":[{"line_number":1500,"context_line":"              dest: /etc/systemd/system/install-systemd-container.service"},{"line_number":1501,"context_line":"              content: |"},{"line_number":1502,"context_line":"                [Unit]"},{"line_number":1503,"context_line":"                Description:Install systemd container package on system boot"},{"line_number":1504,"context_line":"                Before\u003dtripleo_nova_virtqemud.service"},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"                [Service]"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"4d91a0de_85ea00ab","line":1503,"updated":"2023-12-03 10:36:58.000000000","message":"s/:/\u003d/g","commit_id":"cba8721dcaaa8deb70e8a1254fcab10dbd955745"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"43f28c2cd60e0e61f86c01c063c7078538450f03","unresolved":false,"context_lines":[{"line_number":1500,"context_line":"              dest: /etc/systemd/system/install-systemd-container.service"},{"line_number":1501,"context_line":"              content: |"},{"line_number":1502,"context_line":"                [Unit]"},{"line_number":1503,"context_line":"                Description:Install systemd container package on system boot"},{"line_number":1504,"context_line":"                Before\u003dtripleo_nova_virtqemud.service"},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"                [Service]"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"325bbf89_58d8f761","line":1503,"in_reply_to":"4d91a0de_85ea00ab","updated":"2023-12-04 13:48:22.000000000","message":"Done","commit_id":"cba8721dcaaa8deb70e8a1254fcab10dbd955745"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3185fd9cd32b2c1d580798d51ab97e6dcd2a0bb5","unresolved":true,"context_lines":[{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"                [Service]"},{"line_number":1507,"context_line":"                ExecStart\u003d/usr/bin/rpm -ivh {{ latest_systemd_container_package.stdout }}"},{"line_number":1508,"context_line":"                ExecStartPost\u003drm -f /var/tmp/systemd-container*"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"                [Install]"},{"line_number":1511,"context_line":"                WantedBy\u003dmulti-user.target"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"df354369_b3173fbb","line":1508,"updated":"2023-12-04 15:18:20.000000000","message":"got problems testing this removal - this service never attempted to be stopped during shutdown/reboot. Neither it gets installed (but cleaned up) after reboot :/","commit_id":"52ee5442dbe35716081e0739cf8eb4fb43092fd2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"1ed1b6253c3ec4c07e8122bae9b546274db36a40","unresolved":false,"context_lines":[{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"                [Service]"},{"line_number":1507,"context_line":"                ExecStart\u003d/usr/bin/rpm -ivh {{ latest_systemd_container_package.stdout }}"},{"line_number":1508,"context_line":"                ExecStartPost\u003drm -f /var/tmp/systemd-container*"},{"line_number":1509,"context_line":""},{"line_number":1510,"context_line":"                [Install]"},{"line_number":1511,"context_line":"                WantedBy\u003dmulti-user.target"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"c7797afd_c526d881","line":1508,"in_reply_to":"df354369_b3173fbb","updated":"2023-12-04 15:54:59.000000000","message":"Done","commit_id":"52ee5442dbe35716081e0739cf8eb4fb43092fd2"}],"deployment/nova/nova-libvirt-common.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"368c1cf7cf4a3c5ffbcf5e6159b2a6df1132d196","unresolved":true,"context_lines":[{"line_number":185,"context_line":"        name: systemd-container"},{"line_number":186,"context_line":"        state: present"},{"line_number":187,"context_line":"        download_only: true"},{"line_number":188,"context_line":"        download_dir: \u0027/var/tmp/\u0027"},{"line_number":189,"context_line":"      when: not is_systemd_container_package"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"66e862db_97a50c52","line":188,"updated":"2023-11-07 13:49:37.000000000","message":"I wonder if this accumulates all the versioned downloads? If so, we need to add a task to only install the most recent one, like doing \n\nls -1t /var/tmp/systemd-container* | head -1","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        name: systemd-container"},{"line_number":186,"context_line":"        state: present"},{"line_number":187,"context_line":"        download_only: true"},{"line_number":188,"context_line":"        download_dir: \u0027/var/tmp/\u0027"},{"line_number":189,"context_line":"      when: not is_systemd_container_package"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"03ccf65a_bc30e88b","line":188,"in_reply_to":"66e862db_97a50c52","updated":"2023-11-08 06:33:18.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c69f377c44d3661ea0d3a92804cbc19417a3e331","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        state: present"},{"line_number":187,"context_line":"        download_only: true"},{"line_number":188,"context_line":"        download_dir: \u0027/var/tmp/\u0027"},{"line_number":189,"context_line":"      when: not is_systemd_container_package"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ef93f7ed_7b69818d","line":189,"updated":"2023-11-07 13:57:59.000000000","message":"does this work? shouldn\u0027t it be\n\n not is_systemd_container_package.changed\n \n?","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"2d9abd33bb2614f8aaeeaa56fde61bbadb295a1f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        state: present"},{"line_number":187,"context_line":"        download_only: true"},{"line_number":188,"context_line":"        download_dir: \u0027/var/tmp/\u0027"},{"line_number":189,"context_line":"      when: not is_systemd_container_package"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"87342879_012641a6","line":189,"in_reply_to":"ef93f7ed_7b69818d","updated":"2023-11-08 06:33:18.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cb7b2e476d44fd9bcecbb4f0155a34fb251bbc6b","unresolved":true,"context_lines":[{"line_number":186,"context_line":"        state: present"},{"line_number":187,"context_line":"        download_only: true"},{"line_number":188,"context_line":"        download_dir: \u0027/var/tmp/\u0027"},{"line_number":189,"context_line":"      when: not is_systemd_container_package.changed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"726259da_6b24bda9","line":189,"updated":"2023-11-08 13:28:37.000000000","message":"ditto, downloading should only happen when\n\nis_systemd_container_package.changed","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"80a70a11222dc46db8250d483324de2e6ba72426","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        state: present"},{"line_number":187,"context_line":"        download_only: true"},{"line_number":188,"context_line":"        download_dir: \u0027/var/tmp/\u0027"},{"line_number":189,"context_line":"      when: not is_systemd_container_package.changed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"57203ec2_a9cb85e6","line":189,"in_reply_to":"726259da_6b24bda9","updated":"2023-11-21 12:51:45.000000000","message":"Done","commit_id":"aec8fa242d642090bef967623247925642cdcbea"}],"deployment/nova/nova-modular-libvirt-container-puppet.yaml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"e5edf157f10927258cd6482104c84dc4b04ff4cb","unresolved":true,"context_lines":[{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1057,"context_line":"        - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1058,"context_line":"            when: step|int \u003d\u003d 1"},{"line_number":1059,"context_line":"            block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b76fa3c7_d96f78cc","line":1056,"updated":"2023-11-07 13:50:00.000000000","message":"ditto, likely list_concat is needed","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb298c6cb26c15275b10f0c04672df65cfb93325","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                      sed -i -e \u0027s|{{ old_virtlogd_image.stdout }}|{{ virtlogd_image }}|\u0027 /var/lib/container-config-scripts/virtlogd_wrapper"},{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1057,"context_line":"        - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1058,"context_line":"            when: step|int \u003d\u003d 1"},{"line_number":1059,"context_line":"            block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4cc02048_59e47e87","line":1056,"in_reply_to":"b76fa3c7_d96f78cc","updated":"2023-11-21 12:44:52.000000000","message":"Done","commit_id":"24f43fc4193b459303689229e9c939f515714f3e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"81fe7579fa98f141ca402b413b45ad2636c317b3","unresolved":true,"context_lines":[{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        list_concat:"},{"line_number":1057,"context_line":"          - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1058,"context_line":"          - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1059,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":1060,"context_line":"              block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3abc2d98_e4681412","line":1057,"updated":"2023-11-08 13:29:04.000000000","message":"ditto, \n\n- {get_attr: [NovaLibvirtCommon, update_tasks]}","commit_id":"aec8fa242d642090bef967623247925642cdcbea"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bb298c6cb26c15275b10f0c04672df65cfb93325","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                    when: old_virtlogd_image.stdout !\u003d virtlogd_image"},{"line_number":1055,"context_line":"      update_tasks:"},{"line_number":1056,"context_line":"        list_concat:"},{"line_number":1057,"context_line":"          - get_attr: [NovaLibvirtCommon, update_tasks]"},{"line_number":1058,"context_line":"          - - name: nova_libvirt_container_tmpfile_cleanup"},{"line_number":1059,"context_line":"              when: step|int \u003d\u003d 1"},{"line_number":1060,"context_line":"              block: *nova_libvirt_container_tmpfile_cleanup"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"e897479b_91290bbb","line":1057,"in_reply_to":"3abc2d98_e4681412","updated":"2023-11-21 12:44:52.000000000","message":"Done","commit_id":"aec8fa242d642090bef967623247925642cdcbea"}]}