)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc8b9d48d1d2a0bac361494def39adc79404de4f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added ManilaCephFSFileSystemName"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila is broken in tht wallaby as we get the following error:"},{"line_number":10,"context_line":"```"},{"line_number":11,"context_line":"2023-12-19 17:12:47.543 9 ERROR manila.share.manager manila.exception.ShareBackendException: Share backend error: Specify Ceph filesystem name using \u0027cephfs_filesystem_name\u0027 driver option."},{"line_number":12,"context_line":"```"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e3c87459_038b3c63","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":62},"updated":"2023-12-19 23:25:57.000000000","message":"This \"cephfs_filesystem_name\" config option is only necessary if there are multiple Ceph filesystems on the ceph cluster [1]. \n\nIs this the case? \nTripleO-deployed ceph is configured with a single filesystem always [2]. So this can only happen with \"external\" ceph\n\n\n[1] https://opendev.org/openstack/manila/src/commit/eb12c770cc8f08924c8600d14fdf075387594dac/manila/share/drivers/cephfs/driver.py#L432-L444\n[2] https://github.com/openstack/tripleo-ansible/blob/e281ae7624774d71f22fbb993af967ed1ec08780/tripleo_ansible/roles/tripleo_cephadm/tasks/mds.yaml#L71-L81","commit_id":"a9e2c2418d6e56c6bd4c431fb4a65ba7570dd75f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b2e4f216c79f1a19c22c4ce4a6f2be381500271","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added ManilaCephFSFileSystemName"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Manila is broken in tht wallaby as we get the following error:"},{"line_number":10,"context_line":"```"},{"line_number":11,"context_line":"2023-12-19 17:12:47.543 9 ERROR manila.share.manager manila.exception.ShareBackendException: Share backend error: Specify Ceph filesystem name using \u0027cephfs_filesystem_name\u0027 driver option."},{"line_number":12,"context_line":"```"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f3b35e7_e29648ce","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":62},"in_reply_to":"e3c87459_038b3c63","updated":"2024-01-02 17:21:15.000000000","message":"Noting here for posterity that we confirmed this was the case; if we make another update, we could clarify this in the commit message... \nAlso, a validation is being added to prevent the usage of this THT parameter with TripleO deployed Ceph: https://review.opendev.org/c/openstack/python-tripleoclient/+/904182","commit_id":"a9e2c2418d6e56c6bd4c431fb4a65ba7570dd75f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fc8b9d48d1d2a0bac361494def39adc79404de4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98b22ba5_04ab6528","updated":"2023-12-19 23:25:57.000000000","message":"Thanks for the fix, Dave. \n\nI think this is okay.. i want to know if you\u0027d like to customize the name of the cephfs filesystem that TripleO creates; if yes, this wouldn\u0027t be sufficient... we\u0027d need to propagate this option to the MDS manifest [1] as well; and in turn ensure we\u0027re customizing tripleo-ansible as well.\n\n[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/cephadm/ceph-mds.yaml\n[2] https://github.com/openstack/tripleo-ansible/blob/e281ae7624774d71f22fbb993af967ed1ec08780/tripleo_ansible/roles/tripleo_cephadm/tasks/mds.yaml#L71-L81","commit_id":"a9e2c2418d6e56c6bd4c431fb4a65ba7570dd75f"},{"author":{"_account_id":25402,"name":"Francesco Pantano","email":"fpantano@redhat.com","username":"fmount"},"change_message_id":"567b2e5014c144d9fc2ad7c846df99ded8f00a7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f492b81d_57e52187","updated":"2024-01-08 11:09:04.000000000","message":"recheck","commit_id":"850baa83bb445e4fe94fa4eb3ed96ac199c0e7a3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b2e4f216c79f1a19c22c4ce4a6f2be381500271","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f7c8f2b0_21d128aa","updated":"2024-01-02 17:21:15.000000000","message":"recheck\n\nfailures unrelated","commit_id":"850baa83bb445e4fe94fa4eb3ed96ac199c0e7a3"}],"deployment/manila/manila-backend-cephfs.yaml":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6c3be5ada42faa5239247056828ea093ffe11e69","unresolved":true,"context_lines":[{"line_number":48,"context_line":"  ManilaCephFSBackendName:"},{"line_number":49,"context_line":"    type: string"},{"line_number":50,"context_line":"    default: cephfs"},{"line_number":51,"context_line":"  ManilaCephFSFilesystemName:"},{"line_number":52,"context_line":"    type: string"},{"line_number":53,"context_line":"    default: cephfs"},{"line_number":54,"context_line":"  ManilaCephFSAvailabilityZone:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b739c027_625adbac","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":28},"updated":"2023-12-27 07:24:00.000000000","message":"this is not same as the parameter in L108\nManilaCephFSFilesystemName -\u003e ManilaCephFSFileSystemName","commit_id":"a9e2c2418d6e56c6bd4c431fb4a65ba7570dd75f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7b2e4f216c79f1a19c22c4ce4a6f2be381500271","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  ManilaCephFSBackendName:"},{"line_number":49,"context_line":"    type: string"},{"line_number":50,"context_line":"    default: cephfs"},{"line_number":51,"context_line":"  ManilaCephFSFilesystemName:"},{"line_number":52,"context_line":"    type: string"},{"line_number":53,"context_line":"    default: cephfs"},{"line_number":54,"context_line":"  ManilaCephFSAvailabilityZone:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"331694a8_6ab51630","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":28},"in_reply_to":"b739c027_625adbac","updated":"2024-01-02 17:21:15.000000000","message":"+1 Thanks for fixing this up","commit_id":"a9e2c2418d6e56c6bd4c431fb4a65ba7570dd75f"}]}