)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3a8cb4b246637e220c77aa95fb4dc10a1dee732a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e924fcc6_db2404ec","updated":"2023-12-20 16:24:36.000000000","message":"tripleo shoudl never be modifying the AZ of a comptue node under any operation\nthis definaly shoudl not eb done during upgrade.\n\nAZ shoudl only be managed via the nova api.\n\ni have not looke at the history of this but this is very concerning as it woudl likely currpt the nova database.","commit_id":"9ac536204010b8bfa6c807a544feb3526f086cc2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"0d746e84b7dbd634c4ac37ac1ad8f02e474a8c7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96b6ac5e_e7b82b90","in_reply_to":"01e238cd_88bb180b","updated":"2024-01-10 16:43:30.000000000","message":"done","commit_id":"9ac536204010b8bfa6c807a544feb3526f086cc2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"006151ea94b3696cd808a1bfcbee520a8142d40d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"445a75ef_7d6f6848","in_reply_to":"396277fa_a9f207ab","updated":"2023-12-22 12:40:42.000000000","message":"If we don\u0027t want to remove a host from AZ during scale-in, even though we have disabled its compute service, let me know, and I will remove the scale_tasks here.\n\nBut we need to add purge_hosts\u003dfalse. To address the linked BZ.\n\nAlso, let me know, if we do want to remove a host from AZ, should it be done before or after its compute service disabled?","commit_id":"9ac536204010b8bfa6c807a544feb3526f086cc2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ab48de17f9b380a435454eb684039a2ce41826ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01e238cd_88bb180b","in_reply_to":"445a75ef_7d6f6848","updated":"2023-12-22 14:26:43.000000000","message":"nova has code to handlel removing a compute service form all aggreates its apart fo wehn teh compute service is deleted\n\nhttps://github.com/openstack/nova/blob/39f560d6730f2b212506b7d754645c288d13f1cd/nova/api/openstack/compute/services.py#L309-L318\n\ntripleo should be deleting the compute service as part fo scale in\nafter it has stopped the compute agent on the node but before it tries to delete the node in the undercloud.\n\nif the compute node still hosts instnace it will get a 409 form the compute service delete sicne it not valid to scale in a compute node if it still has instnaces assocated with it.\n\nthat would currpt our db so it shoudl cause the scale in to fail as the prequcists have failed.\n\nasssuming the host is empty howver the compute service delete will correct clean up all aggrate entries so tripleo should not be trying to do that itself.","commit_id":"9ac536204010b8bfa6c807a544feb3526f086cc2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"02c6c0a6bf43d5b35e6271c2e1f97ceaa3e8c0b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"396277fa_a9f207ab","in_reply_to":"e924fcc6_db2404ec","updated":"2023-12-22 12:37:09.000000000","message":"During upgrade this ensures no changes done to AZs.\n\nDuring scale-in, we already have the same logic around disabling nova compute services. This seems aligned to me, to remove a host from an AZ, after its compute service got disabled","commit_id":"9ac536204010b8bfa6c807a544feb3526f086cc2"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"33608f88fefbcf592ab40c3ee180c45bd9698c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"745bb125_40bc348c","updated":"2024-01-12 15:24:56.000000000","message":"recheck it works maybe","commit_id":"222b5c9b3c5b3e79a5deedd6b34cbe9a5e4d1466"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fbfd1f6c7105c34e8121bce2ec0b403f82dc4e63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7e1a0880_a2571d03","updated":"2024-01-10 16:43:07.000000000","message":"this patch has been already tested downstream for DCN FFU","commit_id":"222b5c9b3c5b3e79a5deedd6b34cbe9a5e4d1466"}]}