)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"02d5c163c8f716788c97f130e4db05f74cae6eae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     ef2ee612 (Merge \"Use DISTRO_NAME rather than unbound DISTRO\")"},{"line_number":2,"context_line":"Author:     root \u003chaneef.ali@hp.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2014-05-22 09:13:52 -0700"},{"line_number":4,"context_line":"Commit:     Haneef Ali \u003chaneef.ali@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-27 13:45:38 -0700"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_de220f53","line":2,"updated":"2014-06-27 20:57:52.000000000","message":"Suggest updating author","commit_id":"35ac723504158911e3485fe320be3c8d0d34a518"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49ffd8a493d957ed05dab966c31539bc4d3ca633","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haneef Ali \u003chaneef.ali@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-15 11:12:37 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure keystone with apache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone federation support requires Apache. Federation can only be"},{"line_number":10,"context_line":"supported in conjunction with Apache as it needs both mod_mellon and mod_shib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_e2d81054","line":7,"updated":"2014-08-04 07:50:38.000000000","message":"\"when building on ubuntu\"  (which is fine, but I think it should be mentioned in the commit message)","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Haneef Ali \u003chaneef.ali@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-07-15 11:12:37 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Configure keystone with apache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone federation support requires Apache. Federation can only be"},{"line_number":10,"context_line":"supported in conjunction with Apache as it needs both mod_mellon and mod_shib."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"baada198_42e7df0e","line":7,"in_reply_to":"baada198_e2d81054","updated":"2014-08-04 21:02:46.000000000","message":"Will do","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"}],"elements/horizon/install.d/horizon-source-install/100-horizon":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49ffd8a493d957ed05dab966c31539bc4d3ca633","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    sed -i \u0027/Listen/s/^/#/g\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":12,"context_line":"    mkdir -p $TEMPLATE_ROOT/etc/httpd/conf.d/"},{"line_number":13,"context_line":"    install -m 0644 -o root -g root $(dirname $0)/../files/horizon.conf $TEMPLATE_ROOT/etc/httpd/conf.d/"},{"line_number":14,"context_line":"    install -m 0644 -o root -g root $(dirname $0)/../files/ports.conf $TEMPLATE_ROOT/etc/httpd/conf.d/"},{"line_number":15,"context_line":"    sed -e \"s|HORIZON_VENV_DIR|$HORIZON_VENV_DIR|g\" -i $TEMPLATE_ROOT/etc/httpd/conf.d/horizon.conf"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_22ae88e7","line":14,"updated":"2014-08-04 07:50:38.000000000","message":"this seems unrelated to the change here (tidy up?)","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    sed -i \u0027/Listen/s/^/#/g\u0027 /etc/httpd/conf/httpd.conf"},{"line_number":12,"context_line":"    mkdir -p $TEMPLATE_ROOT/etc/httpd/conf.d/"},{"line_number":13,"context_line":"    install -m 0644 -o root -g root $(dirname $0)/../files/horizon.conf $TEMPLATE_ROOT/etc/httpd/conf.d/"},{"line_number":14,"context_line":"    install -m 0644 -o root -g root $(dirname $0)/../files/ports.conf $TEMPLATE_ROOT/etc/httpd/conf.d/"},{"line_number":15,"context_line":"    sed -e \"s|HORIZON_VENV_DIR|$HORIZON_VENV_DIR|g\" -i $TEMPLATE_ROOT/etc/httpd/conf.d/horizon.conf"},{"line_number":16,"context_line":"fi"},{"line_number":17,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_42beffce","line":14,"in_reply_to":"baada198_22ae88e7","updated":"2014-08-04 21:02:46.000000000","message":"Horizon is copying * which is wrong.  In my first patch I only did this change for ubuntu and thought of doing Fedora as separate patch.  Since horizon is copying *, it is also enabled for Fedora .  Anyhow being explicit is better than *","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"}],"elements/keystone/environment.d/10-keystone-venv-dir.bash":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"export DISTRO\u003d`lsb_release -si` || true"},{"line_number":9,"context_line":"export RELEASE\u003d`lsb_release -r` || true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"export DEBIAN_DISTROS\u003d\"Ubuntu Debian\""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"baada198_fba18795","line":11,"updated":"2014-08-04 17:00:41.000000000","message":"No need to set these here because we already have DISTRO_NAME (from DIB) right?","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":8,"context_line":"export DISTRO\u003d`lsb_release -si` || true"},{"line_number":9,"context_line":"export RELEASE\u003d`lsb_release -r` || true"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"export DEBIAN_DISTROS\u003d\"Ubuntu Debian\""},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"baada198_8291f747","line":11,"in_reply_to":"baada198_fba18795","updated":"2014-08-04 21:02:46.000000000","message":"Will use it","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"}],"elements/keystone/files/keystone_modwsgi.conf":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \u003c/Directory\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    ErrorLog /var/log/keystone/keystone_apache_error.log"},{"line_number":17,"context_line":"    LogLevel debug"},{"line_number":18,"context_line":"    CustomLog /var/log/keystone/keystone_apache_access.log combined"},{"line_number":19,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/plain","patch_set":8,"id":"baada198_bb7d4f20","line":17,"updated":"2014-08-04 17:00:41.000000000","message":"Why debug? Our keystone default is currently WARN.","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \u003c/Directory\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    ErrorLog /var/log/keystone/keystone_apache_error.log"},{"line_number":17,"context_line":"    LogLevel debug"},{"line_number":18,"context_line":"    CustomLog /var/log/keystone/keystone_apache_access.log combined"},{"line_number":19,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":20,"context_line":""}],"source_content_type":"text/plain","patch_set":8,"id":"baada198_42ba7fba","line":17,"in_reply_to":"baada198_bb7d4f20","updated":"2014-08-04 21:02:46.000000000","message":"I will change it to INFO. Also this affects only console log. If keystone logging is controlled by logging.conf, it doesn\u0027t have any effect. This just gets wsgi stdout","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003c/Directory\u003e"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ErrorLog /var/log/keystone/keystone_apache_error.log"},{"line_number":34,"context_line":"    LogLevel debug"},{"line_number":35,"context_line":"    CustomLog /var/log/keystone/keystone_apache_access.log combined"},{"line_number":36,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":37,"context_line":""}],"source_content_type":"text/plain","patch_set":8,"id":"baada198_1b763b3f","line":34,"updated":"2014-08-04 17:00:41.000000000","message":"Ditto. Why debug?","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003c/Directory\u003e"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ErrorLog /var/log/keystone/keystone_apache_error.log"},{"line_number":34,"context_line":"    LogLevel debug"},{"line_number":35,"context_line":"    CustomLog /var/log/keystone/keystone_apache_access.log combined"},{"line_number":36,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":37,"context_line":""}],"source_content_type":"text/plain","patch_set":8,"id":"baada198_a2e27bd1","line":34,"in_reply_to":"baada198_1b763b3f","updated":"2014-08-04 21:02:46.000000000","message":"Same as above","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"}],"elements/keystone/install.d/keystone-source-install/70-keystone":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49ffd8a493d957ed05dab966c31539bc4d3ca633","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RELEASE\u003d`lsb_release -r` || true"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"os-svc-install $KEYSTONE_EXTRA_INSTALL_OPTS -i \"$KEYSTONE_VENV_DIR\" -u keystone -r /opt/stack/keystone"},{"line_number":7,"context_line":"os-svc-daemon -i \"$KEYSTONE_VENV_DIR\" keystone keystone keystone-all \"--config-dir /etc/keystone\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_82dd946f","side":"PARENT","line":4,"updated":"2014-08-04 07:50:38.000000000","message":"q: why is it better to have this in /10-keystone-venv-dir.bash vs here?\n(genuine q)","commit_id":"701bf0e912c4fdd4cf6970cfbd2491856c43ef99"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49ffd8a493d957ed05dab966c31539bc4d3ca633","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RELEASE\u003d`lsb_release -r` || true"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"os-svc-install $KEYSTONE_EXTRA_INSTALL_OPTS -i \"$KEYSTONE_VENV_DIR\" -u keystone -r /opt/stack/keystone"},{"line_number":7,"context_line":"os-svc-daemon -i \"$KEYSTONE_VENV_DIR\" keystone keystone keystone-all \"--config-dir /etc/keystone\""},{"line_number":8,"context_line":"install -m 0755 -o keystone -g keystone -d /etc/keystone/ssl"},{"line_number":9,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_e23c9094","side":"PARENT","line":6,"updated":"2014-08-04 07:50:38.000000000","message":"OK, wrt to my comment above, I can see the logic, since the other related KEYSTONE_* params are already set there...","commit_id":"701bf0e912c4fdd4cf6970cfbd2491856c43ef99"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"install-packages libapache2-mod-wsgi libssl-dev libffi-dev"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"os-svc-install $KEYSTONE_EXTRA_INSTALL_OPTS -i \"$KEYSTONE_VENV_DIR\" -u keystone -r /opt/stack/keystone"},{"line_number":7,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_1bf39be7","line":4,"updated":"2014-08-04 17:00:41.000000000","message":"We should probably go ahead and use pkg-map for this instead of hard coding debian package names here.","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"install-packages libapache2-mod-wsgi libssl-dev libffi-dev"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"os-svc-install $KEYSTONE_EXTRA_INSTALL_OPTS -i \"$KEYSTONE_VENV_DIR\" -u keystone -r /opt/stack/keystone"},{"line_number":7,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_02cb274a","line":4,"in_reply_to":"baada198_1bf39be7","updated":"2014-08-04 21:02:46.000000000","message":"Will do","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install -m 0755 -o keystone -g keystone -d /etc/keystone/ssl"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#Create a log directory"},{"line_number":11,"context_line":"mkdir -p /var/log/keystone"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"ln -s $KEYSTONE_VENV_DIR/bin/keystone-manage /usr/local/bin/keystone-manage"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_1bc47b3f","line":11,"updated":"2014-08-04 17:00:41.000000000","message":"set proper permissions on this log directory!?","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":8,"context_line":"install -m 0755 -o keystone -g keystone -d /etc/keystone/ssl"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"#Create a log directory"},{"line_number":11,"context_line":"mkdir -p /var/log/keystone"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"ln -s $KEYSTONE_VENV_DIR/bin/keystone-manage /usr/local/bin/keystone-manage"},{"line_number":14,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_22d66bf2","line":11,"in_reply_to":"baada198_1bc47b3f","updated":"2014-08-04 21:02:46.000000000","message":"Will do","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"49ffd8a493d957ed05dab966c31539bc4d3ca633","unresolved":false,"context_lines":[{"line_number":32,"context_line":"if [[ \"$DEBIAN_DISTROS\" \u003d~ \"$DISTRO\" ]]; then   "},{"line_number":33,"context_line":"   install -m 0744 -o keystone -g keystone /opt/stack/keystone/httpd/keystone.py /etc/keystone/admin"},{"line_number":34,"context_line":"   ln -s /etc/keystone/admin /etc/keystone/main"},{"line_number":35,"context_line":"   "},{"line_number":36,"context_line":"   chmod 711 /etc/keystone"},{"line_number":37,"context_line":"   install -m 0644 -o root -g root $(dirname $0)/../files/keystone_modwsgi.conf  /etc/apache2/sites-available"},{"line_number":38,"context_line":"   a2ensite keystone_modwsgi.conf"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_e253b0db","line":35,"updated":"2014-08-04 07:50:38.000000000","message":"couple whitespace nits here","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":32,"context_line":"if [[ \"$DEBIAN_DISTROS\" \u003d~ \"$DISTRO\" ]]; then   "},{"line_number":33,"context_line":"   install -m 0744 -o keystone -g keystone /opt/stack/keystone/httpd/keystone.py /etc/keystone/admin"},{"line_number":34,"context_line":"   ln -s /etc/keystone/admin /etc/keystone/main"},{"line_number":35,"context_line":"   "},{"line_number":36,"context_line":"   chmod 711 /etc/keystone"},{"line_number":37,"context_line":"   install -m 0644 -o root -g root $(dirname $0)/../files/keystone_modwsgi.conf  /etc/apache2/sites-available"},{"line_number":38,"context_line":"   a2ensite keystone_modwsgi.conf"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_42d19ff6","line":35,"in_reply_to":"baada198_e253b0db","updated":"2014-08-04 21:02:46.000000000","message":"Will do","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"}],"elements/keystone/os-refresh-config/post-configure.d/70-keystone":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"export DISTRO\u003d`lsb_release -si` || true"},{"line_number":5,"context_line":"export DEBIAN_DISTROS\u003d\"Ubuntu Debian\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"keystone-manage --debug db_sync"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_5b10b3f3","line":4,"updated":"2014-08-04 17:00:41.000000000","message":"We already have a DISTRO_NAME variable. So you could just use it instead... All the OS elements set it accordingly.","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"export DISTRO\u003d`lsb_release -si` || true"},{"line_number":5,"context_line":"export DEBIAN_DISTROS\u003d\"Ubuntu Debian\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"keystone-manage --debug db_sync"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_c2fccf73","line":4,"in_reply_to":"baada198_5b10b3f3","updated":"2014-08-04 21:02:46.000000000","message":"Will do","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"export DISTRO\u003d`lsb_release -si` || true"},{"line_number":5,"context_line":"export DEBIAN_DISTROS\u003d\"Ubuntu Debian\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"keystone-manage --debug db_sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"$DEBIAN_DISTROS\" \u003d~ \"$DISTRO\" ]]; then"},{"line_number":10,"context_line":"   service apache2 restart"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_db24c360","line":7,"updated":"2014-08-04 17:00:41.000000000","message":"Why --debug here?","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":4,"context_line":"export DISTRO\u003d`lsb_release -si` || true"},{"line_number":5,"context_line":"export DEBIAN_DISTROS\u003d\"Ubuntu Debian\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"keystone-manage --debug db_sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"$DEBIAN_DISTROS\" \u003d~ \"$DISTRO\" ]]; then"},{"line_number":10,"context_line":"   service apache2 restart"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_42e8bfa6","line":7,"in_reply_to":"baada198_db24c360","updated":"2014-08-04 21:02:46.000000000","message":"Will remove it. Added this to debug jenkins failure","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"892b062f0207db2f383fa6f193259405f60c564b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"keystone-manage --debug db_sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"$DEBIAN_DISTROS\" \u003d~ \"$DISTRO\" ]]; then"},{"line_number":10,"context_line":"   service apache2 restart"},{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"   os-svc-enable -n keystone"},{"line_number":13,"context_line":"   os-svc-restart -n keystone"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_7b2bb732","line":10,"updated":"2014-08-04 17:00:41.000000000","message":"Does apache not need to be restarted on RHEL distros?","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"a3ddd5f22a59fd8b8abd257da28a1234395cd529","unresolved":false,"context_lines":[{"line_number":7,"context_line":"keystone-manage --debug db_sync"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ \"$DEBIAN_DISTROS\" \u003d~ \"$DISTRO\" ]]; then"},{"line_number":10,"context_line":"   service apache2 restart"},{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"   os-svc-enable -n keystone"},{"line_number":13,"context_line":"   os-svc-restart -n keystone"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"baada198_0267a751","line":10,"in_reply_to":"baada198_7b2bb732","updated":"2014-08-04 21:02:46.000000000","message":"I did this initially only for debian.  I thought of adding Fedora as next step. Will add both in next patch set","commit_id":"385c2e24403520dd5307741c8f74409a050d91b6"}]}