)]}'
{"elements/tripleo-cd/deploy-ci-overcloud":[{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"e1960550058a7ffbcd830f636fe83a3efbf9b0f0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# API endpoint for host file injection"},{"line_number":51,"context_line":"export OVERCLOUD_NAME\u003d$(jq -r .OvercloudName \u003c\u003c\u003c $OC_ENV)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# How many machines (46 machines in theory)"},{"line_number":54,"context_line":"export OVERCLOUD_CONTROLSCALE\u003d$(jq -r .OvercloudControlscale \u003c\u003c\u003c $OC_ENV)"},{"line_number":55,"context_line":"export OVERCLOUD_COMPUTESCALE\u003d$(jq -r .OvercloudComputescale \u003c\u003c\u003c $OC_ENV)"},{"line_number":56,"context_line":"# testenv count \u003d 25, 3:2 memory ratio between testenv needs and CI slaves."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"fa98f980_1b75a097","line":53,"updated":"2014-09-12 05:07:17.000000000","message":"46 refers to HP1, this should be removed","commit_id":"f66347cb1e724d49711596f8c967442c58df7edf"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b4dcd73920f6444aa8bfbbee8a2cc40b894a3c9d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CI_ENV\u003d$(jq \".\" ${FILE_PREFIX}_ci_env.json)"},{"line_number":41,"context_line":"NETWORKS\u003d$(jq \".\" ${FILE_PREFIX}_networks.json)"},{"line_number":42,"context_line":"OC_ENV\u003d$(jq \".\" ${FILE_PREFIX}_oc_env.json)"},{"line_number":43,"context_line":"UC_ENV\u003d$(jq \".\" ${FILE_PREFIX}_uc_env.json)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cd /"},{"line_number":46,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baa201ad_53f14fcc","line":43,"updated":"2014-09-30 10:44:55.000000000","message":"UC_ENV doesn\u0027t appear to be used?","commit_id":"2acf5fc7e55f050f20b6f6618e5f92961c917079"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"63b864222dd31c173383bf9f838a2f711f5a2608","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CI_ENV\u003d$(jq \".\" ${FILE_PREFIX}_ci_env.json)"},{"line_number":41,"context_line":"NETWORKS\u003d$(jq \".\" ${FILE_PREFIX}_networks.json)"},{"line_number":42,"context_line":"OC_ENV\u003d$(jq \".\" ${FILE_PREFIX}_oc_env.json)"},{"line_number":43,"context_line":"UC_ENV\u003d$(jq \".\" ${FILE_PREFIX}_uc_env.json)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"cd /"},{"line_number":46,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baa201ad_5bd6f94f","line":43,"in_reply_to":"baa201ad_53f14fcc","updated":"2014-10-09 02:30:11.000000000","message":"Done","commit_id":"2acf5fc7e55f050f20b6f6618e5f92961c917079"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b4dcd73920f6444aa8bfbbee8a2cc40b894a3c9d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    $OVERCLOUD_PUBLIC_VLAN_FINISH $OVERCLOUD_PUBLIC_VLAN_CIDR \\"},{"line_number":79,"context_line":"    $TRIPLEO_ROOT/tripleo-incubator/tripleo-cloud/tripleo-cd-admins \\"},{"line_number":80,"context_line":"    $TRIPLEO_ROOT/tripleo-incubator/tripleo-cloud/tripleo-cd-users \\"},{"line_number":81,"context_line":"    $STACKNAME /home/shared/ssl/${OVERCLOUD_NAME} ${OVERCLOUD_NAME}"},{"line_number":82,"context_line":"RESULT\u003d$?"},{"line_number":83,"context_line":"set -e"},{"line_number":84,"context_line":"MSG\u003d$(echo \"************** $STACKNAME complete status\u003d$RESULT ************\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baa201ad_93881724","line":81,"updated":"2014-09-30 10:44:55.000000000","message":"nit: I\u0027d prefer 78-81 were indented to show they\u0027re continuation lines\n\nalso all values with substitutions should be quoted: Id1a6a0bcd1c385ce4383ef3260efc4ef0bc96f74","commit_id":"2acf5fc7e55f050f20b6f6618e5f92961c917079"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"63b864222dd31c173383bf9f838a2f711f5a2608","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    $OVERCLOUD_PUBLIC_VLAN_FINISH $OVERCLOUD_PUBLIC_VLAN_CIDR \\"},{"line_number":79,"context_line":"    $TRIPLEO_ROOT/tripleo-incubator/tripleo-cloud/tripleo-cd-admins \\"},{"line_number":80,"context_line":"    $TRIPLEO_ROOT/tripleo-incubator/tripleo-cloud/tripleo-cd-users \\"},{"line_number":81,"context_line":"    $STACKNAME /home/shared/ssl/${OVERCLOUD_NAME} ${OVERCLOUD_NAME}"},{"line_number":82,"context_line":"RESULT\u003d$?"},{"line_number":83,"context_line":"set -e"},{"line_number":84,"context_line":"MSG\u003d$(echo \"************** $STACKNAME complete status\u003d$RESULT ************\")"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"baa201ad_9badc19d","line":81,"in_reply_to":"baa201ad_93881724","updated":"2014-10-09 02:30:11.000000000","message":"I\u0027ve fixed the substitutions. \n\nI\u0027m not sure what indentation is used to show a continuation line. As far as I can tell the 4-space indentation here is consistent with what\u0027s used in other elements (eg, in nova-api/install.d/nova-package-install/80-nova-api). If you can point me at a specific guideline or sample I\u0027d be happy to modify this to match.","commit_id":"2acf5fc7e55f050f20b6f6618e5f92961c917079"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"5cb0d3f77a15e82331f82c478d498e15fa81e105","unresolved":false,"context_lines":[{"line_number":1,"context_line":" "},{"line_number":2,"context_line":"!/bin/bash"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"baa201ad_6ed65329","line":2,"updated":"2014-10-12 22:24:53.000000000","message":"Indeed.","commit_id":"1b296fceb00b720a39e3aa5869c970202becc13b"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d9573df412aa346ec168f2c11511bb9a5cb4b562","unresolved":false,"context_lines":[{"line_number":1,"context_line":" "},{"line_number":2,"context_line":"!/bin/bash"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":5,"context_line":"# All Rights Reserved."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"baa201ad_12660b2a","line":2,"updated":"2014-10-09 10:10:47.000000000","message":"oh dear","commit_id":"1b296fceb00b720a39e3aa5869c970202becc13b"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d9573df412aa346ec168f2c11511bb9a5cb4b562","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"${OVERCLOUD_PUBLIC_VLAN_FINISH}\" \"${OVERCLOUD_PUBLIC_VLAN_CIDR}\" \\"},{"line_number":79,"context_line":"    \"${TRIPLEO_ROOT}/tripleo-incubator/tripleo-cloud/tripleo-cd-admins\" \\"},{"line_number":80,"context_line":"    \"${TRIPLEO_ROOT}/tripleo-incubator/tripleo-cloud/tripleo-cd-users\" \\"},{"line_number":81,"context_line":"    \"${STACKNAME}\" \"/home/shared/ssl/${OVERCLOUD_NAME}\" \"${OVERCLOUD_NAME}\""},{"line_number":82,"context_line":"RESULT\u003d$?"},{"line_number":83,"context_line":"set -e"},{"line_number":84,"context_line":"MSG\u003d$(echo \"************** $STACKNAME complete status\u003d$RESULT ************\")"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"baa201ad_b2745fcf","line":81,"updated":"2014-10-09 10:10:47.000000000","message":"re: continuations, this is correct, I didn\u0027t see line 76 somehow!\n\nthanks for adding all those quotes :)","commit_id":"1b296fceb00b720a39e3aa5869c970202becc13b"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"313f53261a0fedc2c438f9b89b8dff1ad193bbbf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    echo \"    will be searched for in confings/hp2_networks.json\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CONFIG_DIR\u003d${1:-$CWD/configs}"},{"line_number":37,"context_line":"REGION_CODE\u003d${2:-hp1}"},{"line_number":38,"context_line":"FILE_PREFIX\u003d$CONFIG_DIR/$REGION_CODE"},{"line_number":39,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"baa201ad_d514b54e","line":36,"updated":"2014-10-16 13:29:59.000000000","message":"$CWD isn\u0027t getting set anywhere, did ya mean PWD ?","commit_id":"a2df814d6afeca920633270ae04b605c76394d53"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"3b92fa08bec9141f78209362ce41cbb1e35b6d97","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    echo \"    will be searched for in confings/hp2_networks.json\""},{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CONFIG_DIR\u003d${1:-$CWD/configs}"},{"line_number":37,"context_line":"REGION_CODE\u003d${2:-hp1}"},{"line_number":38,"context_line":"FILE_PREFIX\u003d$CONFIG_DIR/$REGION_CODE"},{"line_number":39,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9aa7fdbe_6cbbf2c4","line":36,"updated":"2014-10-20 00:10:49.000000000","message":"Yes, that\u0027s exactly what I meant.\n\nI\u0027ve never noticed this problem because I\u0027ve always specified a config dir.","commit_id":"a2df814d6afeca920633270ae04b605c76394d53"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"3b92fa08bec9141f78209362ce41cbb1e35b6d97","unresolved":false,"context_lines":[{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CONFIG_DIR\u003d${1:-$CWD/configs}"},{"line_number":37,"context_line":"REGION_CODE\u003d${2:-hp1}"},{"line_number":38,"context_line":"FILE_PREFIX\u003d$CONFIG_DIR/$REGION_CODE"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CI_ENV\u003d$(jq \".\" ${FILE_PREFIX}_ci_env.json)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9aa7fdbe_8cb016df","line":37,"updated":"2014-10-20 00:10:49.000000000","message":"Backwards compatibility (the old script had hp1 hard-coded).\n\nOn the other hand, that presumably means that if this breaks backwards compatibility, there\u0027s precisely one place in the world that needs to change to match the new setup, and the people approving this change are the people who are able to make that change - so maybe backwards compatibility isn\u0027t such a big deal here.\n\nI\u0027m convinced - this is done.","commit_id":"a2df814d6afeca920633270ae04b605c76394d53"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"313f53261a0fedc2c438f9b89b8dff1ad193bbbf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CONFIG_DIR\u003d${1:-$CWD/configs}"},{"line_number":37,"context_line":"REGION_CODE\u003d${2:-hp1}"},{"line_number":38,"context_line":"FILE_PREFIX\u003d$CONFIG_DIR/$REGION_CODE"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CI_ENV\u003d$(jq \".\" ${FILE_PREFIX}_ci_env.json)"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"baa201ad_582e3c8d","line":37,"updated":"2014-10-16 13:29:59.000000000","message":"there is probably no reason to default this to hp1, how about we make the short name the first param and required?","commit_id":"a2df814d6afeca920633270ae04b605c76394d53"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"313f53261a0fedc2c438f9b89b8dff1ad193bbbf","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CI_ENV\u003d$(jq \".\" ${FILE_PREFIX}_ci_env.json)"},{"line_number":41,"context_line":"NETWORKS\u003d$(jq \".\" ${FILE_PREFIX}_networks.json)"},{"line_number":42,"context_line":"OC_ENV\u003d$(jq \".\" ${FILE_PREFIX}_oc_env.json)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cd /"},{"line_number":45,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"baa201ad_58fd5cb0","line":42,"updated":"2014-10-16 13:29:59.000000000","message":"Can you test if these files exist, jq seems to ignore if they are not present and keep going\n\n    $ jq . configs/hp1_ci_env.json_ ; echo $?\n    jq: configs/hp1_ci_env.json_: No such file or directory\n    0\n\n\nAlso I think its more readable if we don\u0027t load these into env vars and just pass the filepath to jq, but thats just me, I\u0027m good either way.","commit_id":"a2df814d6afeca920633270ae04b605c76394d53"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"3b92fa08bec9141f78209362ce41cbb1e35b6d97","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CI_ENV\u003d$(jq \".\" ${FILE_PREFIX}_ci_env.json)"},{"line_number":41,"context_line":"NETWORKS\u003d$(jq \".\" ${FILE_PREFIX}_networks.json)"},{"line_number":42,"context_line":"OC_ENV\u003d$(jq \".\" ${FILE_PREFIX}_oc_env.json)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cd /"},{"line_number":45,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9aa7fdbe_acb5dace","line":42,"updated":"2014-10-20 00:10:49.000000000","message":"I don\u0027t like the idea of passing the filepath to jq each time it\u0027s used; OC_ENVis read 5 times and NETWORKS 3. Possibly we could put the filepath in the variable and then provide that to jq to avoid the \u003c\u003c\u003c, and rely on the kernel buffering the file to prevent it being re-read repeatedly?\n\nI\u0027ll make this change if anyone strongly wants it, but I\u0027m not convinced it\u0027s required so I\u0027m not going to do it just now.\n\nI think we would want the script to fail if any of the scripts don\u0027t exist, right? Because that would mean that we have no data to use later in the script?\n\nOf course I can test to see if these files exist, but to do that I\u0027m going to be calculating the filename twice, and that means I may as well put it in a variable to avoid the re-calculation... and if it\u0027s in a filename anyway then maybe I should just go ahead and use that.\n\nSo. Looks like I\u0027m going to make that change now after all.","commit_id":"a2df814d6afeca920633270ae04b605c76394d53"}]}