)]}'
{"elements/keepalived/os-refresh-config/configure.d/22-keepalived":[{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"037af02e05973c12d872cafc46db1cdc9620abec","unresolved":false,"context_lines":[{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":"set -o pipefail"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"os-svc-enable -n keepalived"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"INTERFACES\u003d$(os-apply-config --key virtual_interfaces.instances --type raw --key-default \u0027\u0027)"},{"line_number":8,"context_line":"if [ -z \"$INTERFACES\" ] ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa98f980_1db4d480","line":5,"updated":"2014-09-11 11:22:14.000000000","message":"Shouldn\u0027t this be after the test for an interface, otherwise keepalived will come up on boot and may not have an interface?","commit_id":"ac24bc5d7cb3eb2a2a893afcdcc683a1c2efe62d"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"d26afc8f151d959e60447173f52cd90aaf065c68","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"os-svc-enable -n keepalived"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -e /var/run/keepalived.pid ] \u0026\u0026 pgrep -F /var/run/keepalived.pid keepalived \u0026\u003e/dev/null; then"},{"line_number":14,"context_line":"    service keepalived reload"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    service keepalived restart"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_06c9d125","line":13,"updated":"2014-09-11 19:31:57.000000000","message":"this is no longer needed right? since keepalived shouldn\u0027t be running.\n\nyou should be able to replace this \"if\" block with just a:\n\n  os-svc-restart -n keepalived","commit_id":"95bfdde96897805a8447f10e003814c3a5ae5f3a"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"0f39a7504da900175576fd4da82f165db41bd4a0","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"os-svc-enable -n keepalived"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -e /var/run/keepalived.pid ] \u0026\u0026 pgrep -F /var/run/keepalived.pid keepalived \u0026\u003e/dev/null; then"},{"line_number":14,"context_line":"    service keepalived reload"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    service keepalived restart"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_218f9f2b","line":13,"in_reply_to":"fa98f980_06c9d125","updated":"2014-09-11 19:54:24.000000000","message":"Keepalived can be running when:\n * os-refresh-config runs multiple times during boot\n * doing stack update\n\nI don\u0027t think this patch makes the \"if\" condition useless.","commit_id":"95bfdde96897805a8447f10e003814c3a5ae5f3a"},{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"1ab620e46306bcd6847870926df7584337945bc1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"os-svc-enable -n keepalived"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -e /var/run/keepalived.pid ] \u0026\u0026 pgrep -F /var/run/keepalived.pid keepalived \u0026\u003e/dev/null; then"},{"line_number":14,"context_line":"    service keepalived reload"},{"line_number":15,"context_line":"else"},{"line_number":16,"context_line":"    service keepalived restart"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa98f980_d5559cc2","line":13,"in_reply_to":"fa98f980_218f9f2b","updated":"2014-09-12 11:50:45.000000000","message":"ok, thanks for the clarification.","commit_id":"95bfdde96897805a8447f10e003814c3a5ae5f3a"}]}