)]}'
{"elements/os-svc-install/bin/os-svc-install":[{"author":{"_account_id":1872,"name":"therese-mchale","email":"therese.mchale@hp.com","username":"therese-mchale"},"change_message_id":"741c516dc7bcc270e13c29e9b098d4628c2dc475","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                INSTALL_TYPE\u003d${!INSTALL_TYPE_VAR:-source}"},{"line_number":51,"context_line":"                if [ \"$INSTALL_TYPE\" \u003d \"source\" ] \\"},{"line_number":52,"context_line":"                   \u0026\u0026 grep -qw \"^$CLIENT\" $reqs ; then"},{"line_number":53,"context_line":"                    echo \"pip install /opt/stack/$CLIENT\""},{"line_number":54,"context_line":"                fi"},{"line_number":55,"context_line":"            done"},{"line_number":56,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a890539_554a2e84","line":53,"updated":"2014-11-10 14:53:03.000000000","message":"shouldn\u0027t this be pip install not echo pip install?","commit_id":"d51d7400b1f8728299e9e059fd66dcf8edbdb064"}],"elements/os-svc-install/element-deps":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f22b1895c7d08bb00812eb30628dfffa7ffa4bfb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_5fba08c1","line":6,"updated":"2014-11-12 18:09:04.000000000","message":"I don\u0027t think we should be forcing people to install all of the openstack-clients.  As I understand it, this change should use the source version if it\u0027s available, and if not fall back to pip.  That seems like it should work without adding the dependency.","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"213608834e7e9349db443f21a499a898757e2ae2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_852cfb03","line":6,"in_reply_to":"5a890539_17877210","updated":"2014-11-13 17:44:00.000000000","message":"I guess I don\u0027t understand the problem with the git repos not existing.  In that case, we know that none of the clients are being installed from source, so there\u0027s no inconsistency.  If the git repos do exist, then we\u0027ll use them because of the other changes in this patch.  Is there another case that I\u0027m missing?","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"09167044baf2796849ec2e93da6465ecd50435f2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_960a4e77","line":6,"in_reply_to":"5a890539_3510cba7","updated":"2014-11-14 17:04:21.000000000","message":"I guess I don\u0027t really see that as a problem, but if a user is bothered by that they can always include the openstack-clients element themselves.  I\u0027d still rather not force that on everyone, but maybe we could document it in the README for this element?","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":1605,"name":"tom-howley","email":"tom.howley@hp.com","username":"tom-howley"},"change_message_id":"e7e79840878f88f0d55c438f9b6d96d6292c783e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_17877210","line":6,"in_reply_to":"5a890539_5fba08c1","updated":"2014-11-13 11:55:53.000000000","message":"As mentioned in previous comments, I agree that it\u0027s not ideal to be pulling all of the openstack-clients. The problem is I need the git clones to be put on the image or this inconsistency to be resolved. They won\u0027t exist if openstack-clients element is not included.\n\nCan you suggest an alternative? I briefly toyed with the idea of using a separate element purely for the openstack-clients repositories file, but this seemed like overkill.","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":1605,"name":"tom-howley","email":"tom.howley@hp.com","username":"tom-howley"},"change_message_id":"a5bcdb41aabd3677d3e03ab3978731f6b4bd3b96","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_3510cba7","line":6,"in_reply_to":"5a890539_852cfb03","updated":"2014-11-14 00:56:32.000000000","message":"So when I mention inconsistency of a particular client package, I\u0027m talking about across a set of nodes. If I wish to install one particular client off a git repo, any node/image including the openstack-clients element will create the source-repositories file I need, which is in turn picked up by the source-repositories element to clone the required git repos. So all is fine there. However, if the same client is being pulled as a dependency by an os-svc-install on another node that happens not to include openstack-clients element, it will be unable to install the same version of the package as the git repo will not have been created. This is my reason for adding in the openstack-clients dependency, which is not necessarily ideal, but I\u0027m not sure it\u0027s harmful. I\u0027m basically using this element just to create source-repository-clients file -- in earlier patches, I added the file to this element, but this would override the openstack-clients file (when the elements co-exist) and besides, I think it is better to have this defined in one place.\n\nDoes that scenario sound valid/make sense to you?","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":215,"name":"Jon-Paul Sullivan","email":"j3p0uk@hotmail.com","username":"jonpaul-sullivan"},"change_message_id":"f7eec4957c058fbb6b351f47ddc5831b37dcf85c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_cc05f911","line":6,"in_reply_to":"5a890539_960a4e77","updated":"2014-11-17 15:31:53.000000000","message":"@Ben - so at the minute clients will be installed from multiple different places.  The clients themselves, via openstack-clients, are installed from source repos.  But if clients are listed in the requirements file of a service they will be installed from pip.  This results in potentially different versions of the client being installed in a single image.\n\nThe other use-case for this change is when you know that the version of a client on pip is not going to work, and so you want to specifically override it with a source version.  To do this the source repo needs to get into the image, via the source-repositories element, and it seemed the cleanest way of doing that was to add the dependency rather than duplicating the information in 2 different elements, or by breaking up the openstack-clients element to separate the source-repository part to be used as a dependency.","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":1605,"name":"tom-howley","email":"tom.howley@hp.com","username":"tom-howley"},"change_message_id":"dc5eee3486d20813e09111b231a8cfdd7e815650","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_0cab7c89","line":6,"in_reply_to":"5a890539_cc05f911","updated":"2014-11-17 17:38:53.000000000","message":"If it is acceptable, I can go with original idea of creating a separate small openstack-clients-source-repositories element that just contains that file (and make os-svc-install and openstack-clients depend on it). I wasn\u0027t sure if that idea would fly upstream.","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"b27ac5db8ce28fef344f51f339c72e12cd26267e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"pip-manifest"},{"line_number":4,"context_line":"selinux"},{"line_number":5,"context_line":"svc-map"},{"line_number":6,"context_line":"openstack-clients"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_6e4ad928","line":6,"in_reply_to":"5a890539_cc05f911","updated":"2014-11-19 21:39:37.000000000","message":"My reason for objecting to this is that the other part of this change already addresses the inconsistency within images.  On a given image, it will get all source or all pip, depending on whether source clients are being included in the image.\n\nAnd the pip client should always work.  If it doesn\u0027t that\u0027s a \"break the world\" kind of mistake on someone\u0027s part (we\u0027re running pip clients in the gate now, so it would completely blow up), and if that were to happen somehow, the workaround is simple - include openstack-clients in your element list and you get the same behavior we\u0027d otherwise be enforcing with this dependency.\n\nIn any case, I\u0027m happy with the latest patch set so I won\u0027t belabor the point any more. :-)","commit_id":"7a0c01ac039975361e27f899efac448b0d9f0641"}],"elements/os-svc-install/source-repository-clients":[{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"1a70a960388ebee9b357f88de2f957022397d047","unresolved":false,"context_lines":[{"line_number":6,"context_line":"python-keystoneclient git /opt/stack/python-keystoneclient https://git.openstack.org/openstack/python-keystoneclient.git"},{"line_number":7,"context_line":"python-neutronclient git /opt/stack/python-neutronclient https://git.openstack.org/openstack/python-neutronclient.git"},{"line_number":8,"context_line":"python-novaclient git /opt/stack/python-novaclient https://git.openstack.org/openstack/python-novaclient.git"},{"line_number":9,"context_line":"python-swiftclient git /opt/stack/python-swiftclient https://git.openstack.org/openstack/python-swiftclient.git"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a890539_b9816d91","line":9,"updated":"2014-11-11 17:37:45.000000000","message":"python-openstackclient is missing from this list.\n\nAlso, this is duplicated from tripleo-image-elements/elements/openstack-clients/source-repository-clients","commit_id":"afe3c866b1ae42ea2a02d791bab3768f9f1bcbac"},{"author":{"_account_id":1605,"name":"tom-howley","email":"tom.howley@hp.com","username":"tom-howley"},"change_message_id":"3214075d895406d51775431f6cb2c1129a76ba7b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"python-keystoneclient git /opt/stack/python-keystoneclient https://git.openstack.org/openstack/python-keystoneclient.git"},{"line_number":7,"context_line":"python-neutronclient git /opt/stack/python-neutronclient https://git.openstack.org/openstack/python-neutronclient.git"},{"line_number":8,"context_line":"python-novaclient git /opt/stack/python-novaclient https://git.openstack.org/openstack/python-novaclient.git"},{"line_number":9,"context_line":"python-swiftclient git /opt/stack/python-swiftclient https://git.openstack.org/openstack/python-swiftclient.git"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a890539_1f196079","line":9,"in_reply_to":"5a890539_b46c149e","updated":"2014-11-12 17:41:41.000000000","message":"This is a good point. I\u0027ve addressed in the next patch by depending on openstack-clients. It\u0027s not ideal as it causes openstack-clients to be invoked where we don\u0027t necessarily need it, but I think we could get away with it?","commit_id":"afe3c866b1ae42ea2a02d791bab3768f9f1bcbac"},{"author":{"_account_id":1726,"name":"Ghe Rivero","email":"ghe.rivero@gmail.com","username":"ghe.rivero"},"change_message_id":"3f9e78aed17b8f0eb34bfc0838aeee7220315f79","unresolved":false,"context_lines":[{"line_number":6,"context_line":"python-keystoneclient git /opt/stack/python-keystoneclient https://git.openstack.org/openstack/python-keystoneclient.git"},{"line_number":7,"context_line":"python-neutronclient git /opt/stack/python-neutronclient https://git.openstack.org/openstack/python-neutronclient.git"},{"line_number":8,"context_line":"python-novaclient git /opt/stack/python-novaclient https://git.openstack.org/openstack/python-novaclient.git"},{"line_number":9,"context_line":"python-swiftclient git /opt/stack/python-swiftclient https://git.openstack.org/openstack/python-swiftclient.git"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a890539_b46c149e","line":9,"in_reply_to":"5a890539_b9816d91","updated":"2014-11-11 17:50:02.000000000","message":"this file is overwriting the one in the openstack-client element","commit_id":"afe3c866b1ae42ea2a02d791bab3768f9f1bcbac"}]}