)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f741283cfa5328c339ea74255bdcb1bc3b54302a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When creating an ubuntu image with localboot, the postinst script"},{"line_number":10,"context_line":"of grub-pc will try to find root device and install grub which will"},{"line_number":11,"context_line":"definitely fail in such a chroot environment. Refer to"},{"line_number":12,"context_line":"http://paste.openstack.org/show/196974/"},{"line_number":13,"context_line":"for detail output."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia29387f33c33e760c2711c687a43025b2013bd84"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa963961_9304ca15","line":12,"updated":"2015-03-27 10:41:51.000000000","message":"Hey Zhenzan, do you think you can file a bug instead and put the output there - that paste may not be around if someone ever wants to track this change and the problem it addresses.","commit_id":"1abeecf16a7f41c71b3d38beedd98a54ea978430"}],"elements/localboot/install.d/99-boot-helpers":[{"author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"change_message_id":"5c5af4380662d5864b870c0c131bdf33e106f7be","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    # device which definitely fail at this stage."},{"line_number":9,"context_line":"    # The workaround is to skip error and remove postinst script"},{"line_number":10,"context_line":"    if [[ \"ubuntu debian\" \u003d~ \"$DISTRO_NAME\" ]]; then"},{"line_number":11,"context_line":"        install-packages grub-pc || true"},{"line_number":12,"context_line":"        GRUB_POSTINST\u003d/var/lib/dpkg/info/grub-pc.postinst"},{"line_number":13,"context_line":"        [ -e $GRUB_POSTINST ] \u0026\u0026 rm -f $GRUB_POSTINST"},{"line_number":14,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da9b358b_2dad86e9","line":11,"updated":"2015-03-30 20:57:35.000000000","message":"so it\u0027s possible we might end up with grub-pc not installed at all, due to some other error. a localboot failure caused by that would be really hard to debug and trace back to this \"|| true\" here.\n\ncould this be a case to momentarily set +e and check the actual return code from install-packages? assuming apt-get gives you something useful","commit_id":"46211b7d40a7b45c74d0563f07eba49a3ebd51a6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8910b1f9bd7914ebd9a6b19b0d00d256c856001d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        install-packages grub-pc"},{"line_number":13,"context_line":"        # if grub-pc.postinst exists, it\u0027s the postinst issue"},{"line_number":14,"context_line":"        # otherwise we should still fail here"},{"line_number":15,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"            GRUB_POSTINST\u003d/var/lib/dpkg/info/grub-pc.postinst"},{"line_number":17,"context_line":"            if [ -e $GRUB_POSTINST ]; then"},{"line_number":18,"context_line":"                rm -f $GRUB_POSTINST"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"da9b358b_af2b8e93","line":15,"updated":"2015-04-01 07:43:20.000000000","message":"am guessing we can\u0027t be anymore specific here about the code if it was the postinst issue (though this is a great improvement wrt what slagle brought up)","commit_id":"476af257304f42f3e1521919c7b6e06d94d07911"},{"author":{"_account_id":13790,"name":"Zhenzan Zhou","email":"linuxosa@gmail.com","username":"zhenzanzhou"},"change_message_id":"377364f8b24b1bf8dff1fbf473fa538870da26b4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        install-packages grub-pc"},{"line_number":13,"context_line":"        # if grub-pc.postinst exists, it\u0027s the postinst issue"},{"line_number":14,"context_line":"        # otherwise we should still fail here"},{"line_number":15,"context_line":"        if [ $? -ne 0 ]; then"},{"line_number":16,"context_line":"            GRUB_POSTINST\u003d/var/lib/dpkg/info/grub-pc.postinst"},{"line_number":17,"context_line":"            if [ -e $GRUB_POSTINST ]; then"},{"line_number":18,"context_line":"                rm -f $GRUB_POSTINST"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"baa041b7_20aa6a71","line":15,"in_reply_to":"da9b358b_af2b8e93","updated":"2015-04-01 13:36:23.000000000","message":"Thanks for review. Yes, according to apt-get man page, it always returns 100 on error:\n\nDIAGNOSTICS\n       apt-get returns zero on normal operation, decimal 100 on error.","commit_id":"476af257304f42f3e1521919c7b6e06d94d07911"}]}