)]}'
{"id":"openstack%2Ftripleo-image-elements~60054","triplet_id":"openstack%2Ftripleo-image-elements~master~I8c92e8a4808d8c76014fa74279d8a3bbffc017c7","project":"openstack/tripleo-image-elements","branch":"master","topic":"60055","hashtags":[],"change_id":"I8c92e8a4808d8c76014fa74279d8a3bbffc017c7","subject":"Create tests for example metadata and templates","status":"ABANDONED","created":"2013-12-04 19:27:25.000000000","updated":"2013-12-14 06:03:15.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"13bfec29f8cbf4061b41b8bb01fa2bf6d0130f28","_number":60054,"virtual_id_number":60054,"owner":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"value":1,"date":"2013-12-04 21:33:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"all":[{"value":-1,"date":"2013-12-05 02:56:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"date":"2013-12-05 07:06:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":2,"date":"2013-12-04 21:41:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2013-12-05 02:56:51.000000000","_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"date":"2013-12-04 21:41:20.000000000","_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-04 19:38:03.000000000","updated_by":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"reviewer":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"state":"REVIEWER"},{"updated":"2013-12-04 21:33:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2013-12-04 21:41:20.000000000","updated_by":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"reviewer":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"state":"REVIEWER"},{"updated":"2013-12-05 02:56:51.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2013-12-05 07:06:16.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"}],"messages":[{"id":"64bac645941ab13c69796db1662b5b9ae2cc2513","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-04 19:27:31.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-noop http://logs.openstack.org/54/60054/1/check/gate-noop/e460d90 : SUCCESS in 2s\n","accounts_in_message":[],"_revision_number":1},{"id":"1e5fa2020f6f7296f6c114e030a1d015672b1ca4","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2013-12-04 19:33:13.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"089284f33bde4bc9583d9b43b6ea94646584f47b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-04 19:33:17.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-noop http://logs.openstack.org/54/60054/2/check/gate-noop/64198c2 : SUCCESS in 0s\n","accounts_in_message":[],"_revision_number":2},{"id":"4972bad718d269318d5f169bdf6944b7c3b5beca","author":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"date":"2013-12-04 19:38:03.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"5d1a7b0006578cc43b3fb816ef4e4804c38b2271","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2013-12-04 20:50:43.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"21f4f74e0aedc2c0ee88931e7869dd2bd5afa478","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2013-12-04 21:33:31.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ed5cf1503b961369c98bc854f22d8b6c486c1153","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-04 21:33:37.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-noop http://logs.openstack.org/54/60054/3/check/gate-noop/3260abe : SUCCESS in 2s\n","accounts_in_message":[],"_revision_number":3},{"id":"923e8950f62f2a58fe64438840468cce736fc94f","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2013-12-04 21:33:48.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c427ea7e77624b465e4a9abb70cf91cf35a95516","author":{"_account_id":7144,"name":"James Slagle","email":"jslagle@redhat.com","username":"slagle"},"date":"2013-12-04 21:41:20.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8779c60910d3fe0db253f0f540e5fc6f587a68c9","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-12-05 02:56:51.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nI like the idea but:\n\n - The code for this doesn\u0027t belong in tie : this is something other elements repos will want\n\n - merging the config fragment from a README.md with a template will often, legitimately not configure everything. So I\u0027m not sure what it tells us. \n\n - The test script is itself complex enough to warrant tests.","accounts_in_message":[],"_revision_number":3},{"id":"23defa985b8b48f46e07512bec5d8932781a2a17","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-12-05 07:06:16.000000000","message":"Patch Set 3:\n\nWe\u0027re basically just going to catch template rendering errors here. We could go further and have sets of (input metadata, desired rendering) tests to catch more subtle issues like I398ba7bca46b66031e6ed68611fdd86f839c7cbc and have these tests stored in e.g. elements/*/tests/os-apply-config. It could be a pain to keep the tests up to date as we evolve the configs though.\n\nI\u0027m not bothering reviewing in any detail since lifeless wants the whole thing re-worked, but IMHO the basic idea here is fine as a first cut to merge and then we can iterate on it later.","accounts_in_message":[],"_revision_number":3},{"id":"3b3bd190b9c9a1f09b0500ad9c595ba724d44af5","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2013-12-06 17:34:20.000000000","message":"Patch Set 3: Work In Progress\n\nlifeless has convinced me to move this to os-apply-config.","accounts_in_message":[],"_revision_number":3},{"id":"8602abb3a002c98bb1fedb50b50fa00686875956","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-12-14 06:03:15.000000000","message":"Patch Set 3:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3},{"id":"6aef58114774a0281de8a304eb436b42f85723b2","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-12-14 06:03:15.000000000","message":"Patch Set 3: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e4489a6ce442f14d9f47584159e2c1e5eec6f0de","revisions":{"9e2756d0eccb23bac23a7981cc8ae1b81cfefe0f":{"kind":"REWORK","_number":1,"created":"2013-12-04 19:27:25.000000000","uploader":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"ref":"refs/changes/54/60054/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-image-elements","ref":"refs/changes/54/60054/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/1"}}},"commit":{"parents":[{"commit":"fa289b865c0fe016161d09cfb8546704dc84df7f","subject":"Merge \"Add element for tripleo-heat-templates.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/fa289b865c0fe016161d09cfb8546704dc84df7f"}]}],"author":{"name":"Clint Byrum","email":"clint@fewbar.com","date":"2013-12-04 19:18:06.000000000","tz":-480},"committer":{"name":"Clint Byrum","email":"clint@fewbar.com","date":"2013-12-04 19:18:06.000000000","tz":-480},"subject":"Create tests for example metadata and templates","message":"Create tests for example metadata and templates\n\nIt can be difficult to test these things in their natural environment as\ntypically one must build an image and deploy it. test-example-metadata\nencourages making the example metadata in README.md parsable. We also\nattempt to merge it with any os-apply-config templates in the element.\n\nChange-Id: I8c92e8a4808d8c76014fa74279d8a3bbffc017c7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/9e2756d0eccb23bac23a7981cc8ae1b81cfefe0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/9e2756d0eccb23bac23a7981cc8ae1b81cfefe0f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fa289b865c0fe016161d09cfb8546704dc84df7f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"01eb0a911c01f249487523d5c1af79963080443a":{"kind":"REWORK","_number":2,"created":"2013-12-04 19:33:13.000000000","uploader":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"ref":"refs/changes/54/60054/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-image-elements","ref":"refs/changes/54/60054/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/2"}}},"commit":{"parents":[{"commit":"fa289b865c0fe016161d09cfb8546704dc84df7f","subject":"Merge \"Add element for tripleo-heat-templates.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/fa289b865c0fe016161d09cfb8546704dc84df7f"}]}],"author":{"name":"Clint Byrum","email":"clint@fewbar.com","date":"2013-12-04 19:18:06.000000000","tz":-480},"committer":{"name":"Clint Byrum","email":"clint@fewbar.com","date":"2013-12-04 19:32:52.000000000","tz":-480},"subject":"Create tests for example metadata and templates","message":"Create tests for example metadata and templates\n\nIt can be difficult to test these things in their natural environment as\ntypically one must build an image and deploy it. test-example-metadata\nencourages making the example metadata in README.md parsable. We also\nattempt to merge it with any os-apply-config templates in the element.\n\nChange-Id: I8c92e8a4808d8c76014fa74279d8a3bbffc017c7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/01eb0a911c01f249487523d5c1af79963080443a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/01eb0a911c01f249487523d5c1af79963080443a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fa289b865c0fe016161d09cfb8546704dc84df7f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"e4489a6ce442f14d9f47584159e2c1e5eec6f0de":{"kind":"REWORK","_number":3,"created":"2013-12-04 21:33:31.000000000","uploader":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"ref":"refs/changes/54/60054/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-image-elements","ref":"refs/changes/54/60054/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-image-elements refs/changes/54/60054/3"}}},"commit":{"parents":[{"commit":"64c3708cb4d0edd35853103019fce3f0f9522f07","subject":"Add diskimage-builder element.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/64c3708cb4d0edd35853103019fce3f0f9522f07"}]}],"author":{"name":"Clint Byrum","email":"clint@fewbar.com","date":"2013-12-04 19:18:06.000000000","tz":-480},"committer":{"name":"Clint Byrum","email":"clint@fewbar.com","date":"2013-12-04 21:33:06.000000000","tz":-480},"subject":"Create tests for example metadata and templates","message":"Create tests for example metadata and templates\n\nIt can be difficult to test these things in their natural environment as\ntypically one must build an image and deploy it. test-example-metadata\nencourages making the example metadata in README.md parsable. We also\nattempt to merge it with any os-apply-config templates in the element.\n\nChange-Id: I8c92e8a4808d8c76014fa74279d8a3bbffc017c7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/e4489a6ce442f14d9f47584159e2c1e5eec6f0de"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/e4489a6ce442f14d9f47584159e2c1e5eec6f0de"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"64c3708cb4d0edd35853103019fce3f0f9522f07","is_merged_in_target_branch":true,"change_id":"I237ad800255d1ba927bfaa15c44dc352589b2df8","change_number":59361,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}