)]}'
{"id":"openstack%2Ftripleo-image-elements~777495","triplet_id":"openstack%2Ftripleo-image-elements~master~I03ca096ce69689a26fddc404279a8b003c971c15","project":"openstack/tripleo-image-elements","branch":"master","topic":"python3","hashtags":[],"change_id":"I03ca096ce69689a26fddc404279a8b003c971c15","subject":"Don\u0027t uninstall kexec-tools","status":"ABANDONED","created":"2021-02-25 02:33:59.000000000","updated":"2021-03-04 00:29:33.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"22e4115c2dea0e38bf4ad710f767e60976ef2172","_number":777495,"virtual_id_number":777495,"owner":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-02-25 04:11:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-02-25 05:19:18.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"disliked":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"value":2,"date":"2021-02-25 21:15:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":-1,"date":"2021-02-26 03:52:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-25 04:11:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-25 05:19:18.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-25 20:47:51.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"state":"REVIEWER"},{"updated":"2021-02-25 20:47:51.000000000","updated_by":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"},{"updated":"2021-03-01 22:01:54.000000000","updated_by":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"reviewer":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"state":"REVIEWER"}],"messages":[{"id":"798cc04713e390a9059bb0c0edd846cedbab9599","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-02-25 02:33:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93c74566312bd62817d813b8a4a79f9ee47b463c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-25 04:11:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-buildimage-overcloud-full-centos-8 https://zuul.opendev.org/t/openstack/build/e0609320452e45fd84e47cd886130b99 : SUCCESS in 56m 29s\n- tripleo-buildimage-ironic-python-agent-centos-8 https://zuul.opendev.org/t/openstack/build/428722d0486f4abd9d433c5fbc822da7 : SUCCESS in 30m 52s\n- tripleo-buildimage-overcloud-hardened-full-centos-8 https://zuul.opendev.org/t/openstack/build/bf3d544037754c6781856f5fd7f3a091 : SUCCESS in 34m 31s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/269cff3101cd485ea7515f221a5b9106 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f2740ffe7fa0441488c40daa54b93dff : SUCCESS in 3m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ba8d3e8b146445988b1002b9fcd2b932 : SUCCESS in 3m 24s","accounts_in_message":[],"_revision_number":1},{"id":"75892872e8f2e2cceacbe2cfb14811d56f8b44f5","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2021-02-25 05:19:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001 https://review.rdoproject.org/zuul/build/51082c3cef344e7491684d8a47bdc830 : SUCCESS in 2h 44m 25s","accounts_in_message":[],"_revision_number":1},{"id":"fc27be7e60aa22fe0c881a30f0579f4293987d17","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2021-02-25 21:15:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"78c0c911a9aaad212ef6a6154877af3e000559d8","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-02-26 03:52:04.000000000","message":"Patch Set 1: Code-Review-1\n\nThinking about this some more, removing kexec-tools is a security hardening action, so maybe leaving it is not ideal.\n\nOther options I can think of to handle this:\n- convert this into a script which runs in finalize after 50-dracut-regenerate\n- changing the behaviour of uninstall to leave \"unused\" dependencies","accounts_in_message":[],"_revision_number":1},{"id":"05e25925697ffe43a27b8db606a1debbd8d846ff","author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"date":"2021-03-01 22:13:45.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Thinking about this some more, removing kexec-tools is a security hardening action, so maybe leaving it is not ideal.\n\u003e \n\u003e Other options I can think of to handle this:\n\u003e - convert this into a script which runs in finalize after 50-dracut-regenerate\n\u003e - changing the behaviour of uninstall to leave \"unused\" dependencies\n\nWould it work to simply add here:\n\ndracut-network:\n  uninstall: False","accounts_in_message":[],"_revision_number":1},{"id":"22e4115c2dea0e38bf4ad710f767e60976ef2172","tag":"autogenerated:gerrit:abandon","author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"date":"2021-03-04 00:29:33.000000000","message":"Abandoned\n\nIt looks like only dracut-049-95.git20200804 is affected by this. dracut-network-049-70 which is available in the recommended eus repos works fine. Lets revisit when this becomes an issue for recommended repos","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"be3d62bc84aa0470952642fb830ac15c6888c390","revisions":{"be3d62bc84aa0470952642fb830ac15c6888c390":{"kind":"REWORK","_number":1,"created":"2021-02-25 02:33:59.000000000","uploader":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"ref":"refs/changes/95/777495/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-image-elements","ref":"refs/changes/95/777495/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/95/777495/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/95/777495/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/95/777495/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-image-elements refs/changes/95/777495/1"}}},"commit":{"parents":[{"commit":"a038c08017277dff1ceea6bdab03fa16975b8e6b","subject":"Use python3 for map-services-tripleo","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/a038c08017277dff1ceea6bdab03fa16975b8e6b"}]}],"author":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-02-25 02:30:10.000000000","tz":780},"committer":{"name":"Steve Baker","email":"sbaker@redhat.com","date":"2021-02-25 02:30:10.000000000","tz":780},"subject":"Don\u0027t uninstall kexec-tools","message":"Don\u0027t uninstall kexec-tools\n\nThis has the side-effect of uninstalling dracut-network on rhel-8,\nwhich causes dracut to fail during finalise because of the broken\nlegacy-network module.\n\nChange-Id: I03ca096ce69689a26fddc404279a8b003c971c15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/be3d62bc84aa0470952642fb830ac15c6888c390"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/be3d62bc84aa0470952642fb830ac15c6888c390"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a038c08017277dff1ceea6bdab03fa16975b8e6b","is_merged_in_target_branch":true,"change_id":"Ib17a8009f335d7ef9e72e35e3477e471b69e895e","change_number":777469,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}