)]}'
{"id":"openstack%2Ftripleo-image-elements~79352","triplet_id":"openstack%2Ftripleo-image-elements~master~I3ba94d1f399df0c5bd67ba93ac7fa030a271aaa0","project":"openstack/tripleo-image-elements","branch":"master","topic":"lint","hashtags":[],"change_id":"I3ba94d1f399df0c5bd67ba93ac7fa030a271aaa0","subject":"WIP: Check that scripts are set -e","status":"ABANDONED","created":"2014-03-10 15:53:33.000000000","updated":"2014-03-19 21:26:18.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"23ac8ccf0964c88eaae77456503b8e06783c6afb","_number":79352,"virtual_id_number":79352,"owner":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-03-10 16:25:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-10 16:25:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d4277d8d075a6973a1286001eb950a1a5b33e593","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-10 15:53:35.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2781e4f66e85793ef905a98776db138ddc85700c","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2014-03-10 15:55:33.000000000","message":"Patch Set 1: Work In Progress\n\nAs stated in the commit message, I need some agreement on the correct things to enforce with this check.","accounts_in_message":[],"_revision_number":1},{"id":"a00898849463f92b8c70a7eaacd840be0a869af7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-10 16:25:04.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-noop http://logs.openstack.org/52/79352/1/check/gate-noop/5d78414 : SUCCESS in 6s\n","accounts_in_message":[],"_revision_number":1},{"id":"8a887b52e180386d96bdca3b4207e530f53e36e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-10 18:17:44.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- check-tripleo-seed-precise http://logs.openstack.org/52/79352/1/check-tripleo/check-tripleo-seed-precise/405d0eb : SUCCESS in 46m 47s\n- check-tripleo-undercloud-precise http://logs.openstack.org/52/79352/1/check-tripleo/check-tripleo-undercloud-precise/dc0df90 : SUCCESS in 1h 32m 58s\n- check-tripleo-overcloud-precise http://logs.openstack.org/52/79352/1/check-tripleo/check-tripleo-overcloud-precise/7dfac52 : SUCCESS in 2h 24m 02s\n","accounts_in_message":[],"_revision_number":1},{"id":"9b1cc41961643ae31918d8e9658e06129db29e0f","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2014-03-19 21:26:18.000000000","message":"Patch Set 1: Abandoned\n\nThis, too, was moved to dib.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6d2560b4b0dac7a81355f2f515f471ec5123ded9","revisions":{"6d2560b4b0dac7a81355f2f515f471ec5123ded9":{"kind":"REWORK","_number":1,"created":"2014-03-10 15:53:33.000000000","uploader":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"ref":"refs/changes/52/79352/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-image-elements","ref":"refs/changes/52/79352/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/52/79352/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/52/79352/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-image-elements refs/changes/52/79352/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-image-elements refs/changes/52/79352/1"}}},"commit":{"parents":[{"commit":"8dc9708b58d5bdcbfa59e947765b4f648458b2c9","subject":"Enforce alphabetical ordering in element-deps","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/8dc9708b58d5bdcbfa59e947765b4f648458b2c9"}]}],"author":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2014-03-10 14:56:26.000000000","tz":0},"committer":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2014-03-10 15:53:19.000000000","tz":0},"subject":"WIP: Check that scripts are set -e","message":"WIP: Check that scripts are set -e\n\nWIP reason: Before I go through and fix up all of the set calls\nin the elements, I want a consensus on what we should be\nenforcing here.  I think -e definitely makes sense, probably -u,\nand possibly -x.  -e for the reasons below, -u for similar reasons,\nand -x is helpful for debugging, but it does tend to clutter up the\nlogs somewhat so I don\u0027t know that we want to enforce it.\n\nWhen element scripts are not set -e, it\u0027s possible for failures to\nbe ignored and then bite us later when deploying the image.  It\u0027s\nbetter to catch those errors when they happen.\n\nChange-Id: I3ba94d1f399df0c5bd67ba93ac7fa030a271aaa0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/6d2560b4b0dac7a81355f2f515f471ec5123ded9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-image-elements/commit/6d2560b4b0dac7a81355f2f515f471ec5123ded9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8dc9708b58d5bdcbfa59e947765b4f648458b2c9","is_merged_in_target_branch":false,"change_id":"Ibba4136f7da1c01fbe49b70f242c99238ddd1382","change_number":79351,"patch_set_number":1,"change_status":"ABANDONED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}