)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"9924ebf8980c61d7c3105a01b27464f050e03161","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jufang Wang \u003cjufang.wang@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 21:58:52 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure keystone with apache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I03a577b7e88c9026e6fc3cd6839b6c75e8072925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXH%2F%2FGnM%3D","line":7,"updated":"2014-04-24 00:55:58.000000000","message":"Please improve the commit message to meet OpenStack standards.  Specifically:\n- Do not assume the code is self-evident/self-documenting.  \n- Describe why a change is being made.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"1fdb99b8305061dfa8f8f069d75e6c37832211c0"}],"elements/keystone/files/keystone.conf":[{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"9924ebf8980c61d7c3105a01b27464f050e03161","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    WSGIScriptAlias / /etc/keystone/admin"},{"line_number":4,"context_line":"    WSGIDaemonProcess keystone_ssl user\u003dkeystone group\u003dkeystone processes\u003d1 threads\u003d1 home\u003dKEYSTONE_VENV_DIR python-path\u003dKEYSTONE_VENV_DIR:KEYSTONE_VENV_DIR/lib/python2.7/site-packages/"},{"line_number":5,"context_line":"    WSGIApplicationGroup keystone"},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    SSLEngine on"},{"line_number":8,"context_line":"    SSLVerifyClient optional"},{"line_number":9,"context_line":"    SSLOptions +stdEnvVars"}],"source_content_type":"text/plain","patch_set":1,"id":"AAAAXH%2F%2FGpA%3D","line":6,"updated":"2014-04-24 00:55:58.000000000","message":"excess whitespace","commit_id":"1fdb99b8305061dfa8f8f069d75e6c37832211c0"},{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"93540ff52386b7aeee6fc39fc1fbdd4e92f80826","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    WSGIDaemonProcess keystone_ssl user\u003dkeystone group\u003dkeystone processes\u003d1 threads\u003d1 home\u003dKEYSTONE_VENV_DIR python-path\u003dKEYSTONE_VENV_DIR:KEYSTONE_VENV_DIR/lib/python2.7/site-packages/"},{"line_number":5,"context_line":"    WSGIApplicationGroup keystone"},{"line_number":6,"context_line":"    "},{"line_number":7,"context_line":"    SSLEngine on"},{"line_number":8,"context_line":"    SSLVerifyClient optional"},{"line_number":9,"context_line":"    SSLOptions +stdEnvVars"},{"line_number":10,"context_line":"    SSLVerifyDepth 1"}],"source_content_type":"text/plain","patch_set":1,"id":"AAAAXH%2F%2FGyM%3D","line":7,"updated":"2014-04-24 00:09:29.000000000","message":"This enables SSL for Keystone communication in nonc-nfigurable manner.","commit_id":"1fdb99b8305061dfa8f8f069d75e6c37832211c0"},{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"93540ff52386b7aeee6fc39fc1fbdd4e92f80826","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    SSLVerifyClient optional"},{"line_number":9,"context_line":"    SSLOptions +stdEnvVars"},{"line_number":10,"context_line":"    SSLVerifyDepth 1"},{"line_number":11,"context_line":"    SSLCertificateFile /etc/keystone/ssl/certs/keystone.pem"},{"line_number":12,"context_line":"    SSLCertificateKeyFile /etc/keystone/ssl/private/keystonekey.pem"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    SetEnv APACHE_RUN_USER keystone"}],"source_content_type":"text/plain","patch_set":1,"id":"AAAAXH%2F%2FGyc%3D","line":11,"updated":"2014-04-24 00:09:29.000000000","message":"Do these key and cert exist?","commit_id":"1fdb99b8305061dfa8f8f069d75e6c37832211c0"}],"elements/keystone/install.d/keystone-source-install/70-keystone":[{"author":{"_account_id":10992,"name":"Michael Tupitsyn","email":"michael.tupitsyn@suse.com","username":"tupitsyn"},"change_message_id":"93540ff52386b7aeee6fc39fc1fbdd4e92f80826","unresolved":false,"context_lines":[{"line_number":38,"context_line":"         chmod 711 /etc/keystone"},{"line_number":39,"context_line":"         install -m 0644 -o root -g root $(dirname $0)/../files/keystone.conf /etc/apache2/sites-available"},{"line_number":40,"context_line":"         ln -s /etc/apache2/sites-available/keystone.conf /etc/apache2/sites-enabled/keystone.conf"},{"line_number":41,"context_line":"         ln -s ../mods-available/keystone.conf /etc/apache2/sites-enabled/ssl.conf"},{"line_number":42,"context_line":"         ln -s ../mods-available/keystone.conf /etc/apache2/sites-enabled/ssl.load"},{"line_number":43,"context_line":"         ln -s ../mods-available/keystone.conf /etc/apache2/sites-enabled/socache_shmbc.load"},{"line_number":44,"context_line":"         ln -s /var/log/apache2 /var/log/httpd"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"AAAAXH%2F%2FGzQ%3D","line":41,"updated":"2014-04-24 00:09:29.000000000","message":"This seems to be a mistyping. I would imaging this line should read as\n\nln -s /etc/apache2/mods-available/ssl.conf /etc/apache2/mods-enabled/ssl.conf\n\nln -s /etc/apache2/mods-available/ssl.load /etc/apache2/mods-enabled/ssl.load\n\nln -s /etc/apache2/mods-available/socache_shmbc.load /etc/apache2/mods-enabled/socache_shmbc.load","commit_id":"1fdb99b8305061dfa8f8f069d75e6c37832211c0"},{"author":{"_account_id":5639,"name":"Coleman Corrigan","email":"coleman.corrigan@hp.com","username":"coleman-corrigan"},"change_message_id":"50a2a2310fcaca22afaf9964d0101143f6338940","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"os-svc-install $KEYSTONE_EXTRA_INSTALL_OPTS -i \"$KEYSTONE_VENV_DIR\" -u keystone -r /opt/stack/keystone"},{"line_number":8,"context_line":"#os-svc-daemon -i \"$KEYSTONE_VENV_DIR\" keystone keystone keystone-all \"--config-dir /etc/keystone\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"install -m 0755 -o keystone -g keystone -d /etc/keystone/ssl"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"ln -s $KEYSTONE_VENV_DIR/bin/keystone-manage /usr/local/bin/keystone-manage"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_89a89a21","line":9,"updated":"2014-05-15 16:54:04.000000000","message":"let git do the history, remove the old line","commit_id":"3c40600afdba93aec3fbe2cd88764edf9e6f3118"},{"author":{"_account_id":5639,"name":"Coleman Corrigan","email":"coleman.corrigan@hp.com","username":"coleman-corrigan"},"change_message_id":"50a2a2310fcaca22afaf9964d0101143f6338940","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#Check if keystone has to be started under Apache"},{"line_number":29,"context_line":"OVERCLOUD_KEYSTONE_APACHE\u003d${OVERCLOUD_KEYSTONE_APACHE:\u003d0}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if [ $OVERCLOUD_KEYSTONE_APACHE -eq 0 ]; then"},{"line_number":32,"context_line":"    os-svc-daemon -i \"$KEYSTONE_VENV_DIR\" keystone keystone keystone-all \"--config-dir /etc/keystone\""},{"line_number":33,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_a98e36ce","line":30,"updated":"2014-05-15 16:54:04.000000000","message":"This is a bit belt and braces approach,  wouldn\u0027t you either use \nOVERCLOUD_KEYSTONE_APACHE\u003d${OVERCLOUD_KEYSTONE_APACHE:-0}\nor  \n[ ${OVERCLOUD_KEYSTONE_APACHE:\u003d0} ]","commit_id":"3c40600afdba93aec3fbe2cd88764edf9e6f3118"},{"author":{"_account_id":5639,"name":"Coleman Corrigan","email":"coleman.corrigan@hp.com","username":"coleman-corrigan"},"change_message_id":"50a2a2310fcaca22afaf9964d0101143f6338940","unresolved":false,"context_lines":[{"line_number":47,"context_line":"         rm -f /etc/apache2/sites-enabled/{000-default.conf,default.conf,default-ssl.conf}"},{"line_number":48,"context_line":"         sed -e \"s|KEYSTONE_VENV_DIR|$KEYSTONE_VENV_DIR|g\" -i /etc/apache2/sites-available/keystone.conf"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"         #service apache2 restart"},{"line_number":51,"context_line":"    fi"},{"line_number":52,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_29486686","line":50,"updated":"2014-05-15 16:54:04.000000000","message":"uncomment ?","commit_id":"3c40600afdba93aec3fbe2cd88764edf9e6f3118"}],"elements/keystone/os-refresh-config/post-configure.d/70-keystone":[{"author":{"_account_id":5639,"name":"Coleman Corrigan","email":"coleman.corrigan@hp.com","username":"coleman-corrigan"},"change_message_id":"50a2a2310fcaca22afaf9964d0101143f6338940","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"os-svc-enable -n keystone"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"#service apache2 restart"},{"line_number":9,"context_line":"os-svc-restart -n keystone"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_0943aa6c","line":8,"updated":"2014-05-15 16:54:04.000000000","message":"uncomment ?","commit_id":"3c40600afdba93aec3fbe2cd88764edf9e6f3118"}]}
