)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"b3e86a1da09d8defaf5b3cb6530600da91d3cf10","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Prince \u003cdprince@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-29 16:20:12 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a squid element."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8eb006ab0af731587bfb0a99659f6dc8bed42fc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_9ad04a55","line":7,"updated":"2014-04-30 15:39:37.000000000","message":"Please add additional information to the commit message.","commit_id":"e5adcbcbc5407c574f991ee4c8ff4ac0e947bbfe"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"47f6cfd59b2d115641e0b9a6babfd9ba40f9d7ec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Prince \u003cdprince@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-29 16:20:12 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a squid element."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8eb006ab0af731587bfb0a99659f6dc8bed42fc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_7de2a0a0","line":7,"in_reply_to":"9ad9bd40_1aca7a4f","updated":"2014-04-30 16:33:09.000000000","message":"There\u0027s nothing that explains why or what it is.   Please add one or more paragraphs that explain in greater detail [0].   Squid itself may be well known or easy to look up, but specifically why we need it in TripleO may be helpful [1].  Folks may not have been in the IRC meeting yesterday where this was brought up.  Finding the motivation behind a specific change isn\u0027t as easy in the irc logs or mailing list archives as it is in a git log.  I find verbosity in these commit messages invaluable at times and I think that fits within OpenStack\u0027s commit guidelines.\n\n[0] https://wiki.openstack.org/wiki/GerritWorkflow#Committing_Changes\n[1] https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages","commit_id":"e5adcbcbc5407c574f991ee4c8ff4ac0e947bbfe"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"008f5a5b62de4d4a362a5608d8f75b6381b58044","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Prince \u003cdprince@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-29 16:20:12 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a squid element."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8eb006ab0af731587bfb0a99659f6dc8bed42fc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_1aca7a4f","line":7,"in_reply_to":"9ad9bd40_9ad04a55","updated":"2014-04-30 15:48:59.000000000","message":"Ryan: what specifically do you have in mind?","commit_id":"e5adcbcbc5407c574f991ee4c8ff4ac0e947bbfe"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"8627dac90c25d6b310c33f992ff49eb49633b5bc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Unlike traditional caching software, Squid handles all requests in a"},{"line_number":14,"context_line":"single, non-blocking process."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We are considering using this as part of our CI overclouds"},{"line_number":17,"context_line":"for caching."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I8eb006ab0af731587bfb0a99659f6dc8bed42fc7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad9bd40_1368a5b9","line":16,"updated":"2014-04-30 17:25:39.000000000","message":"Line 16: helpful.  thanks.","commit_id":"2ffdc63ef6df513e5f0ce900fcec18d20df6ba93"}],"elements/squid/install.d/30-squid":[{"author":{"_account_id":7471,"name":"Richard Su","email":"rwsu@redhat.com","username":"rwsu"},"change_message_id":"c4e94392d5e5bf2ab81897661b553c863808bf2c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"install-packages squid"},{"line_number":5,"context_line":"os-svc-enable -n squid"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_bf632cb0","line":5,"updated":"2014-05-08 18:50:44.000000000","message":"Why is the service enabled here and then in os-refresh-config 80-squid? Should this line be removed?","commit_id":"a992fd490169676aec36bbee09b0d04630d27313"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"039fd0bae160862db853b54dfcfc85c3928027b1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"install-packages squid"},{"line_number":5,"context_line":"os-svc-enable -n squid"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_9f9590e6","line":5,"in_reply_to":"7adec928_bf632cb0","updated":"2014-05-08 19:06:32.000000000","message":"I did that so squid would startup regardless of whether Heat was used or not.","commit_id":"a992fd490169676aec36bbee09b0d04630d27313"}],"elements/squid/os-apply-config/etc/squid/squid.conf":[{"author":{"_account_id":114,"name":"Victor Lowther","email":"victor.lowther@gmail.com","username":"victor-lowther"},"change_message_id":"98cadc38ba06de46aa9734576db9cb8aa14d1a9a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"refresh_pattern .               0       20%     4320"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{#squid.fedora_mirror_url}}"},{"line_number":64,"context_line":"url_rewrite_program /usr/local/bin/yum_mirror_rewriter"},{"line_number":65,"context_line":"{{/squid.fedora_mirror_url}}"}],"source_content_type":"text/plain","patch_set":2,"id":"9ad9bd40_d3dd5d44","line":64,"updated":"2014-04-30 17:30:55.000000000","message":"I am dubious about using url_rewrite_program as a solution for this sort of thing -- imo it would be better to use squid in conjunction with another module that rewrites /etc/yum.repos.d to use your chosen mirror in the baseurl stanza while commenting out any mirrorlist options.  Another option would be to use the recently-resurrected store_id support in squid 3.4, which is explicitly engineered for the caching mirrored static content use case.","commit_id":"2ffdc63ef6df513e5f0ce900fcec18d20df6ba93"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"0eab7fd955063eed7eee460b4b791ef304082567","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Example rule allowing access from your local networks."},{"line_number":35,"context_line":"# Adapt localnet in the ACL section to list your (internal) IP networks"},{"line_number":36,"context_line":"# from where browsing should be allowed"},{"line_number":37,"context_line":"http_access allow localnet"},{"line_number":38,"context_line":"http_access allow localhost"},{"line_number":39,"context_line":""}],"source_content_type":"text/plain","patch_set":3,"id":"9ad9bd40_e6cf657d","line":36,"updated":"2014-05-07 11:49:06.000000000","message":"I wonder should we add a rule here to prevent people accessing other services on the same host as the squid server, e.g. this element may end up being used on the same host as another service we don\u0027t want external access too, squid would allow people to bypass other measures we\u0027ve taken (iptables / binding only to 127.0.0.1)\n\n    http_proxy\u003dhttp://1.2.3.4:3128 curl http://127.0.0.1:9999\n\nThis seems to work (would need ip6 equiv aslo)\n\n    acl dstlocalhost dst 127.0.0.1\n    http_access deny dstlocalhost\n\nI\u0027m not sure if this is usually how people would set up squid but it seems like a good idea","commit_id":"bff7dfc2223c5a158db132c4b17607337e2e0ebe"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"0eab7fd955063eed7eee460b4b791ef304082567","unresolved":false,"context_lines":[{"line_number":47,"context_line":"#cache_dir ufs /var/spool/squid 100 16 256"},{"line_number":48,"context_line":"cache_dir ufs /var/spool/squid 512 16 256"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"maximum_object_size 32768 KB"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Leave coredumps in the first cache dir"},{"line_number":53,"context_line":"coredump_dir /var/spool/squid"}],"source_content_type":"text/plain","patch_set":3,"id":"9ad9bd40_0667e9e9","line":50,"updated":"2014-05-07 11:49:06.000000000","message":"I tried using this and testing if it was caching, it wasn\u0027t (curl http://ftp.heanet.ie/mirrors/www.apache.org/dist//httpd/httpd-2.4.9.tar.bz2).\nRunning squid with lots of debug output, yeilds\n\n    2014/05/07 10:55:16.001| store.cc(1005) checkCachable: StoreEntry::checkCachable: NO: too big\n\nIt turns out the value for maximum_object_size is only respected if it appears before the cache_dir directive. A quick google shows up plenty of people with the same problem and a bug http://bugs.squid-cache.org/show_bug.cgi?id\u003d3830\n\nWhy this hasn\u0027t been fixed is beyond me, I would imagine it causes a lot of heartache\n\n\nAlso considering we\u0027ll be downloading distro qcow images how about increasing the limits too include them? Or did you specifically want not to cache them?","commit_id":"bff7dfc2223c5a158db132c4b17607337e2e0ebe"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"a61f54b9bf3c092c00f5bf2845bc398cc49b4182","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# maximum_object_size must come before cache_dir to be active"},{"line_number":52,"context_line":"maximum_object_size 1024 MB"},{"line_number":53,"context_line":"cache_dir ufs /var/spool/squid 512 16 256"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Leave coredumps in the first cache dir"},{"line_number":56,"context_line":"coredump_dir /var/spool/squid"}],"source_content_type":"text/plain","patch_set":4,"id":"7adec928_3403dd10","line":53,"updated":"2014-05-07 20:23:05.000000000","message":"512 here, is the total size of the cache in MB, this should be increased also.","commit_id":"a9629a8478291bf6fd171b380a9c118f47fddea1"}],"elements/squid/os-refresh-config/pre-configure.d/97-squid-iptables":[{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"a2615afb58d7150d0c58cae696bfe0d27fb5ce1b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"DISTRO\u003d`lsb_release -si` || true"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [[ \"Fedora\" \u003d \"$DISTRO\" ]]; then"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    # Check if the iptables service is active"},{"line_number":15,"context_line":"    if systemctl is-active iptables.service ; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9ad9bd40_bab0b3de","line":12,"updated":"2014-04-30 13:36:06.000000000","message":"Support for other RH distros?  (\"RedHatEnterpriseServer CentOS Fedora\" \u003d~ \"$DISTRO\")","commit_id":"e5adcbcbc5407c574f991ee4c8ff4ac0e947bbfe"},{"author":{"_account_id":10277,"name":"Trent Geerdes","email":"trent.geerdes@hp.com","username":"geerdest"},"change_message_id":"c6e005451df731177532b3d983025e9922d046e1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"touch $OK"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bad4c104_0325b3c1","line":29,"updated":"2014-04-29 21:44:43.000000000","message":"Why not use the iptables element add-rule command here?","commit_id":"e5adcbcbc5407c574f991ee4c8ff4ac0e947bbfe"},{"author":{"_account_id":8532,"name":"Ryan Brady","email":"rbrady@redhat.com","username":"rbrady"},"change_message_id":"a2615afb58d7150d0c58cae696bfe0d27fb5ce1b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"touch $OK"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9ad9bd40_3ac4a33f","line":29,"in_reply_to":"bad4c104_0325b3c1","updated":"2014-04-30 13:36:06.000000000","message":"The code is nearly identical.  No reason not to use the iptables element.","commit_id":"e5adcbcbc5407c574f991ee4c8ff4ac0e947bbfe"}]}