)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"b5d6365423f2b745f79b291110778367b03412c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Switch from upstart to os-refresh-config for MySQL server-id\u0027s"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is both more reliable, and more cross-platform. With the"},{"line_number":10,"context_line":"mysql element, this upstart job is never ran, as an sysvinit rather"},{"line_number":11,"context_line":"that upstart job triggers mysql."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I208310048d7617ec7726eceee9e4e269f1473510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7adec928_74c02950","line":10,"updated":"2014-05-19 20:23:53.000000000","message":"As long as we are making grammatical nit picks, \u0027is never run\u0027 would be the correct pronunciation.","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5073a012f5ff47c355376ab345bf91d5f20a3924","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Switch from upstart to os-refresh-config for MySQL server-id\u0027s"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is both more reliable, and more cross-platform. With the"},{"line_number":10,"context_line":"mysql element, this upstart job is never ran, as an sysvinit rather"},{"line_number":11,"context_line":"that upstart job triggers mysql."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I208310048d7617ec7726eceee9e4e269f1473510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5adbc538_a894e037","line":10,"in_reply_to":"7adec928_74c02950","updated":"2014-05-26 14:12:33.000000000","message":"Done","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"1a9ab99ce1289bc2dfc2795cb8021e2950cc2d1f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is both more reliable, and more cross-platform. With the"},{"line_number":10,"context_line":"mysql element, this upstart job is never ran, as an sysvinit rather"},{"line_number":11,"context_line":"that upstart job triggers mysql."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I208310048d7617ec7726eceee9e4e269f1473510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7adec928_8f215e4f","line":11,"updated":"2014-05-19 20:19:53.000000000","message":"s/that/than","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5073a012f5ff47c355376ab345bf91d5f20a3924","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is both more reliable, and more cross-platform. With the"},{"line_number":10,"context_line":"mysql element, this upstart job is never ran, as an sysvinit rather"},{"line_number":11,"context_line":"that upstart job triggers mysql."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I208310048d7617ec7726eceee9e4e269f1473510"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5adbc538_c8992c70","line":11,"in_reply_to":"7adec928_8f215e4f","updated":"2014-05-26 14:12:33.000000000","message":"Done","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"}],"elements/mysql-common/install.d/mysql-set-server-id.upstart":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"490d764d8b9914fcbcfc66392b8e318a34e28e53","unresolved":false,"context_lines":[{"line_number":8,"context_line":"env CONF_TARGET\u003d\"/etc/mysql/conf.d/server_id.cnf\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"pre-start script"},{"line_number":11,"context_line":"    if ! [ -e $INSTANCE_ID ] ; then"},{"line_number":12,"context_line":"        stop"},{"line_number":13,"context_line":"        exit 0"},{"line_number":14,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1ae5cdf2_e1546224","side":"PARENT","line":11,"updated":"2014-06-23 06:51:19.000000000","message":"Same argument as later, I\u0027d prefer -f and the ! in the brackets.\n\nif [ ! -f $INSTANCE_ID ]; then","commit_id":"0eec6b2744f027bc8f956d19723d8c2c8e365b0c"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d7a98b3633300f43fa0581e0ae5c52f10761c669","unresolved":false,"context_lines":[{"line_number":8,"context_line":"env CONF_TARGET\u003d\"/etc/mysql/conf.d/server_id.cnf\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"pre-start script"},{"line_number":11,"context_line":"    if ! [ -e $INSTANCE_ID ] ; then"},{"line_number":12,"context_line":"        stop"},{"line_number":13,"context_line":"        exit 0"},{"line_number":14,"context_line":"    fi"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1ae5cdf2_5ba4044b","side":"PARENT","line":11,"in_reply_to":"1ae5cdf2_e1546224","updated":"2014-06-23 20:20:51.000000000","message":"This file has been deleted, the original code looked like this ;)","commit_id":"0eec6b2744f027bc8f956d19723d8c2c8e365b0c"}],"elements/mysql-common/os-refresh-config/configure.d/51-mysql-server-id":[{"author":{"_account_id":1872,"name":"therese-mchale","email":"therese.mchale@hp.com","username":"therese-mchale"},"change_message_id":"ac8fcf4f5b2cc13a69250cb3144ccf8f6290bbe3","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"INSTANCE_ID\u003d$(cat $INSTANCE_ID_FILE)"},{"line_number":19,"context_line":"SERVER_ID\u003d$(python -c \"print 0x${INSTANCE_ID##i-}\")"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cat \u003e $CONF_TARGET \u003c\u003cEOF"},{"line_number":22,"context_line":"# Generated by os-refresh-config on $(date)"},{"line_number":23,"context_line":"# From $INSTANCE_ID_FILE ${INSTANCE_ID}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_ef9a256d","line":20,"updated":"2014-05-23 13:41:32.000000000","message":"Above Doesn\u0027t handle \"nocloud\" in the instance-id file as is on the seed. \ni.e. seed logs show:\n\n+ INSTANCE_ID_FILE\u003d/var/lib/cloud/data/instance-id\n+ CONF_TARGET\u003d/etc/mysql/conf.d/server_id.cnf\n+ \u0027[\u0027 -e /var/lib/cloud/data/instance-id \u0027]\u0027\n+ \u0027[\u0027 -e /etc/mysql/conf.d/server_id.cnf \u0027]\u0027\n++ cat /var/lib/cloud/data/instance-id\n+ INSTANCE_ID\u003dnocloud\n++ python -c \u0027print 0xnocloud\u0027\n  File \"\u003cstring\u003e\", line 1\n    print 0xnocloud\nSyntaxError: invalid token\n+ SERVER_ID\u003d\n[2014-05-18 18:15:31,640] (os-refresh-config) [ERROR] during configure phase. [Command \u0027[\u0027dib-run-parts\u0027, \u0027/opt/stack/os-config-refresh/configure.d\u0027]\u0027 returned non-zero exit status 1]\n\nERROR:os-refresh-config:during configure phase. [Command \u0027[\u0027dib-run-parts\u0027, \u0027/opt/stack/os-config-refresh/configure.d\u0027]\u0027 returned non-zero exit status 1]\n\n[2014-05-18 18:15:31,641] (os-refresh-config) [ERROR] Aborting...\nERROR:os-refresh-config:Aborting...\n\nfrom the build.","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"5073a012f5ff47c355376ab345bf91d5f20a3924","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"INSTANCE_ID\u003d$(cat $INSTANCE_ID_FILE)"},{"line_number":19,"context_line":"SERVER_ID\u003d$(python -c \"print 0x${INSTANCE_ID##i-}\")"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cat \u003e $CONF_TARGET \u003c\u003cEOF"},{"line_number":22,"context_line":"# Generated by os-refresh-config on $(date)"},{"line_number":23,"context_line":"# From $INSTANCE_ID_FILE ${INSTANCE_ID}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5adbc538_e8aa68d3","line":20,"in_reply_to":"7adec928_7abfb2fc","updated":"2014-05-26 14:12:33.000000000","message":"Done","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":1872,"name":"therese-mchale","email":"therese.mchale@hp.com","username":"therese-mchale"},"change_message_id":"3fef22fffe632af7be676063a227cb4b82cfed46","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"INSTANCE_ID\u003d$(cat $INSTANCE_ID_FILE)"},{"line_number":19,"context_line":"SERVER_ID\u003d$(python -c \"print 0x${INSTANCE_ID##i-}\")"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cat \u003e $CONF_TARGET \u003c\u003cEOF"},{"line_number":22,"context_line":"# Generated by os-refresh-config on $(date)"},{"line_number":23,"context_line":"# From $INSTANCE_ID_FILE ${INSTANCE_ID}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_7abfb2fc","line":20,"in_reply_to":"7adec928_c118dd77","updated":"2014-05-23 15:50:52.000000000","message":"yea..when it was in install.d  it didn\u0027t appear to cause seed install to fallover but does here.  Don\u0027t think you need server-id for nocloud?\ni.e. with this type of diff it should be ok:\n\n+if [  $INSTANCE_ID \u003d\u003d \u0027nocloud\u0027 ] ; then\n+   echo \"nocloud, not configuring server-id\"\n+   exit 0\n+fi\n+","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"e177ef700eddd49215426f87cda2e195a321da3c","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"INSTANCE_ID\u003d$(cat $INSTANCE_ID_FILE)"},{"line_number":19,"context_line":"SERVER_ID\u003d$(python -c \"print 0x${INSTANCE_ID##i-}\")"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cat \u003e $CONF_TARGET \u003c\u003cEOF"},{"line_number":22,"context_line":"# Generated by os-refresh-config on $(date)"},{"line_number":23,"context_line":"# From $INSTANCE_ID_FILE ${INSTANCE_ID}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7adec928_c118dd77","line":20,"in_reply_to":"7adec928_ef9a256d","updated":"2014-05-23 14:07:04.000000000","message":"Heh - This code was a copy and paste from the pre-existing stuff ;)\n\nI\u0027m not sure what the \"ID\" should be with no-cloud? Suggestions?","commit_id":"26fe874c90a073f67f5061cc9be722b4eb347bb1"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"aca2cb098c45e84a81ecfe41b15db1510f8f1dc7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if [ $INSTANCE_ID \u003d\u003d \u0027nocloud\u0027 ]; then"},{"line_number":21,"context_line":"\techo \"nocloud, not configuring server-id\""},{"line_number":22,"context_line":"\texit 0"},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"SERVER_ID\u003d$(python -c \"print 0x${INSTANCE_ID##i-}\")"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3ae8d1ca_83b7cb85","line":22,"updated":"2014-05-29 04:52:27.000000000","message":"real tabs, needs to be spaces.","commit_id":"301ce9d52cb338d4fa90a456b3f240c554201f10"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"72506888dc92fc03e3bf9f9fea82fbae2b6f38d3","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if [ $INSTANCE_ID \u003d\u003d \u0027nocloud\u0027 ]; then"},{"line_number":21,"context_line":"\techo \"nocloud, not configuring server-id\""},{"line_number":22,"context_line":"\texit 0"},{"line_number":23,"context_line":"fi"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"SERVER_ID\u003d$(python -c \"print 0x${INSTANCE_ID##i-}\")"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3ae8d1ca_a108382e","line":22,"in_reply_to":"3ae8d1ca_83b7cb85","updated":"2014-05-29 10:56:02.000000000","message":"Done","commit_id":"301ce9d52cb338d4fa90a456b3f240c554201f10"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"490d764d8b9914fcbcfc66392b8e318a34e28e53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -eux"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Set mysql server_id based on instance-id"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_e17d42b4","line":1,"updated":"2014-06-23 06:51:19.000000000","message":"Could you have perhaps called this 50-mysql-server-id, rather than having to juggle two other renames?","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"490d764d8b9914fcbcfc66392b8e318a34e28e53","unresolved":false,"context_lines":[{"line_number":6,"context_line":"INSTANCE_ID_FILE\u003d\"/var/lib/cloud/data/instance-id\""},{"line_number":7,"context_line":"CONF_TARGET\u003d\"/etc/mysql/conf.d/server_id.cnf\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if ! [ -e $INSTANCE_ID_FILE ] ; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_2192cafc","line":9,"updated":"2014-06-23 06:51:19.000000000","message":"I\u0027d feel safer with -f. The ! can also be inside the square brackets, like so:\n\nif [ ! -f $INSTANCE_ID_FILE ]; then\n\nI think that matches other elements more closely, too.","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d7a98b3633300f43fa0581e0ae5c52f10761c669","unresolved":false,"context_lines":[{"line_number":6,"context_line":"INSTANCE_ID_FILE\u003d\"/var/lib/cloud/data/instance-id\""},{"line_number":7,"context_line":"CONF_TARGET\u003d\"/etc/mysql/conf.d/server_id.cnf\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if ! [ -e $INSTANCE_ID_FILE ] ; then"},{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_bb6a68eb","line":9,"in_reply_to":"1ae5cdf2_2192cafc","updated":"2014-06-23 20:20:51.000000000","message":"Done","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"490d764d8b9914fcbcfc66392b8e318a34e28e53","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -e $CONF_TARGET ] ; then"},{"line_number":14,"context_line":"    echo \"MySQL Server ID has already been configured\""},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_a185faaf","line":13,"updated":"2014-06-23 06:51:19.000000000","message":"Same argument, -f.","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d7a98b3633300f43fa0581e0ae5c52f10761c669","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    exit 0"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [ -e $CONF_TARGET ] ; then"},{"line_number":14,"context_line":"    echo \"MySQL Server ID has already been configured\""},{"line_number":15,"context_line":"    exit 0"},{"line_number":16,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_1b719cde","line":13,"in_reply_to":"1ae5cdf2_a185faaf","updated":"2014-06-23 20:20:51.000000000","message":"Done","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"490d764d8b9914fcbcfc66392b8e318a34e28e53","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"INSTANCE_ID\u003d$(cat $INSTANCE_ID_FILE)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if [ $INSTANCE_ID \u003d\u003d \u0027nocloud\u0027 ]; then"},{"line_number":21,"context_line":"    echo \"nocloud, not configuring server-id\""},{"line_number":22,"context_line":"    exit 0"},{"line_number":23,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_018dced3","line":20,"updated":"2014-06-23 06:51:19.000000000","message":"Nit: \u003d\u003d in bash means substring match, use single \u003d.","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d7a98b3633300f43fa0581e0ae5c52f10761c669","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"INSTANCE_ID\u003d$(cat $INSTANCE_ID_FILE)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if [ $INSTANCE_ID \u003d\u003d \u0027nocloud\u0027 ]; then"},{"line_number":21,"context_line":"    echo \"nocloud, not configuring server-id\""},{"line_number":22,"context_line":"    exit 0"},{"line_number":23,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"1ae5cdf2_bb0fc838","line":20,"in_reply_to":"1ae5cdf2_018dced3","updated":"2014-06-23 20:20:51.000000000","message":"Done","commit_id":"48fdc7c1144c680aa3dc8c19c81b7567d9bde5ea"}]}