)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"b52efb94f40d615b6b005214b46e3a4b2a6da76a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Robert Collins \u003crbtcollins@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-07 17:46:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for expected_nodes ovs agents not 1."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We were waiting for one ovs agent on a compute node, but if we don\u0027t"},{"line_number":10,"context_line":"have it on the second node, spawning vms can still fail. Races are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_fb1599e6","line":7,"updated":"2014-08-07 05:50:23.000000000","message":"Can we have an \u0027all\u0027 in this short message? Perhaps:\n\nWait for OVS agents on all expected nodes","commit_id":"727aa828f47644d797ebe62ca73a82c8b1a4eac5"},{"author":{"_account_id":9453,"name":"James Polley","email":"jp@jamezpolley.com","username":"tchaypo"},"change_message_id":"7f76b6c7407670de32fb6e7d0bb4de1d87d2f1b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Robert Collins \u003crbtcollins@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-07 17:46:14 +1200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for expected_nodes ovs agents not 1."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We were waiting for one ovs agent on a compute node, but if we don\u0027t"},{"line_number":10,"context_line":"have it on the second node, spawning vms can still fail. Races are"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_994ec636","line":7,"updated":"2014-09-15 08:48:36.000000000","message":"or maybe  \"Wait for all OVS agents to come up, rather than just 1\"","commit_id":"727aa828f47644d797ebe62ca73a82c8b1a4eac5"}],"scripts/devtest_overcloud.sh":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"b52efb94f40d615b6b005214b46e3a4b2a6da76a","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"wait_for 30 10 nova service-list --binary nova-compute 2\\\u003e/dev/null \\| grep \u0027enabled.*\\ up\\ \u0027"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"## #. Wait for L2 Agent On all nodes"},{"line_number":460,"context_line":"##    ::"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"wait_for 30 10 [ $expected_nodes -eq \\$\\(neutron agent-list -f csv -c alive -c agent_type -c host \\| grep \u0027\":-).*Open vSwitch agent.*\"\u0027 \\| wc -l\\) ]"}],"source_content_type":"text/x-sh","patch_set":2,"id":"baada198_7b0b49d5","line":459,"updated":"2014-08-07 05:50:23.000000000","message":"Nit: s/On/on/","commit_id":"727aa828f47644d797ebe62ca73a82c8b1a4eac5"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"b52efb94f40d615b6b005214b46e3a4b2a6da76a","unresolved":false,"context_lines":[{"line_number":459,"context_line":"## #. Wait for L2 Agent On all nodes"},{"line_number":460,"context_line":"##    ::"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"wait_for 30 10 [ $expected_nodes -eq \\$\\(neutron agent-list -f csv -c alive -c agent_type -c host \\| grep \u0027\":-).*Open vSwitch agent.*\"\u0027 \\| wc -l\\) ]"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"## #. Log in as a user."},{"line_number":465,"context_line":"##    ::"}],"source_content_type":"text/x-sh","patch_set":2,"id":"baada198_3b28f135","line":462,"updated":"2014-08-07 05:50:23.000000000","message":"I was about to ask why all the escaping, but then realised that we need wait_for\u0027s shell to execute it, not the current one. Perhaps a comment might help here.","commit_id":"727aa828f47644d797ebe62ca73a82c8b1a4eac5"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5977f46070fe9ffe8551fc5f1c0ab917e4f96c49","unresolved":false,"context_lines":[{"line_number":658,"context_line":"##    executed."},{"line_number":659,"context_line":"##    ::"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"wait_for -w 300 --delay 10 [ $expected_nodes -eq \\$\\(neutron agent-list -f csv -c alive -c agent_type -c host \\| grep \u0027\":-).*Open vSwitch agent.*\"\u0027 \\| wc -l\\) ] #nodocs"},{"line_number":662,"context_line":"##         wait_for 30 10 [ $expected_nodes -eq \\$\\(neutron agent-list -f csv -c alive -c agent_type -c host \\| grep \u0027\":-).*Open vSwitch agent.*\"\u0027 \\| wc -l\\) ]"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"## #. Log in as a user."}],"source_content_type":"text/x-sh","patch_set":3,"id":"da86d52c_b61a6c15","line":661,"updated":"2015-02-02 14:08:38.000000000","message":"we don\u0027t deploy l2 agent on block storage nodes, swift nodes, ceph nodes ... so we can\u0027t assume the number matches $expected_nodes","commit_id":"7fa57d130a3587bbbf41b51d4a9ce5973fa738f4"}]}