)]}'
{"scripts/devtest_overcloud.sh":[{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"66806ff97d2960ff66b5257a4a4febfa105a2245","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if (heat stack-show $STACKNAME | grep -q FAILED); then"},{"line_number":124,"context_line":"        echo \"Cannot update a failed stack\" \u003e\u00262"},{"line_number":125,"context_line":"        exit 1"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":"else"},{"line_number":128,"context_line":"    HEAT_OP\u003dstack-create"},{"line_number":129,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAUX%2F%2B5cc%3D","line":126,"updated":"2014-02-18 10:36:36.000000000","message":"just a nit: this could be optimized by DRYing \"heat stack-show\" on both places above:\n\nSTATE\u003d$(heat stack-show $1 | awk \u0027/ stack_status / { print $4 }\u0027)\nif [ -n \"$STATE\" ]; then\n  HEAT_OP\u003dstack-update\n  if [ \"$STATE\" \u003d \"FAILED\" ]","commit_id":"388ac62c1fbbfd7e69a850a2b4029a64627454c8"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"7676a40d9d07eb3aa50678c720bf304f4a779247","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if (heat stack-show $STACKNAME | grep -q FAILED); then"},{"line_number":124,"context_line":"        echo \"Cannot update a failed stack\" \u003e\u00262"},{"line_number":125,"context_line":"        exit 1"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":"else"},{"line_number":128,"context_line":"    HEAT_OP\u003dstack-create"},{"line_number":129,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAUX%2F%2BncQ%3D","line":126,"in_reply_to":"AAAAUX%2F%2B5cc%3D","updated":"2014-02-20 07:12:30.000000000","message":"Actually no, that loses the rv from stack-show.","commit_id":"388ac62c1fbbfd7e69a850a2b4029a64627454c8"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"b0d5a73c945a6c17c6c403783cb5f1d39c29765e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    if (heat stack-show $STACKNAME | grep -q FAILED); then"},{"line_number":124,"context_line":"        echo \"Cannot update a failed stack\" \u003e\u00262"},{"line_number":125,"context_line":"        exit 1"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":"else"},{"line_number":128,"context_line":"    HEAT_OP\u003dstack-create"},{"line_number":129,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAUX%2F%2Bmu4%3D","line":126,"in_reply_to":"AAAAUX%2F%2BncQ%3D","updated":"2014-02-20 08:48:24.000000000","message":"Return value is used only for checking if stack exists so checking if stack_status is set or not should be sufficient replacement. But it was just a nit, giving +2 - the patch works fine.","commit_id":"388ac62c1fbbfd7e69a850a2b4029a64627454c8"}]}