)]}'
{"scripts/devtest_overcloud.sh":[{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"6730fb14246c103e99fb083a7d2c45486bcf0756","unresolved":false,"context_lines":[{"line_number":207,"context_line":"##    ::"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"echo \"Waiting for the overcloud stack to be ready\" #nodocs"},{"line_number":210,"context_line":"FAIL_MATCH_OUTPUT\u003dCREATE_FAILED wait_for 300 10 stack-ready $STACKNAME #nodocs"},{"line_number":211,"context_line":"##         wait_for 300 10 stack-ready overcloud"},{"line_number":212,"context_line":"export OVERCLOUD_IP\u003d$(nova list | grep notCompute0.*ctlplane | sed  -e \"s/.*\u003d\\\\([0-9.]*\\\\).*/\\1/\")"},{"line_number":213,"context_line":"### --end"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAVX%2F%2FxC4%3D","line":210,"updated":"2014-02-28 12:51:04.000000000","message":"This is duplicated with devtest_undercloud.sh which can lead to problems maintaining it and if someone else wants to use wait_for with stack-ready then they have to know the correct FAIL_MATCH_OUTPUT that works with stack-ready.","commit_id":"3cdbbeb842b77aa45b9bd757fcf8b183436d23c3"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a5913ddf3f41f5b367f12312ff775c29f82dc7d7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"##    ::"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"echo \"Waiting for the overcloud stack to be ready\" #nodocs"},{"line_number":210,"context_line":"FAIL_MATCH_OUTPUT\u003dCREATE_FAILED wait_for 300 10 stack-ready $STACKNAME #nodocs"},{"line_number":211,"context_line":"##         wait_for 300 10 stack-ready overcloud"},{"line_number":212,"context_line":"export OVERCLOUD_IP\u003d$(nova list | grep notCompute0.*ctlplane | sed  -e \"s/.*\u003d\\\\([0-9.]*\\\\).*/\\1/\")"},{"line_number":213,"context_line":"### --end"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAVn%2F%2FNFk%3D","line":210,"in_reply_to":"AAAAVX%2F%2FxC4%3D","updated":"2014-03-07 16:52:05.000000000","message":"I agree. I think the issue though is tied into the way we signal failure with wait_for. It would be nice to allow an error code (e.g. 254) to signal \u0027stop now\u0027 and thus push the continue/do not continue logic down to the thing being run. E.g. stack-ready should encapsulate the \u0027wait\u0027/\u0027ready\u0027/\u0027will never succeed\u0027 states.","commit_id":"3cdbbeb842b77aa45b9bd757fcf8b183436d23c3"}],"scripts/devtest_undercloud.sh":[{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"6730fb14246c103e99fb083a7d2c45486bcf0756","unresolved":false,"context_lines":[{"line_number":80,"context_line":"##    ::"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"echo \"Waiting for the undercloud stack to be ready\" #nodocs"},{"line_number":83,"context_line":"FAIL_MATCH_OUTPUT\u003dCREATE_FAILED wait_for 220 10 stack-ready undercloud"},{"line_number":84,"context_line":"export UNDERCLOUD_IP\u003d$(nova list | grep ctlplane | sed  -e \"s/.*\u003d\\\\([0-9.]*\\\\).*/\\1/\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"## #. We don\u0027t (yet) preserve ssh keys on rebuilds."}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAVX%2F%2FxC0%3D","line":83,"updated":"2014-02-28 12:51:04.000000000","message":"Same issue as with devtest_overcloud","commit_id":"3cdbbeb842b77aa45b9bd757fcf8b183436d23c3"}],"scripts/stack-ready":[{"author":{"_account_id":6969,"name":"Michael Kerrin","email":"michael.kerrin@hpe.com","username":"mkerrin"},"change_message_id":"6730fb14246c103e99fb083a7d2c45486bcf0756","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"STACK_STATUS\u003d$(heat stack-show $STACK_NAME | awk \u0027/ stack_status / { print $4 }\u0027)"},{"line_number":28,"context_line":"# provide status feedback to calling script for fail fast error detection"},{"line_number":29,"context_line":"echo $STACK_STATUS"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if [ \"CREATE_COMPLETE\" \u003d \"$STACK_STATUS\" -o \"UPDATE_COMPLETE\" \u003d \"$STACK_STATUS\" ]; then"},{"line_number":32,"context_line":"    exit 0"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAVX%2F%2FxB0%3D","line":29,"updated":"2014-02-28 12:51:04.000000000","message":"This seems very weak and hackish to me and is very dependent on the value of FAIL_MATCH_OUTPUT variable that is in devtest_overcloud \u0026 devtest_undercloud. All 3 have to be aligned to get working.","commit_id":"3cdbbeb842b77aa45b9bd757fcf8b183436d23c3"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a5913ddf3f41f5b367f12312ff775c29f82dc7d7","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"STACK_STATUS\u003d$(heat stack-show $STACK_NAME | awk \u0027/ stack_status / { print $4 }\u0027)"},{"line_number":28,"context_line":"# provide status feedback to calling script for fail fast error detection"},{"line_number":29,"context_line":"echo $STACK_STATUS"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"if [ \"CREATE_COMPLETE\" \u003d \"$STACK_STATUS\" -o \"UPDATE_COMPLETE\" \u003d \"$STACK_STATUS\" ]; then"},{"line_number":32,"context_line":"    exit 0"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"AAAAVn%2F%2FNFQ%3D","line":29,"in_reply_to":"AAAAVX%2F%2FxB0%3D","updated":"2014-03-07 16:52:05.000000000","message":"I think its going to be reliable to pull it out, but agree about the alignment issue.","commit_id":"3cdbbeb842b77aa45b9bd757fcf8b183436d23c3"}]}