)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"f6b2b0fe937d4f4563ca1eea725d3a4cba3b288e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jufang Wang \u003cjufang.wang@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-04-22 21:31:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"configure keystone with apache"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I77f3f9aa155475c908809f3b04292e88a291e772"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAXH%2F%2FPV8%3D","line":7,"updated":"2014-04-23 05:09:54.000000000","message":"I\u0027d like to see a lot more detail in the commit message, please.\n\nSee https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes","commit_id":"5be4e00cd4aa3d5a69ef1fc9b491572e24ce6091"}],"scripts/devtest_overcloud.sh":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"f6b2b0fe937d4f4563ca1eea725d3a4cba3b288e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"OVERCLOUD_IMAGE_UPDATE_POLICY\u003d${OVERCLOUD_IMAGE_UPDATE_POLICY:-\u0027REBUILD\u0027}"},{"line_number":78,"context_line":"OVERCLOUD_KEYSTONE_APACHE\u003d${OVERCLOUD_KEYSTONE_APACHE:-0}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"if [ $OVERCLOUD_KEYSTONE_APACHE -eq 1 ]; then"},{"line_number":81,"context_line":"   OVERCLOUD_CONTROL_DIB_EXTRA_ARGS\u003d\"${OVERCLOUD_CONTROL_DIB_EXTRA_ARGS} apache2\" "},{"line_number":82,"context_line":"fi"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAXH%2F%2FPVk%3D","line":80,"updated":"2014-04-23 05:09:54.000000000","message":"This can be collapsed into one line.\n\nOn a separate note, I\u0027m concerned about adding yet another environment variable. Is OVERCLOUD_CONTROL_DIB_EXTRA_ARGS able to be overridden from outside the scripts and if so, could you fix this with some documentation rather than adding more environment variables?","commit_id":"5be4e00cd4aa3d5a69ef1fc9b491572e24ce6091"},{"author":{"_account_id":11230,"name":"Jufang Wang","email":"jufang.wang@hp.com","username":"wangjuf"},"change_message_id":"f4b8baf0ac47f205455c34047a351bd6c267d134","unresolved":false,"context_lines":[{"line_number":77,"context_line":"OVERCLOUD_IMAGE_UPDATE_POLICY\u003d${OVERCLOUD_IMAGE_UPDATE_POLICY:-\u0027REBUILD\u0027}"},{"line_number":78,"context_line":"OVERCLOUD_KEYSTONE_APACHE\u003d${OVERCLOUD_KEYSTONE_APACHE:-0}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"if [ $OVERCLOUD_KEYSTONE_APACHE -eq 1 ]; then"},{"line_number":81,"context_line":"   OVERCLOUD_CONTROL_DIB_EXTRA_ARGS\u003d\"${OVERCLOUD_CONTROL_DIB_EXTRA_ARGS} apache2\" "},{"line_number":82,"context_line":"fi"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"facab960_a2125e56","line":80,"in_reply_to":"AAAAXH%2F%2FPVk%3D","updated":"2014-04-28 20:41:34.000000000","message":"Steve:\n\n   We need this environment variable to configure keystone with apache SSL. If  OVERCLOUD_KEYSTONE_APACHE \u003d1, keystone will be run with Apache.  Otherwise, it just run via openstack keystone.\n\n   Do you have any suggestion on how to make keystone via Apache SSL configurable if we don\u0027t use env variable?","commit_id":"5be4e00cd4aa3d5a69ef1fc9b491572e24ce6091"},{"author":{"_account_id":8907,"name":"Dmitry Shulyak","email":"dshulyak@mirantis.com","username":"dshulyak"},"change_message_id":"11376a97299720b47b6c4ead25425d728e9b3a40","unresolved":false,"context_lines":[{"line_number":77,"context_line":"OVERCLOUD_IMAGE_UPDATE_POLICY\u003d${OVERCLOUD_IMAGE_UPDATE_POLICY:-\u0027REBUILD\u0027}"},{"line_number":78,"context_line":"OVERCLOUD_KEYSTONE_APACHE\u003d${OVERCLOUD_KEYSTONE_APACHE:-0}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"if [ $OVERCLOUD_KEYSTONE_APACHE -eq 1 ]; then"},{"line_number":81,"context_line":"   OVERCLOUD_CONTROL_DIB_EXTRA_ARGS\u003d\"${OVERCLOUD_CONTROL_DIB_EXTRA_ARGS} apache2\" "},{"line_number":82,"context_line":"fi"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7adec928_a00f522d","line":80,"in_reply_to":"facab960_a2125e56","updated":"2014-05-13 05:47:04.000000000","message":"1. apache should be already installed cause horizon uses it\n\n2. i dont see how this helps to decide how we want to configure keystone, it seems like that decision will be made in post-configure phase","commit_id":"5be4e00cd4aa3d5a69ef1fc9b491572e24ce6091"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"7681cf697ac5447330c77cc46b82e33fa9e4074b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"OVERCLOUD_KEYSTONE_APACHE\u003d${OVERCLOUD_KEYSTONE_APACHE:-0}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"if [ $OVERCLOUD_KEYSTONE_APACHE -eq 1 ]; then"},{"line_number":81,"context_line":"   OVERCLOUD_CONTROL_DIB_EXTRA_ARGS\u003d\"${OVERCLOUD_CONTROL_DIB_EXTRA_ARGS} apache2\" "},{"line_number":82,"context_line":"fi"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"### --include"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7adec928_c04ffebb","line":81,"updated":"2014-05-13 07:14:55.000000000","message":"The trailing space should be deleted.","commit_id":"5be4e00cd4aa3d5a69ef1fc9b491572e24ce6091"}]}