)]}'
{"roles/tripleo-overcloud-node-provide/README.md":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0133ea7114a6096c0124a6cc838af556ec62bae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      tasks:"},{"line_number":36,"context_line":"        - name: Set overcloud nodes to available (provide nodes)"},{"line_number":37,"context_line":"          import_role:"},{"line_number":38,"context_line":"            name: tripleo-overcloud-node-provide"},{"line_number":39,"context_line":"          vars:"},{"line_number":40,"context_line":"            tripleo_overcloud_node_provide_node_uuids: 4ca0448a-3892-4fc8-aea1-1834ac3c0caa"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"3fa7e38b_2abfd060","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":48},"updated":"2020-01-21 18:55:02.000000000","message":"We need to use _ and not - per https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#roles-directory\n\nSee also https://review.opendev.org/#/c/703419/","commit_id":"7432faff5daf1510df856d49225c7658311451aa"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8022d74c69b9f5f4e23ebbc106fd120e7c5799f6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      tasks:"},{"line_number":36,"context_line":"        - name: Set overcloud nodes to available (provide nodes)"},{"line_number":37,"context_line":"          import_role:"},{"line_number":38,"context_line":"            name: tripleo-overcloud-node-provide"},{"line_number":39,"context_line":"          vars:"},{"line_number":40,"context_line":"            tripleo_overcloud_node_provide_node_uuids: 4ca0448a-3892-4fc8-aea1-1834ac3c0caa"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"3fa7e38b_671e485f","line":38,"range":{"start_line":38,"start_character":18,"end_line":38,"end_character":48},"in_reply_to":"3fa7e38b_2abfd060","updated":"2020-01-22 22:04:40.000000000","message":"Done","commit_id":"7432faff5daf1510df856d49225c7658311451aa"}],"roles/tripleo-overcloud-node-provide/defaults/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0133ea7114a6096c0124a6cc838af556ec62bae","unresolved":false,"context_lines":[{"line_number":3,"context_line":"tripleo_overcloud_node_provide_debug: false"},{"line_number":4,"context_line":"tripleo_overcloud_node_provide_all_manageable: \u0027\u0027"},{"line_number":5,"context_line":"# https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_node.py#L225"},{"line_number":6,"context_line":"tripleo_overcloud_node_provide_node_uuids: []  # maybe \"\" (break on whitespace)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_aa8180a2","line":6,"updated":"2020-01-21 18:55:02.000000000","message":"Yea might be a good think to check that this isn\u0027t empty. I\u0027ve been skipping defining a default for required parameters but it might make sense to do a fail check","commit_id":"7432faff5daf1510df856d49225c7658311451aa"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8022d74c69b9f5f4e23ebbc106fd120e7c5799f6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"tripleo_overcloud_node_provide_debug: false"},{"line_number":4,"context_line":"tripleo_overcloud_node_provide_all_manageable: \u0027\u0027"},{"line_number":5,"context_line":"# https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_node.py#L225"},{"line_number":6,"context_line":"tripleo_overcloud_node_provide_node_uuids: []  # maybe \"\" (break on whitespace)"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_076514e2","line":6,"in_reply_to":"3fa7e38b_aa8180a2","updated":"2020-01-22 22:04:40.000000000","message":"So really this could be empty if tripleo_overcloud_node_provide_all_manageable is not empty.\nIt\u0027s one or the other, would have to check for that.","commit_id":"7432faff5daf1510df856d49225c7658311451aa"}],"roles/tripleo-overcloud-node-provide/tasks/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c0133ea7114a6096c0124a6cc838af556ec62bae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    _provide_cmd: \u003e-"},{"line_number":6,"context_line":"      openstack overcloud node provide"},{"line_number":7,"context_line":"      {{ tripleo_overcloud_node_provide_all_manageable | ternary(\u0027--all-manageable\u0027, \u0027\u0027) }}"},{"line_number":8,"context_line":"      {{ tripleo_overcloud_node_provide_node_uuids }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Show the overcloud node provide command"},{"line_number":11,"context_line":"  debug:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_0a91b4f7","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":50},"updated":"2020-01-21 18:55:02.000000000","message":"If this is a list (because it can be more than one), we should use {{ tripleo.operator.shell_arg_list(tripleo_overcloud_node_provide_node_uuids) }} here instead. It\u0027ll also work with a string correctly as well","commit_id":"7432faff5daf1510df856d49225c7658311451aa"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"8022d74c69b9f5f4e23ebbc106fd120e7c5799f6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    _provide_cmd: \u003e-"},{"line_number":6,"context_line":"      openstack overcloud node provide"},{"line_number":7,"context_line":"      {{ tripleo_overcloud_node_provide_all_manageable | ternary(\u0027--all-manageable\u0027, \u0027\u0027) }}"},{"line_number":8,"context_line":"      {{ tripleo_overcloud_node_provide_node_uuids }}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Show the overcloud node provide command"},{"line_number":11,"context_line":"  debug:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_07aaf4d1","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":50},"in_reply_to":"3fa7e38b_0a91b4f7","updated":"2020-01-22 22:04:40.000000000","message":"Done","commit_id":"7432faff5daf1510df856d49225c7658311451aa"}],"roles/tripleo_overcloud_node_provide/README.md":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8b6697293534860b1f0673f9873fc8d6503b114a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Example overcloud node provide playbook"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    - hosts: undercloud"},{"line_number":34,"context_line":"      gather_facts: true"},{"line_number":35,"context_line":"      tasks:"},{"line_number":36,"context_line":"        - name: Set overcloud nodes to available (provide nodes)"},{"line_number":37,"context_line":"          import_role:"},{"line_number":38,"context_line":"            name: tripleo_overcloud_node_provide"},{"line_number":39,"context_line":"          vars:"},{"line_number":40,"context_line":"            tripleo_overcloud_node_provide_node_uuids: 4ca0448a-3892-4fc8-aea1-1834ac3c0caa"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"License"},{"line_number":43,"context_line":"-------"}],"source_content_type":"text/x-gfm","patch_set":7,"id":"3fa7e38b_afc12451","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":91},"updated":"2020-01-29 16:20:55.000000000","message":"markdownlint also merged so you need to wrap this in a\n\n```yaml\n\n```\n\nAnd move the indentation over \u003c-","commit_id":"5550349ef52ba7b5deaa73f3b902060246648399"}],"roles/tripleo_overcloud_node_provide/defaults/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c65d03ff766b307ff47ec73f430f02566c06c99e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# defaults file for tripleo-overcloud-node-provide"},{"line_number":3,"context_line":"tripleo_overcloud_node_provide_debug: false"},{"line_number":4,"context_line":"tripleo_overcloud_node_provide_all_manageable: \u0027\u0027"},{"line_number":5,"context_line":"# https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_node.py#L225"},{"line_number":6,"context_line":"tripleo_overcloud_node_provide_node_uuids: []"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_4f6bd0b6","line":4,"range":{"start_line":4,"start_character":47,"end_line":4,"end_character":49},"updated":"2020-01-29 16:06:22.000000000","message":"This should probably be a boolean since it just adds a flag","commit_id":"5550349ef52ba7b5deaa73f3b902060246648399"}],"roles/tripleo_overcloud_node_provide/tasks/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"465043f9cba9f534c0b7a174940b20e18fa1cf2b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - tripleo_overcloud_node_provide_all_manageable is defined"},{"line_number":29,"context_line":"    - tripleo_overcloud_node_provide_all_manageable|length \u003e 0"},{"line_number":30,"context_line":"    - tripleo_overcloud_node_provide_node_uuids is defined"},{"line_number":31,"context_line":"    - tripleo_overcloud_node_provide_node_uuids|length \u003e 0"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Overcloud node provide"},{"line_number":34,"context_line":"  shell: \"{{ _provide_cmd }}\"  # noqa 305"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_8df7db8e","line":31,"updated":"2020-01-23 16:27:47.000000000","message":"These checks work but you should put them before the top set fact. No point in generating the command if the input is invalid","commit_id":"bac901b2ce385fefa161fe48180dedf88594a741"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"f927d6a097d21cd51eda4670e8b5022e59b8f767","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - tripleo_overcloud_node_provide_all_manageable is defined"},{"line_number":29,"context_line":"    - tripleo_overcloud_node_provide_all_manageable|length \u003e 0"},{"line_number":30,"context_line":"    - tripleo_overcloud_node_provide_node_uuids is defined"},{"line_number":31,"context_line":"    - tripleo_overcloud_node_provide_node_uuids|length \u003e 0"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Overcloud node provide"},{"line_number":34,"context_line":"  shell: \"{{ _provide_cmd }}\"  # noqa 305"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_1c575429","line":31,"in_reply_to":"3fa7e38b_8df7db8e","updated":"2020-01-29 15:58:23.000000000","message":"Done","commit_id":"bac901b2ce385fefa161fe48180dedf88594a741"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c65d03ff766b307ff47ec73f430f02566c06c99e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  fail:"},{"line_number":14,"context_line":"    msg: \"Do not pass both \u0027--all-manageable\u0027 and a node UUID list.\""},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - tripleo_overcloud_node_provide_all_manageable is defined"},{"line_number":17,"context_line":"    - tripleo_overcloud_node_provide_all_manageable|length \u003e 0"},{"line_number":18,"context_line":"    - tripleo_overcloud_node_provide_node_uuids is defined"},{"line_number":19,"context_line":"    - tripleo_overcloud_node_provide_node_uuids|length \u003e 0"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_af5b6420","line":17,"range":{"start_line":16,"start_character":6,"end_line":17,"end_character":62},"updated":"2020-01-29 16:06:22.000000000","message":"If you switch this to a boolean (because it\u0027s just a cli flag), you can just do tripleo_overcloud_node_provide_all_manageable|bool","commit_id":"5550349ef52ba7b5deaa73f3b902060246648399"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1953d3a0107fe3c3a97b5c08bcfb3367ee343188","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    _provide_cmd: \u003e-"},{"line_number":24,"context_line":"      openstack overcloud node provide"},{"line_number":25,"context_line":"      {{ tripleo_overcloud_node_provide_all_manageable | ternary(\u0027--all-manageable\u0027, \u0027\u0027) }}"},{"line_number":26,"context_line":"      {{ tripleo.operator.shell_arg_list(tripleo_overcloud_node_provide_node_uuids) }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: Show the overcloud node provide command"},{"line_number":29,"context_line":"  debug:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3fa7e38b_361a4b19","line":26,"range":{"start_line":26,"start_character":8,"end_line":26,"end_character":40},"updated":"2020-01-31 14:15:41.000000000","message":"this should come after a pipe, it\u0027s a filter, but in this case you\u0027d better use join, you don\u0027t need this filter:\n\n{{ tripleo_overcloud_node_provide_node_uuids | join (\u0027 \u0027) }}","commit_id":"5550349ef52ba7b5deaa73f3b902060246648399"}]}