)]}'
{"id":"openstack%2Ftripleo-puppet-elements~172973","triplet_id":"openstack%2Ftripleo-puppet-elements~master~Ia8a1e2ca78cb70835bc4ec3e9df38478b9a82b72","project":"openstack/tripleo-puppet-elements","branch":"master","hashtags":[],"change_id":"Ia8a1e2ca78cb70835bc4ec3e9df38478b9a82b72","subject":"Add newline to end of source-repository-puppet-modules","status":"MERGED","created":"2015-04-13 16:00:37.000000000","updated":"2015-04-14 14:39:12.000000000","submitted":"2015-04-14 13:59:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"afce64ff6942eee843c952c549e3dc7dda458c34","_number":172973,"virtual_id_number":172973,"owner":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"date":"2015-04-14 13:15:04.000000000","_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"value":0,"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":0,"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},{"value":0,"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":2,"date":"2015-04-14 13:59:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"all":[{"value":2,"date":"2015-04-14 13:58:06.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"value":1,"date":"2015-04-14 07:54:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"value":1,"date":"2015-04-13 16:16:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":1,"date":"2015-04-13 16:17:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},{"value":1,"date":"2015-04-13 16:17:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":1,"date":"2015-04-13 17:41:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":2,"date":"2015-04-14 13:16:11.000000000","_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"all":[{"value":1,"date":"2015-04-14 13:58:06.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"value":0,"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"value":0,"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"value":0,"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},{"value":0,"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-04-13 16:16:43.000000000","updated_by":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"reviewer":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"state":"REVIEWER"},{"updated":"2015-04-13 16:17:44.000000000","updated_by":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"reviewer":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"state":"REVIEWER"},{"updated":"2015-04-13 16:17:46.000000000","updated_by":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"reviewer":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"state":"REVIEWER"},{"updated":"2015-04-13 17:41:08.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2015-04-14 07:54:32.000000000","updated_by":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"reviewer":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"state":"REVIEWER"},{"updated":"2015-04-14 13:16:11.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2015-04-14 13:58:06.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2015-04-14 13:59:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"41350ae9416e710e936af6af1923ef07a7f2e051","author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"date":"2015-04-13 16:00:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"13c150b88f4dafef881d365db7aae3bd0d11516e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-13 16:06:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-puppet-elements-pep8 http://logs.openstack.org/73/172973/1/check/gate-tripleo-puppet-elements-pep8/50c650a/ : SUCCESS in 27s\n- gate-tripleo-puppet-elements-docs http://docs-draft.openstack.org/73/172973/1/check/gate-tripleo-puppet-elements-docs/f63c68e//doc/build/html/ : SUCCESS in 41s\n- gate-tripleo-puppet-elements-python27 http://logs.openstack.org/73/172973/1/check/gate-tripleo-puppet-elements-python27/681317a/ : SUCCESS in 39s","accounts_in_message":[],"_revision_number":1},{"id":"c49c3ed53571a48f169ddb326f1c9cb80c70b0ee","author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"date":"2015-04-13 16:16:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"6ae0ac1300639895759f374193eed82fa471ec3c","author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"date":"2015-04-13 16:17:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c4ec800a5169bc6b0095e95873cf9e6c031519de","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2015-04-13 16:17:46.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a6cc86b3b6e4044ba6f3f82d2c71540ad90655e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-13 17:40:59.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- check-tripleo-ironic-overcloud-f20puppet-nonha http://logs.openstack.org/73/172973/1/check-tripleo/check-tripleo-ironic-overcloud-f20puppet-nonha/5b843a4/ : FAILURE in 1h 40m 13s","accounts_in_message":[],"_revision_number":1},{"id":"b3bea0998234844dcc42a5a14018219978b2ceaa","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2015-04-13 17:41:08.000000000","message":"Patch Set 1: Code-Review+1\n\nThis is fine, and we enforce trailing newlines in some of the other repos anyway, but we should fix source-repositories to handle this case properly.","accounts_in_message":[],"_revision_number":1},{"id":"23009802951f9b18315a55dbe55e4e865aa9aedf","author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"date":"2015-04-14 07:54:32.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"35f0a1574bed0d0dbee1dfa53cb704a18a661950","author":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"date":"2015-04-14 13:15:04.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"fe55a89c4a11cbb607e30f27e88082d2d989de01","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2015-04-14 13:16:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e8e0ae60429c46e5d8569ff8af2d2c22bd9abfbe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-14 13:25:16.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-tripleo-puppet-elements-pep8 http://logs.openstack.org/73/172973/1/check/gate-tripleo-puppet-elements-pep8/f05f892/ : SUCCESS in 40s\n- gate-tripleo-puppet-elements-docs http://docs-draft.openstack.org/73/172973/1/check/gate-tripleo-puppet-elements-docs/2424e79//doc/build/html/ : SUCCESS in 44s\n- gate-tripleo-puppet-elements-python27 http://logs.openstack.org/73/172973/1/check/gate-tripleo-puppet-elements-python27/67b4cdf/ : SUCCESS in 32s","accounts_in_message":[],"_revision_number":1},{"id":"58fe7aa89404e302a9a2d58c8e5c8057e573b19e","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2015-04-14 13:58:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThis is fine as a quick fix but I think we should fix source-repositories (the element) to handle this better. Will file a bug accordingly.","accounts_in_message":[],"_revision_number":1},{"id":"910adfb2590c3eadd25159beb3d58ed50f21e382","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-14 13:58:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"6da771e7190d6baff2f9862d75d5af4d17fb394b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-14 13:59:06.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-tripleo-puppet-elements-docs http://docs-draft.openstack.org/73/172973/1/gate/gate-tripleo-puppet-elements-docs/98d304b//doc/build/html/ : SUCCESS in 35s\n- gate-tripleo-puppet-elements-pep8 http://logs.openstack.org/73/172973/1/gate/gate-tripleo-puppet-elements-pep8/b224f26/ : SUCCESS in 29s\n- gate-tripleo-puppet-elements-python27 http://logs.openstack.org/73/172973/1/gate/gate-tripleo-puppet-elements-python27/46aff83/ : SUCCESS in 34s","accounts_in_message":[],"_revision_number":1},{"id":"8d6538cf88ba08995245c8aba5526608bdb38fa5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-14 13:59:06.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"afce64ff6942eee843c952c549e3dc7dda458c34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-14 14:39:12.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- check-tripleo-ironic-overcloud-f20puppet-nonha http://logs.openstack.org/73/172973/1/check-tripleo/check-tripleo-ironic-overcloud-f20puppet-nonha/ed700ea/ : SUCCESS in 1h 24m 02s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c9befdc83990720ed9650558b7718e13c2f5eec8","revisions":{"c9befdc83990720ed9650558b7718e13c2f5eec8":{"kind":"REWORK","_number":1,"created":"2015-04-13 16:00:37.000000000","uploader":{"_account_id":7065,"name":"Brad P. Crochet","email":"brad@redhat.com","username":"bcrochet"},"ref":"refs/changes/73/172973/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-puppet-elements","ref":"refs/changes/73/172973/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/73/172973/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/73/172973/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/73/172973/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/73/172973/1"}}},"commit":{"parents":[{"commit":"45b025d246c6c6fe4df41a2e6fdfa216687b4a29","subject":"Merge \"Temporarily remove dashboard\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-puppet-elements/commit/45b025d246c6c6fe4df41a2e6fdfa216687b4a29"}]}],"author":{"name":"Brad P. Crochet","email":"brad@redhat.com","date":"2015-04-13 16:00:06.000000000","tz":-240},"committer":{"name":"Brad P. Crochet","email":"brad@redhat.com","date":"2015-04-13 16:00:06.000000000","tz":-240},"subject":"Add newline to end of source-repository-puppet-modules","message":"Add newline to end of source-repository-puppet-modules\n\nWithout the newline at the end, the last item will not be read\n\nChange-Id: Ia8a1e2ca78cb70835bc4ec3e9df38478b9a82b72\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-puppet-elements/commit/c9befdc83990720ed9650558b7718e13c2f5eec8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-puppet-elements/commit/c9befdc83990720ed9650558b7718e13c2f5eec8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"45b025d246c6c6fe4df41a2e6fdfa216687b4a29","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}