)]}'
{"id":"openstack%2Ftripleo-puppet-elements~662252","triplet_id":"openstack%2Ftripleo-puppet-elements~master~I0552c7b9f40567a7c55ce502995f5166aa92c092","project":"openstack/tripleo-puppet-elements","branch":"master","topic":"openldap-clients-package","hashtags":[],"change_id":"I0552c7b9f40567a7c55ce502995f5166aa92c092","subject":"Add openldap-clients package to overcloud-controller image","status":"ABANDONED","created":"2019-05-30 15:53:27.000000000","updated":"2019-05-30 18:00:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b88ce5a35de58df02d14e9381dd6875754c55b5d","_number":662252,"virtual_id_number":662252,"owner":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"actions":{},"labels":{"Verified":{"all":[{"date":"2019-05-30 16:40:06.000000000","_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":-1,"date":"2019-05-30 16:16:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"value":-1,"date":"2019-05-30 16:03:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"date":"2019-05-30 16:05:41.000000000","_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-30 16:03:43.000000000","updated_by":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"reviewer":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"state":"REVIEWER"},{"updated":"2019-05-30 16:05:41.000000000","updated_by":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"reviewer":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"state":"REVIEWER"},{"updated":"2019-05-30 16:40:06.000000000","updated_by":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"reviewer":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"state":"REVIEWER"}],"messages":[{"id":"0f512a145761751b90918221c2b1ce81a1a52232","author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"date":"2019-05-30 15:53:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49c5b86894d2100d29dd0fee779182bd0211dde9","author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"date":"2019-05-30 16:03:43.000000000","message":"Patch Set 1: Code-Review-1\n\nIt\u0027s not clear to me why we would need a keystone dependency on the host while we containerized Keystone.\nIf it\u0027s a dependency of Keystone, then you need to patch the keystone-distgit and add the proper dependencies.","accounts_in_message":[],"_revision_number":1},{"id":"e52fd587e81e1be8bfb852147a257c38a9c67751","author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"date":"2019-05-30 16:16:45.000000000","message":"Patch Set 1: Code-Review-1\n\nGood catch Emilien!  I made an incorrect assumption about why openldap-clients is needed.  Keystone will not need it on the node since it is containerized as you stated.  We need openldap-clients for use by ipa-client (which is used for TLS everywhere on all overcloud nodes).  This can be seen here in T-H-T:\n\n  https://github.com/openstack/tripleo-heat-templates/blob/63985433dedaa675b3d3e5c8f99accbc0933e4f6/extraconfig/services/ipaclient.yaml#L77\n\nThis should already be a dependency of ipa-client, so perhaps it shouldn\u0027t be listed explicitly in t-h-t?","accounts_in_message":[],"_revision_number":1},{"id":"66548db1e11ace500a5d694caef6a3d0bd34708a","author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"date":"2019-05-30 16:40:06.000000000","message":"Patch Set 1:\n\nso slight problem with the ansible for that service is that it shouldn\u0027t try to install packages if EnablePackageInstall is false.  That being said, it looks like it\u0027s a host package so maybe it make sense to have on the overcloud image but we should just pull in ipa-client and the package deps should come with it.  Is openldap-clients an optional package for ipa-client?","accounts_in_message":[],"_revision_number":1},{"id":"4487898ea38bf179b2494ff50932c610c897c0c5","author":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"date":"2019-05-30 18:00:26.000000000","message":"Abandoned\n\nAbandoning in favor of https://review.opendev.org/#/c/662276/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"00110bc5f8b0198f00e1c53cdd1f34eb3ef827e2","revisions":{"00110bc5f8b0198f00e1c53cdd1f34eb3ef827e2":{"kind":"REWORK","_number":1,"created":"2019-05-30 15:53:27.000000000","uploader":{"_account_id":9098,"name":"Nathan Kinder","email":"nkinder@redhat.com","username":"nkinder"},"ref":"refs/changes/52/662252/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tripleo-puppet-elements","ref":"refs/changes/52/662252/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/52/662252/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/52/662252/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/52/662252/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tripleo-puppet-elements refs/changes/52/662252/1"}}},"commit":{"parents":[{"commit":"98368f114f9a96c7dbb1284c82042362ea26fc50","subject":"Add upper constraints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-puppet-elements/commit/98368f114f9a96c7dbb1284c82042362ea26fc50"}]}],"author":{"name":"Nathan Kinder","email":"nkinder@redhat.com","date":"2019-05-30 15:52:04.000000000","tz":-420},"committer":{"name":"Nathan Kinder","email":"nkinder@redhat.com","date":"2019-05-30 15:52:04.000000000","tz":-420},"subject":"Add openldap-clients package to overcloud-controller image","message":"Add openldap-clients package to overcloud-controller image\n\nThe openldap-clients package is needed in the overcloud-controller\nimage for use by keystone.  This package is used when keystone is\nconfigured to use an LDAP backend for an identity store.\n\nChange-Id: I0552c7b9f40567a7c55ce502995f5166aa92c092\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-puppet-elements/commit/00110bc5f8b0198f00e1c53cdd1f34eb3ef827e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tripleo-puppet-elements/commit/00110bc5f8b0198f00e1c53cdd1f34eb3ef827e2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}