)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"fccbd09af4ae204cfe38b3c5c78209d9e9463bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ee82765_49cac347","updated":"2022-01-20 20:36:26.000000000","message":"Actually, all mentions of yum_plugin_priorities_package should be removed entirely, here and in 01-install-yum-priorities.\n\nThe same goes for python_ipaddr, lets delete it from pkg-map and package-installs-overcloud-base also","commit_id":"05b8095da9b93e5f02f793d558c59a55b4997b03"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"29efd415db00bb786f834e740fd1fc7dbd88dec5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f51fb8ba_070a1064","updated":"2022-01-20 15:04:31.000000000","message":"recheck","commit_id":"05b8095da9b93e5f02f793d558c59a55b4997b03"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"23d56fbb999dfea63dd8b030a13b766d1d3819cb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ec61d41d_c5ba4b0a","in_reply_to":"08b883cc_e6e5074e","updated":"2022-01-20 23:58:53.000000000","message":"\u003e Hello Steve,\n\u003e \n\u003e Thank you so much for your suggestion, I have some clarifying questions:-\n\u003e \n\u003e 1) \n\u003e \n\u003e https://opendev.org/openstack/tripleo-puppet-elements/src/branch/master/elements/overcloud-base/pre-install.d/01-install-yum-priorities#L5-L6\n\u003e \n\u003e ~~~\n\u003e if [[ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" || \"$DISTRO_NAME\" \u003d\u003d \"fedora\" ]]; then\n\u003e   install-packages -m overcloud-base yum_plugin_priorities_package\n\u003e fi\n\u003e ~~~\n\u003e \n\u003e ^^ above tries to install yum_plugin_priorities_package on i.e centos7 or fedora, if we remove yum_plugin_priorities_package that would mean we will not be installing `yum_plugin_priorities_package` on c7 or fedora anymore - Is that okay?\n\u003e \n\u003e Atleast, We are not building image for c7 train in tripleo perodic CI - https://review.rdoproject.org/zuul/buildset/ed2f9eaeabe74fb9b4fbf326fa693851 .\n\ntripleo-puppet-elements has stable branches, so train builds should be using stable/train of tripleo-puppet-elements\n\nThis means we can be brutal about refactoring here to only support centos/rhel 8/9\n\n\u003e 2) There are mentions of yum_plugin_priorities_package in openstack/tripleo-image-elements repo as well, Do we need to remove it from there as well?\n\u003e \n\u003e https://opendev.org/openstack/tripleo-image-elements/src/branch/master/elements/delorean-repo/pre-install.d/03-install-yum-priorities#L5\n\nI think so, yes","commit_id":"05b8095da9b93e5f02f793d558c59a55b4997b03"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"6ae8c1d62308aa97522bc2dddd068bacd7ea4995","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08b883cc_e6e5074e","in_reply_to":"0ee82765_49cac347","updated":"2022-01-20 23:52:20.000000000","message":"Hello Steve,\n\nThank you so much for your suggestion, I have some clarifying questions:-\n\n1) \n\nhttps://opendev.org/openstack/tripleo-puppet-elements/src/branch/master/elements/overcloud-base/pre-install.d/01-install-yum-priorities#L5-L6\n\n~~~\nif [[ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" || \"$DISTRO_NAME\" \u003d\u003d \"fedora\" ]]; then\n  install-packages -m overcloud-base yum_plugin_priorities_package\nfi\n~~~\n\n^^ above tries to install yum_plugin_priorities_package on i.e centos7 or fedora, if we remove yum_plugin_priorities_package that would mean we will not be installing `yum_plugin_priorities_package` on c7 or fedora anymore - Is that okay?\n\nAtleast, We are not building image for c7 train in tripleo perodic CI - https://review.rdoproject.org/zuul/buildset/ed2f9eaeabe74fb9b4fbf326fa693851 .\n\n2) There are mentions of yum_plugin_priorities_package in openstack/tripleo-image-elements repo as well, Do we need to remove it from there as well?\n\nhttps://opendev.org/openstack/tripleo-image-elements/src/branch/master/elements/delorean-repo/pre-install.d/03-install-yum-priorities#L5","commit_id":"05b8095da9b93e5f02f793d558c59a55b4997b03"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"184372b76f5f60913982dc57186f4676a9d02fea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3ff0477_4ed89539","in_reply_to":"ec61d41d_c5ba4b0a","updated":"2022-01-21 00:10:29.000000000","message":"Thanks, fixing in next patchset.","commit_id":"05b8095da9b93e5f02f793d558c59a55b4997b03"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"483c58d1a84d51eeecfdb7c02526ae87b2ec68e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1f1f4c20_fd878ea8","updated":"2022-01-21 00:29:37.000000000","message":"Looking good, just one small thing","commit_id":"a9b1934bbf0c0d5c5a20db0b120595ad37a6ffcd"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"85d9d1829edfeed97296657723b4dba0e6a9f8f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"557fe7e7_5360751b","updated":"2022-01-21 11:34:22.000000000","message":"recheck","commit_id":"fce5d94e021a948efc420d8f41a1ac3a97359e86"}],"elements/overcloud-base/pkg-map":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9aebdba02d5fd2bf26181c4e45191c63124120ca","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    \"openstack_selinux\": \"openstack-selinux\","},{"line_number":33,"context_line":"    \"net_snmp\": \"net-snmp\","},{"line_number":34,"context_line":"    \"numactl\": \"numactl\","},{"line_number":35,"context_line":"    \"yum_plugin_priorities_package\": \"yum-plugin-priorities\","},{"line_number":36,"context_line":"    \"iptables_services\": \"iptables-services\","},{"line_number":37,"context_line":"    \"tmpwatch\": \"tmpwatch\","},{"line_number":38,"context_line":"    \"sysstat\": \"sysstat\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"456cca07_68626c55","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":61},"updated":"2022-01-19 14:47:51.000000000","message":"If these are getting nuked for all our supported versions, let\u0027s remove them from down here.","commit_id":"74ee7b163ea820122b268f156c96e0cb33841b05"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3bf99b928cce666154abcaa88aee89e1fcd4d665","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    \"openstack_selinux\": \"openstack-selinux\","},{"line_number":33,"context_line":"    \"net_snmp\": \"net-snmp\","},{"line_number":34,"context_line":"    \"numactl\": \"numactl\","},{"line_number":35,"context_line":"    \"yum_plugin_priorities_package\": \"yum-plugin-priorities\","},{"line_number":36,"context_line":"    \"iptables_services\": \"iptables-services\","},{"line_number":37,"context_line":"    \"tmpwatch\": \"tmpwatch\","},{"line_number":38,"context_line":"    \"sysstat\": \"sysstat\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"71b59d8d_0047184b","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":61},"in_reply_to":"456cca07_68626c55","updated":"2022-01-19 19:47:16.000000000","message":"Agreed, in general the default should reflect the latest release, and the exceptions should handle old releases which differ. Here is looks like nothing differs, so lets remove the \"release\" section completely and fix \"default\"","commit_id":"74ee7b163ea820122b268f156c96e0cb33841b05"},{"author":{"_account_id":29775,"name":"Sandeep Yadav","email":"sandyada@redhat.com","username":"sandeepyadav93"},"change_message_id":"f4fa146f0e54a17f6530ec5afaaea0e33240be93","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"openstack_selinux\": \"openstack-selinux\","},{"line_number":33,"context_line":"    \"net_snmp\": \"net-snmp\","},{"line_number":34,"context_line":"    \"numactl\": \"numactl\","},{"line_number":35,"context_line":"    \"yum_plugin_priorities_package\": \"yum-plugin-priorities\","},{"line_number":36,"context_line":"    \"iptables_services\": \"iptables-services\","},{"line_number":37,"context_line":"    \"tmpwatch\": \"tmpwatch\","},{"line_number":38,"context_line":"    \"sysstat\": \"sysstat\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fc03b12e_cffec104","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":61},"in_reply_to":"71b59d8d_0047184b","updated":"2022-01-20 08:32:47.000000000","message":"Hello Alex/Steve,\n\nThanks for review, I have updated as per suggestions.","commit_id":"74ee7b163ea820122b268f156c96e0cb33841b05"}],"elements/overcloud-base/pre-install.d/01-install-yum-priorities":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"483c58d1a84d51eeecfdb7c02526ae87b2ec68e1","unresolved":true,"context_lines":[{"line_number":2,"context_line":"set -e"},{"line_number":3,"context_line":"set -o xtrace"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"if [[ \"$DISTRO_NAME\" \u003d\u003d \"centos7\" || \"$DISTRO_NAME\" \u003d\u003d \"fedora\" ]]; then"},{"line_number":6,"context_line":"  install-packages -m overcloud-base"},{"line_number":7,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"f8752f23_c9c5f891","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":2},"updated":"2022-01-21 00:29:37.000000000","message":"This is a no-op now so these 3 lines can be remove","commit_id":"a9b1934bbf0c0d5c5a20db0b120595ad37a6ffcd"}]}