)]}'
{"roles/overcloud-deploy/tasks/create-scripts.yml":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"22be133b0e76efbee45d6cc7eb6a3657ae4f7500","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    src: \"neutronl3ha.yaml.j2\""},{"line_number":20,"context_line":"    dest: \"{{ working_dir }}/neutronl3ha.yaml\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Copy composable services file"},{"line_number":23,"context_line":"  when: composable_services"},{"line_number":24,"context_line":"  template:"},{"line_number":25,"context_line":"    src: \"overcloud_services.yaml.j2\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a6eadb0_aabbfbe3","line":22,"updated":"2016-12-15 11:08:07.000000000","message":"Any better place to put this ? this is not a script, and you\u0027re putting into a create-scripts task","commit_id":"d62746681c9930db31b38cb946b5910faec04822"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"37a5c258d489a4bcd804fb0a0a03d5cf09c8d81d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    src: \"neutronl3ha.yaml.j2\""},{"line_number":20,"context_line":"    dest: \"{{ working_dir }}/neutronl3ha.yaml\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Copy composable services file"},{"line_number":23,"context_line":"  when: composable_services"},{"line_number":24,"context_line":"  template:"},{"line_number":25,"context_line":"    src: \"overcloud_services.yaml.j2\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a6eadb0_b0536516","line":22,"in_reply_to":"1a6eadb0_aabbfbe3","updated":"2016-12-15 13:10:13.000000000","message":"actually i put it here because the neutronl3ha env file was already there. We could make a new task file for the non script, but i don\u0027t think it\u0027s really mandatory and its more refactoring than a blocker for the review","commit_id":"d62746681c9930db31b38cb946b5910faec04822"}],"roles/overcloud-deploy/tasks/pre-deploy.yml":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"6d511e878568eaaeb591d06e90a41207295667b5","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- name: set workers_args fact"},{"line_number":101,"context_line":"  set_fact:"},{"line_number":102,"context_line":"    extra_args: \u003e-"},{"line_number":103,"context_line":"      -e $HOME/overcloud_services.yaml"},{"line_number":104,"context_line":"  when: composable_services"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_7d14dcf4","line":102,"range":{"start_line":102,"start_character":4,"end_line":102,"end_character":14},"updated":"2017-01-02 11:46:55.000000000","message":"This will completely override extra_args which is used to add a bunch of settings to the deployments in the configs.\n\nE.g.: https://github.com/openstack/tripleo-quickstart/blob/master/config/general_config/ha.yml#L48-L50\n\nAppend the file by including {{ extra_args }} in the beginning of the variable.","commit_id":"3d90fa75b448eb495086f8fafb945c7da5a53966"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"6d511e878568eaaeb591d06e90a41207295667b5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"- name: set workers_args fact"},{"line_number":101,"context_line":"  set_fact:"},{"line_number":102,"context_line":"    extra_args: \u003e-"},{"line_number":103,"context_line":"      -e $HOME/overcloud_services.yaml"},{"line_number":104,"context_line":"  when: composable_services"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_9de7c011","line":103,"range":{"start_line":103,"start_character":10,"end_line":103,"end_character":14},"updated":"2017-01-02 11:46:55.000000000","message":"Use {{ working_dir }} here too, if you created the template there anyway.\n\nAlso a nitpick: maybe use a - in the name instead of _, that seems to be the pattern above and in general in THT.","commit_id":"3d90fa75b448eb495086f8fafb945c7da5a53966"}],"roles/overcloud-deploy/templates/overcloud_services.yaml.j2":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"22be133b0e76efbee45d6cc7eb6a3657ae4f7500","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  ControllerServices:"},{"line_number":3,"context_line":"{% for nodes in overcloud_services   %}"},{"line_number":4,"context_line":"  {{ nodes.name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a6eadb0_6aef23e9","line":1,"updated":"2016-12-15 11:08:07.000000000","message":"Any reason why the ovetrcloud_services dict can\u0027t have the exact same structure of the equivalent for paramenters_defaults ? In this way you could just set parameter_defaults: {{ overcloud_services}}","commit_id":"d62746681c9930db31b38cb946b5910faec04822"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"dad94c4b618a76ad86295561c74e1aa815d1d586","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  ControllerServices:"},{"line_number":3,"context_line":"{% for nodes in overcloud_services   %}"},{"line_number":4,"context_line":"  {{ nodes.name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a6eadb0_6bc9aaab","line":1,"updated":"2016-12-16 13:17:50.000000000","message":"Doesn\u0027t neeed to be a string. The template tag {{}} replaces also dicts. So if you use the same exact dict structure that you expect to see here, you can avoid this iteration.We\u0027ve done something similar in roles/overcloud-prep-config/templates/network-environment.yaml.j2","commit_id":"d62746681c9930db31b38cb946b5910faec04822"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"37a5c258d489a4bcd804fb0a0a03d5cf09c8d81d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  ControllerServices:"},{"line_number":3,"context_line":"{% for nodes in overcloud_services   %}"},{"line_number":4,"context_line":"  {{ nodes.name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a6eadb0_501bf172","line":1,"in_reply_to":"1a6eadb0_6aef23e9","updated":"2016-12-15 13:10:13.000000000","message":"because it\u0027s more flexible than putting a big string here.","commit_id":"d62746681c9930db31b38cb946b5910faec04822"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"5823c275f8e805a9fd110b92a7e2da5c8fd4a6d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  ControllerServices:"},{"line_number":3,"context_line":"{% for nodes in overcloud_services   %}"},{"line_number":4,"context_line":"  {{ nodes.name }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a6eadb0_3225625b","line":1,"in_reply_to":"1a6eadb0_6bc9aaab","updated":"2016-12-16 13:58:56.000000000","message":"This is not the same thing.\nThe network-environment.yaml is a set of key value.\nHere it is just nodes with associated services.","commit_id":"d62746681c9930db31b38cb946b5910faec04822"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"22be133b0e76efbee45d6cc7eb6a3657ae4f7500","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  ControllerServices:"},{"line_number":3,"context_line":"{% for nodes in overcloud_services   %}"},{"line_number":4,"context_line":"  {{ nodes.name }}"},{"line_number":5,"context_line":"   {% for node in nodes.services %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a6eadb0_8aec7ff4","line":2,"updated":"2016-12-15 11:08:07.000000000","message":"If you specify ControllerServices here, how is you ComputeServices going to work ?","commit_id":"d62746681c9930db31b38cb946b5910faec04822"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"37a5c258d489a4bcd804fb0a0a03d5cf09c8d81d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parameter_defaults:"},{"line_number":2,"context_line":"  ControllerServices:"},{"line_number":3,"context_line":"{% for nodes in overcloud_services   %}"},{"line_number":4,"context_line":"  {{ nodes.name }}"},{"line_number":5,"context_line":"   {% for node in nodes.services %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"1a6eadb0_fc0f7936","line":2,"in_reply_to":"1a6eadb0_8aec7ff4","updated":"2016-12-15 13:10:13.000000000","message":"yep it\u0027s a mistake, it should not be here","commit_id":"d62746681c9930db31b38cb946b5910faec04822"}]}
