)]}'
{"roles/overcloud-upgrade/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8918b721b46d6e462c56f10ea4a8c21b25e3aed4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  - https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/{{ upgrade_delorean_hash | default(\u0027current-passed-ci\u0027)}}/delorean.repo"},{"line_number":21,"context_line":"  - https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":22,"context_line":"# upgrade settings:"},{"line_number":23,"context_line":"upgrade_working_dir: \"{{ working_dir|default(\u0027/home/stack\u0027) }}\""},{"line_number":24,"context_line":"tht_dir: tripleo-heat-templates"},{"line_number":25,"context_line":"# scripts"},{"line_number":26,"context_line":"undercloud_upgrade_script: upgrade-undercloud.sh.j2"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5ff73747_990ce1ec","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":57},"updated":"2017-04-28 07:18:15.000000000","message":"just wondering why was this default override required - assuming I\u0027ve understood this is set in the common role @ oooq https://github.com/openstack/tripleo-quickstart/blob/master/roles/common/defaults/main.yml#L14 . \n\nthere is also an undercloud_upgrade_user below may be worth using that instead explicitly using stack here?","commit_id":"6239ce895a86b24e9b1dd75ea9cb24a7a2ec9c40"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"893b9a53a82e50bf46b59e16ba6bf28c9b046dcc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  - https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/{{ upgrade_delorean_hash | default(\u0027current-passed-ci\u0027)}}/delorean.repo"},{"line_number":21,"context_line":"  - https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":22,"context_line":"# upgrade settings:"},{"line_number":23,"context_line":"upgrade_working_dir: \"{{ working_dir|default(\u0027/home/stack\u0027) }}\""},{"line_number":24,"context_line":"tht_dir: tripleo-heat-templates"},{"line_number":25,"context_line":"# scripts"},{"line_number":26,"context_line":"undercloud_upgrade_script: upgrade-undercloud.sh.j2"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"5ff73747_74f59cec","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":57},"in_reply_to":"5ff73747_990ce1ec","updated":"2017-04-28 07:40:51.000000000","message":"yep, it\u0027s in case of a user need to use the role on its own, like what i\u0027ve did with infrared (qe automation tool)","commit_id":"6239ce895a86b24e9b1dd75ea9cb24a7a2ec9c40"}],"roles/overcloud-upgrade/tasks/pre-overcloud.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"26ff89758d31c9a465dcc3df8febb0b9654c9be5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dest: \"{{ upgrade_working_dir }}/ceph-upgrade.yaml\""},{"line_number":12,"context_line":"  when: enable_ceph|bool"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Make sure no Tht repo is present"},{"line_number":15,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":16,"context_line":"  file: path\u003d{{ upgrade_working_dir }}/{{ tht_dir }} state\u003dabsent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Copy new Tht directory to the upgrade working dir"},{"line_number":19,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":20,"context_line":"  shell: \u003e"},{"line_number":21,"context_line":"      cp -R /usr/share/openstack-tripleo-heat-templates \\"},{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  become: yes"},{"line_number":26,"context_line":"  shell: \u003e"},{"line_number":27,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"},{"line_number":28,"context_line":"      {{ upgrade_non_controller_script }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: allow traffic for the controller"},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  shell: \u003e"},{"line_number":33,"context_line":"        sudo iptables -A BOOTSTACK_MASQ -s {{ network_isolation_ipv4_cidr }} ! \\"},{"line_number":34,"context_line":"        -d {{ network_isolation_ipv4_cidr }} -j MASQUERADE -t nat;"},{"line_number":35,"context_line":"        sudo iptables-save \u003e /etc/sysconfig/iptables;"},{"line_number":36,"context_line":"  when: network_isolation|bool and deployment_type \u003d\u003d \"virtual\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: get the number of core"},{"line_number":39,"context_line":"  when: set_heat_workers"},{"line_number":40,"context_line":"  register: core"},{"line_number":41,"context_line":"  shell: \u003e"},{"line_number":42,"context_line":"    cat /proc/cpuinfo | grep processor | wc -l"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: set the number of workers for heat engine before runnning OC upgrade"},{"line_number":45,"context_line":"  when: set_heat_workers"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    heat_workers\u003d\"{{ core.stdout|int / 2 }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Hardcode the number of heat workers, to try to avoid the badstatusline in"},{"line_number":50,"context_line":"# centos ci:"},{"line_number":51,"context_line":"# 1 / append after the commented line"},{"line_number":52,"context_line":"# 2 / make sure all heat engine workers are set to 6"},{"line_number":53,"context_line":"# TODO: remove this with a smarter fix"},{"line_number":54,"context_line":"- name: Set the num of heat workers"},{"line_number":55,"context_line":"  when: set_heat_workers"},{"line_number":56,"context_line":"  become: yes"},{"line_number":57,"context_line":"  shell: \u003e"},{"line_number":58,"context_line":"    sed -i \"/#num_engine_workers/a num_engine_workers \u003d 6\" /etc/heat/heat.conf;"},{"line_number":59,"context_line":"    sed -i \"s/num_engine_workers.*$/num_engine_workers \u003d 6/\" /etc/heat/heat.conf;"},{"line_number":60,"context_line":"    systemctl restart openstack-heat-engine"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a30ddce_a3b24804","line":60,"range":{"start_line":14,"start_character":2,"end_line":60,"end_character":43},"updated":"2017-03-09 19:46:53.000000000","message":"this section should be in a jinja2 bash script if a customer would have to run these sections.","commit_id":"461152492ecc002d746ce22f994e696adee65c92"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"0ca52c769c68d24350204f3dc2fb0ebcc5068619","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dest: \"{{ upgrade_working_dir }}/ceph-upgrade.yaml\""},{"line_number":12,"context_line":"  when: enable_ceph|bool"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Make sure no Tht repo is present"},{"line_number":15,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":16,"context_line":"  file: path\u003d{{ upgrade_working_dir }}/{{ tht_dir }} state\u003dabsent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Copy new Tht directory to the upgrade working dir"},{"line_number":19,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":20,"context_line":"  shell: \u003e"},{"line_number":21,"context_line":"      cp -R /usr/share/openstack-tripleo-heat-templates \\"},{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  become: yes"},{"line_number":26,"context_line":"  shell: \u003e"},{"line_number":27,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"},{"line_number":28,"context_line":"      {{ upgrade_non_controller_script }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: allow traffic for the controller"},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  shell: \u003e"},{"line_number":33,"context_line":"        sudo iptables -A BOOTSTACK_MASQ -s {{ network_isolation_ipv4_cidr }} ! \\"},{"line_number":34,"context_line":"        -d {{ network_isolation_ipv4_cidr }} -j MASQUERADE -t nat;"},{"line_number":35,"context_line":"        sudo iptables-save \u003e /etc/sysconfig/iptables;"},{"line_number":36,"context_line":"  when: network_isolation|bool and deployment_type \u003d\u003d \"virtual\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: get the number of core"},{"line_number":39,"context_line":"  when: set_heat_workers"},{"line_number":40,"context_line":"  register: core"},{"line_number":41,"context_line":"  shell: \u003e"},{"line_number":42,"context_line":"    cat /proc/cpuinfo | grep processor | wc -l"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: set the number of workers for heat engine before runnning OC upgrade"},{"line_number":45,"context_line":"  when: set_heat_workers"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    heat_workers\u003d\"{{ core.stdout|int / 2 }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Hardcode the number of heat workers, to try to avoid the badstatusline in"},{"line_number":50,"context_line":"# centos ci:"},{"line_number":51,"context_line":"# 1 / append after the commented line"},{"line_number":52,"context_line":"# 2 / make sure all heat engine workers are set to 6"},{"line_number":53,"context_line":"# TODO: remove this with a smarter fix"},{"line_number":54,"context_line":"- name: Set the num of heat workers"},{"line_number":55,"context_line":"  when: set_heat_workers"},{"line_number":56,"context_line":"  become: yes"},{"line_number":57,"context_line":"  shell: \u003e"},{"line_number":58,"context_line":"    sed -i \"/#num_engine_workers/a num_engine_workers \u003d 6\" /etc/heat/heat.conf;"},{"line_number":59,"context_line":"    sed -i \"s/num_engine_workers.*$/num_engine_workers \u003d 6/\" /etc/heat/heat.conf;"},{"line_number":60,"context_line":"    systemctl restart openstack-heat-engine"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a30ddce_c8e57d38","line":60,"range":{"start_line":14,"start_character":2,"end_line":60,"end_character":43},"in_reply_to":"9a30ddce_a3b24804","updated":"2017-03-10 10:07:37.000000000","message":"meh, all those parts is legacy pre overcloud upgrade.\nWe need only line 28 for automation purpose, but the rest is for old upgrade path.\nI\u0027m not a big fan of using those kind of workaround/tips\u0026tricks in a bash file, with jinja variables/conditions and loops every where, that make it unreadable, and will add crap to the current \"official\" path which is Newton to Ocata.","commit_id":"461152492ecc002d746ce22f994e696adee65c92"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"6429db0484007bab800aa6824852ab73a153950c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dest: \"{{ upgrade_working_dir }}/ceph-upgrade.yaml\""},{"line_number":12,"context_line":"  when: enable_ceph|bool"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Make sure no Tht repo is present"},{"line_number":15,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":16,"context_line":"  file: path\u003d{{ upgrade_working_dir }}/{{ tht_dir }} state\u003dabsent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Copy new Tht directory to the upgrade working dir"},{"line_number":19,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":20,"context_line":"  shell: \u003e"},{"line_number":21,"context_line":"      cp -R /usr/share/openstack-tripleo-heat-templates \\"},{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  become: yes"},{"line_number":26,"context_line":"  shell: \u003e"},{"line_number":27,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"},{"line_number":28,"context_line":"      {{ upgrade_non_controller_script }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: allow traffic for the controller"},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  shell: \u003e"},{"line_number":33,"context_line":"        sudo iptables -A BOOTSTACK_MASQ -s {{ network_isolation_ipv4_cidr }} ! \\"},{"line_number":34,"context_line":"        -d {{ network_isolation_ipv4_cidr }} -j MASQUERADE -t nat;"},{"line_number":35,"context_line":"        sudo iptables-save \u003e /etc/sysconfig/iptables;"},{"line_number":36,"context_line":"  when: network_isolation|bool and deployment_type \u003d\u003d \"virtual\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: get the number of core"},{"line_number":39,"context_line":"  when: set_heat_workers"},{"line_number":40,"context_line":"  register: core"},{"line_number":41,"context_line":"  shell: \u003e"},{"line_number":42,"context_line":"    cat /proc/cpuinfo | grep processor | wc -l"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: set the number of workers for heat engine before runnning OC upgrade"},{"line_number":45,"context_line":"  when: set_heat_workers"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    heat_workers\u003d\"{{ core.stdout|int / 2 }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Hardcode the number of heat workers, to try to avoid the badstatusline in"},{"line_number":50,"context_line":"# centos ci:"},{"line_number":51,"context_line":"# 1 / append after the commented line"},{"line_number":52,"context_line":"# 2 / make sure all heat engine workers are set to 6"},{"line_number":53,"context_line":"# TODO: remove this with a smarter fix"},{"line_number":54,"context_line":"- name: Set the num of heat workers"},{"line_number":55,"context_line":"  when: set_heat_workers"},{"line_number":56,"context_line":"  become: yes"},{"line_number":57,"context_line":"  shell: \u003e"},{"line_number":58,"context_line":"    sed -i \"/#num_engine_workers/a num_engine_workers \u003d 6\" /etc/heat/heat.conf;"},{"line_number":59,"context_line":"    sed -i \"s/num_engine_workers.*$/num_engine_workers \u003d 6/\" /etc/heat/heat.conf;"},{"line_number":60,"context_line":"    systemctl restart openstack-heat-engine"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a1ff146_296db798","line":60,"range":{"start_line":14,"start_character":2,"end_line":60,"end_character":43},"in_reply_to":"9a30ddce_be5788c8","updated":"2017-03-15 14:30:17.000000000","message":"Yes more or less.\nI think most of the lines could be removed, or won\u0027t be really important for customer cases for example. (ie workaround line 25, which is here for automation only).\nAll the rest of the file would probably need a clean up. The worker setting was introduced for liberty because of a regression which was override all the undercloud workers to 1 if the undercloud had less than 8 cores.","commit_id":"461152492ecc002d746ce22f994e696adee65c92"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"5adfa69c3a0afdc8240d4cdd9edad3cf0ff72594","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    dest: \"{{ upgrade_working_dir }}/ceph-upgrade.yaml\""},{"line_number":12,"context_line":"  when: enable_ceph|bool"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Make sure no Tht repo is present"},{"line_number":15,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":16,"context_line":"  file: path\u003d{{ upgrade_working_dir }}/{{ tht_dir }} state\u003dabsent"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Copy new Tht directory to the upgrade working dir"},{"line_number":19,"context_line":"  when: not mixed_upgrade|bool"},{"line_number":20,"context_line":"  shell: \u003e"},{"line_number":21,"context_line":"      cp -R /usr/share/openstack-tripleo-heat-templates \\"},{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  become: yes"},{"line_number":26,"context_line":"  shell: \u003e"},{"line_number":27,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"},{"line_number":28,"context_line":"      {{ upgrade_non_controller_script }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: allow traffic for the controller"},{"line_number":31,"context_line":"  become: yes"},{"line_number":32,"context_line":"  shell: \u003e"},{"line_number":33,"context_line":"        sudo iptables -A BOOTSTACK_MASQ -s {{ network_isolation_ipv4_cidr }} ! \\"},{"line_number":34,"context_line":"        -d {{ network_isolation_ipv4_cidr }} -j MASQUERADE -t nat;"},{"line_number":35,"context_line":"        sudo iptables-save \u003e /etc/sysconfig/iptables;"},{"line_number":36,"context_line":"  when: network_isolation|bool and deployment_type \u003d\u003d \"virtual\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: get the number of core"},{"line_number":39,"context_line":"  when: set_heat_workers"},{"line_number":40,"context_line":"  register: core"},{"line_number":41,"context_line":"  shell: \u003e"},{"line_number":42,"context_line":"    cat /proc/cpuinfo | grep processor | wc -l"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: set the number of workers for heat engine before runnning OC upgrade"},{"line_number":45,"context_line":"  when: set_heat_workers"},{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    heat_workers\u003d\"{{ core.stdout|int / 2 }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Hardcode the number of heat workers, to try to avoid the badstatusline in"},{"line_number":50,"context_line":"# centos ci:"},{"line_number":51,"context_line":"# 1 / append after the commented line"},{"line_number":52,"context_line":"# 2 / make sure all heat engine workers are set to 6"},{"line_number":53,"context_line":"# TODO: remove this with a smarter fix"},{"line_number":54,"context_line":"- name: Set the num of heat workers"},{"line_number":55,"context_line":"  when: set_heat_workers"},{"line_number":56,"context_line":"  become: yes"},{"line_number":57,"context_line":"  shell: \u003e"},{"line_number":58,"context_line":"    sed -i \"/#num_engine_workers/a num_engine_workers \u003d 6\" /etc/heat/heat.conf;"},{"line_number":59,"context_line":"    sed -i \"s/num_engine_workers.*$/num_engine_workers \u003d 6/\" /etc/heat/heat.conf;"},{"line_number":60,"context_line":"    systemctl restart openstack-heat-engine"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9a30ddce_be5788c8","line":60,"range":{"start_line":14,"start_character":2,"end_line":60,"end_character":43},"in_reply_to":"9a30ddce_c8e57d38","updated":"2017-03-10 19:35:09.000000000","message":"If OSP is something we intend to support, legacy upgrade path is still very much in play.  Unless you are saying you can use the new upgrade path with older releases.  Is that what you are saying?\n\nMy bottom line is this, if a customer would run it or if it\u0027s a documented step in the official product doc it needs to be done via jinja2 bash.","commit_id":"461152492ecc002d746ce22f994e696adee65c92"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"73aee58c5f15ef498bc760d93a9575cecb0887bf","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  when: step_upgrade_undercloud"},{"line_number":26,"context_line":"  become: yes"},{"line_number":27,"context_line":"  shell: \u003e"},{"line_number":28,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9ff52f3f_f49a746c","side":"PARENT","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":31},"updated":"2017-04-13 11:23:39.000000000","message":"why do we want this to start working unconditionally?","commit_id":"59b1011c76edfb0d8225df7edcbcc528f93c1e5f"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"dc610e8036cbb5449062ab87792d960dea797213","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  when: step_upgrade_undercloud"},{"line_number":26,"context_line":"  become: yes"},{"line_number":27,"context_line":"  shell: \u003e"},{"line_number":28,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9ff52f3f_3d9e7863","side":"PARENT","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":31},"in_reply_to":"9ff52f3f_14ab981d","updated":"2017-04-13 14:36:00.000000000","message":"got it, thank you","commit_id":"59b1011c76edfb0d8225df7edcbcc528f93c1e5f"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"7d84d87d3b58974ac5a5af6d819ba2748b3ce01c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      {{ upgrade_working_dir }}/{{ tht_dir }};"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Add the no ssh finger print checking into upgrade-non-controller.sh"},{"line_number":25,"context_line":"  when: step_upgrade_undercloud"},{"line_number":26,"context_line":"  become: yes"},{"line_number":27,"context_line":"  shell: \u003e"},{"line_number":28,"context_line":"      sed -i \u0027s/ssh/ssh -o StrictHostKeyChecking\u003dno/\u0027 \\"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9ff52f3f_14ab981d","side":"PARENT","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":31},"in_reply_to":"9ff52f3f_f49a746c","updated":"2017-04-13 11:31:50.000000000","message":"I was put here by mistake i guess, because all those tasks are already under the condition: step-pre-overcloud-upgrade","commit_id":"59b1011c76edfb0d8225df7edcbcc528f93c1e5f"}],"roles/overcloud-upgrade/templates/major-upgrade-overcloud.sh.j2":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"9bb34e29e3647d330c81db20fc801e05fcb9a628","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    {% for item in upgrade_custom_templates_script_delivery %}"},{"line_number":142,"context_line":"        -e {{ item }} \\"},{"line_number":143,"context_line":"    {% endfor %}"},{"line_number":144,"context_line":"    {% for item in upgrade_custom_templates %}"},{"line_number":145,"context_line":"        -e {{ item }} \\"},{"line_number":146,"context_line":"    {% endfor %}"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9a30ddce_3cea97db","line":144,"updated":"2017-03-13 14:26:17.000000000","message":"From other code i see this is not a naming convention introduced in this patch (and probably will not be fixed in this patch), but still commenting to pass the info at least.\n\nThe var should be named something like `upgrade_custom_env_files` or `upgrade_custom_environments` or something of that sort. `--templates` point to templates, `-e` point to environment files.\n\nSounds like a nit, but in my experience misleading names tend to generate recurring trouble over time and wasting of person-hours, and make things harder for newcomers. It would be nice to fix the naming at some point.","commit_id":"8dfe946a43ff3c660e45521aa902736a158bcc84"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8918b721b46d6e462c56f10ea4a8c21b25e3aed4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        -e {{ tht_dir }}/environments/puppet-pacemaker.yaml \\"},{"line_number":153,"context_line":"    {% endif %}"},{"line_number":154,"context_line":"        -e {{ tht_dir }}/environments/major-upgrade-composable-steps.yaml \\"},{"line_number":155,"context_line":"    {% for item in upgrade_custom_templates_script_delivery %}"},{"line_number":156,"context_line":"        -e {{ item }} \\"},{"line_number":157,"context_line":"    {% endfor %}"},{"line_number":158,"context_line":"    {% for item in upgrade_custom_templates %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"5ff73747_19c3313a","line":155,"range":{"start_line":155,"start_character":19,"end_line":155,"end_character":59},"updated":"2017-04-28 07:18:15.000000000","message":"had to go looking for this - its upgrade init/reposwitch? https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-upgrade/templates/overcloud-repo.yaml.j2 seems to be a bit of duplication there to what is already in the env file you pass before it fyi https://github.com/openstack/tripleo-heat-templates/blob/master/environments/major-upgrade-composable-steps.yaml\n\nedit: thanks i see you are removing it here https://review.openstack.org/#/c/439598/30/roles/overcloud-upgrade/templates/overcloud-repo.yaml.j2","commit_id":"6239ce895a86b24e9b1dd75ea9cb24a7a2ec9c40"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"893b9a53a82e50bf46b59e16ba6bf28c9b046dcc","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        -e {{ tht_dir }}/environments/puppet-pacemaker.yaml \\"},{"line_number":153,"context_line":"    {% endif %}"},{"line_number":154,"context_line":"        -e {{ tht_dir }}/environments/major-upgrade-composable-steps.yaml \\"},{"line_number":155,"context_line":"    {% for item in upgrade_custom_templates_script_delivery %}"},{"line_number":156,"context_line":"        -e {{ item }} \\"},{"line_number":157,"context_line":"    {% endfor %}"},{"line_number":158,"context_line":"    {% for item in upgrade_custom_templates %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"5ff73747_1461b8d3","line":155,"range":{"start_line":155,"start_character":19,"end_line":155,"end_character":59},"in_reply_to":"5ff73747_19c3313a","updated":"2017-04-28 07:40:51.000000000","message":"yes, that the repo setup stuff. The review 439598 is rebased on top of this one.","commit_id":"6239ce895a86b24e9b1dd75ea9cb24a7a2ec9c40"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8918b721b46d6e462c56f10ea4a8c21b25e3aed4","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    {% for item in upgrade_custom_templates_script_delivery %}"},{"line_number":156,"context_line":"        -e {{ item }} \\"},{"line_number":157,"context_line":"    {% endfor %}"},{"line_number":158,"context_line":"    {% for item in upgrade_custom_templates %}"},{"line_number":159,"context_line":"        -e {{ item }} \\"},{"line_number":160,"context_line":"    {% endfor %}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"fi"},{"line_number":163,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"5ff73747_19d8d11b","line":160,"range":{"start_line":158,"start_character":0,"end_line":160,"end_character":16},"updated":"2017-04-28 07:18:15.000000000","message":"i think it is safer to put the major-upgrade-composable-steps.yaml \u0026 reposwitch last in case there is something in the custom environment files that overrides it","commit_id":"6239ce895a86b24e9b1dd75ea9cb24a7a2ec9c40"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"893b9a53a82e50bf46b59e16ba6bf28c9b046dcc","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    {% for item in upgrade_custom_templates_script_delivery %}"},{"line_number":156,"context_line":"        -e {{ item }} \\"},{"line_number":157,"context_line":"    {% endfor %}"},{"line_number":158,"context_line":"    {% for item in upgrade_custom_templates %}"},{"line_number":159,"context_line":"        -e {{ item }} \\"},{"line_number":160,"context_line":"    {% endfor %}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"fi"},{"line_number":163,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"5ff73747_549980c1","line":160,"range":{"start_line":158,"start_character":0,"end_line":160,"end_character":16},"in_reply_to":"5ff73747_19d8d11b","updated":"2017-04-28 07:40:51.000000000","message":"yep probably, for this 1st use, i don\u0027t think it would be the case, but anyway this jinja bash script need to be cleaned a bit (at least reorganize the steps depending on the release, or create 1 major upgrade files per release), but i could be done in a follow up patch","commit_id":"6239ce895a86b24e9b1dd75ea9cb24a7a2ec9c40"}],"roles/overcloud-upgrade/templates/overcloud-repo.yaml.j2":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"0e8a0b6ccc9e91c32137ccb40bc9a56b1a5e2790","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"dfeb2761_cc60f335","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":25},"updated":"2017-03-31 15:01:09.000000000","message":"This way we\u0027d overwrite delorean.repo from above with contents of delorean-deps.repo. Either we need delorean-deps.repo here, or use -O.","commit_id":"4f283834f65569028eb11d64e1cc268570c0d2e1"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"9e14ab8a4c4a256663127cfe1b2a929a008c61b4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"dfeb2761_f7cb84a2","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":25},"in_reply_to":"dfeb2761_cc60f335","updated":"2017-03-31 15:11:32.000000000","message":"Yep, this is the goal ? In which cases we won\u0027t want to not override it during upgrade ?","commit_id":"4f283834f65569028eb11d64e1cc268570c0d2e1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3cf8ff6b2e262b7a2ffcb46b288c1d4e802a1a8f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"dfeb2761_d7e1a000","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":25},"in_reply_to":"dfeb2761_f7cb84a2","updated":"2017-03-31 15:14:13.000000000","message":"I think we don\u0027t understand each other -- we want delorean.repo and a separate delorean-deps.repo. We want to overwrite both old ones with new ones, but we don\u0027t want to mix them up.\n\nHere on line 11 we\u0027re downloading delorean-deps.repo, and naming it delorean.repo, which overwrites the file we downloaded on line 7 or 9.","commit_id":"4f283834f65569028eb11d64e1cc268570c0d2e1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"89c1c17888b5728022102867f90b622b6521af05","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"dfeb2761_670ce2eb","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":26},"updated":"2017-04-05 08:51:42.000000000","message":"This will still break the repos, as discussed on last patchset.","commit_id":"3d357faba7b4694720291b45216d16b7aa12dee3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"99b303fb6a52318c20d06351e2ad8fd954183f06","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"dfeb2761_a72f8a3d","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":26},"in_reply_to":"dfeb2761_670ce2eb","updated":"2017-04-05 08:52:25.000000000","message":"I mean PS 18.","commit_id":"3d357faba7b4694720291b45216d16b7aa12dee3"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"51fdbdde7ca57d21eaf8315b07a601fc8fcfbc0a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"dfeb2761_c7de0ed9","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":26},"in_reply_to":"dfeb2761_a72f8a3d","updated":"2017-04-05 09:05:02.000000000","message":"i\u0027ll rebase the review when the 452233 will be merged","commit_id":"3d357faba7b4694720291b45216d16b7aa12dee3"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"13653e5c5697a19795da61e99850c7d540c689e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bff0334d_2388b41d","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":26},"in_reply_to":"dfeb2761_a7bf8a5f","updated":"2017-04-05 13:22:30.000000000","message":"Done,\nIt took 2 hours to be available with a git pull :/","commit_id":"3d357faba7b4694720291b45216d16b7aa12dee3"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"05cab471ee01ed66684e9e93c80387778d67e6c5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% else %}"},{"line_number":9,"context_line":"    curl -o delorean.repo -L https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-{{ target_upgrade_version }}/delorean.repo"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"    curl -o delorean.repo -L https://trunk.rdoproject.org/centos7-{{ target_upgrade_version }}/delorean-deps.repo"},{"line_number":12,"context_line":"    popd"},{"line_number":13,"context_line":"    yum clean all"},{"line_number":14,"context_line":"{% if target_upgrade_version in [\u0027ocata\u0027, \u0027master\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"dfeb2761_a7bf8a5f","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":26},"in_reply_to":"dfeb2761_c7de0ed9","updated":"2017-04-05 09:06:07.000000000","message":"Thanks!","commit_id":"3d357faba7b4694720291b45216d16b7aa12dee3"}]}
