)]}'
{"roles/overcloud-deploy/tasks/create-scripts.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"192bb0125162d93add6cc6f64c50db30b0dcb5b7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    dest: \"{{ working_dir }}/neutronl3ha.yaml\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Write composable roles file"},{"line_number":23,"context_line":"  when: composable_roles"},{"line_number":24,"context_line":"  template:"},{"line_number":25,"context_line":"    src: \"overcloud_roles.yaml.j2\""},{"line_number":26,"context_line":"    dest: \"{{ working_dir }}/overcloud_roles.yaml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_83b45681","line":23,"updated":"2017-05-24 11:06:08.000000000","message":"|bool?","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"c92ea1819cc4f434e9f03a24e3ee38397c8d8135","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    dest: \"{{ working_dir }}/neutronl3ha.yaml\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Write composable roles file"},{"line_number":23,"context_line":"  when: composable_roles"},{"line_number":24,"context_line":"  template:"},{"line_number":25,"context_line":"    src: \"overcloud_roles.yaml.j2\""},{"line_number":26,"context_line":"    dest: \"{{ working_dir }}/overcloud_roles.yaml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_f4306aa1","line":23,"in_reply_to":"ff0f0b1f_83b45681","updated":"2017-05-24 12:38:53.000000000","message":"thanks, will fix this up","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"}],"roles/overcloud-deploy/tasks/pre-deploy.yml":[{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"aa486b0a53ae9e06c1a3563ceec28c2c479377e7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    extra_args: \u003e-"},{"line_number":170,"context_line":"      {{ extra_args }}"},{"line_number":171,"context_line":"      --roles-file {{ working_dir }}/overcloud_roles.yaml"},{"line_number":172,"context_line":"  when: composable_roles|bool"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- name: set composable service args fact"},{"line_number":175,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_680804d9","line":172,"updated":"2017-05-24 08:37:12.000000000","message":"i think the task line 174 is doing quite the same thing ? I don\u0027t really the difference, I guess the overcloud_services.yaml is a set of services per roles yaml file","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"c92ea1819cc4f434e9f03a24e3ee38397c8d8135","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    extra_args: \u003e-"},{"line_number":170,"context_line":"      {{ extra_args }}"},{"line_number":171,"context_line":"      --roles-file {{ working_dir }}/overcloud_roles.yaml"},{"line_number":172,"context_line":"  when: composable_roles|bool"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- name: set composable service args fact"},{"line_number":175,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_14eabed6","line":172,"in_reply_to":"ff0f0b1f_43919ef0","updated":"2017-05-24 12:38:53.000000000","message":"overcloud_services can set the ControllerServices etc. params, so they can change what services you deploy on the predefined roles.\n\nOn the other hand overcloud_roles allow you to completely customize the *roles* (not just services) -- add new or remove the predefined ones.","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"192bb0125162d93add6cc6f64c50db30b0dcb5b7","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    extra_args: \u003e-"},{"line_number":170,"context_line":"      {{ extra_args }}"},{"line_number":171,"context_line":"      --roles-file {{ working_dir }}/overcloud_roles.yaml"},{"line_number":172,"context_line":"  when: composable_roles|bool"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"- name: set composable service args fact"},{"line_number":175,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_43919ef0","line":172,"in_reply_to":"ff0f0b1f_680804d9","updated":"2017-05-24 11:06:08.000000000","message":"role files can\u0027t be passed as env file and vice versa, AFAIK. These two are a different templated files","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"}],"roles/overcloud-deploy/templates/overcloud_roles.yaml.j2":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"5c05fb437a3de0f5bde931bbb5a631340c46ae27","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ overcloud_roles | to_nice_yaml }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_0ef83bc2","line":1,"updated":"2017-05-17 13:06:29.000000000","message":"Where is this variable defined ? please add it to roles defaults and documentation on how to use it","commit_id":"e7c4a0c2267ad48f0a1c76b6baf7f67905ff2177"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"8d009010e737b30f1720eab5259ed791ee2d0368","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ overcloud_roles | to_nice_yaml }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff0f0b1f_4f34ed4a","line":1,"in_reply_to":"ff0f0b1f_0ef83bc2","updated":"2017-05-17 14:19:39.000000000","message":"It is not defined -- i don\u0027t want to provide any default. If someone sets `composable_roles: true` and forgets to set overcloud_roles, OOOQ should fail that overcloud_roles are undefined.\n\nIf the user wants sane defaults, they already have them. The default is `composable_roles: false`, which means using the roles_data.yaml which comes with t-h-t.\n\nThe composable_services/overcloud_services pair is very similar, and overcloud_services does have a default:\n\nhttps://github.com/openstack/tripleo-quickstart-extras/blob/4d0f6329df10faa416235bc0f88ee7e010f895eb/roles/overcloud-deploy/defaults/main.yml#L137-L140\n\nBut imo that default is quite impractical/unusable...\n\n\nSo i totally agree on documenting the composable_roles/overcloud_roles variable pair, but would like to avoid providing a default for overcloud_roles. WDYT?\n\nI\u0027ll update the patch.","commit_id":"e7c4a0c2267ad48f0a1c76b6baf7f67905ff2177"},{"author":{"_account_id":16515,"name":"mbu","email":"mat.bultel@gmail.com","username":"matbu"},"change_message_id":"aa486b0a53ae9e06c1a3563ceec28c2c479377e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ overcloud_roles | to_nice_yaml }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff0f0b1f_2840cc06","line":1,"updated":"2017-05-24 08:37:12.000000000","message":"where is define the default value for overcloud_roles variable ?","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"c92ea1819cc4f434e9f03a24e3ee38397c8d8135","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ overcloud_roles | to_nice_yaml }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff0f0b1f_d4944639","line":1,"in_reply_to":"ff0f0b1f_0366062b","updated":"2017-05-24 12:38:53.000000000","message":"In the defaults there\u0027s composable_roles (true/false), but overcloud_roles (the data structure) doesn\u0027t have a default, and it shouldn\u0027t have a default. If you want to deploy the default overcloud roles, just don\u0027t set composable_roles to true. If you set them to true, you\u0027re also expected to provide the correct value, otherwise OOOQ will complain (rightfully).\n\nSee the discussion on previous patch set. In fact i believe we should remove the default for overcloud_services variable, as it\u0027s basically unusable for any deployment, so having such a default value is wrong. We should rather let OOOQ fail early and complain.","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"192bb0125162d93add6cc6f64c50db30b0dcb5b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ overcloud_roles | to_nice_yaml }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff0f0b1f_0366062b","line":1,"in_reply_to":"ff0f0b1f_2840cc06","updated":"2017-05-24 11:06:08.000000000","message":"it\u0027s in overcloud-deploy/defaults/main.yml :)","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"1d9ea09230adbd67bc1c0987d1468b62c6e02d95","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{ overcloud_roles | to_nice_yaml }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff0f0b1f_542276ba","line":1,"in_reply_to":"ff0f0b1f_d4944639","updated":"2017-05-24 12:51:33.000000000","message":"I removed the default overcloud_services in https://review.openstack.org/#/c/467614/ and provided rationale in the commit message there.","commit_id":"c607cabc46e002a256efd9fba5a0a724f1232dd1"}]}