)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"e319dd74cd6c958ba3933a37039259dc80ac0e1e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When using libvirt, use nameserver derived from the"},{"line_number":10,"context_line":"virthost /etc/resolv.conf file."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Ieb21119f807974c5bc999a92591be9caa483ac1a"},{"line_number":13,"context_line":"Change-Id: Id35120df9dd5331e64a06ee886ccd64edf8834ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f201791_d17891f9","line":12,"updated":"2017-06-21 10:11:53.000000000","message":"We will need to override the default env in tripleo-ci before this will pass the ovb/multinode gates I think.","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"}],"roles/undercloud-deploy/defaults/main.yml":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"a3e072726a383126184f19a79b121cd86b8f1365","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# only to be used in libvirt deployments, see environment config for details"},{"line_number":57,"context_line":"nameserver_from_virthost: false"},{"line_number":58,"context_line":"virsthost_nameservers: None"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_b9680e21","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":21},"updated":"2017-06-23 12:41:12.000000000","message":"/s/virsthost/virthost/, also maybe it would be better to initialize it as an empty list.","commit_id":"60cba0e9422127642eab24179d0b6083092940c4"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"584f664ecea9b3da275b231e0039dc338795f223","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# only to be used in libvirt deployments, see environment config for details"},{"line_number":57,"context_line":"nameserver_from_virthost: false"},{"line_number":58,"context_line":"virthost_nameservers: []"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f201791_7fe10c2a","line":58,"updated":"2017-06-26 11:48:03.000000000","message":"why not just use undercloud_nameservers ?","commit_id":"05736951f0273f033e4c96aaf56cd00f454822c8"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"233d9bf910de079e6f0dda5db7949a848453772d","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# only to be used in libvirt deployments, see environment config for details"},{"line_number":57,"context_line":"nameserver_from_virthost: false"},{"line_number":58,"context_line":"virthost_nameservers: []"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f201791_bfd9e4f3","line":58,"in_reply_to":"5f201791_7fe10c2a","updated":"2017-06-26 12:03:37.000000000","message":"we already have \"undercloud_undercloud_nameservers\", let\u0027s not overload that namespace any more. :)\n\nThese are in fact the parsed nameservers from the virthost.","commit_id":"05736951f0273f033e4c96aaf56cd00f454822c8"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"aa9467a99babb8fe57a2c82c2a86029b914d5e12","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# only to be used in libvirt deployments, see environment config for details"},{"line_number":57,"context_line":"nameserver_from_virthost: false"},{"line_number":58,"context_line":"virthost_nameservers: []"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f201791_5f9770ed","line":58,"in_reply_to":"5f201791_bfd9e4f3","updated":"2017-06-26 12:04:50.000000000","message":"oh, now I see. Thanks","commit_id":"05736951f0273f033e4c96aaf56cd00f454822c8"}],"roles/undercloud-deploy/tasks/create-scripts.yml":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"e319dd74cd6c958ba3933a37039259dc80ac0e1e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# environment."},{"line_number":3,"context_line":"- name: Check the dns information provided by the virthost"},{"line_number":4,"context_line":"  shell: \u003e"},{"line_number":5,"context_line":"    cat /etc/resolv.conf |"},{"line_number":6,"context_line":"    grep -v \"#\" |"},{"line_number":7,"context_line":"    grep nameserver |"},{"line_number":8,"context_line":"    awk \u0027{print $2}\u0027 |"},{"line_number":9,"context_line":"    head -n 2"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  delegate_to: virthost"},{"line_number":12,"context_line":"  register: virthost_nameservers"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_313d85bb","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":13},"updated":"2017-06-21 10:11:53.000000000","message":"My hobby: compacting awk invocations. :)\n\nYou can use this single command instead:\n\n    gawk \u0027/^nameserver +/ { print $2 }\u0027 /etc/resolv.conf\n\nAlso we can leave out the `head -n 2`, why not add all if the system has more?","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"47d9200531ca3ddea255b2b0268e22ac80885fb9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# environment."},{"line_number":3,"context_line":"- name: Check the dns information provided by the virthost"},{"line_number":4,"context_line":"  shell: \u003e"},{"line_number":5,"context_line":"    cat /etc/resolv.conf |"},{"line_number":6,"context_line":"    grep -v \"#\" |"},{"line_number":7,"context_line":"    grep nameserver |"},{"line_number":8,"context_line":"    awk \u0027{print $2}\u0027 |"},{"line_number":9,"context_line":"    head -n 2"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  delegate_to: virthost"},{"line_number":12,"context_line":"  register: virthost_nameservers"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_3b767608","line":9,"range":{"start_line":5,"start_character":0,"end_line":9,"end_character":13},"in_reply_to":"5f201791_313d85bb","updated":"2017-06-21 22:51:06.000000000","message":"Done","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"e319dd74cd6c958ba3933a37039259dc80ac0e1e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    grep nameserver |"},{"line_number":8,"context_line":"    awk \u0027{print $2}\u0027 |"},{"line_number":9,"context_line":"    head -n 2"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  delegate_to: virthost"},{"line_number":12,"context_line":"  register: virthost_nameservers"},{"line_number":13,"context_line":"  when: nameserver_from_virthost is defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_51736181","line":10,"updated":"2017-06-21 10:11:53.000000000","message":"resolv.conf should be readable by everybody so you don\u0027t need become.","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"47d9200531ca3ddea255b2b0268e22ac80885fb9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    grep nameserver |"},{"line_number":8,"context_line":"    awk \u0027{print $2}\u0027 |"},{"line_number":9,"context_line":"    head -n 2"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  delegate_to: virthost"},{"line_number":12,"context_line":"  register: virthost_nameservers"},{"line_number":13,"context_line":"  when: nameserver_from_virthost is defined"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_1b73ba17","line":10,"in_reply_to":"5f201791_51736181","updated":"2017-06-21 22:51:06.000000000","message":"Done","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"e319dd74cd6c958ba3933a37039259dc80ac0e1e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  delegate_to: virthost"},{"line_number":12,"context_line":"  register: virthost_nameservers"},{"line_number":13,"context_line":"  when: nameserver_from_virthost is defined"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: set name server facts"},{"line_number":16,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_91dc5947","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":32},"updated":"2017-06-21 10:11:53.000000000","message":"Define a default for this and just use\n\n    when: nameserver_from_virthost|bool","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"47d9200531ca3ddea255b2b0268e22ac80885fb9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  delegate_to: virthost"},{"line_number":12,"context_line":"  register: virthost_nameservers"},{"line_number":13,"context_line":"  when: nameserver_from_virthost is defined"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: set name server facts"},{"line_number":16,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_bb5ba685","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":32},"in_reply_to":"5f201791_91dc5947","updated":"2017-06-21 22:51:06.000000000","message":"Done","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"e319dd74cd6c958ba3933a37039259dc80ac0e1e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- name: set name server facts"},{"line_number":16,"context_line":"  set_fact:"},{"line_number":17,"context_line":"    virsthost_nameservers: \"{{ virthost_nameservers.stdout_lines }}\""},{"line_number":18,"context_line":"  when: nameserver_from_virthost is defined"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create undercloud configuration"},{"line_number":21,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_d1bbf1e2","line":18,"updated":"2017-06-21 10:11:53.000000000","message":"Same as above.","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"47d9200531ca3ddea255b2b0268e22ac80885fb9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- name: set name server facts"},{"line_number":16,"context_line":"  set_fact:"},{"line_number":17,"context_line":"    virsthost_nameservers: \"{{ virthost_nameservers.stdout_lines }}\""},{"line_number":18,"context_line":"  when: nameserver_from_virthost is defined"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create undercloud configuration"},{"line_number":21,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_9b60ea34","line":18,"in_reply_to":"5f201791_d1bbf1e2","updated":"2017-06-21 22:51:06.000000000","message":"Done","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bbaed451c8f56c84ccd56c70fe039d7d841032d4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# environment."},{"line_number":3,"context_line":"- name: Check the dns information provided by the virthost"},{"line_number":4,"context_line":"  shell: \u003e"},{"line_number":5,"context_line":"    gawk \u0027/^nameserver +/ { print $2 }\u0027 /etc/resolv.conf"},{"line_number":6,"context_line":"  delegate_to: virthost"},{"line_number":7,"context_line":"  register: virthost_nameservers"},{"line_number":8,"context_line":"  when: nameserver_from_virthost|bool"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f201791_63ed4e8a","line":5,"updated":"2017-06-22 09:04:34.000000000","message":"nice!","commit_id":"60cba0e9422127642eab24179d0b6083092940c4"}],"roles/undercloud-deploy/templates/undercloud.conf.j2":[{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"e319dd74cd6c958ba3933a37039259dc80ac0e1e","unresolved":false,"context_lines":[{"line_number":78,"context_line":"undercloud_nameservers \u003d {{ undercloud_undercloud_nameservers }}"},{"line_number":79,"context_line":"{% elif undercloud_undercloud_nameservers is sequence and nameserver_from_virthost is not defined %}"},{"line_number":80,"context_line":"undercloud_nameservers \u003d {{ undercloud_undercloud_nameservers|join(\u0027,\u0027) }}"},{"line_number":81,"context_line":"{% elif virsthost_nameservers is string and nameserver_from_virthost is defined %}"},{"line_number":82,"context_line":"undercloud_nameservers \u003d {{ virsthost_nameservers }}"},{"line_number":83,"context_line":"{% elif virsthost_nameservers is sequence and nameserver_from_virthost is defined %}"},{"line_number":84,"context_line":"undercloud_nameservers \u003d {{ virsthost_nameservers|join(\u0027,\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5f201791_d1dc111a","line":81,"updated":"2017-06-21 10:11:53.000000000","message":"Put these causes first so that we can override a predefined nameserver (like 8.8.8.8). I think you need to also check if you have a zero length list. In case there are no nameservers defined in resolv.conf, the awk command will still succeed and then you need to fall back to the default defined ones.","commit_id":"375a738dc812b7d897db9c09e22f9f1034433ba4"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"bbaed451c8f56c84ccd56c70fe039d7d841032d4","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Nameserver for the Undercloud node."},{"line_number":76,"context_line":"# (string value)"},{"line_number":77,"context_line":"{% if virthost_nameservers !\u003d None and virthost_nameservers is string %}"},{"line_number":78,"context_line":"undercloud_nameservers \u003d {{ virsthost_nameservers }}"},{"line_number":79,"context_line":"{% elif virthost_nameservers !\u003d None and virthost_nameservers is sequence %}"},{"line_number":80,"context_line":"undercloud_nameservers \u003d {{ virsthost_nameservers|join(\u0027,\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f201791_63a2ee4d","line":77,"range":{"start_line":77,"start_character":6,"end_line":77,"end_character":34},"updated":"2017-06-22 09:04:34.000000000","message":"hm, how this is different to the \"is defined\" check?..","commit_id":"60cba0e9422127642eab24179d0b6083092940c4"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"a3e072726a383126184f19a79b121cd86b8f1365","unresolved":false,"context_lines":[{"line_number":78,"context_line":"undercloud_nameservers \u003d {{ virsthost_nameservers }}"},{"line_number":79,"context_line":"{% elif virthost_nameservers !\u003d None and virthost_nameservers is sequence %}"},{"line_number":80,"context_line":"undercloud_nameservers \u003d {{ virsthost_nameservers|join(\u0027,\u0027) }}"},{"line_number":81,"context_line":"{% elif undercloud_undercloud_nameservers is string and nameserver_from_virthost is not defined %}"},{"line_number":82,"context_line":"undercloud_nameservers \u003d {{ undercloud_undercloud_nameservers }}"},{"line_number":83,"context_line":"{% elif undercloud_undercloud_nameservers is sequence and nameserver_from_virthost is not defined %}"},{"line_number":84,"context_line":"undercloud_nameservers \u003d {{ undercloud_undercloud_nameservers|join(\u0027,\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f201791_9492b99d","line":81,"updated":"2017-06-23 12:41:12.000000000","message":"This needs some rework, I\u0027ll put up a patchset, easier than commenting. :)","commit_id":"60cba0e9422127642eab24179d0b6083092940c4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4d8bf1196eda6b7cfc9b2084e3124ef6f9b81a8b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{% endif %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Nameserver for the Undercloud node."},{"line_number":76,"context_line":"# (string value)"},{"line_number":77,"context_line":"{% if virthost_nameservers is string %}"},{"line_number":78,"context_line":"undercloud_nameservers \u003d {{ virthost_nameservers }}"},{"line_number":79,"context_line":"{% elif virthost_nameservers is sequence and virthost_nameservers|length \u003e 0 %}"},{"line_number":80,"context_line":"undercloud_nameservers \u003d {{ virthost_nameservers|join(\u0027,\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f201791_1aa7d9a9","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":39},"updated":"2017-06-25 10:15:04.000000000","message":"If \"{{ virthost_nameservers_output.stdout_lines }}\", then virthost_nameservers will never be a string","commit_id":"c2207e41a06b10d795c5d6d21f028e7d9a43bbbc"},{"author":{"_account_id":8652,"name":"Attila Darazs","email":"adarazs@redhat.com","username":"adarazs"},"change_message_id":"6369efcc80ffcaeeabe728fab5372ea41691bd46","unresolved":false,"context_lines":[{"line_number":73,"context_line":"{% endif %}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"# Nameserver for the Undercloud node."},{"line_number":76,"context_line":"# (string value)"},{"line_number":77,"context_line":"{% if virthost_nameservers is string %}"},{"line_number":78,"context_line":"undercloud_nameservers \u003d {{ virthost_nameservers }}"},{"line_number":79,"context_line":"{% elif virthost_nameservers is sequence and virthost_nameservers|length \u003e 0 %}"},{"line_number":80,"context_line":"undercloud_nameservers \u003d {{ virthost_nameservers|join(\u0027,\u0027) }}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f201791_9f33c8f6","line":77,"range":{"start_line":76,"start_character":0,"end_line":77,"end_character":39},"in_reply_to":"5f201791_1aa7d9a9","updated":"2017-06-26 11:43:46.000000000","message":"I agree but it can be overridden by --extra-vars. Not that we couldn\u0027t override undercloud_undercloud_nameservers instead. I just carried this over from Wes\u0027s change. I little redundancy won\u0027t hurt.","commit_id":"c2207e41a06b10d795c5d6d21f028e7d9a43bbbc"}]}