)]}'
{"roles/overcloud-prep-containers/README.md":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"5bb11c50ebde7f32e5eee4613e96cb326727ab2e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* overcloud_prep_containers_script: overcloud-prep-containers.sh.j2"},{"line_number":30,"context_line":"* overcloud_prep_containers_log: overcloud_prep_containers.log"},{"line_number":31,"context_line":"* undercloud_network_cidr: 192.168.24.0/24"},{"line_number":32,"context_line":"* local_registry_host: \"{{undercloud_network_gateway|default(undercloud_network_cidr|nthhost(1))}}\""},{"line_number":33,"context_line":"* docker_registry_host: docker.io"},{"line_number":34,"context_line":"* docker_image_tag: latest"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"9f436f4f_1e7de8b0","line":32,"updated":"2017-08-09 10:32:41.000000000","message":"Shouldn\u0027t the documentation for these variables move to the extra-common README file?\n\nAlso, the variable is named local_docker_registry_host.","commit_id":"116dda48634b6d40cd1d704c659b9841e774dcdb"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"29eb8b0de2b18c0889f5ce586aa7f8c3086c4805","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* overcloud_prep_containers_script: overcloud-prep-containers.sh.j2"},{"line_number":30,"context_line":"* overcloud_prep_containers_log: overcloud_prep_containers.log"},{"line_number":31,"context_line":"* undercloud_network_cidr: 192.168.24.0/24"},{"line_number":32,"context_line":"* local_registry_host: \"{{undercloud_network_gateway|default(undercloud_network_cidr|nthhost(1))}}\""},{"line_number":33,"context_line":"* docker_registry_host: docker.io"},{"line_number":34,"context_line":"* docker_image_tag: latest"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":4,"id":"9f436f4f_fd74699b","line":32,"in_reply_to":"9f436f4f_1e7de8b0","updated":"2017-08-09 11:17:29.000000000","message":"Yup, thanks :)","commit_id":"116dda48634b6d40cd1d704c659b9841e774dcdb"}],"roles/overcloud-prep-containers/templates/overcloud-prep-containers.sh.j2":[{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b90adff006d5690c6a384187bbaec728d40b7f48","unresolved":false,"context_lines":[{"line_number":39,"context_line":"## ::"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"openstack overcloud container image prepare \\"},{"line_number":42,"context_line":"    --env-file {{ working_dir }}/containers-default-parameters.yaml \\"},{"line_number":43,"context_line":"    --namespace {{ local_docker_registry_host }}:8787/{{ docker_registry_namespace }}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"  DockerInsecureRegistryAddress: {{ local_docker_registry_host }}:8787\" \u003e\u003e \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f436f4f_2a8977c9","line":42,"updated":"2017-08-09 22:22:42.000000000","message":"can this also get the missing\n\n  --tag {{ docker_image_tag }} \\","commit_id":"fe9147f81d59728dc8fc24656d31e1dba3ccc54f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"1e8992dc9140b331062b0147fd89ed66442803e7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"## ::"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"openstack overcloud container image prepare \\"},{"line_number":42,"context_line":"    --env-file {{ working_dir }}/containers-default-parameters.yaml \\"},{"line_number":43,"context_line":"    --namespace {{ local_docker_registry_host }}:8787/{{ docker_registry_namespace }}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"  DockerInsecureRegistryAddress: {{ local_docker_registry_host }}:8787\" \u003e\u003e \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f436f4f_9aab0488","line":42,"in_reply_to":"9f436f4f_2a8977c9","updated":"2017-08-10 09:48:06.000000000","message":"Ok but it\u0027s not an issue introduced by this patch, so i\u0027d prefer if we use the largely green CI on this to hopefully unblock our upgrades job after several days.\n\nI posted a follow up here to add the --tag param, which is not strictly needed right now IIUC, but might become important in the future: https://review.openstack.org/#/c/491463","commit_id":"fe9147f81d59728dc8fc24656d31e1dba3ccc54f"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"e30b3d0296383e3d73526d9ca7ce097dd784634e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"## ::"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"openstack overcloud container image prepare \\"},{"line_number":42,"context_line":"    --env-file {{ working_dir }}/containers-default-parameters.yaml \\"},{"line_number":43,"context_line":"    --namespace {{ local_docker_registry_host }}:8787/{{ docker_registry_namespace }}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"echo \"  DockerInsecureRegistryAddress: {{ local_docker_registry_host }}:8787\" \u003e\u003e \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9f436f4f_fa721049","line":42,"in_reply_to":"9f436f4f_9aab0488","updated":"2017-08-10 09:52:10.000000000","message":"Sorry, the correct link is: https://review.openstack.org/#/c/492456","commit_id":"fe9147f81d59728dc8fc24656d31e1dba3ccc54f"}]}
