)]}'
{"roles/build-test-packages/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a1ce2aa3c94a552715a8457433ce1bc4e1aaa100","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    line: \u0027target\u003dcentos-local\u0027"},{"line_number":83,"context_line":"  when: dlrn_use_local_mirrors|bool"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# let\u0027s include the rpm install test and see how it goes"},{"line_number":86,"context_line":"# - name: Remove DLRN RPM install test"},{"line_number":87,"context_line":"#   shell: \u003e"},{"line_number":88,"context_line":"#     sed -i -e \u0027s%--postinstall%%\u0027"},{"line_number":89,"context_line":"#     {{ build_repo_dir }}/DLRN/scripts/build_rpm.sh"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: get env variables for changes and default change list"},{"line_number":92,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f287b81_f72bee91","line":89,"range":{"start_line":85,"start_character":0,"end_line":89,"end_character":52},"updated":"2017-08-28 22:04:56.000000000","message":"you need to remove commenting here (or lines)","commit_id":"c4630b151f1ab33bfcea7cc3a229f02a7c548f9f"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"913adf63313cfbd00b1e0aff6a3dc0360c827a92","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    line: \u0027target\u003dcentos-local\u0027"},{"line_number":83,"context_line":"  when: dlrn_use_local_mirrors|bool"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# let\u0027s include the rpm install test and see how it goes"},{"line_number":86,"context_line":"# - name: Remove DLRN RPM install test"},{"line_number":87,"context_line":"#   shell: \u003e"},{"line_number":88,"context_line":"#     sed -i -e \u0027s%--postinstall%%\u0027"},{"line_number":89,"context_line":"#     {{ build_repo_dir }}/DLRN/scripts/build_rpm.sh"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: get env variables for changes and default change list"},{"line_number":92,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7f287b81_e953126a","line":89,"range":{"start_line":85,"start_character":0,"end_line":89,"end_character":52},"in_reply_to":"7f287b81_f72bee91","updated":"2017-08-28 22:35:27.000000000","message":"Done","commit_id":"c4630b151f1ab33bfcea7cc3a229f02a7c548f9f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"af55e4b77083088499a0895c18f15153fe518796","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    virtualenv: \"{{ build_repo_dir }}/dlrn-venv\""},{"line_number":55,"context_line":"    state: latest"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: copy the DLRN scripts in the virtualenv to the scripts dir"},{"line_number":58,"context_line":"  shell: /usr/bin/cp -Rv \"{{ build_repo_dir }}/dlrn-venv/share/dlrn/scripts\" \"{{ build_repo_dir }}/DLRN/\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Fetch local rdoinfo copy"},{"line_number":61,"context_line":"  git:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f287b81_e59686f0","line":58,"range":{"start_line":57,"start_character":2,"end_line":58,"end_character":105},"updated":"2017-08-29 11:18:37.000000000","message":"seems like it\u0027s not copied, maybe you need -f flag to suppress prompts: http://logs.openstack.org/12/498712/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq/d06fa3a/console.html#_2017-08-29_09_00_41_105047\n\nif it works without copying them, why to copy? and if we copy it, better to do with ansible module.","commit_id":"1c6913352a579c559a8ec302178a15784b3d76da"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"771b6ed21e26cd7c41487da64aea205cd9872d49","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    virtualenv: \"{{ build_repo_dir }}/dlrn-venv\""},{"line_number":55,"context_line":"    state: latest"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: copy the DLRN scripts in the virtualenv to the scripts dir"},{"line_number":58,"context_line":"  shell: /usr/bin/cp -Rv \"{{ build_repo_dir }}/dlrn-venv/share/dlrn/scripts\" \"{{ build_repo_dir }}/DLRN/\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Fetch local rdoinfo copy"},{"line_number":61,"context_line":"  git:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f287b81_0652b5de","line":58,"range":{"start_line":57,"start_character":2,"end_line":58,"end_character":105},"in_reply_to":"7f287b81_e59686f0","updated":"2017-08-29 14:32:30.000000000","message":"I don\u0027t think you are reading the log correctly.  The scripts are copied.  Run devmode locally w/ this change and you can confirm it.  \n\nWhich ansible module would you suggest to copy files from one dir to another on the same host.  AFAICT there aren\u0027t any great modules for doing that in ansible.","commit_id":"1c6913352a579c559a8ec302178a15784b3d76da"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"7108dfc9662f79af5f3b743f192d7dc58774f435","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    src: projects.ini.j2"},{"line_number":42,"context_line":"    dest: \u0027{{ build_repo_dir }}/DLRN/projects.ini\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Install and update pip"},{"line_number":45,"context_line":"  pip:"},{"line_number":46,"context_line":"    name: pip"},{"line_number":47,"context_line":"    virtualenv: \"{{ build_repo_dir }}/dlrn-venv\""},{"line_number":48,"context_line":"    state: latest"},{"line_number":49,"context_line":"    extra_args: --upgrade"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f287b81_0cd3e8d6","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":13},"updated":"2017-08-30 01:21:00.000000000","message":"Referring to the \"install pip\" portion of this, this isn\u0027t going to work if pip isn\u0027t already installed.\n\nYou can do this to make sure it works:\n\n- name: Ensure setuptools is installed\n  package:\n    name: python-setuptools\n    state: installed\n\n- name: Ensure pip is installed\n  easy_install:\n    name: pip\n    state: installed","commit_id":"208076851e769126dc1f669e80c1096d8b5b8eaf"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"ff7d576786fca53a70026b3ac7b9d66fca996832","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    src: projects.ini.j2"},{"line_number":42,"context_line":"    dest: \u0027{{ build_repo_dir }}/DLRN/projects.ini\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Install and update pip"},{"line_number":45,"context_line":"  pip:"},{"line_number":46,"context_line":"    name: pip"},{"line_number":47,"context_line":"    virtualenv: \"{{ build_repo_dir }}/dlrn-venv\""},{"line_number":48,"context_line":"    state: latest"},{"line_number":49,"context_line":"    extra_args: --upgrade"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f287b81_a7206df8","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":13},"in_reply_to":"7f287b81_0cd3e8d6","updated":"2017-08-30 02:13:36.000000000","message":"Thanks David, I\u0027ll follow up with another patch on top of this one. AFAICT, this is a priority for Paul atm.","commit_id":"208076851e769126dc1f669e80c1096d8b5b8eaf"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"7108dfc9662f79af5f3b743f192d7dc58774f435","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Pip install DLRN"},{"line_number":52,"context_line":"  pip:"},{"line_number":53,"context_line":"    name: dlrn"},{"line_number":54,"context_line":"    virtualenv: \"{{ build_repo_dir }}/dlrn-venv\""},{"line_number":55,"context_line":"    state: latest"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f287b81_ac9174f3","line":53,"range":{"start_line":53,"start_character":10,"end_line":53,"end_character":14},"updated":"2017-08-30 01:21:00.000000000","message":"I\u0027m not aware if this is going to be an issue for you but I just wanted to point out that installing DLRN from pypi and from git are entirely two different things.\n\nThe latest version of DLRN on pypi right now is 0.3.0 and there has already been 5 commits beyond 0.3.0 right now: https://github.com/softwarefactory-project/DLRN/compare/0.3.0...master\n\nIf anything, it might help avoid issues that would come from a broken commit (until it\u0027s released), but just thought I would mention it.","commit_id":"208076851e769126dc1f669e80c1096d8b5b8eaf"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"7108dfc9662f79af5f3b743f192d7dc58774f435","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  pip:"},{"line_number":53,"context_line":"    name: dlrn"},{"line_number":54,"context_line":"    virtualenv: \"{{ build_repo_dir }}/dlrn-venv\""},{"line_number":55,"context_line":"    state: latest"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- name: copy the DLRN scripts in the virtualenv to the scripts dir"},{"line_number":58,"context_line":"  shell: \"/usr/bin/cp -Rv {{ build_repo_dir }}/dlrn-venv/share/dlrn/scripts {{ build_repo_dir }}/DLRN/\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7f287b81_0cec088d","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":17},"updated":"2017-08-30 01:21:00.000000000","message":"It will always install the latest version by default. However, if there is already a version installed, this will upgrade it which might not be the expected behavior","commit_id":"208076851e769126dc1f669e80c1096d8b5b8eaf"}],"roles/build-test-packages/templates/projects.ini.j2":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a1ce2aa3c94a552715a8457433ce1bc4e1aaa100","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"datadir\u003d./data"},{"line_number":3,"context_line":"scriptsdir\u003d./scripts"},{"line_number":4,"context_line":"baseurl\u003dhttp://trunk.rdoproject.org/centos7/"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7f287b81_89000e03","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"updated":"2017-08-28 22:04:56.000000000","message":"if it doesn\u0027t have any j2 variables, it should be just in files/, not in templates/","commit_id":"c4630b151f1ab33bfcea7cc3a229f02a7c548f9f"},{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"913adf63313cfbd00b1e0aff6a3dc0360c827a92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"datadir\u003d./data"},{"line_number":3,"context_line":"scriptsdir\u003d./scripts"},{"line_number":4,"context_line":"baseurl\u003dhttp://trunk.rdoproject.org/centos7/"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7f287b81_e96af217","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"in_reply_to":"7f287b81_89000e03","updated":"2017-08-28 22:35:27.000000000","message":"I don\u0027t know man, as soon as we need to add something or set a conditional we\u0027ll have to move right back to templates.  IMHO using files is a subset of just using templates.","commit_id":"c4630b151f1ab33bfcea7cc3a229f02a7c548f9f"}]}