)]}'
{"roles/overcloud-deploy/defaults/main.yml":[{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3a41cc222e00cdfbbe601c164b3c7ebdbe90d2e0","unresolved":false,"context_lines":[{"line_number":134,"context_line":"step_deploy_overcloud: true"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"deploy_steps_ansible_workflow: false"},{"line_number":137,"context_line":"overcloud_key: \"{{ working_dir }}/.ssh/id_rsa\""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"step_validate_overcloud: true"},{"line_number":140,"context_line":"prepare_tempest: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff82abbf_13dcda16","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":30},"updated":"2017-12-01 12:47:56.000000000","message":"I guess this should be ansible_user_dir instead, as the old default is referencing $HOME rather than $PWD. Both will work as the dirs happen to coincide, but $HOME is the traditional location for .ssh directory. Not a blocker but nice to have.","commit_id":"73f8953b1180b0e83daa31bcdd105571b7d05583"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"36841a3c91761cb47ff0d915823ac0af7468542b","unresolved":false,"context_lines":[{"line_number":134,"context_line":"step_deploy_overcloud: true"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"deploy_steps_ansible_workflow: false"},{"line_number":137,"context_line":"overcloud_key: \"{{ working_dir }}/.ssh/id_rsa\""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"step_validate_overcloud: true"},{"line_number":140,"context_line":"prepare_tempest: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_440de035","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":30},"in_reply_to":"df87a7cf_e16bc61c","updated":"2017-12-01 14:31:12.000000000","message":"Ack, but those patterns are for files which don\u0027t have an expected dir, like logs and scripts generated by OOOQ. In case of .ssh directory, that always happens to be in user\u0027s home. If someone uses a different working_dir than their $HOME, the default key path will not be correct for them. I don\u0027t know of anyone doing that though, so as i said, not a blocker.","commit_id":"73f8953b1180b0e83daa31bcdd105571b7d05583"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c0d5c3909bf668b4ef8d229284cce270c1ae4b1","unresolved":false,"context_lines":[{"line_number":134,"context_line":"step_deploy_overcloud: true"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"deploy_steps_ansible_workflow: false"},{"line_number":137,"context_line":"overcloud_key: \"{{ working_dir }}/.ssh/id_rsa\""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"step_validate_overcloud: true"},{"line_number":140,"context_line":"prepare_tempest: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_e16bc61c","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":30},"in_reply_to":"ff82abbf_13dcda16","updated":"2017-12-01 14:14:48.000000000","message":"just followed existing patterns, like documented http://git.openstack.org/cgit/openstack/tripleo-quickstart/tree/doc/source/configuration.rst\nI\u0027d prefer to not alter it for this specific case only","commit_id":"73f8953b1180b0e83daa31bcdd105571b7d05583"}],"roles/overcloud-deploy/templates/deployed_server_prepare.sh.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"828da5c38dc1a9926568c1abd0f3aa09fffcf20c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"# these are the intended variables for overriding"},{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff82abbf_ae450bb6","line":20,"updated":"2017-11-27 07:45:18.000000000","message":"Shouldn\u0027t this be ANSIBLE_SSH_USER? Cf Ieddbb4c87d88888f78d494ff670db907bce4fd78","commit_id":"26fca2bc833e3f83e62db8da4178e8282a89a08e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f2dca2e0544b8748966e651ce5c74f3fa1389f80","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{% endif %}"},{"line_number":18,"context_line":"# these are the intended variables for overriding"},{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff82abbf_77c83621","line":20,"in_reply_to":"ff82abbf_ae450bb6","updated":"2017-11-27 10:21:27.000000000","message":"Both seem OK. Not sure which way would be better. Inventory vars vs env vars?","commit_id":"26fca2bc833e3f83e62db8da4178e8282a89a08e"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"3a41cc222e00cdfbbe601c164b3c7ebdbe90d2e0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# these are the intended variables for overriding"},{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh 2\u003e\u00261 | sudo dd of\u003d/var/log/deployed-server-os-collect-config.log"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ff82abbf_93a1ca98","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":64},"updated":"2017-12-01 12:47:56.000000000","message":"If we\u0027re setting the OVERCLOUD_* variables above, then the SUBNODES_* will not be used at all, as OVERCLOUD_* takes priority in enable-ssh-admin.sh. We should not be setting SUBNODES_SSH_KEY here then, to prevent confusion.","commit_id":"73f8953b1180b0e83daa31bcdd105571b7d05583"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"36841a3c91761cb47ff0d915823ac0af7468542b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# these are the intended variables for overriding"},{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh 2\u003e\u00261 | sudo dd of\u003d/var/log/deployed-server-os-collect-config.log"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df87a7cf_a434ecdf","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":64},"in_reply_to":"df87a7cf_210d2e90","updated":"2017-12-01 14:31:12.000000000","message":"Ack yea that makes perfect sense, i forgot about get-occ-config.sh listening for different var there. +2","commit_id":"73f8953b1180b0e83daa31bcdd105571b7d05583"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2c0d5c3909bf668b4ef8d229284cce270c1ae4b1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# these are the intended variables for overriding"},{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh 2\u003e\u00261 | sudo dd of\u003d/var/log/deployed-server-os-collect-config.log"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"df87a7cf_210d2e90","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":64},"in_reply_to":"ff82abbf_93a1ca98","updated":"2017-12-01 14:14:48.000000000","message":"deployed-server/scripts/get-occ-config.sh knows nothing of OVERCLOUD_SSH_KEY and relies on SUBNODES_SSH_KEY. I had to leave it as is. I\u0027d prefer to not modify get-occ-config.sh, if possible.","commit_id":"73f8953b1180b0e83daa31bcdd105571b7d05583"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c38fb29fe0ee24ecd08e9ea613c4ce7e21d646ba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh 2\u003e\u00261 | sudo dd of\u003d/var/log/deployed-server-os-collect-config.log"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"df87a7cf_384bd82b","line":22,"range":{"start_line":22,"start_character":25,"end_line":22,"end_character":64},"updated":"2017-12-05 10:10:09.000000000","message":"you don\u0027t need overcloud_key then.","commit_id":"43984c584b458a5804efceee8daae418a780860a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"97efbd51b8720f17f87d3ca965efe7694e52a29d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh 2\u003e\u00261 | sudo dd of\u003d/var/log/deployed-server-os-collect-config.log"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"df87a7cf_f81b3018","line":22,"range":{"start_line":22,"start_character":25,"end_line":22,"end_character":64},"in_reply_to":"df87a7cf_384bd82b","updated":"2017-12-05 10:12:00.000000000","message":"it is used in the admin ssh script, and should be allowed to be altered","commit_id":"43984c584b458a5804efceee8daae418a780860a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"90c98ca46e36f885c255292d80a0c6ff640530c4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export OVERCLOUD_SSH_KEY\u003d\"{{ overcloud_key }}\""},{"line_number":20,"context_line":"export OVERCLOUD_SSH_USER\u003d\"{{ overcloud_user }}\""},{"line_number":21,"context_line":"# this is just for compatibility with CI"},{"line_number":22,"context_line":"export SUBNODES_SSH_KEY\u003d${SUBNODES_SSH_KEY:-\"$HOME/.ssh/id_rsa\"}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh 2\u003e\u00261 | sudo dd of\u003d/var/log/deployed-server-os-collect-config.log"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"df87a7cf_b67059de","line":22,"range":{"start_line":22,"start_character":25,"end_line":22,"end_character":64},"in_reply_to":"df87a7cf_f81b3018","updated":"2017-12-05 11:55:42.000000000","message":"I didn\u0027t understand - where exactly is it used?","commit_id":"43984c584b458a5804efceee8daae418a780860a"}]}