)]}'
{"roles/create-reproducer-script/templates/reproducer-quickstart.sh.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"77526b030011edb7dc364d5f72b8191e57ed5f0b","unresolved":false,"context_lines":[{"line_number":184,"context_line":"ansible-playbook $WORKSPACE/tripleo-quickstart-extras/playbooks/provision_multinodes.yml \\"},{"line_number":185,"context_line":"    -e local_working_dir\u003d$WORKSPACE \\"},{"line_number":186,"context_line":"    -e subnode_count\u003d$SUBNODE_COUNT \\"},{"line_number":187,"context_line":"    -e subnode_flavor\u003d$FLAVOR \\"},{"line_number":188,"context_line":"    -e ansible_python_interpreter\u003d\"/usr/bin/python\" \\"},{"line_number":189,"context_line":"    -e prefix\u003d$NODESTACK_PREFIX"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3fa0c359_9d286686","line":187,"updated":"2018-02-22 17:08:12.000000000","message":"please also apply for undercloud_flavor","commit_id":"d1cab053b5c0cd035730e1c43fa00ff2cfe4fa43"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"563c5a9a416d9a688e34551e9beef5510bc9ce5a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":41,"context_line":"    echo \"                      File including specific parameters to be passed\""},{"line_number":42,"context_line":"    echo \"                      at provision time.\""},{"line_number":43,"context_line":"    echo \"                      creating the multinode instances\""},{"line_number":44,"context_line":"    echo \"  -h, --help          print this help and exit\""},{"line_number":45,"context_line":"}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa0c359_90ecb9bb","line":43,"updated":"2018-02-23 12:15:18.000000000","message":"The way it\u0027s currently define you can add that it can be repeated.","commit_id":"f5f4bf60a64dae7fb86c8588272ae6d594b5fdce"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"e03418e8b6ab18174c206efd1ce0ba241fd51683","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            ;;"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        --extra_params|-e)"},{"line_number":84,"context_line":"            EXTRA_PARAMS+\u003d(\"-e\")"},{"line_number":85,"context_line":"            EXTRA_PARAMS+\u003d(\"@$2 \")"},{"line_number":86,"context_line":"            shift"},{"line_number":87,"context_line":"            ;;"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa0c359_d591d353","line":84,"updated":"2018-02-23 11:19:03.000000000","message":"You can do a simple one_liner\nEXTRA_PARAMS+\u003d(\"-e $2\")","commit_id":"f5f4bf60a64dae7fb86c8588272ae6d594b5fdce"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"930fae437f8758cd70d739ef95d95114f568c125","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            ;;"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        --extra_params|-e)"},{"line_number":84,"context_line":"            EXTRA_PARAMS+\u003d(\"-e\")"},{"line_number":85,"context_line":"            EXTRA_PARAMS+\u003d(\"@$2 \")"},{"line_number":86,"context_line":"            shift"},{"line_number":87,"context_line":"            ;;"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa0c359_d00fa12b","line":84,"in_reply_to":"3fa0c359_d591d353","updated":"2018-02-23 11:45:42.000000000","message":"Done, thanks! I also added realpath function so if the file provided doesn\u0027t exist, it will fail sooner.","commit_id":"f5f4bf60a64dae7fb86c8588272ae6d594b5fdce"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"563c5a9a416d9a688e34551e9beef5510bc9ce5a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            ;;"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        --extra_params|-e)"},{"line_number":84,"context_line":"            EXTRA_PARAMS+\u003d(\"-e\")"},{"line_number":85,"context_line":"            EXTRA_PARAMS+\u003d(\"@$2 \")"},{"line_number":86,"context_line":"            shift"},{"line_number":87,"context_line":"            ;;"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa0c359_b099b5c4","line":84,"in_reply_to":"3fa0c359_d591d353","updated":"2018-02-23 12:15:18.000000000","message":"would be \n\n  EXTRA_PARAMS+\u003d(\"-e @${2}\")","commit_id":"f5f4bf60a64dae7fb86c8588272ae6d594b5fdce"},{"author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"change_message_id":"563c5a9a416d9a688e34551e9beef5510bc9ce5a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    -e ansible_python_interpreter\u003d\"/usr/bin/python\" \\"},{"line_number":167,"context_line":"    -e cleanup_stacks_keypairs\u003d$REMOVE_STACKS_KEYPAIRS \\"},{"line_number":168,"context_line":"    -e @$WORKSPACE/tripleo-quickstart/$NODES_FILE \\"},{"line_number":169,"context_line":"    $EXTRA_PARAMS"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":172,"context_line":"ansible-playbook -i $WORKSPACE/ovb_hosts $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"3fa0c359_d0f6c18f","line":169,"range":{"start_line":169,"start_character":4,"end_line":169,"end_character":17},"updated":"2018-02-23 12:15:18.000000000","message":"This should be\n\n   \"${EXTRA_PARAMS[@]}\"","commit_id":"f5f4bf60a64dae7fb86c8588272ae6d594b5fdce"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"7650ce76dd5e3e6001084813e7d94469fe9280a7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        --timeout|-t)"},{"line_number":96,"context_line":"            TIMEOUT\u003d$2"},{"line_number":97,"context_line":"        --extra-params|-e)"},{"line_number":98,"context_line":"            EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2}) \")"},{"line_number":99,"context_line":"            shift"},{"line_number":100,"context_line":"            ;;"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf659307_2ef6f164","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":47},"updated":"2018-04-11 13:43:07.000000000","message":"why to hardcode it to file? maybe someone want just to pass \"-e var\u003dvalue\". Maybe just \"-e ${2}\" and then you can run it with:\n\n   reproducer-quickstart.sh -e var\u003dvalue -e @my_file.yml -e other_var\u003dother_value ...","commit_id":"f5ba7f2e3c7dd2f2e2f2cf3c374f389ef01d0138"},{"author":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"change_message_id":"47ac49cf303d592f2c9d1ab5099460a4da60b966","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        --timeout|-t)"},{"line_number":96,"context_line":"            TIMEOUT\u003d$2"},{"line_number":97,"context_line":"        --extra-params|-e)"},{"line_number":98,"context_line":"            EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2}) \")"},{"line_number":99,"context_line":"            shift"},{"line_number":100,"context_line":"            ;;"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf659307_4918ff1c","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":47},"in_reply_to":"bf659307_2ef6f164","updated":"2018-04-11 13:57:25.000000000","message":"If we do so, we lose the realpath thing (don\u0027t know if it really necessary though).","commit_id":"f5ba7f2e3c7dd2f2e2f2cf3c374f389ef01d0138"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"586fc6f17a6b894ac555f965cb4f917d078de71d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        --timeout|-t)"},{"line_number":96,"context_line":"            TIMEOUT\u003d$2"},{"line_number":97,"context_line":"        --extra-params|-e)"},{"line_number":98,"context_line":"            EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2}) \")"},{"line_number":99,"context_line":"            shift"},{"line_number":100,"context_line":"            ;;"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"9f6a8fd7_c520f9fa","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":47},"in_reply_to":"bf659307_389b8517","updated":"2018-04-16 14:25:12.000000000","message":"This looks like a better option, I\u0027ll test it and add it. Thanks!","commit_id":"f5ba7f2e3c7dd2f2e2f2cf3c374f389ef01d0138"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5bdbcae7febb7e5c00b59dd7a1a50f0d566c50ec","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        --timeout|-t)"},{"line_number":96,"context_line":"            TIMEOUT\u003d$2"},{"line_number":97,"context_line":"        --extra-params|-e)"},{"line_number":98,"context_line":"            EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2}) \")"},{"line_number":99,"context_line":"            shift"},{"line_number":100,"context_line":"            ;;"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bf659307_389b8517","line":98,"range":{"start_line":98,"start_character":28,"end_line":98,"end_character":47},"in_reply_to":"bf659307_4918ff1c","updated":"2018-04-12 00:22:37.000000000","message":"right, how about this then?\n\n  --extra-params|-e)\n\n        [[ ${2::1} \u003d\u003d \"@\" ]] \u0026\u0026 EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2#@}) \") || EXTRA_PARAMS+\u003d(\"-e ${2} \")\n        shift\n            ;;","commit_id":"f5ba7f2e3c7dd2f2e2f2cf3c374f389ef01d0138"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ccedd4756c420a0e28fd9201b12967899420562e","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"SSH_OPTS\u003d\"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"EXTRA_PARAMS\u003d()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"usage () {"},{"line_number":28,"context_line":"    echo \"Usage: $0 [options]\""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_c991ca54","line":25,"updated":"2018-05-07 14:18:49.000000000","message":"Should be defined like the other options above","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5435b1ca2fab462825dcb06ed2f84e30a11b18a","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"SSH_OPTS\u003d\"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"EXTRA_PARAMS\u003d()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"usage () {"},{"line_number":28,"context_line":"    echo \"Usage: $0 [options]\""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_e9ffe664","line":25,"in_reply_to":"5f7c97a3_c991ca54","updated":"2018-05-07 14:34:15.000000000","message":"Done","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ccedd4756c420a0e28fd9201b12967899420562e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    echo \"                      The script sets the virthost to be 127.0.0.2\""},{"line_number":56,"context_line":"    echo \"                      so the reproducer must be run from the virthost.\""},{"line_number":57,"context_line":"    echo \"                      If a singlenode reproducer is run, two VMs will still be created.\""},{"line_number":58,"context_line":"    echo \"  -d, --libvirt-volume-path\""},{"line_number":59,"context_line":"    echo \"                      Specify the full path to the directory where libvirt volumes\""},{"line_number":60,"context_line":"    echo \"                      and snapshots will be stored.\""},{"line_number":61,"context_line":"    echo \"                      The volume directory will default to /opt/vm_images.\""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_498ffa29","line":58,"updated":"2018-05-07 14:18:49.000000000","message":"This can be removed and incorporated in the -e option - with doc change in review https://review.openstack.org/#/c/566155","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ccedd4756c420a0e28fd9201b12967899420562e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":75,"context_line":"    echo \"                      File used to override multinode stack\""},{"line_number":76,"context_line":"    echo \"                      parameters at provision time. Multiple files\""},{"line_number":77,"context_line":"    echo \"                      can be passed [-e file1.yml -e file2.yml, ...]\""},{"line_number":78,"context_line":"    echo \"  -h, --help          print this help and exit\""},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_a97d6e1d","line":77,"updated":"2018-05-07 14:18:49.000000000","message":"Doc needs to be more generic","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5435b1ca2fab462825dcb06ed2f84e30a11b18a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":75,"context_line":"    echo \"                      File used to override multinode stack\""},{"line_number":76,"context_line":"    echo \"                      parameters at provision time. Multiple files\""},{"line_number":77,"context_line":"    echo \"                      can be passed [-e file1.yml -e file2.yml, ...]\""},{"line_number":78,"context_line":"    echo \"  -h, --help          print this help and exit\""},{"line_number":79,"context_line":"}"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_6948b6cb","line":77,"in_reply_to":"5f7c97a3_a97d6e1d","updated":"2018-05-07 14:34:15.000000000","message":"Done","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ccedd4756c420a0e28fd9201b12967899420562e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        --timeout|-t)"},{"line_number":112,"context_line":"            TIMEOUT\u003d$2"},{"line_number":113,"context_line":"        --extra-params|-e)"},{"line_number":114,"context_line":"            [[ ${2::1} \u003d\u003d \"@\" ]] \u0026\u0026 EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2#@}) \") || EXTRA_PARAMS+\u003d(\"-e ${2} \")"},{"line_number":115,"context_line":"            shift"},{"line_number":116,"context_line":"            ;;"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_29a15eaa","line":114,"updated":"2018-05-07 14:18:49.000000000","message":"I would leave the -e out of the option and put it in the playbook call","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5435b1ca2fab462825dcb06ed2f84e30a11b18a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        --timeout|-t)"},{"line_number":112,"context_line":"            TIMEOUT\u003d$2"},{"line_number":113,"context_line":"        --extra-params|-e)"},{"line_number":114,"context_line":"            [[ ${2::1} \u003d\u003d \"@\" ]] \u0026\u0026 EXTRA_PARAMS+\u003d(\"-e @$(realpath ${2#@}) \") || EXTRA_PARAMS+\u003d(\"-e ${2} \")"},{"line_number":115,"context_line":"            shift"},{"line_number":116,"context_line":"            ;;"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_e96cc609","line":114,"in_reply_to":"5f7c97a3_29a15eaa","updated":"2018-05-07 14:34:15.000000000","message":"not sure I understand. This allows to use pure ansible syntax - -e @file.yml -e var\u003dvalue.","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ccedd4756c420a0e28fd9201b12967899420562e","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    ${EXTRA_PARAMS[@]}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":249,"context_line":"ansible-playbook -i $WORKSPACE/ovb_hosts $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"# Copy the nodes.json file to the undercloud"},{"line_number":252,"context_line":"export $(awk \u0027/subnode-0/ {print $2}\u0027 ovb_hosts)"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_4994da37","line":249,"updated":"2018-05-07 14:18:49.000000000","message":"what about extra vars here?","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5435b1ca2fab462825dcb06ed2f84e30a11b18a","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    ${EXTRA_PARAMS[@]}"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":249,"context_line":"ansible-playbook -i $WORKSPACE/ovb_hosts $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"# Copy the nodes.json file to the undercloud"},{"line_number":252,"context_line":"export $(awk \u0027/subnode-0/ {print $2}\u0027 ovb_hosts)"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_692196fb","line":249,"in_reply_to":"5f7c97a3_4994da37","updated":"2018-05-07 14:34:15.000000000","message":"Done","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"ccedd4756c420a0e28fd9201b12967899420562e","unresolved":false,"context_lines":[{"line_number":291,"context_line":"fi"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":294,"context_line":"ansible-playbook -i $WORKSPACE/$HOSTS_FILE $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml ${EXTRA_PARAMS[@]}"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"# Get ansible_host"},{"line_number":297,"context_line":"export $(awk \u0027/subnode-0/ {print $2}\u0027 $WORKSPACE/$HOSTS_FILE)"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_e9b126e3","line":294,"updated":"2018-05-07 14:18:49.000000000","message":"Line is getting long - let\u0027s add some line splits here and continue on more lines","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5435b1ca2fab462825dcb06ed2f84e30a11b18a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"fi"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":294,"context_line":"ansible-playbook -i $WORKSPACE/$HOSTS_FILE $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml ${EXTRA_PARAMS[@]}"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"# Get ansible_host"},{"line_number":297,"context_line":"export $(awk \u0027/subnode-0/ {print $2}\u0027 $WORKSPACE/$HOSTS_FILE)"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_891e72b8","line":294,"in_reply_to":"5f7c97a3_e9b126e3","updated":"2018-05-07 14:34:15.000000000","message":"Done","commit_id":"81ea26c094af8c60731f22be86ef3fe16ba6c2fc"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3200acf9a0d95f6218ad20c3c97c1a847c8f2905","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    echo \"                      TOCI description of the job to run\""},{"line_number":64,"context_line":"    echo \"                      default: $TOCI_JOBTYPE\""},{"line_number":65,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":66,"context_line":"    echo \"                      File used to override playbooks\""},{"line_number":67,"context_line":"    echo \"                      parameters at provision time. Multiple files\""},{"line_number":68,"context_line":"    echo \"                      can be passed [-e @file1.yml -e @file2.yml ...]\""},{"line_number":69,"context_line":"    echo \"                      and arguments [-e var\u003dvalue -e var2\u003dvalue2 ...]\""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f7c97a3_44a601c4","line":66,"updated":"2018-05-07 14:52:16.000000000","message":"Files and/or variables to override the default settings?","commit_id":"ee27807eff25c980d7ccccb5036982b267d64588"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2989f6f8df3a01565575bf40c90eebbf1fc27226","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    echo \"                      TOCI description of the job to run\""},{"line_number":64,"context_line":"    echo \"                      default: $TOCI_JOBTYPE\""},{"line_number":65,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":66,"context_line":"    echo \"                      File used to override playbooks\""},{"line_number":67,"context_line":"    echo \"                      parameters at provision time. Multiple files\""},{"line_number":68,"context_line":"    echo \"                      can be passed [-e @file1.yml -e @file2.yml ...]\""},{"line_number":69,"context_line":"    echo \"                      and arguments [-e var\u003dvalue -e var2\u003dvalue2 ...]\""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f7c97a3_a45fd53f","line":66,"in_reply_to":"5f7c97a3_44a601c4","updated":"2018-05-07 15:10:28.000000000","message":"Done","commit_id":"ee27807eff25c980d7ccccb5036982b267d64588"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3200acf9a0d95f6218ad20c3c97c1a847c8f2905","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    echo \"                      default: $TOCI_JOBTYPE\""},{"line_number":65,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":66,"context_line":"    echo \"                      File used to override playbooks\""},{"line_number":67,"context_line":"    echo \"                      parameters at provision time. Multiple files\""},{"line_number":68,"context_line":"    echo \"                      can be passed [-e @file1.yml -e @file2.yml ...]\""},{"line_number":69,"context_line":"    echo \"                      and arguments [-e var\u003dvalue -e var2\u003dvalue2 ...]\""},{"line_number":70,"context_line":"    echo \"  -h, --help          print this help and exit\""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f7c97a3_c491b154","line":67,"updated":"2018-05-07 14:52:16.000000000","message":"at provision time? At run time?","commit_id":"ee27807eff25c980d7ccccb5036982b267d64588"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2989f6f8df3a01565575bf40c90eebbf1fc27226","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    echo \"                      default: $TOCI_JOBTYPE\""},{"line_number":65,"context_line":"    echo \"  -e, --extra-params\""},{"line_number":66,"context_line":"    echo \"                      File used to override playbooks\""},{"line_number":67,"context_line":"    echo \"                      parameters at provision time. Multiple files\""},{"line_number":68,"context_line":"    echo \"                      can be passed [-e @file1.yml -e @file2.yml ...]\""},{"line_number":69,"context_line":"    echo \"                      and arguments [-e var\u003dvalue -e var2\u003dvalue2 ...]\""},{"line_number":70,"context_line":"    echo \"  -h, --help          print this help and exit\""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f7c97a3_e43aade5","line":67,"in_reply_to":"5f7c97a3_c491b154","updated":"2018-05-07 15:10:28.000000000","message":"Done","commit_id":"ee27807eff25c980d7ccccb5036982b267d64588"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3200acf9a0d95f6218ad20c3c97c1a847c8f2905","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":240,"context_line":"ansible-playbook -i $WORKSPACE/ovb_hosts \\"},{"line_number":241,"context_line":"    $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml ${EXTRA_PARAMS[@]}"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# Copy the nodes.json file to the undercloud"},{"line_number":244,"context_line":"export $(awk \u0027/subnode-0/ {print $2}\u0027 ovb_hosts)"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f7c97a3_44d84152","line":241,"updated":"2018-05-07 14:52:16.000000000","message":"nit: would split there line per option like the OVB call above","commit_id":"ee27807eff25c980d7ccccb5036982b267d64588"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3200acf9a0d95f6218ad20c3c97c1a847c8f2905","unresolved":false,"context_lines":[{"line_number":284,"context_line":""},{"line_number":285,"context_line":"# Run the playbook to setup the undercloud/subnodes to look like nodepool nodes"},{"line_number":286,"context_line":"ansible-playbook -i $WORKSPACE/$HOSTS_FILE \\"},{"line_number":287,"context_line":"    $WORKSPACE/tripleo-quickstart-extras/playbooks/nodepool-setup.yml ${EXTRA_PARAMS[@]}"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"# Get ansible_host"},{"line_number":290,"context_line":"export $(awk \u0027/subnode-0/ {print $2}\u0027 $WORKSPACE/$HOSTS_FILE)"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"5f7c97a3_e4dced47","line":287,"updated":"2018-05-07 14:52:16.000000000","message":"nit: same comment about line splitting","commit_id":"ee27807eff25c980d7ccccb5036982b267d64588"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"91e57462b7f2d23b5b4130b304cafca0858e79bb","unresolved":false,"context_lines":[{"line_number":18,"context_line":": ${TOCI_JOBTYPE:\u003d\"{{ toci_jobtype }}\"}"},{"line_number":19,"context_line":": ${NODES_FILE:\u003d\"{{ nodes_config }}\"}"},{"line_number":20,"context_line":": ${ZUUL_CHANGES:\u003d\"{{ zuul_changes }}\"}"},{"line_number":21,"context_line":": ${EXTRA_PARAMS:\u003d()}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"SSH_OPTS\u003d\"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5f7c97a3_46684020","line":21,"updated":"2018-05-07 20:26:06.000000000","message":"\"\" rather than ()?","commit_id":"41ad601e8c1ce193887a5fc25ae1abe07403635d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5a858dbdfd294fea71b141a3b0d4b6fc373395dc","unresolved":false,"context_lines":[{"line_number":18,"context_line":": ${TOCI_JOBTYPE:\u003d\"{{ toci_jobtype }}\"}"},{"line_number":19,"context_line":": ${NODES_FILE:\u003d\"{{ nodes_config }}\"}"},{"line_number":20,"context_line":": ${ZUUL_CHANGES:\u003d\"{{ zuul_changes }}\"}"},{"line_number":21,"context_line":": ${EXTRA_PARAMS:\u003d()}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"SSH_OPTS\u003d\"-o StrictHostKeyChecking\u003dno -o UserKnownHostsFile\u003d/dev/null\""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5f7c97a3_69f50883","line":21,"in_reply_to":"5f7c97a3_46684020","updated":"2018-05-08 04:28:23.000000000","message":"Done","commit_id":"41ad601e8c1ce193887a5fc25ae1abe07403635d"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"76bc7001ed698c4a110e523da599331e3b259f00","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Exit if the user requests the libvirt-volume-path option without"},{"line_number":187,"context_line":"# running a libvirt reproducer"},{"line_number":188,"context_line":"if [[ \"$LIBVIRT_VOLUME_PATH\" !\u003d \"/opt/vm_images\" \u0026\u0026 \"$LIBVIRT\" !\u003d \"1\" ]]; then"},{"line_number":189,"context_line":"    echo \""},{"line_number":190,"context_line":"        The libvirt-volume-path option is only valid"},{"line_number":191,"context_line":"        when running a libvirt reproducer.\""}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"5f7c97a3_26950441","line":188,"updated":"2018-05-07 20:14:51.000000000","message":"This case should be removed as -d (libvirt_volume_path) no longer exists","commit_id":"41ad601e8c1ce193887a5fc25ae1abe07403635d"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"4b0c570c0f981da83922e37a92026a2a213508ab","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Exit if the user requests the libvirt-volume-path option without"},{"line_number":187,"context_line":"# running a libvirt reproducer"},{"line_number":188,"context_line":"if [[ \"$LIBVIRT_VOLUME_PATH\" !\u003d \"/opt/vm_images\" \u0026\u0026 \"$LIBVIRT\" !\u003d \"1\" ]]; then"},{"line_number":189,"context_line":"    echo \""},{"line_number":190,"context_line":"        The libvirt-volume-path option is only valid"},{"line_number":191,"context_line":"        when running a libvirt reproducer.\""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"5f7c97a3_3100d267","line":188,"updated":"2018-05-08 13:21:24.000000000","message":"I made this comment earlier but I think it got lost in my other comments posted later.\n\nThis check needs to me removed. The LIBVIRT_VOLUME_PATH related option does not exist anymore","commit_id":"a1563de4f1b527de19fa870f6392368edea03509"}]}
