)]}'
{"roles/build-test-packages/tasks/install_roles.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"88bc3d9d9c37902b87109e3338e3a05782422343","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    version: \u0027FETCH_HEAD\u0027"},{"line_number":22,"context_line":"  when: artg_repos_dir is not defined or copy_dir|failed or clone_from_net|default(true)|bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Install role"},{"line_number":25,"context_line":"  pip:"},{"line_number":26,"context_line":"    state: forcereinstall"},{"line_number":27,"context_line":"    name: \u0027file://{{ build_repo_dir }}/DLRN/data/{{ artg_role_name }}/\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f6a8fd7_0876fc07","line":24,"updated":"2018-04-16 17:25:11.000000000","message":"wait.. are we installing ansible roles into the DLRN dir?","commit_id":"f945de7729063e7d7841915af09a85833e0f9b32"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"20997f6403bae3d51d780e727cbfa7594ad0bfbb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    version: \u0027FETCH_HEAD\u0027"},{"line_number":22,"context_line":"  when: artg_repos_dir is not defined or copy_dir|failed or clone_from_net|default(true)|bool"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- name: Install role"},{"line_number":25,"context_line":"  pip:"},{"line_number":26,"context_line":"    state: forcereinstall"},{"line_number":27,"context_line":"    name: \u0027file://{{ build_repo_dir }}/DLRN/data/{{ artg_role_name }}/\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f6a8fd7_b5d07752","line":24,"in_reply_to":"9f6a8fd7_0876fc07","updated":"2018-04-17 08:45:59.000000000","message":"we install role where it\u0027s defined in setup.cfg of this role. DLRN dir is only for clone","commit_id":"f945de7729063e7d7841915af09a85833e0f9b32"}],"roles/build-test-packages/tasks/main.yml":[{"author":{"_account_id":12715,"name":"John Trowbridge","email":"trown@redhat.com","username":"trown"},"change_message_id":"1ab2b489d7d99f36570a0100e16427dd80d8af3e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  when: item.project not in artg_skipped_projects"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Clone and install additional ansible roles"},{"line_number":139,"context_line":"  include: install_roles.yml artg_change\u003d{{ item }} clone_from_net\u003dtrue build_repo_dir\u003d/tmp/"},{"line_number":140,"context_line":"  with_items: \u0027{{ artg_change_list|default([]) }}\u0027"},{"line_number":141,"context_line":"  when: item.project in artg_roles"},{"line_number":142,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_2fde843d","line":139,"updated":"2018-04-04 13:53:11.000000000","message":"why do we have hardcoded clone_from_net\u003dtrue here?\n\ndoesnt seem like we need it to be a variable if this is the only place we use the install_roles.yml, and we hardcode the variable here.","commit_id":"05f93f56c93774360a57ae84b6d8b66d732d24ac"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c7ee13c29a6fc2124cfa57cfce71e2a0ee752a3a","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  when: item.project not in artg_skipped_projects"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Clone and install additional ansible roles"},{"line_number":139,"context_line":"  include: install_roles.yml artg_change\u003d{{ item }} clone_from_net\u003dtrue build_repo_dir\u003d/tmp/"},{"line_number":140,"context_line":"  with_items: \u0027{{ artg_change_list|default([]) }}\u0027"},{"line_number":141,"context_line":"  when: item.project in artg_roles"},{"line_number":142,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf659307_8fa9d024","line":139,"in_reply_to":"bf659307_2fde843d","updated":"2018-04-10 13:53:26.000000000","message":"yeah, will remove it here.","commit_id":"05f93f56c93774360a57ae84b6d8b66d732d24ac"},{"author":{"_account_id":27898,"name":"Quique Llorente","email":"ellorent@redhat.com","username":"quiquell"},"change_message_id":"73011631ec2b111e20a69c7923941c523280205b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  when: item.project not in artg_skipped_projects"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Clone and install additional ansible roles"},{"line_number":139,"context_line":"  include: install_roles.yml artg_change\u003d{{ item }} build_repo_dir\u003d/tmp/"},{"line_number":140,"context_line":"  with_items: \u0027{{ artg_change_list|default([]) }}\u0027"},{"line_number":141,"context_line":"  when: item.project in artg_roles"},{"line_number":142,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_3a0cefa3","line":139,"updated":"2018-04-11 10:57:57.000000000","message":"Using ansible tempfile module for the build_repo_dir will prevent collisions","commit_id":"07f2cda0ca48bb73dfcbe3bbb0946c95d61ed9b4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"939d17e328385dfe561b131c87c750de62b74d5d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  when: item.project not in artg_skipped_projects"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Clone and install additional ansible roles"},{"line_number":139,"context_line":"  include: install_roles.yml artg_change\u003d{{ item }} build_repo_dir\u003d/tmp/"},{"line_number":140,"context_line":"  with_items: \u0027{{ artg_change_list|default([]) }}\u0027"},{"line_number":141,"context_line":"  when: item.project in artg_roles"},{"line_number":142,"context_line":"  delegate_to: localhost"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf659307_00badc6c","line":139,"in_reply_to":"bf659307_3a0cefa3","updated":"2018-04-11 12:35:59.000000000","message":"Yeah, good idea. I\u0027d prefer to do it in following up patch, because it needs additional conditional task to create it.","commit_id":"07f2cda0ca48bb73dfcbe3bbb0946c95d61ed9b4"}]}