)]}'
{"roles/undercloud-deploy/defaults/main.yml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"51235a88b7dc5459c163454e9d5118ea71233f32","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# defines a custom undercloud roles file should be used with"},{"line_number":19,"context_line":"# openstack overcloud container image prepare and undercloud deploy/install CLI"},{"line_number":20,"context_line":"undercloud_roles_data: roles_data_undercloud.yaml"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# defines extra args and service templates for the undercloud deploy command"},{"line_number":23,"context_line":"undercloud_extra_args: \"\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_433249a9","line":20,"updated":"2018-05-09 11:56:51.000000000","message":"I don\u0027t think we should define this in CI by default. This would cover up any possible issues if we break the defaults. Since this is an optional param, we should drop this from the defaluts but still allow it\u0027s overriding in oooq","commit_id":"024e4dd01fd42745e418c08db4ad8ffb01b75848"}],"roles/undercloud-deploy/templates/undercloud-deploy.sh.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"51235a88b7dc5459c163454e9d5118ea71233f32","unresolved":false,"context_lines":[{"line_number":77,"context_line":"{% if undercloud_extra_services_args %}"},{"line_number":78,"context_line":"    {{ undercloud_extra_services_args }} \\"},{"line_number":79,"context_line":"{% endif %}"},{"line_number":80,"context_line":"{% if release not in [\u0027pike\u0027, \u0027queens\u0027] -%}"},{"line_number":81,"context_line":"    -r {{undercloud_roles_data}} \\"},{"line_number":82,"context_line":"{% endif %}"},{"line_number":83,"context_line":"{% if undercloud_extra_args %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f7c97a3_23d4ed1f","line":80,"updated":"2018-05-09 11:56:51.000000000","message":"and undercloud_roles_data","commit_id":"024e4dd01fd42745e418c08db4ad8ffb01b75848"}],"roles/undercloud-deploy/templates/undercloud-prep-containers.sh.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"52ef92c89b7d8670acc03ce06ef043526c2a1e9e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    -e {{ working_dir }}/undercloud-parameter-defaults.yaml \\"},{"line_number":66,"context_line":"{% endif %}"},{"line_number":67,"context_line":"{% if release not in [\u0027pike\u0027, \u0027queens\u0027] and undercloud_roles_data is defined -%}"},{"line_number":68,"context_line":"    -r {{undercloud_roles_data}} \\"},{"line_number":69,"context_line":"{% endif %}"},{"line_number":70,"context_line":"    --namespace {{ undercloud_docker_registry_host }}{% if undercloud_docker_registry_port is defined %}:{{ undercloud_docker_registry_port }}{% endif%}/{{ undercloud_docker_registry_namespace }} \\"},{"line_number":71,"context_line":"    --tag $BUILD_ID"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"5f7c97a3_cd58d657","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":34},"updated":"2018-05-22 14:19:36.000000000","message":"it seems that OVB fs001 fails cuz of this is expected to present?","commit_id":"4bfe4f2b84d88fc9af2a59d535c2359c9433ce5e"}],"roles/undercloud-deploy/templates/undercloud.conf.j2":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"51235a88b7dc5459c163454e9d5118ea71233f32","unresolved":false,"context_lines":[{"line_number":297,"context_line":"enable_routed_networks \u003d {{undercloud_enable_routed_networks}}"},{"line_number":298,"context_line":"{% endif %}"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"roles_file \u003d {{undercloud_roles_data}}"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"# Whether to clean overcloud nodes (wipe the hard drive) between"},{"line_number":303,"context_line":"# deployments and after the introspection."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f7c97a3_a3e79d12","line":300,"updated":"2018-05-09 11:56:51.000000000","message":"We should only define this if set","commit_id":"024e4dd01fd42745e418c08db4ad8ffb01b75848"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"d7ca3a81eba480e14e225ed1ff8e54539a1f5b94","unresolved":false,"context_lines":[{"line_number":297,"context_line":"enable_routed_networks \u003d {{undercloud_enable_routed_networks}}"},{"line_number":298,"context_line":"{% endif %}"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"roles_file \u003d {{undercloud_roles_data}}"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"# Whether to clean overcloud nodes (wipe the hard drive) between"},{"line_number":303,"context_line":"# deployments and after the introspection."}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f7c97a3_283618e9","line":300,"in_reply_to":"5f7c97a3_a3e79d12","updated":"2018-05-22 14:24:36.000000000","message":"It happened for the undercloud, we should always be providing a -r roles_data_undercloud.yaml , back to that revision","commit_id":"024e4dd01fd42745e418c08db4ad8ffb01b75848"}]}