)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"42295e12b9df379ceefb755708207da875ff4f70","unresolved":false,"context_lines":[{"line_number":17,"context_line":"It is expected that overcloud deploy will use the exact same"},{"line_number":18,"context_line":"containers-prepare-parameter.yaml and the logic will be in place to"},{"line_number":19,"context_line":"skip any unnecessary prepare actions. For this reason, the parameter"},{"line_number":20,"context_line":"undercloud_docker_image_tag has been removed, and docker_image_tag is"},{"line_number":21,"context_line":"used directly."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I290806b9296773688dfd02bc41f8baea28cf3d6a"},{"line_number":24,"context_line":"Depends-On: I7449ee364ec9e976fbe9df95024ce3c42f6459b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_ce9fdeb1","line":21,"range":{"start_line":20,"start_character":50,"end_line":21,"end_character":13},"updated":"2018-06-01 12:34:35.000000000","message":"Could you please clarify why we want to keep overcloud_docker_image_tag then?","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"}],"roles/extras-common/README.md":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"fa8eb29304b363cad6f2d11cb206fe25eb2f94a1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  image"},{"line_number":40,"context_line":"- `docker_ceph_image: \u003c\u0027daemon\u0027\u003e Name of the ceph container image"},{"line_number":41,"context_line":"- `docker_ceph_tag: \u003c\u0027v3.0.3-stable-3.0-luminous-centos-7-x86_64\u0027\u003e Tag for the"},{"line_number":42,"context_line":"  ceph container image"},{"line_number":43,"context_line":"- `composable_scenario`: \u003c\u0027\u0027\u003e -- path to the composable scenarios used at deployment time"},{"line_number":44,"context_line":"- `upgrade_composable_scenario`: \u003c\u0027\u0027\u003e -- path to the composable scenarios used at upgrade time"},{"line_number":45,"context_line":"- `undercloud_rpm_dependencies`: \u003c\u0027python-tripleoclient\u0027\u003e -- Dependency packages for undercloud deployments."}],"source_content_type":"text/x-gfm","patch_set":18,"id":"5f7c97a3_75a208b0","line":42,"updated":"2018-06-14 16:26:07.000000000","message":"thanks for adding doc :)","commit_id":"cdf147bc956f3aee77dfd5c05a3f40acdc52f338"}],"roles/extras-common/defaults/main.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"fa8eb29304b363cad6f2d11cb206fe25eb2f94a1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"docker_prep_suffix: \"\""},{"line_number":13,"context_line":"docker_ceph_namespace: docker.io/ceph"},{"line_number":14,"context_line":"docker_ceph_image: daemon"},{"line_number":15,"context_line":"docker_ceph_tag: v3.0.3-stable-3.0-luminous-centos-7-x86_64"},{"line_number":16,"context_line":"additional_insecure_registry: false"},{"line_number":17,"context_line":"deployed_server: false"},{"line_number":18,"context_line":"overcloud_templates_path: /usr/share/openstack-tripleo-heat-templates"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_d5799c30","line":15,"updated":"2018-06-14 16:26:07.000000000","message":"to expose the used version a bit more.. I may follow up with a patch to the config/release/$files to it\u0027s more transparent when moving through releases. Sound OK?","commit_id":"cdf147bc956f3aee77dfd5c05a3f40acdc52f338"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"993360f59e5bc26bd8852d455379d1234cfc1c2e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"docker_prep_suffix: \"\""},{"line_number":13,"context_line":"docker_ceph_namespace: docker.io/ceph"},{"line_number":14,"context_line":"docker_ceph_image: daemon"},{"line_number":15,"context_line":"docker_ceph_tag: v3.0.3-stable-3.0-luminous-centos-7-x86_64"},{"line_number":16,"context_line":"additional_insecure_registry: false"},{"line_number":17,"context_line":"deployed_server: false"},{"line_number":18,"context_line":"overcloud_templates_path: /usr/share/openstack-tripleo-heat-templates"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_0f4ff9be","line":15,"in_reply_to":"5f7c97a3_d5799c30","updated":"2018-06-14 20:45:08.000000000","message":"yeah, this is only going to get worse when the openshift image versions are specified too","commit_id":"cdf147bc956f3aee77dfd5c05a3f40acdc52f338"}],"roles/extras-common/tasks/main.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"fa8eb29304b363cad6f2d11cb206fe25eb2f94a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Conditional facts to be set which are common to undercloud and overcloud"},{"line_number":2,"context_line":"- name: set docker_registry_namespace_used"},{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"    docker_registry_namespace_used: \"{{ docker_registry_namespace }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_15e394da","line":1,"updated":"2018-06-14 16:26:07.000000000","message":"Noting to everyone here.... \nAny tasks in extras-common will be rerun every time a role marks extras-common as a meta dependency.  This will run at least 10-15 times\n\nNoting dissent about that in the past from others. \n\nWe should be able to follow this up w/ an improvement","commit_id":"cdf147bc956f3aee77dfd5c05a3f40acdc52f338"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"993360f59e5bc26bd8852d455379d1234cfc1c2e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Conditional facts to be set which are common to undercloud and overcloud"},{"line_number":2,"context_line":"- name: set docker_registry_namespace_used"},{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"    docker_registry_namespace_used: \"{{ docker_registry_namespace }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5f7c97a3_4febb177","line":1,"in_reply_to":"5f7c97a3_15e394da","updated":"2018-06-14 20:45:08.000000000","message":"Yes, I figured there was a reason why extras-common had no tasks.\n\nI\u0027m hoping that if we limit these tasks to set_fact that this will be OK to remain, at least for the facts which can\u0027t live in defaults because of the conditional logic required to define them.\n\nThe only alternative would be to put these in a role which always runs, and runs before undercloud deploy.","commit_id":"cdf147bc956f3aee77dfd5c05a3f40acdc52f338"}],"roles/undercloud-deploy/tasks/undercloud-prep-containers.yml":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cf1a2998efe231400d4758ac794af7c43169f7f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    docker_registry_namespace_used: \"{{ docker_registry_namespace }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: set container_build_id from get_build_command"},{"line_number":7,"context_line":"  set_fact:"},{"line_number":8,"context_line":"    container_build_id: \"{{ get_build_command }}\""},{"line_number":9,"context_line":"  when: get_build_command is defined"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: set mixed upgrade container_build_id"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_2ec77298","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"updated":"2018-06-01 12:40:11.000000000","message":"this looks not compatible with the shell script implementation:\n\nBUILD_ID\u003d{{ get_build_command }}\n\nSo we prolly want instead to use the command module and get the build id from its registered stdout?","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"864f1051b1de891dd9cdda2d676f6a2c420275de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    docker_registry_namespace_used: \"{{ docker_registry_namespace }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: set container_build_id from get_build_command"},{"line_number":7,"context_line":"  set_fact:"},{"line_number":8,"context_line":"    container_build_id: \"{{ get_build_command }}\""},{"line_number":9,"context_line":"  when: get_build_command is defined"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: set mixed upgrade container_build_id"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_ae38629f","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"in_reply_to":"5f7c97a3_2ec77298","updated":"2018-06-01 12:42:05.000000000","message":"for better or worse, we already have this around http://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/tree/roles/overcloud-prep-containers/tasks/create-scripts.yml#n16\n\nso should be OK","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"183e410ee0dfe573c24da02fbee9ac85f5237d8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    docker_registry_namespace_used: \"{{ docker_registry_namespace }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: set container_build_id from get_build_command"},{"line_number":7,"context_line":"  set_fact:"},{"line_number":8,"context_line":"    container_build_id: \"{{ get_build_command }}\""},{"line_number":9,"context_line":"  when: get_build_command is defined"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: set mixed upgrade container_build_id"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_2fb3c24f","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"in_reply_to":"5f7c97a3_ae38629f","updated":"2018-06-04 22:13:24.000000000","message":"I\u0027ll likely remove those tasks from create-scripts.yml#n16 now that they\u0027re done earlier here.","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"42295e12b9df379ceefb755708207da875ff4f70","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: set mixed upgrade container_build_id"},{"line_number":12,"context_line":"  set_fact:"},{"line_number":13,"context_line":"    container_build_id: \"{{ overcloud_docker_image_tag }}\""},{"line_number":14,"context_line":"    docker_registry_namespace_used: \"{{ overcloud_docker_registry_namespace }}\""},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"  - container_build_id is not defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_0e5cf616","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":54},"updated":"2018-06-01 12:34:35.000000000","message":"could we just use docker_image_tag?","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"f04bf78c895fa42a9c7fa5507ffe570f9872aea2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: set mixed upgrade container_build_id"},{"line_number":12,"context_line":"  set_fact:"},{"line_number":13,"context_line":"    container_build_id: \"{{ overcloud_docker_image_tag }}\""},{"line_number":14,"context_line":"    docker_registry_namespace_used: \"{{ overcloud_docker_registry_namespace }}\""},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"  - container_build_id is not defined"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_8ea56605","line":13,"range":{"start_line":13,"start_character":38,"end_line":13,"end_character":54},"in_reply_to":"5f7c97a3_0e5cf616","updated":"2018-06-01 12:35:31.000000000","message":"never-mind it\u0027s all about mixed upgrades ...","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"}],"roles/undercloud-deploy/templates/containers-prepare-parameter.yaml.j2":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"58db4cb1f7e5936497ce766c4ae7c5c474943b7a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - push_destination: \"{{ local_docker_registry_host }}:8787\""},{"line_number":4,"context_line":"    set:"},{"line_number":5,"context_line":"      tag: \"{{ container_build_id }}\""},{"line_number":6,"context_line":"      namespace: \"{{ docker_registry_host }}/{{ docker_registry_namespace_used }}\""},{"line_number":7,"context_line":"      name_prefix: \"{{ docker_prep_prefix|default(\u0027centos-binary-\u0027) }}\""},{"line_number":8,"context_line":"      name_suffix: \"{{ docker_prep_suffix|default(\u0027\u0027) }}\""},{"line_number":9,"context_line":"      ceph_namespace: \"{{ docker_ceph_namespace|default(\u0027docker.io/ceph\u0027) }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_e5668251","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":82},"updated":"2018-06-01 03:27:50.000000000","message":"it fails:\n\nfatal: [undercloud]: FAILED! \u003d\u003e {\"changed\": false, \"failed\": true, \"msg\": \"AnsibleUndefinedVariable: \u0027docker_registry_namespace_used\u0027 is undefined\"}\n\nDo we want \"undercloud_docker_registry_namespace\" ?","commit_id":"386c26ca12f16b54a5ef34de4396cd1a586f00e0"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"36f71e780efedefe9e2f911c36910d21a39f32fc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - push_destination: \"{{ local_docker_registry_host }}:8787\""},{"line_number":4,"context_line":"    set:"},{"line_number":5,"context_line":"      tag: \"{{ container_build_id }}\""},{"line_number":6,"context_line":"      namespace: \"{{ docker_registry_host }}/{{ docker_registry_namespace_used }}\""},{"line_number":7,"context_line":"      name_prefix: \"{{ docker_prep_prefix|default(\u0027centos-binary-\u0027) }}\""},{"line_number":8,"context_line":"      name_suffix: \"{{ docker_prep_suffix|default(\u0027\u0027) }}\""},{"line_number":9,"context_line":"      ceph_namespace: \"{{ docker_ceph_namespace|default(\u0027docker.io/ceph\u0027) }}\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_85e78eac","line":6,"range":{"start_line":6,"start_character":45,"end_line":6,"end_character":82},"in_reply_to":"5f7c97a3_e5668251","updated":"2018-06-01 03:33:55.000000000","message":"I meant to use docker_registry_namespace. I\u0027m hoping this file can be reused for the overcloud deploy, so undercloud specific parameters can be avoided","commit_id":"386c26ca12f16b54a5ef34de4396cd1a586f00e0"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"cf1a2998efe231400d4758ac794af7c43169f7f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    set:"},{"line_number":5,"context_line":"      tag: \"{{ container_build_id }}\""},{"line_number":6,"context_line":"      namespace: \"{{ docker_registry_host }}/{{ docker_registry_namespace_used }}\""},{"line_number":7,"context_line":"      name_prefix: \"{{ docker_prep_prefix|default(\u0027centos-binary-\u0027) }}\""},{"line_number":8,"context_line":"      name_suffix: \"{{ docker_prep_suffix|default(\u0027\u0027) }}\""},{"line_number":9,"context_line":"      ceph_namespace: \"{{ docker_ceph_namespace|default(\u0027docker.io/ceph\u0027) }}\""},{"line_number":10,"context_line":"      ceph_image: \"{{ docker_ceph_image|default(\u0027daemon\u0027) }}\""},{"line_number":11,"context_line":"      ceph_tag: \"{{ docker_ceph_tag|default(\u0027v3.0.3-stable-3.0-luminous-centos-7-x86_64\u0027) }}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_6ef00afe","line":11,"range":{"start_line":7,"start_character":0,"end_line":11,"end_character":93},"updated":"2018-06-01 12:40:11.000000000","message":"nit: may be it is better to keep defaults in the role defaults?","commit_id":"e902f0e5477a68554cd206e4fd8d37be68aabe3b"}],"roles/undercloud-deploy/templates/undercloud-parameter-defaults.yaml.j2":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"db3d55bbcdaaf1f315ef66872f0d6316bbd6d75b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{#"},{"line_number":2,"context_line":"This takes advantage of the fact that valid JSON is also"},{"line_number":3,"context_line":"valid YAML.  The default to_nice_yaml filter doesn\u0027t quote strings,"},{"line_number":4,"context_line":"which can cause unexpected implicit type conversion when the"},{"line_number":5,"context_line":"resulting YAML is consumed, whereas with JSON all strings are quoted."}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_3af3de75","line":2,"updated":"2018-06-06 08:09:37.000000000","message":"removing this file undoes the networking configuration interface for undercloud. This seems not related to the patch scope and not we want to do prolly.","commit_id":"915f5a5b761ebb90113f05b4b1c43e57100b32ee"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"9d75fe6d144ed03d821a9260753487ef36a35c38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{#"},{"line_number":2,"context_line":"This takes advantage of the fact that valid JSON is also"},{"line_number":3,"context_line":"valid YAML.  The default to_nice_yaml filter doesn\u0027t quote strings,"},{"line_number":4,"context_line":"which can cause unexpected implicit type conversion when the"},{"line_number":5,"context_line":"resulting YAML is consumed, whereas with JSON all strings are quoted."}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5f7c97a3_74fdd806","line":2,"in_reply_to":"5f7c97a3_3af3de75","updated":"2018-06-06 21:48:06.000000000","message":"Huh, not sure what I was thinking here","commit_id":"915f5a5b761ebb90113f05b4b1c43e57100b32ee"}]}