)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"b15b5562eb62df4c0f26fa58307f3906e8e2f591","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix tempest related files permissions for tempest container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* https://review.openstack.org/#/c/583961/3 added tempest user with"},{"line_number":10,"context_line":"  tempest container to fix tempest init log issue and it broke the"},{"line_number":11,"context_line":"  container as all the directory with in tempest container and files"},{"line_number":12,"context_line":"  getting mounted from host have different permision. It fixes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5f7c97a3_e94a7858","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":43},"updated":"2018-07-25 07:35:38.000000000","message":"this points to the abandoned patch","commit_id":"6dac1f4132c73987b553b4da02c947307becaf86"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0497eece79576015effcf144a51860e7c256ca5e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix tempest related files permissions for tempest container"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* https://review.openstack.org/#/c/583961/3 added tempest user with"},{"line_number":10,"context_line":"  tempest container to fix tempest init log issue and it broke the"},{"line_number":11,"context_line":"  container as all the directory with in tempest container and files"},{"line_number":12,"context_line":"  getting mounted from host have different permision. It fixes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"5f7c97a3_c9ff7caf","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":43},"in_reply_to":"5f7c97a3_e94a7858","updated":"2018-07-25 07:41:02.000000000","message":"Nice catch, fixed","commit_id":"6dac1f4132c73987b553b4da02c947307becaf86"}],"roles/validate-tempest/templates/run-tempest.sh.j2":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ce3c51030373ab72568cea3cbaf54cd93c136bcf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    {% endif %}"},{"line_number":53,"context_line":"    {% if tempest_whitelist|length \u003e 0 %}"},{"line_number":54,"context_line":"    {{ working_dir }}/{{ tempest_whitelist_file }} \\"},{"line_number":55,"context_line":"    {{ working_dir }}/{{ tempest_deployer_input_file }} \\"},{"line_number":56,"context_line":"    {% endif %}"},{"line_number":57,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":58,"context_line":"    {{ tempest_test_image_path }} \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_63e561db","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":57},"updated":"2018-07-23 11:00:37.000000000","message":"cp /home/zuul/stackrc /home/zuul/skip_file /home/zuul/whitelist_file.conf /home/zuul/tempest-deployer-input.conf /opt/cache/files/cirros-0.3.5-x86_64-disk.img /home/zuul/tempest_container.sh /home/zuul/tempest_data\n\n2018-07-23 10:03:59 | cp: cannot stat /home/zuul/tempest-deployer-input.conf: No such file or directory","commit_id":"cb45f4118b8f64c72511cebac4904c94c14cb5ae"},{"author":{"_account_id":28223,"name":"Cedric Jeanneret","display_name":"cjeanner (Tengu)","email":"cjeanner@redhat.com","username":"cjeanner"},"change_message_id":"5ba92b6f5f17497f8845de27e2ec3fd0dad86e0d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    {{ working_dir }}/tempest_data"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# Fix the permission of tempest container directory"},{"line_number":63,"context_line":"if [ $(sudo docker inspect --format \"{{ \u0027{{\u0027 }} .Config.User {{ \u0027}}\u0027 }}\" {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }}) \u003d\u003d \u0027tempest\u0027 ]; then"},{"line_number":64,"context_line":"    sudo docker run --net\u003dhost -u root -v {{ working_dir }}/tempest_data:{{ working_dir }} \\"},{"line_number":65,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":66,"context_line":"        -v {{ tempest_test_image_path }}:{{ tempest_test_image_path }} \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5f7c97a3_36a54d49","line":63,"range":{"start_line":63,"start_character":5,"end_line":63,"end_character":181},"updated":"2018-07-24 09:44:19.000000000","message":"prefix with an x the command: \"x$(sudo .....)\" and check against \"xtempest\" in order to avoid empty string.","commit_id":"be251126d3a68bf2fd9d614b1217113d8b64ef60"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"4de8cc5341472377efac8488a469c6f710327fd3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        {{ working_dir }}"},{"line_number":74,"context_line":"fi"},{"line_number":75,"context_line":"# Run tempest container using docker mouting required files"},{"line_number":76,"context_line":"sudo docker run --net\u003dhost -i -v {{ working_dir }}/tempest_data/:{{ working_dir }} \\"},{"line_number":77,"context_line":"    -v /var/log/containers/tempest:{{ tempest_log_dir }} \\"},{"line_number":78,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":79,"context_line":"    -v {{ tempest_test_image_path }}:{{ tempest_test_image_path }} \\"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_5177b3d2","line":76,"updated":"2018-07-24 10:33:18.000000000","message":"WHy do you run the same command twice in some cases ?","commit_id":"1eadad1fd12f1481dbfa5762f20b528a7d4b76b0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"9d3094b8b06325054f4acb1a775c99736b2edde3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        {{ working_dir }}"},{"line_number":74,"context_line":"fi"},{"line_number":75,"context_line":"# Run tempest container using docker mouting required files"},{"line_number":76,"context_line":"sudo docker run --net\u003dhost -i -v {{ working_dir }}/tempest_data/:{{ working_dir }} \\"},{"line_number":77,"context_line":"    -v /var/log/containers/tempest:{{ tempest_log_dir }} \\"},{"line_number":78,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":79,"context_line":"    -v {{ tempest_test_image_path }}:{{ tempest_test_image_path }} \\"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"5f7c97a3_ccf1e602","line":76,"in_reply_to":"5f7c97a3_5177b3d2","updated":"2018-07-24 10:52:36.000000000","message":"https://review.openstack.org/#/c/583961/3 added tempest user to fix tempest logging failure issue in containerized undercloud deployment and this patch also changes the directory permission and it will be available in next promotion,\nWe are running docker command twice one with root user iftempest user already present in image then change the permission of directory so that in next docker run it will execute tempest otherwise it will run last the docker run if tempest user is not present.","commit_id":"1eadad1fd12f1481dbfa5762f20b528a7d4b76b0"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2080f406fc22a1f5da0d1bab39359f97528edf83","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    {{ working_dir }}/tempest_container.sh \\"},{"line_number":60,"context_line":"    {{ working_dir }}/tempest_data"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# https://review.openstack.org/#/c/583940/ added tempest user to tempest container"},{"line_number":63,"context_line":"# The file getting mounted from host to tempest container have different permission"},{"line_number":64,"context_line":"# as tempest user does not own those folders which will give permission denied"},{"line_number":65,"context_line":"# So first check whether tempest user is there or not if present run the docker"},{"line_number":66,"context_line":"# command to change the dir permission and if not found the usual command"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [ \u0027x$(sudo docker inspect --format \"{{ \u0027{{\u0027 }} .Config.User {{ \u0027}}\u0027 }}\" {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }})\u0027 \u003d\u003d \u0027xtempest\u0027 ]; then"},{"line_number":69,"context_line":"    sudo docker run --net\u003dhost -u root -v {{ working_dir }}/tempest_data:{{ working_dir }} \\"},{"line_number":70,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":71,"context_line":"        -v {{ tempest_test_image_path }}:{{ tempest_test_image_path }} \\"},{"line_number":72,"context_line":"    {% endif %}"},{"line_number":73,"context_line":"        {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }} \\"},{"line_number":74,"context_line":"        chown -R tempest:tempest \\"},{"line_number":75,"context_line":"        {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":76,"context_line":"        {{ tempest_test_image_path }} \\"},{"line_number":77,"context_line":"        {% endif %}"},{"line_number":78,"context_line":"        {{ working_dir }}"},{"line_number":79,"context_line":"fi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Run tempest container using docker mouting required files"},{"line_number":82,"context_line":"sudo docker run --net\u003dhost -i -v {{ working_dir }}/tempest_data/:{{ working_dir }} \\"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_9a03040d","line":79,"range":{"start_line":62,"start_character":0,"end_line":79,"end_character":2},"updated":"2018-07-25 09:35:27.000000000","message":"So, if https://review.openstack.org/#/c/583940/ is merged, that means there will always have a tempest user correct? If so, why the test here? If we are using different tempest docker image per release, we should check only the release.\n\nAlso, you are using the if not \u0027http\u0027 in tempest_test_image_path several times here, it would be simple to set a variable with the proper value and just pass this variable everywhere needed.","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6f90911642df0bc7c83cd3579ac2b9e718c7cecd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    {{ working_dir }}/tempest_container.sh \\"},{"line_number":60,"context_line":"    {{ working_dir }}/tempest_data"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# https://review.openstack.org/#/c/583940/ added tempest user to tempest container"},{"line_number":63,"context_line":"# The file getting mounted from host to tempest container have different permission"},{"line_number":64,"context_line":"# as tempest user does not own those folders which will give permission denied"},{"line_number":65,"context_line":"# So first check whether tempest user is there or not if present run the docker"},{"line_number":66,"context_line":"# command to change the dir permission and if not found the usual command"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [ \u0027x$(sudo docker inspect --format \"{{ \u0027{{\u0027 }} .Config.User {{ \u0027}}\u0027 }}\" {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }})\u0027 \u003d\u003d \u0027xtempest\u0027 ]; then"},{"line_number":69,"context_line":"    sudo docker run --net\u003dhost -u root -v {{ working_dir }}/tempest_data:{{ working_dir }} \\"},{"line_number":70,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":71,"context_line":"        -v {{ tempest_test_image_path }}:{{ tempest_test_image_path }} \\"},{"line_number":72,"context_line":"    {% endif %}"},{"line_number":73,"context_line":"        {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }} \\"},{"line_number":74,"context_line":"        chown -R tempest:tempest \\"},{"line_number":75,"context_line":"        {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":76,"context_line":"        {{ tempest_test_image_path }} \\"},{"line_number":77,"context_line":"        {% endif %}"},{"line_number":78,"context_line":"        {{ working_dir }}"},{"line_number":79,"context_line":"fi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Run tempest container using docker mouting required files"},{"line_number":82,"context_line":"sudo docker run --net\u003dhost -i -v {{ working_dir }}/tempest_data/:{{ working_dir }} \\"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_fa5d58eb","line":79,"range":{"start_line":62,"start_character":0,"end_line":79,"end_character":2},"in_reply_to":"5f7c97a3_9a03040d","updated":"2018-07-25 09:42:47.000000000","message":"https://review.openstack.org/#/c/583940/ patch will comes once tripleo CI promotion will happen unless we have tempest image having root user only, If i donot keep both the things at a time, It will break the current CI jobs.\n\nAnd regarding second, if I expose in a variable then the docker run syntex will break so I have done that.","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"923db12198a3de041fe66dce4b021ba7ece1eda4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    {{ working_dir }}/tempest_container.sh \\"},{"line_number":60,"context_line":"    {{ working_dir }}/tempest_data"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# https://review.openstack.org/#/c/583940/ added tempest user to tempest container"},{"line_number":63,"context_line":"# The file getting mounted from host to tempest container have different permission"},{"line_number":64,"context_line":"# as tempest user does not own those folders which will give permission denied"},{"line_number":65,"context_line":"# So first check whether tempest user is there or not if present run the docker"},{"line_number":66,"context_line":"# command to change the dir permission and if not found the usual command"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"if [ \u0027x$(sudo docker inspect --format \"{{ \u0027{{\u0027 }} .Config.User {{ \u0027}}\u0027 }}\" {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }})\u0027 \u003d\u003d \u0027xtempest\u0027 ]; then"},{"line_number":69,"context_line":"    sudo docker run --net\u003dhost -u root -v {{ working_dir }}/tempest_data:{{ working_dir }} \\"},{"line_number":70,"context_line":"    {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":71,"context_line":"        -v {{ tempest_test_image_path }}:{{ tempest_test_image_path }} \\"},{"line_number":72,"context_line":"    {% endif %}"},{"line_number":73,"context_line":"        {{ tempest_container_registry }}/{{ tempest_container_namespace }}:{{ tempest_container_tag }} \\"},{"line_number":74,"context_line":"        chown -R tempest:tempest \\"},{"line_number":75,"context_line":"        {% if not \u0027http\u0027 in tempest_test_image_path %}"},{"line_number":76,"context_line":"        {{ tempest_test_image_path }} \\"},{"line_number":77,"context_line":"        {% endif %}"},{"line_number":78,"context_line":"        {{ working_dir }}"},{"line_number":79,"context_line":"fi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# Run tempest container using docker mouting required files"},{"line_number":82,"context_line":"sudo docker run --net\u003dhost -i -v {{ working_dir }}/tempest_data/:{{ working_dir }} \\"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_da841c11","line":79,"range":{"start_line":62,"start_character":0,"end_line":79,"end_character":2},"in_reply_to":"5f7c97a3_fa5d58eb","updated":"2018-07-25 09:47:49.000000000","message":"Okay, fair enough, so pleas e add a TODO to remove this once we have the promotion.","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"2080f406fc22a1f5da0d1bab39359f97528edf83","unresolved":false,"context_lines":[{"line_number":91,"context_line":"sudo chmod -R 777 {{ working_dir }}/tempest_data"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Copy tempest related data to tempest folder so that stackviz can use it"},{"line_number":94,"context_line":"cp -R {{ working_dir }}/tempest_data/tempest {{ working_dir }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% endif %}"},{"line_number":97,"context_line":"### --stop_docs"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_1a8cd47e","line":94,"updated":"2018-07-25 09:35:27.000000000","message":"Where stackviz will use it? Stackviz task looks for {{ working_dir }}/tempest","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6f90911642df0bc7c83cd3579ac2b9e718c7cecd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"sudo chmod -R 777 {{ working_dir }}/tempest_data"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Copy tempest related data to tempest folder so that stackviz can use it"},{"line_number":94,"context_line":"cp -R {{ working_dir }}/tempest_data/tempest {{ working_dir }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% endif %}"},{"line_number":97,"context_line":"### --stop_docs"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_5a1c8c13","line":94,"in_reply_to":"5f7c97a3_1a8cd47e","updated":"2018-07-25 09:42:47.000000000","message":"After tempest execution, stackviz looks for stestr facts where it finds .stestr/.testr folder if .stestr not found, it will not generate html report and it just passes the job","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"923db12198a3de041fe66dce4b021ba7ece1eda4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"sudo chmod -R 777 {{ working_dir }}/tempest_data"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Copy tempest related data to tempest folder so that stackviz can use it"},{"line_number":94,"context_line":"cp -R {{ working_dir }}/tempest_data/tempest {{ working_dir }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% endif %}"},{"line_number":97,"context_line":"### --stop_docs"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_fa879810","line":94,"in_reply_to":"5f7c97a3_5a1c8c13","updated":"2018-07-25 09:47:49.000000000","message":"staciviz looks for .stestr folder in current directory, that is set to {{ working_dir }}/tempest, not {{ working_dir }}/tempest_data/tempest","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f290fbada708712f66ff4d7f7ea8e3b653ae5a22","unresolved":false,"context_lines":[{"line_number":91,"context_line":"sudo chmod -R 777 {{ working_dir }}/tempest_data"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Copy tempest related data to tempest folder so that stackviz can use it"},{"line_number":94,"context_line":"cp -R {{ working_dir }}/tempest_data/tempest {{ working_dir }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% endif %}"},{"line_number":97,"context_line":"### --stop_docs"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_b506131b","line":94,"in_reply_to":"5f7c97a3_da5dfc54","updated":"2018-07-25 10:12:11.000000000","message":"Ok","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1a503c0b72cdf9c7de097679532f84491414d760","unresolved":false,"context_lines":[{"line_number":91,"context_line":"sudo chmod -R 777 {{ working_dir }}/tempest_data"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"# Copy tempest related data to tempest folder so that stackviz can use it"},{"line_number":94,"context_line":"cp -R {{ working_dir }}/tempest_data/tempest {{ working_dir }}"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"{% endif %}"},{"line_number":97,"context_line":"### --stop_docs"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"5f7c97a3_da5dfc54","line":94,"in_reply_to":"5f7c97a3_fa879810","updated":"2018-07-25 10:06:41.000000000","message":"The volume we are mounting in container is {{ working_dir }}/tempest_data from host. So once tempest run finished, tempest folder will be created under mounted {{ working_dir }}/tempest_data directory so on host it will be {{ working_dir }}/tempest_data/tempest, In this step, to fix stackviz, the we are copying tempest folder to working directory so that other steps can run easily.","commit_id":"d122438560cb2116f130c0e1776a8acf1efe053c"}]}