)]}'
{"roles/overcloud-prep-images/defaults/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"298921fd3fed04dbfa02e99483245ab3ec2cba69","unresolved":false,"context_lines":[{"line_number":9,"context_line":"step_introspect: false"},{"line_number":10,"context_line":"step_introspect_debug: false"},{"line_number":11,"context_line":"step_introspect_debug_tcpdump_log: \"{{ working_dir }}/overcloud_prep_images_introspection_debug.pcap.log\""},{"line_number":12,"context_line":"step_introspect_debug_tcpdump_ports:"},{"line_number":13,"context_line":"  - 67"},{"line_number":14,"context_line":"  - 68"},{"line_number":15,"context_line":"  - 69"},{"line_number":16,"context_line":"  - 623"},{"line_number":17,"context_line":"step_introspect_with_retry: false"},{"line_number":18,"context_line":"bash_deploy_ramdisk: false"},{"line_number":19,"context_line":"step_install_undercloud: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_d89d310a","line":16,"range":{"start_line":12,"start_character":36,"end_line":16,"end_character":7},"updated":"2018-10-18 09:32:36.000000000","message":"just a thought but are we gaining anything by having a list instead of just the string we want and avoid the join in https://review.openstack.org/#/c/610087/4/roles/overcloud-prep-images/templates/overcloud-prep-images.sh.j2 but in any case doesn\u0027t make a big difference i guess the string is uglier and longer if we want to keep adding ports","commit_id":"96892ddcf18c3d54ffe7aafedb7e472ea8f49dc4"},{"author":{"_account_id":20936,"name":"Raoul Scarazzini","email":"rasca@mmul.it","username":"rasca"},"change_message_id":"2b169e5a1a96b30873601f0edac1795a1627c37f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"step_introspect: false"},{"line_number":10,"context_line":"step_introspect_debug: false"},{"line_number":11,"context_line":"step_introspect_debug_tcpdump_log: \"{{ working_dir }}/overcloud_prep_images_introspection_debug.pcap.log\""},{"line_number":12,"context_line":"step_introspect_debug_tcpdump_ports:"},{"line_number":13,"context_line":"  - 67"},{"line_number":14,"context_line":"  - 68"},{"line_number":15,"context_line":"  - 69"},{"line_number":16,"context_line":"  - 623"},{"line_number":17,"context_line":"step_introspect_with_retry: false"},{"line_number":18,"context_line":"bash_deploy_ramdisk: false"},{"line_number":19,"context_line":"step_install_undercloud: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_14d03bc8","line":16,"range":{"start_line":12,"start_character":36,"end_line":16,"end_character":7},"in_reply_to":"3f79a3b5_d89d310a","updated":"2018-10-19 07:28:04.000000000","message":"That is my point, for example, we can think about creating a tcpdump_args variable in which we can add whatever we want to the command (concerning arguments), but for what we\u0027re looking for this way is limited to the ports and more readable.","commit_id":"96892ddcf18c3d54ffe7aafedb7e472ea8f49dc4"}],"roles/overcloud-prep-images/templates/overcloud-prep-images.sh.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8515bca8bd1e8da57bc076d2d4b854256daa5764","unresolved":false,"context_lines":[{"line_number":137,"context_line":"{% if step_introspect_debug|bool %}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"sudo yum -y install tcpdump"},{"line_number":140,"context_line":"sudo tcpdump -i any {{ step_introspect_debug_tcpdump_ports | join(\u0027 or port \u0027) }} -w {{ step_introspect_debug_tcpdump_log }} \u0026"},{"line_number":141,"context_line":"sleep 1"},{"line_number":142,"context_line":"pidof_tcpdump\u003d$(ps --ppid $! -o pid\u003d)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_5d5ccf57","line":140,"range":{"start_line":140,"start_character":13,"end_line":140,"end_character":18},"updated":"2018-10-17 08:05:40.000000000","message":"didn\u0027t we say we\u0027d confine it?","commit_id":"99f647b0f0b575984ff079fc16de0b77f4121fa6"},{"author":{"_account_id":20936,"name":"Raoul Scarazzini","email":"rasca@mmul.it","username":"rasca"},"change_message_id":"439517b9f7c4ecbc3d417c11bc55fcfee2d82040","unresolved":false,"context_lines":[{"line_number":137,"context_line":"{% if step_introspect_debug|bool %}"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"sudo yum -y install tcpdump"},{"line_number":140,"context_line":"sudo tcpdump -i any {{ step_introspect_debug_tcpdump_ports | join(\u0027 or port \u0027) }} -w {{ step_introspect_debug_tcpdump_log }} \u0026"},{"line_number":141,"context_line":"sleep 1"},{"line_number":142,"context_line":"pidof_tcpdump\u003d$(ps --ppid $! -o pid\u003d)"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3f79a3b5_9d7907c8","line":140,"range":{"start_line":140,"start_character":13,"end_line":140,"end_character":18},"in_reply_to":"3f79a3b5_5d5ccf57","updated":"2018-10-17 08:08:15.000000000","message":"Yes, but then we realized that without confining it, it would be possible to see wrong responses on other interfaces, so it is worth keeping \"any\" here.","commit_id":"99f647b0f0b575984ff079fc16de0b77f4121fa6"}]}