)]}'
{"roles/validate-tempest/files/bugcheck/bugcheck.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7d583b5f0ac724fd3d501129ec4fd7071ce4f08b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            LOG.error(\u0027File not found {}\u0027.format(self.args.skip_file))"},{"line_number":126,"context_line":"        else:"},{"line_number":127,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":128,"context_line":"                bug \u003d {\u0027test\u0027: t.get(\u0027test\u0027), \u0027reason\u0027: t.get(\u0027reason\u0027)}"},{"line_number":129,"context_line":"                if t.get(\u0027lp\u0027):"},{"line_number":130,"context_line":"                    bug[\u0027lp\u0027] \u003d t.get(\u0027lp\u0027)"},{"line_number":131,"context_line":"                if t.get(\u0027bz\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_903c4c92","line":128,"updated":"2018-11-16 16:01:26.000000000","message":"if test not found in t we register:\n\u0027test\u0027: None\n\nI think we need to rethink this part\nalso same comment for reason","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"304b3c71784134a206d608d67cd40006d9fee1ee","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            LOG.error(\u0027File not found {}\u0027.format(self.args.skip_file))"},{"line_number":126,"context_line":"        else:"},{"line_number":127,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":128,"context_line":"                bug \u003d {\u0027test\u0027: t.get(\u0027test\u0027), \u0027reason\u0027: t.get(\u0027reason\u0027)}"},{"line_number":129,"context_line":"                if t.get(\u0027lp\u0027):"},{"line_number":130,"context_line":"                    bug[\u0027lp\u0027] \u003d t.get(\u0027lp\u0027)"},{"line_number":131,"context_line":"                if t.get(\u0027bz\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_70ae50a2","line":128,"in_reply_to":"3f79a3b5_903c4c92","updated":"2018-11-16 16:07:01.000000000","message":"Yes you probably right but I have not modified this part, it was already like that. That can be make in another patch.","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"}],"roles/validate-tempest/files/tempestmail/tempestmail.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7d583b5f0ac724fd3d501129ec4fd7071ce4f08b","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        known_failures \u003d []"},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            skip \u003d yaml.load(open(self.args.skip_file))"},{"line_number":324,"context_line":"        except Exception:"},{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_10859c53","line":324,"updated":"2018-11-16 16:01:26.000000000","message":"I think we can more manage properly exceptions by catch specific cases (e.g. yaml loading error, file not found) and log errors","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"44b381e0a2145a0aad027ad8534bde3cc682268d","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        known_failures \u003d []"},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            skip \u003d yaml.load(open(self.args.skip_file))"},{"line_number":324,"context_line":"        except Exception:"},{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_064cbc95","line":324,"range":{"start_line":324,"start_character":4,"end_line":324,"end_character":25},"updated":"2018-12-12 11:44:23.000000000","message":"What is this exception for? If it\u0027s passed, then \"skip\" is not defined and it fails in \"else\". Either you don\u0027t change this block or you change the logic, that way it won\u0027t work.","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"0a9a66fe75e6346c6b49261099c55b63355122ab","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        known_failures \u003d []"},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            skip \u003d yaml.load(open(self.args.skip_file))"},{"line_number":324,"context_line":"        except Exception:"},{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fad6efc1","line":324,"range":{"start_line":324,"start_character":4,"end_line":324,"end_character":25},"in_reply_to":"3f79a3b5_064cbc95","updated":"2018-12-12 14:22:20.000000000","message":"Sorry but I\u0027m not sure to understand what you mean. The skip is defined in the try block, if the statement is ok, you enter in the else block and skip was defined.","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"304b3c71784134a206d608d67cd40006d9fee1ee","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        known_failures \u003d []"},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            skip \u003d yaml.load(open(self.args.skip_file))"},{"line_number":324,"context_line":"        except Exception:"},{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_10bd9cd0","line":324,"in_reply_to":"3f79a3b5_10859c53","updated":"2018-11-16 16:07:01.000000000","message":"Yes you probably right but I have not modified this part, it was already like that. That can be make in another patch.","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7d583b5f0ac724fd3d501129ec4fd7071ce4f08b","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":328,"context_line":"                known_failures.append({\u0027test\u0027: t.get(\u0027test\u0027),"},{"line_number":329,"context_line":"                                       \u0027reason\u0027: t.get(\u0027reason\u0027)})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return known_failures"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_70ebb010","line":328,"updated":"2018-11-16 16:01:26.000000000","message":"if test not found in t we register:\n\u0027test\u0027: None\n\nI think we need to rethink this part","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"304b3c71784134a206d608d67cd40006d9fee1ee","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            pass"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":328,"context_line":"                known_failures.append({\u0027test\u0027: t.get(\u0027test\u0027),"},{"line_number":329,"context_line":"                                       \u0027reason\u0027: t.get(\u0027reason\u0027)})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return known_failures"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d09c0471","line":328,"in_reply_to":"3f79a3b5_70ebb010","updated":"2018-11-16 16:07:01.000000000","message":"Yes you probably right but I have not modified this part, it was already like that. That can be make in another patch.","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7d583b5f0ac724fd3d501129ec4fd7071ce4f08b","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":328,"context_line":"                known_failures.append({\u0027test\u0027: t.get(\u0027test\u0027),"},{"line_number":329,"context_line":"                                       \u0027reason\u0027: t.get(\u0027reason\u0027)})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return known_failures"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_50d0f456","line":329,"updated":"2018-11-16 16:01:26.000000000","message":"if reason not found in t we register:\n\u0027reason\u0027: None\n\nI think we need to rethink this part","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"304b3c71784134a206d608d67cd40006d9fee1ee","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":328,"context_line":"                known_failures.append({\u0027test\u0027: t.get(\u0027test\u0027),"},{"line_number":329,"context_line":"                                       \u0027reason\u0027: t.get(\u0027reason\u0027)})"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        return known_failures"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5088f423","line":329,"in_reply_to":"3f79a3b5_50d0f456","updated":"2018-11-16 16:07:01.000000000","message":"Yes you probably right but I have not modified this part, it was already like that. That can be make in another patch.","commit_id":"d64bb498f4430be1315df693a09bfc072d514b8b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"67317f9d5a5ae3ad5b5be3f35a455c8c2c0de691","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            skip \u003d yaml.load(open(self.args.skip_file))"},{"line_number":324,"context_line":"        except Exception:"},{"line_number":325,"context_line":"            self.log.error("},{"line_number":326,"context_line":"                \"Can\u0027t load the file {skip_file}\".format(skip_file\u003dskip))"},{"line_number":327,"context_line":"        else:"},{"line_number":328,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"},{"line_number":329,"context_line":"                known_failures.append({\u0027test\u0027: t.get(\u0027test\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f769fc5_277c1db4","line":326,"range":{"start_line":326,"start_character":67,"end_line":326,"end_character":71},"updated":"2019-01-02 18:07:09.000000000","message":"\"skip\" is fd in try section, it should be \"self.args.skip_file\" - path to file.","commit_id":"dd2dff9c08fa261df27409b014f4fcc42c37862a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2dfdf83a4c3be4c20bb1f7504359bae848c37c12","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        known_failures \u003d []"},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            skip \u003d yaml.safe_load(open(self.args.skip_file))"},{"line_number":324,"context_line":"        except yaml.constructor.ConstructorError:"},{"line_number":325,"context_line":"            self.log.error(\u0027Invalid yaml file {}\u0027.format(self.args.skip_file))"},{"line_number":326,"context_line":"        else:"},{"line_number":327,"context_line":"            for t in skip.get(\u0027known_failures\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfdaf3ff_4fdab017","line":324,"range":{"start_line":324,"start_character":8,"end_line":324,"end_character":49},"updated":"2019-01-14 20:12:18.000000000","message":"and if files doesn\u0027t exist/has bad permission?\n\nas well for all other places","commit_id":"3e5aaee36d44f466ced2cb928393a273b35d28c6"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2dfdf83a4c3be4c20bb1f7504359bae848c37c12","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                   \u0027reason\u0027: t.get(\u0027reason\u0027)})"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"        if self.args.skip_file:"},{"line_number":393,"context_line":"            known_failures \u003d \\"},{"line_number":394,"context_line":"                (known_failures + self.load_skip_file(self.args.skip_file))"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        newconfig.known_failures \u003d known_failures"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfdaf3ff_efeb64ad","line":393,"range":{"start_line":393,"start_character":28,"end_line":393,"end_character":30},"updated":"2019-01-14 20:12:18.000000000","message":"let\u0027s avoid using backslashes, better to use ()","commit_id":"3e5aaee36d44f466ced2cb928393a273b35d28c6"}]}