)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"9a61b9de7a837393cf7710f8896ad6fd1a81c79b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The baremetal deployment should follow OVB closely."},{"line_number":10,"context_line":"Add a baseos undercloud and build/fetch images"},{"line_number":11,"context_line":"under the same conditions as OVB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I67439f3497499f30801d185a298e01f112f01fbe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":27,"id":"dfbec78f_e7077e17","line":12,"updated":"2019-05-15 07:38:44.000000000","message":"point to https://tree.taiga.io/project/tripleo-ci-board/task/950 since we\u0027ve got it and it\u0027s public","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"}],"playbooks/baremetal-prep-virthost.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f901c9bf84298008eeba5ffb79c347561059e42b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  vars:"},{"line_number":79,"context_line":"    artg_compressed_gating_repo: \"/home/{{ undercloud_user }}/gating_repo.tar.gz\""},{"line_number":80,"context_line":"    artg_repos_dir: \"{{ repo_clone_dir|default(\u0027/opt/stack/new\u0027) }}\""},{"line_number":81,"context_line":"    ib_create_web_repo: \"{{ to_build|bool }}\""},{"line_number":82,"context_line":"  tasks:"},{"line_number":83,"context_line":"    - name: get to_build value from virthost"},{"line_number":84,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5fc1f717_21af682c","line":81,"range":{"start_line":81,"start_character":27,"end_line":81,"end_character":37},"updated":"2019-03-31 14:28:16.000000000","message":"shouldn\u0027t it be hostvars[\u0027localhost\u0027][\u0027to_build\u0027] as well?","commit_id":"199a34cc22d915527f7e8eb7bdddfa255ca50ee2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"188eeb99f5f6299cb43c3df9a218fb9381a4381b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  hosts: virthost"},{"line_number":40,"context_line":"  gather_facts: true"},{"line_number":41,"context_line":"  roles:"},{"line_number":42,"context_line":"    - check-to-build-or-not-to-build"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Setup undercloud and baremetal vms and networks in libvirt"},{"line_number":45,"context_line":"  hosts: virthost"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dfbec78f_c40b5827","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":34},"updated":"2019-05-15 07:37:53.000000000","message":":D I\u0027d remove \u0027check\u0027 call it \u0027to-build-or-not-to-build\u0027 role :)\nor maybe just the \"that-is-the-question\" role :)","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"562eeff54f1067d773b8ea23881b14e70530f75e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  hosts: virthost"},{"line_number":40,"context_line":"  gather_facts: true"},{"line_number":41,"context_line":"  roles:"},{"line_number":42,"context_line":"    - check-to-build-or-not-to-build"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Setup undercloud and baremetal vms and networks in libvirt"},{"line_number":45,"context_line":"  hosts: virthost"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bfb3d3c7_f46b5d1c","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":34},"in_reply_to":"bfb3d3c7_4f873ed9","updated":"2019-05-17 14:17:42.000000000","message":"I am not ignoring you here ... personally, I am against playbooks and roles by the same name - due to the possibly to confuse the two.\nOpen to other objections","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"392f01125cf66947c9ae932bf025b2ba15d879e7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  hosts: virthost"},{"line_number":40,"context_line":"  gather_facts: true"},{"line_number":41,"context_line":"  roles:"},{"line_number":42,"context_line":"    - check-to-build-or-not-to-build"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Setup undercloud and baremetal vms and networks in libvirt"},{"line_number":45,"context_line":"  hosts: virthost"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bfb3d3c7_4f873ed9","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":34},"in_reply_to":"dfbec78f_b4a689aa","updated":"2019-05-17 06:27:19.000000000","message":"ACK - ok i see that is a pattern we use elsewhere too (i.e. we have a role and also a playbook (that maybe invokes it) that are related but with different name).\n\nBut I don\u0027t think that is a requirement i.e. there is no problem if you choose to call your playbook the same name as the role. in fact i found at least one example of us having the same in tqe.. roles/baremetal-undercloud and also playbooks/baremetal-undercloud.yml\n\nObviously not a blocker I just think the \u0027check\u0027 is redundant in an already long name","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3f439b7ea00972fa549066c99a9dade393b085af","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  hosts: virthost"},{"line_number":40,"context_line":"  gather_facts: true"},{"line_number":41,"context_line":"  roles:"},{"line_number":42,"context_line":"    - check-to-build-or-not-to-build"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Setup undercloud and baremetal vms and networks in libvirt"},{"line_number":45,"context_line":"  hosts: virthost"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dfbec78f_b4a689aa","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":34},"in_reply_to":"dfbec78f_c40b5827","updated":"2019-05-15 20:10:32.000000000","message":"So, not sure how serious this comment is :)\nThe playbook is named to-build-or-not-t-build so I am adding the check to the role name to differenciate","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"188eeb99f5f6299cb43c3df9a218fb9381a4381b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    artg_repos_dir: \"{{ repo_clone_dir|default(\u0027/opt/stack/new\u0027) }}\""},{"line_number":102,"context_line":"    ib_create_web_repo: \"{{ hostvars[groups[\u0027virthost\u0027][0]][\u0027to_build\u0027] }}\""},{"line_number":103,"context_line":"  tasks:"},{"line_number":104,"context_line":"    - debug:"},{"line_number":105,"context_line":"        msg: \"to_build on undercloud is: {{ to_build }}\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Always build images even if running a periodic-* named job"},{"line_number":108,"context_line":"    # in a check pipeline for testing"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dfbec78f_642dcca6","line":105,"range":{"start_line":104,"start_character":6,"end_line":105,"end_character":12},"updated":"2019-05-15 07:37:53.000000000","message":"remove?","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"3f439b7ea00972fa549066c99a9dade393b085af","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    artg_repos_dir: \"{{ repo_clone_dir|default(\u0027/opt/stack/new\u0027) }}\""},{"line_number":102,"context_line":"    ib_create_web_repo: \"{{ hostvars[groups[\u0027virthost\u0027][0]][\u0027to_build\u0027] }}\""},{"line_number":103,"context_line":"  tasks:"},{"line_number":104,"context_line":"    - debug:"},{"line_number":105,"context_line":"        msg: \"to_build on undercloud is: {{ to_build }}\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    # Always build images even if running a periodic-* named job"},{"line_number":108,"context_line":"    # in a check pipeline for testing"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dfbec78f_d4977d47","line":105,"range":{"start_line":104,"start_character":6,"end_line":105,"end_character":12},"in_reply_to":"dfbec78f_642dcca6","updated":"2019-05-15 20:10:32.000000000","message":"Done","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"},{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"6284deaa2c7833141642adc35424464a48dc5ea2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  hosts: virthost"},{"line_number":40,"context_line":"  gather_facts: true"},{"line_number":41,"context_line":"  roles:"},{"line_number":42,"context_line":"    - check-to-build-or-not-to-build"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Setup undercloud and baremetal vms and networks in libvirt"},{"line_number":45,"context_line":"  hosts: virthost"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"bfb3d3c7_88a52cb8","line":42,"updated":"2019-05-17 09:33:23.000000000","message":"That is the question.","commit_id":"f7f35f0ec2f7de0efa58a5c017fca04b25f8a307"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"562eeff54f1067d773b8ea23881b14e70530f75e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  hosts: virthost"},{"line_number":40,"context_line":"  gather_facts: true"},{"line_number":41,"context_line":"  roles:"},{"line_number":42,"context_line":"    - check-to-build-or-not-to-build"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Setup undercloud and baremetal vms and networks in libvirt"},{"line_number":45,"context_line":"  hosts: virthost"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"bfb3d3c7_b4d96523","line":42,"in_reply_to":"bfb3d3c7_88a52cb8","updated":"2019-05-17 14:17:42.000000000","message":"ugh - everybody made that comment :)","commit_id":"f7f35f0ec2f7de0efa58a5c017fca04b25f8a307"}],"playbooks/to-build-or-not-to-build.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"188eeb99f5f6299cb43c3df9a218fb9381a4381b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Decide whether we need to build images"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - include_role:"},{"line_number":6,"context_line":"        name: check-to-build-or-not-to-build"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"dfbec78f_4420c8ac","line":6,"range":{"start_line":5,"start_character":10,"end_line":6,"end_character":13},"updated":"2019-05-15 07:37:53.000000000","message":"nice and all of the stuff on the left is moved into the main role instead https://review.opendev.org/#/c/648519/27/roles/check-to-build-or-not-to-build/tasks/main.yml","commit_id":"cd05a891a6fcb840c7d8f37cd8c7001f9e930e13"}],"roles/check-to-build-or-not-to-build/README.md":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c785a3a8bf1e80fced8268844751a74e62f6eb6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"An Ansible role created from the original playbook"},{"line_number":5,"context_line":"to decide whether we need to build images. The role"},{"line_number":6,"context_line":"was created to allow this functionality to run on"},{"line_number":7,"context_line":"hosts other than the undercloud."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Role Variables:"},{"line_number":10,"context_line":"---------------"}],"source_content_type":"text/x-gfm","patch_set":29,"id":"bfb3d3c7_083aa7e6","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":32},"updated":"2019-05-16 18:39:09.000000000","message":"there should be explained the output of this role - to_build variable, that is set to true or false for later usage.","commit_id":"7334eb7c957059fdf512135849baf08e1c46e7d8"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cc4e61762165edc1a39fa60ee1546c867a7e0bf6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"An Ansible role created from the original playbook"},{"line_number":5,"context_line":"to decide whether we need to build images. The role"},{"line_number":6,"context_line":"was created to allow this functionality to run on"},{"line_number":7,"context_line":"hosts other than the undercloud."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Role Variables:"},{"line_number":10,"context_line":"---------------"}],"source_content_type":"text/x-gfm","patch_set":29,"id":"bfb3d3c7_6be1ddd0","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":32},"in_reply_to":"bfb3d3c7_083aa7e6","updated":"2019-05-16 19:14:31.000000000","message":"good point - adding","commit_id":"7334eb7c957059fdf512135849baf08e1c46e7d8"}],"roles/check-to-build-or-not-to-build/meta/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c785a3a8bf1e80fced8268844751a74e62f6eb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_887f77aa","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":17},"updated":"2019-05-16 18:39:09.000000000","message":"what is it depend on in extras?","commit_id":"7334eb7c957059fdf512135849baf08e1c46e7d8"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"cc4e61762165edc1a39fa60ee1546c867a7e0bf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_ebc70d45","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":17},"in_reply_to":"bfb3d3c7_887f77aa","updated":"2019-05-16 19:14:31.000000000","message":"Almost all the roles in tqe do. I kept the pattern.","commit_id":"7334eb7c957059fdf512135849baf08e1c46e7d8"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"562eeff54f1067d773b8ea23881b14e70530f75e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_34e6d5ea","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":17},"in_reply_to":"bfb3d3c7_d723c6bd","updated":"2019-05-17 14:17:42.000000000","message":"Done","commit_id":"7334eb7c957059fdf512135849baf08e1c46e7d8"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f2a21723cbb695b5ac7662dba48cda4320afdb67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"dependencies:"},{"line_number":3,"context_line":"  - extras-common"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_d723c6bd","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":17},"in_reply_to":"bfb3d3c7_ebc70d45","updated":"2019-05-17 00:40:12.000000000","message":"AFAIK we try to get rid off this pattern to make roles more independent, let\u0027s not add it to new roles at least if no reasons to depend on extras-common","commit_id":"7334eb7c957059fdf512135849baf08e1c46e7d8"}],"roles/check-to-build-or-not-to-build/tasks/main.yml":[{"author":{"_account_id":10022,"name":"Gabriele Cerami","email":"gcerami@redhat.com","username":"panda"},"change_message_id":"6284deaa2c7833141642adc35424464a48dc5ea2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# The next two tasks make the list of ZUUL_CHANGES look like our build list"},{"line_number":3,"context_line":"# after we cleanup the extra stuff there, we can just intersect the two"},{"line_number":4,"context_line":"# lists in order to match."},{"line_number":5,"context_line":"- name: Cleanup front of ZUUL_CHANGES"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    zuul_changes: \"{{ lookup(\u0027env\u0027, \u0027ZUUL_CHANGES\u0027)|regex_replace(\u0027openstack/\u0027, \u0027\u0027) }}\""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"bfb3d3c7_68a0f8a6","line":5,"updated":"2019-05-17 09:33:23.000000000","message":"ANy chance you can start using direclty the new zuul inventory variables instead of legacu ZUUL_CHANGES ? ZUUL_CHANGES was never updated for cross site depends-ons","commit_id":"f7f35f0ec2f7de0efa58a5c017fca04b25f8a307"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"562eeff54f1067d773b8ea23881b14e70530f75e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# The next two tasks make the list of ZUUL_CHANGES look like our build list"},{"line_number":3,"context_line":"# after we cleanup the extra stuff there, we can just intersect the two"},{"line_number":4,"context_line":"# lists in order to match."},{"line_number":5,"context_line":"- name: Cleanup front of ZUUL_CHANGES"},{"line_number":6,"context_line":"  set_fact:"},{"line_number":7,"context_line":"    zuul_changes: \"{{ lookup(\u0027env\u0027, \u0027ZUUL_CHANGES\u0027)|regex_replace(\u0027openstack/\u0027, \u0027\u0027) }}\""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":30,"id":"bfb3d3c7_f4d91df4","line":5,"in_reply_to":"bfb3d3c7_68a0f8a6","updated":"2019-05-17 14:17:42.000000000","message":"ack - will do that in a follow up patch.\nThis patch just does the basic move as to not add more possible areas for change","commit_id":"f7f35f0ec2f7de0efa58a5c017fca04b25f8a307"}]}