)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2114cf89c8b029e04d90419e98948f17c4b03b2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Slawek Kaplonski \u003cskaplons@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-06-05 12:19:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Add playbooks to run tobiko jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Tobiko project we want to run job based on TripleO. To achieve that"},{"line_number":10,"context_line":"we need to use some Tobiko specific playbooks which are added by this"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9fb8cfa7_311aa616","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2019-06-13 07:56:56.000000000","message":"remove?","commit_id":"3c75d76a39c04b690d12874db46a4c4996ba817f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"94c0eb130539021b279faadc47fec765b2253fa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Add playbooks to run tobiko jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In Tobiko project we want to run job based on TripleO. To achieve that"},{"line_number":10,"context_line":"we need to use some Tobiko specific playbooks which are added by this"},{"line_number":11,"context_line":"patch."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_14bda767","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":36},"updated":"2019-06-19 15:59:05.000000000","message":"can you add reference to https://review.opendev.org/#/c/651828/ please","commit_id":"78c5a2745b954c3598ac17e15276c9591c370625"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"27702a9831af6389b6cabb2df7df3dfae14c8699","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In Tobiko project we want to run job based on TripleO. To achieve that"},{"line_number":10,"context_line":"we need to use some Tobiko specific playbooks which are added by this"},{"line_number":11,"context_line":"patch."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To collect logs:"},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/671939"},{"line_number":15,"context_line":"Change-Id: Ieffc859a92c8ef99dbc6d2c725d3c4bed8012b7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":44,"id":"7faddb67_da8a79ba","line":12,"updated":"2019-08-16 07:05:08.000000000","message":"please also point to the job review?","commit_id":"33c4043970bdffb0b9ef9092daaa99026298cd39"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"be03407be7e8a4222323127407dc0261f4b27eea","unresolved":false,"context_lines":[{"line_number":11,"context_line":"patch."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To collect logs:"},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/671939"},{"line_number":15,"context_line":"Change-Id: Ieffc859a92c8ef99dbc6d2c725d3c4bed8012b7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":56,"id":"7faddb67_62127dff","line":14,"updated":"2019-09-05 07:27:59.000000000","message":"might consider removing the depends-on and keep it as reference if you like\n\nas a reviewer it is sometimes off-putting when there is a dependency :D especially if i only have a few minutes for a review then i have to go do another one :D\n\njust thinking in terms of attracting more reviews","commit_id":"631fb8986c9f5208d5d72eef6a26ad93e5646f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa07c4142a3264c60d873509080f5069ffbd560e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"patch."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To collect logs:"},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/671939"},{"line_number":15,"context_line":"Change-Id: Ieffc859a92c8ef99dbc6d2c725d3c4bed8012b7a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":56,"id":"7faddb67_ddca369e","line":14,"in_reply_to":"7faddb67_62127dff","updated":"2019-09-05 08:18:18.000000000","message":"Done","commit_id":"631fb8986c9f5208d5d72eef6a26ad93e5646f87"}],"playbooks/tobiko-prepare.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"b2114cf89c8b029e04d90419e98948f17c4b03b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- hosts: undercloud"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":"    - name: TODO generate tobiko.conf"},{"line_number":5,"context_line":"      debug:"},{"line_number":6,"context_line":"      msg: |"},{"line_number":7,"context_line":"        System {{ inventory_hostname }} has uuid {{ ansible_product_uuid }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_71249e5e","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":16},"updated":"2019-06-13 07:56:56.000000000","message":"whats left/blocking here?","commit_id":"3c75d76a39c04b690d12874db46a4c4996ba817f"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"94c0eb130539021b279faadc47fec765b2253fa8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- hosts: undercloud"},{"line_number":3,"context_line":"  tasks:"},{"line_number":4,"context_line":"    - name: TODO generate tobiko.conf"},{"line_number":5,"context_line":"      debug:"},{"line_number":6,"context_line":"      msg: |"},{"line_number":7,"context_line":"        System {{ inventory_hostname }} has uuid {{ ansible_product_uuid }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_f4bb336f","line":4,"range":{"start_line":4,"start_character":12,"end_line":4,"end_character":16},"updated":"2019-06-19 15:59:05.000000000","message":"how can we help what is left here\nhow is the conf ususally generated is it a jinja template ?","commit_id":"78c5a2745b954c3598ac17e15276c9591c370625"}],"playbooks/tobiko.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2dcf327c53c73d6990a5ba36f809181882d141ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Run tobiko with tox"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Run tobiko"},{"line_number":6,"context_line":"      command: tools/ci/tox -e {{tox_envlist}} {{tox_extra_args}}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9fb8cfa7_b124c4c7","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":19},"updated":"2019-06-21 12:58:35.000000000","message":"from irc just now #tripleo\n\n15:51 \u003c marios\u003e slaweq: like hosts: undercloud in https://review.opendev.org/#/c/655423/8/playbooks/tobiko.yml\n15:52 \u003c marios\u003e slaweq: i see hosts like \n                http://logs.openstack.org/28/651828/15/check/tobiko-tripleo-containers-update/6e5c613/zuul-info/inventory.yaml compute1 \n                compute2 controller\n15:52 \u003c marios\u003e slaweq: so maybe its that\n15:52 \u003c slaweq\u003e marios: so should \"controller\" than, right?\n15:52 \u003c marios\u003e slaweq: you can try hosts: all on https://review.opendev.org/#/c/655423/8/playbooks/tobiko.yml or right wherever you \n                want it controller for example","commit_id":"d38afb9cd4c92dc229cec1054a438515b2503944"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5a566a08e747e0c954d15827905472caabd30caf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Run tobiko with tox"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Execute tobiko"},{"line_number":6,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_b7e6e2e7","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":7},"updated":"2019-06-24 07:09:57.000000000","message":"hnmmm... looking at the inventory where you want the job to run, i.e. on http://logs.openstack.org/28/651828/18/check/tobiko-tripleo-containers-update/0bd1880/zuul-info/inventory.yaml\n\nyour hosts there are primary and secondary. perhaps that\u0027s why controller was also skipping.","commit_id":"38b2863a393a1fb42e2bd6ba36f449783dd2acc5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5a566a08e747e0c954d15827905472caabd30caf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Run tobiko with tox"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Execute tobiko"},{"line_number":6,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_37c5123d","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":19},"updated":"2019-06-24 07:09:57.000000000","message":"why is it back to undercloud though I mean that will definitely not match any of your hosts\n\non that last run I see it failed on the overcloud so before the \u0027run tobiko with tox\u0027 task @ http://logs.openstack.org/28/651828/18/check/tobiko-tripleo-containers-update/0bd1880/job-output.txt.gz#_2019-06-23_12_34_04_096054","commit_id":"38b2863a393a1fb42e2bd6ba36f449783dd2acc5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bed56c2a9fd65aa53a855e156923fe9cf53257f7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Run tobiko with tox"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  tasks:"},{"line_number":5,"context_line":"    - name: Execute tobiko"},{"line_number":6,"context_line":"      vars:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"9fb8cfa7_ed153d3e","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":7},"in_reply_to":"9fb8cfa7_b7e6e2e7","updated":"2019-06-26 13:09:18.000000000","message":"I\u0027m not sure but IMO if I set here e.g. \"controller\" I saw in logs that \"no host match to run this\" (or something like that). And if I set \"under cloud\" there is no such information.","commit_id":"38b2863a393a1fb42e2bd6ba36f449783dd2acc5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2324ca03248606106da95e710c320436a216f26e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Prepare tobiko"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    ansible_become: true"},{"line_number":6,"context_line":"    debug: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9fb8cfa7_ca6ec82a","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":19},"updated":"2019-07-02 11:17:50.000000000","message":"i still think its this - try \u0027primary\u0027 (see the hosts at http://logs.openstack.org/28/651828/22/check/tobiko-tripleo-containers-update/3bb338c/zuul-info/inventory.yaml","commit_id":"11b9d6b3449b904c22bedad2ea983dbb5c189118"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c124b245e2c12dab3c2044bc003f491744bd59e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Prepare tobiko"},{"line_number":3,"context_line":"  hosts: undercloud"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    ansible_become: true"},{"line_number":6,"context_line":"    debug: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9fb8cfa7_c5c1db4f","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":19},"in_reply_to":"9fb8cfa7_ca6ec82a","updated":"2019-07-02 12:05:07.000000000","message":"I\u0027m not 100% sure, but lets try :)","commit_id":"11b9d6b3449b904c22bedad2ea983dbb5c189118"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2324ca03248606106da95e710c320436a216f26e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - {role: validate-tempest}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Run tobiko"},{"line_number":13,"context_line":"  hosts: undercloud"},{"line_number":14,"context_line":"  vars:"},{"line_number":15,"context_line":"    ansible_become: true"},{"line_number":16,"context_line":"    debug: true"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"9fb8cfa7_6a631c43","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":19},"updated":"2019-07-02 11:17:50.000000000","message":"ditto","commit_id":"11b9d6b3449b904c22bedad2ea983dbb5c189118"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"3c89cb0d224d2fad963dd6a7b5eaa664a4c26196","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Prepare tobiko"},{"line_number":3,"context_line":"  hosts: primary"},{"line_number":4,"context_line":"  vars:"},{"line_number":5,"context_line":"    ansible_become: true"},{"line_number":6,"context_line":"    debug: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9fb8cfa7_9f08fe91","line":3,"updated":"2019-07-03 06:45:14.000000000","message":"so not that :/ http://logs.openstack.org/28/651828/22/check/tobiko-tripleo-containers-update/94e9dd9/job-output.txt.gz#_2019-07-02_17_41_39_880552","commit_id":"c6e50a7c61a475d1a67c554c08946eca5cacc149"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5134ce2930af1598f0352a2a1da4994b116eb87e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    debug: true"},{"line_number":7,"context_line":"    tobiko_config: true"},{"line_number":8,"context_line":"    tobiko_run: false"},{"line_number":9,"context_line":"  debug:"},{"line_number":10,"context_line":"    var: play_hosts"},{"line_number":11,"context_line":"  roles:"},{"line_number":12,"context_line":"    - {role: validate-tempest}"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7faddb67_29ee8988","line":9,"range":{"start_line":9,"start_character":2,"end_line":9,"end_character":8},"updated":"2019-07-03 17:30:50.000000000","message":"ERROR! \u0027debug\u0027 is not a valid attribute for a Play","commit_id":"7baf54ec31789293f16fc886ec266c23357ad242"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d10cae811223775708334becf8218551d7ea889f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"3fa7e38b_6fbe8f00","updated":"2019-10-04 07:19:28.000000000","message":"what\u0027s the value in having two tasks here... why not have prepare \u0026 run together tobiko_config: true and tobiko_run true... afaics it happens in the right order at https://review.opendev.org/#/c/655423/66/roles/validate-tobiko/tasks/main.yml ;)","commit_id":"1227d2808cbc27f9f5404a90dbf653f5d015cc5a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50570fb8e968ab7022444cd1a17b8f92778424b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":66,"id":"3fa7e38b_55c8fd72","in_reply_to":"3fa7e38b_6fbe8f00","updated":"2019-10-04 13:46:43.000000000","message":"You\u0027re right. It can be done at once :)","commit_id":"1227d2808cbc27f9f5404a90dbf653f5d015cc5a"}],"roles/validate-tobiko/README.md":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"0a008ad86db45cda29a18f77d196a0b6116d1262","unresolved":false,"context_lines":[{"line_number":1,"context_line":"validate-tempest"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ansible role for running tobiko tests on undercloud or overcloud."}],"source_content_type":"text/x-gfm","patch_set":40,"id":"7faddb67_33ee2122","line":1,"range":{"start_line":1,"start_character":9,"end_line":1,"end_character":16},"updated":"2019-08-05 12:11:06.000000000","message":"Shouldn\u0027t be validate-tobiko?","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db5e03b3b1131150565c53b6b804557530915f0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"validate-tempest"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ansible role for running tobiko tests on undercloud or overcloud."}],"source_content_type":"text/x-gfm","patch_set":40,"id":"7faddb67_49729a7e","line":1,"range":{"start_line":1,"start_character":9,"end_line":1,"end_character":16},"in_reply_to":"7faddb67_33ee2122","updated":"2019-08-12 10:41:11.000000000","message":"Yes, it should be :)","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"0a008ad86db45cda29a18f77d196a0b6116d1262","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                   \"tobiko.conf\")"},{"line_number":37,"context_line":"* `tobiko_undercloud`: false/true - if set to true than tobiko will be run"},{"line_number":38,"context_line":"                                    on undercloud, otherwise it will be run"},{"line_number":39,"context_line":"                                    on overcloud (default: false)"},{"line_number":40,"context_line":"* `tobiko_log_file`: \u003cstring\u003e - name of tobiko log file (default: \"tobiko.log\")"},{"line_number":41,"context_line":"* `tobiko_image_name`: \u003cstring\u003e - name of image which will be used by tobiko in"},{"line_number":42,"context_line":"                                  tests (default: \"cirros\")"}],"source_content_type":"text/x-gfm","patch_set":40,"id":"7faddb67_33d7014e","line":39,"range":{"start_line":39,"start_character":50,"end_line":39,"end_character":64},"updated":"2019-08-05 12:11:06.000000000","message":"Why on overcloud by default? Which overcloud node would be used by default?","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db5e03b3b1131150565c53b6b804557530915f0d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                   \"tobiko.conf\")"},{"line_number":37,"context_line":"* `tobiko_undercloud`: false/true - if set to true than tobiko will be run"},{"line_number":38,"context_line":"                                    on undercloud, otherwise it will be run"},{"line_number":39,"context_line":"                                    on overcloud (default: false)"},{"line_number":40,"context_line":"* `tobiko_log_file`: \u003cstring\u003e - name of tobiko log file (default: \"tobiko.log\")"},{"line_number":41,"context_line":"* `tobiko_image_name`: \u003cstring\u003e - name of image which will be used by tobiko in"},{"line_number":42,"context_line":"                                  tests (default: \"cirros\")"}],"source_content_type":"text/x-gfm","patch_set":40,"id":"7faddb67_890df2e9","line":39,"range":{"start_line":39,"start_character":50,"end_line":39,"end_character":64},"in_reply_to":"7faddb67_33d7014e","updated":"2019-08-12 10:41:11.000000000","message":"Maybe I wrote in unclearly. It is matter of each OpenStack (under/overcloud) will be tested by Tobiko)","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"0a008ad86db45cda29a18f77d196a0b6116d1262","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                    on undercloud, otherwise it will be run"},{"line_number":39,"context_line":"                                    on overcloud (default: false)"},{"line_number":40,"context_line":"* `tobiko_log_file`: \u003cstring\u003e - name of tobiko log file (default: \"tobiko.log\")"},{"line_number":41,"context_line":"* `tobiko_image_name`: \u003cstring\u003e - name of image which will be used by tobiko in"},{"line_number":42,"context_line":"                                  tests (default: \"cirros\")"},{"line_number":43,"context_line":"* `tobiko_flavor`: \u003cstring\u003e - name of flavot which will be used by tobiko in"},{"line_number":44,"context_line":"                              tests (default: \"m1.tiny\")"},{"line_number":45,"context_line":"* `tobiko_key_file_name`: \u003cstring\u003e - path to ssh key used by tobiko in tests"},{"line_number":46,"context_line":"                                     (default: \"~/.ssh/id_rsa\")"},{"line_number":47,"context_line":"* `tobiko_floating_ip_network`: \u003cstring\u003e - ID of floating IP network used by"}],"source_content_type":"text/x-gfm","patch_set":40,"id":"7faddb67_73b81910","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":56},"updated":"2019-08-05 12:11:06.000000000","message":"These parameters to configure flavor and image are no more supported. Tobiko is now creting required images and flavors on its own. There are no more configuration required for it.","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db5e03b3b1131150565c53b6b804557530915f0d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                    on undercloud, otherwise it will be run"},{"line_number":39,"context_line":"                                    on overcloud (default: false)"},{"line_number":40,"context_line":"* `tobiko_log_file`: \u003cstring\u003e - name of tobiko log file (default: \"tobiko.log\")"},{"line_number":41,"context_line":"* `tobiko_image_name`: \u003cstring\u003e - name of image which will be used by tobiko in"},{"line_number":42,"context_line":"                                  tests (default: \"cirros\")"},{"line_number":43,"context_line":"* `tobiko_flavor`: \u003cstring\u003e - name of flavot which will be used by tobiko in"},{"line_number":44,"context_line":"                              tests (default: \"m1.tiny\")"},{"line_number":45,"context_line":"* `tobiko_key_file_name`: \u003cstring\u003e - path to ssh key used by tobiko in tests"},{"line_number":46,"context_line":"                                     (default: \"~/.ssh/id_rsa\")"},{"line_number":47,"context_line":"* `tobiko_floating_ip_network`: \u003cstring\u003e - ID of floating IP network used by"}],"source_content_type":"text/x-gfm","patch_set":40,"id":"7faddb67_69f2f6e5","line":44,"range":{"start_line":41,"start_character":0,"end_line":44,"end_character":56},"in_reply_to":"7faddb67_73b81910","updated":"2019-08-12 10:41:11.000000000","message":"Thx, removed","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"27702a9831af6389b6cabb2df7df3dfae14c8699","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ansible role for running tobiko tests on undercloud or overcloud."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Requirements"},{"line_number":7,"context_line":"------------"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":44,"id":"7faddb67_7aefc586","line":5,"updated":"2019-08-16 07:05:08.000000000","message":"please consider adding link to https://opendev.org/x/tobiko/","commit_id":"33c4043970bdffb0b9ef9092daaa99026298cd39"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24fc5629d1510bb6a351099f1f16ee0672eb235c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"validate-tobiko"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ansible role for running tobiko tests on undercloud or overcloud."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Requirements"},{"line_number":7,"context_line":"------------"}],"source_content_type":"text/x-gfm","patch_set":52,"id":"7faddb67_e73c5893","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":28},"updated":"2019-09-04 07:53:21.000000000","message":"please consider adding link to https://opendev.org/x/tobiko/ https://review.opendev.org/#/c/655423/44/roles/validate-tobiko/README.md@5","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ba56213dca46ff50bf365d35b6ea0d146f502522","unresolved":false,"context_lines":[{"line_number":1,"context_line":"validate-tobiko"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Ansible role for running tobiko tests on undercloud or overcloud."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Requirements"},{"line_number":7,"context_line":"------------"}],"source_content_type":"text/x-gfm","patch_set":52,"id":"7faddb67_b8120157","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":28},"in_reply_to":"7faddb67_e73c5893","updated":"2019-09-04 10:37:51.000000000","message":"Done","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"d10cae811223775708334becf8218551d7ea889f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Requirements"},{"line_number":8,"context_line":"------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This Ansible role allows to run tobiko tests against installed overcloud from undercloud."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Role Variables"},{"line_number":13,"context_line":"--------------"}],"source_content_type":"text/x-gfm","patch_set":66,"id":"3fa7e38b_af96c793","line":10,"updated":"2019-10-04 07:19:28.000000000","message":"this says nothing about requirements perhaps remove the section head above or add some requirement info.\n\nWith respect to the sentence itself can you maybe add another line with some simple examples of the tests that are executed/available.","commit_id":"1227d2808cbc27f9f5404a90dbf653f5d015cc5a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"50570fb8e968ab7022444cd1a17b8f92778424b0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Requirements"},{"line_number":8,"context_line":"------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This Ansible role allows to run tobiko tests against installed overcloud from undercloud."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Role Variables"},{"line_number":13,"context_line":"--------------"}],"source_content_type":"text/x-gfm","patch_set":66,"id":"3fa7e38b_351ea170","line":10,"in_reply_to":"3fa7e38b_af96c793","updated":"2019-10-04 13:46:43.000000000","message":"Done","commit_id":"1227d2808cbc27f9f5404a90dbf653f5d015cc5a"}],"roles/validate-tobiko/defaults/main.yml":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"0a008ad86db45cda29a18f77d196a0b6116d1262","unresolved":false,"context_lines":[{"line_number":15,"context_line":"tobiko_undercloud: false"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tobiko_log_file_base: \"tobiko\""},{"line_number":18,"context_line":"tobiko_image_name: \"cirros\""},{"line_number":19,"context_line":"tobiko_flavor: \"m1.tiny\""},{"line_number":20,"context_line":"tobiko_key_file_name: \"~/.ssh/id_rsa\""},{"line_number":21,"context_line":"tobiko_floating_ip_network: \"public\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"7faddb67_536b9d83","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":24},"updated":"2019-08-05 12:11:06.000000000","message":"Please remove these two entries. They are not required by tobiko any more.","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db5e03b3b1131150565c53b6b804557530915f0d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"tobiko_undercloud: false"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tobiko_log_file_base: \"tobiko\""},{"line_number":18,"context_line":"tobiko_image_name: \"cirros\""},{"line_number":19,"context_line":"tobiko_flavor: \"m1.tiny\""},{"line_number":20,"context_line":"tobiko_key_file_name: \"~/.ssh/id_rsa\""},{"line_number":21,"context_line":"tobiko_floating_ip_network: \"public\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"7faddb67_090102b0","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":24},"in_reply_to":"7faddb67_536b9d83","updated":"2019-08-12 10:41:11.000000000","message":"Done","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"aadd15093df240f6eb14a3094f674276e9e8a089","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"tobiko_src_path: \"src/opendev.org/x/tobiko\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tobiko_config: true"},{"line_number":5,"context_line":"tobiko_run: true"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_a45f3e3f","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":43},"updated":"2019-09-04 07:28:39.000000000","message":"tobiko_src_path and tobiko_dst_dir destination path not required we can directly use the zuul provided workspace workspace {{ ansible_user_dir }}/src/opendev.org/x/tobiko and install it in venv.","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e12408fec5e2e7410dc9323ed55d74eec30ad62b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"tobiko_src_path: \"src/opendev.org/x/tobiko\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"tobiko_config: true"},{"line_number":5,"context_line":"tobiko_run: true"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_874b2426","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":43},"in_reply_to":"7faddb67_a45f3e3f","updated":"2019-09-04 07:51:20.000000000","message":"Done","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"}],"roles/validate-tobiko/tasks/main.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"a38862de7350c6704f17e9b34d9e98198cdf0d54","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    cacheable: true"},{"line_number":19,"context_line":"  when: ansible_python.version.major \u003e 2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: tobiko-git.yml"},{"line_number":22,"context_line":"  when: tobiko_config|bool and tobiko_format \u003d\u003d \u0027git\u0027"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - prepare-tobiko"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- include: tobiko-copy.yml"},{"line_number":27,"context_line":"  when: tobiko_config|bool and tobiko_format \u003d\u003d \u0027copy\u0027"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_1a52a236","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":20},"updated":"2019-08-27 15:20:12.000000000","message":"if tobiko is upstream, this is automatically added if tobiko is represented in required projects.  Cloning from git midway through the job is prone to failures.","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"60e76a823c2ceb8d6157e64c1cb2943ea0e479e2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    cacheable: true"},{"line_number":19,"context_line":"  when: ansible_python.version.major \u003e 2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: tobiko-git.yml"},{"line_number":22,"context_line":"  when: tobiko_config|bool and tobiko_format \u003d\u003d \u0027git\u0027"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - prepare-tobiko"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- include: tobiko-copy.yml"},{"line_number":27,"context_line":"  when: tobiko_config|bool and tobiko_format \u003d\u003d \u0027copy\u0027"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_283866ec","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":20},"in_reply_to":"7faddb67_1a52a236","updated":"2019-08-28 09:46:04.000000000","message":"Please include opendev.org/x/tobiko here in the required projects: https://opendev.org/openstack/tripleo-ci/src/branch/master/zuul.d/base.yaml#L26 in tripleo-ci, then It will automatically clone in zuul workspace i.e \"{{ ansible_user_dir }}/src/opendev.org/x/ directory and from there we can easily install the project.\n\nThen we do not need this task.","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e12408fec5e2e7410dc9323ed55d74eec30ad62b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    cacheable: true"},{"line_number":19,"context_line":"  when: ansible_python.version.major \u003e 2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: tobiko-git.yml"},{"line_number":22,"context_line":"  when: tobiko_config|bool and tobiko_format \u003d\u003d \u0027git\u0027"},{"line_number":23,"context_line":"  tags:"},{"line_number":24,"context_line":"    - prepare-tobiko"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- include: tobiko-copy.yml"},{"line_number":27,"context_line":"  when: tobiko_config|bool and tobiko_format \u003d\u003d \u0027copy\u0027"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_e8799d92","line":24,"range":{"start_line":21,"start_character":0,"end_line":24,"end_character":20},"in_reply_to":"7faddb67_283866ec","updated":"2019-09-04 07:51:20.000000000","message":"But this option is here more for someone who will want to use this role manually.\nIn CI it will use \"copy\" method which will in fact copy tobiko from zuul workspace to undercloud node.","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"92ead502b0283cda3f4cf42cfa21a05c649bb0de","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  set_fact:"},{"line_number":17,"context_line":"    python_package_prefix: \"python{{ ansible_python.version.major }}\""},{"line_number":18,"context_line":"    cacheable: true"},{"line_number":19,"context_line":"  when: ansible_python.version.major \u003e 2"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- include: prepare-tobiko.yml"},{"line_number":22,"context_line":"  when: tobiko_config|bool"}],"source_content_type":"text/x-yaml","patch_set":67,"id":"3fa7e38b_b2cc7c35","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":40},"updated":"2019-10-11 05:27:28.000000000","message":"On RHEL 8.0 \u0027python\u0027 could be an alias for python3 instead of python2, but I would not bother about it until we have no job using CentOS 8","commit_id":"3565c0ec5eaee96a0f9145592fa348c609407125"}],"roles/validate-tobiko/tasks/prepare-tobiko.yml":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"bda3e2d246340c07a45125292f703da89dc93855","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  set_fact:"},{"line_number":69,"context_line":"    tobiko_no_proxy_servers: \"{{ no_proxy_cmd.stdout }}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Get identity api_version"},{"line_number":72,"context_line":"  shell: \u003e"},{"line_number":73,"context_line":"    grep OS_IDENTITY_API_VERSION {{ rc_file }} | awk -F\u0027\u003d\u0027 \u0027{print $2}\u0027"},{"line_number":74,"context_line":"  register: identity_api_version_cmd"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Set identity api_version"},{"line_number":77,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"7faddb67_89232456","line":74,"range":{"start_line":71,"start_character":2,"end_line":74,"end_character":36},"updated":"2019-08-05 12:48:57.000000000","message":"I think best way to parse RC files is calling bash and printout result. For example you could  do something like below\n\n bash -c \"source \u0027{{ rc_file }}\u0027; env\" | grep \u0027^OS_\u0027 | xargs echo\n\nThe resulting output could be put in a ansible variable. Esample:\n\n OS_PROJECT_NAME\u003dadmin OS_PASSWORD\u003dRNMFKzewK4yn9TTzphRhmeJ29 OS_AUTH_URL\u003dhttp://10.0.0.109:5000/v2.0 OS_USERNAME\u003dadmin OS_TENANT_NAME\u003dadmin OS_NO_CACHE\u003dTrue OS_CLOUDNAME\u003dovercloud\n\nThen it could be used in bash to be prepended to tobiko-keystone-credentials command to have them translated by tobiko.\n\n {{ tobiko_rc_vars }} tobiko-keystone-credentials\n\nAbove comand would generate a yaml dictionary easy to be parsed by ansible and to be used later to write tobiko.conf file.\n\nThis should reduce the amount of code written here and probably fix the problem with Keystone API version you found.","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"db5e03b3b1131150565c53b6b804557530915f0d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  set_fact:"},{"line_number":69,"context_line":"    tobiko_no_proxy_servers: \"{{ no_proxy_cmd.stdout }}\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Get identity api_version"},{"line_number":72,"context_line":"  shell: \u003e"},{"line_number":73,"context_line":"    grep OS_IDENTITY_API_VERSION {{ rc_file }} | awk -F\u0027\u003d\u0027 \u0027{print $2}\u0027"},{"line_number":74,"context_line":"  register: identity_api_version_cmd"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Set identity api_version"},{"line_number":77,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"7faddb67_29bf1eab","line":74,"range":{"start_line":71,"start_character":2,"end_line":74,"end_character":36},"in_reply_to":"7faddb67_89232456","updated":"2019-08-12 10:41:11.000000000","message":"But to use this I first need to install tobiko e.g. in venv and it\u0027s not done here yet. Also I\u0027m not sure how this may fix problem with Keystone API version.","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"27702a9831af6389b6cabb2df7df3dfae14c8699","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    state: present"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install stestr"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  package:"},{"line_number":14,"context_line":"    name: \"{{python_package_prefix}}-stestr\""},{"line_number":15,"context_line":"    state: present"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install packages required for create venv"},{"line_number":18,"context_line":"  become: true"},{"line_number":19,"context_line":"  package:"},{"line_number":20,"context_line":"    state: present"},{"line_number":21,"context_line":"    name:"},{"line_number":22,"context_line":"      - gcc"},{"line_number":23,"context_line":"      - libffi-devel"},{"line_number":24,"context_line":"      - openssl-devel"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Install virtualenv"},{"line_number":27,"context_line":"  become: true"},{"line_number":28,"context_line":"  package:"},{"line_number":29,"context_line":"    state: present"},{"line_number":30,"context_line":"    name: \u003e"},{"line_number":31,"context_line":"        {% if ansible_python.version.major \u003d\u003d 3 %}"},{"line_number":32,"context_line":"        python3-virtualenv"},{"line_number":33,"context_line":"        {% else %}"},{"line_number":34,"context_line":"        python-virtualenv"},{"line_number":35,"context_line":"        {% endif %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Install pip"},{"line_number":38,"context_line":"  become: true"},{"line_number":39,"context_line":"  package:"},{"line_number":40,"context_line":"    state: present"},{"line_number":41,"context_line":"    name: \u003e"},{"line_number":42,"context_line":"        {% if ansible_python.version.major \u003d\u003d 3 %}"},{"line_number":43,"context_line":"        python3-pip"},{"line_number":44,"context_line":"        {% else %}"},{"line_number":45,"context_line":"        python-pip"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"7faddb67_9a996120","line":42,"range":{"start_line":12,"start_character":9,"end_line":42,"end_character":20},"updated":"2019-08-16 07:05:08.000000000","message":"do we really need 4 tasks for package install why not try them in one task?","commit_id":"33c4043970bdffb0b9ef9092daaa99026298cd39"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"27702a9831af6389b6cabb2df7df3dfae14c8699","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  shell: \u003e"},{"line_number":100,"context_line":"    grep OS_PASSWORD {{ rc_file }} | awk -F\u0027\u003d\u0027 \u0027{print $2}\u0027"},{"line_number":101,"context_line":"  register: password_cmd"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- name: Set password"},{"line_number":104,"context_line":"  set_fact:"},{"line_number":105,"context_line":"    tobiko_password: \"{{ password_cmd.stdout }}\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"- name: Get project name"},{"line_number":108,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"7faddb67_daf59952","line":105,"range":{"start_line":102,"start_character":0,"end_line":105,"end_character":48},"updated":"2019-08-16 07:05:08.000000000","message":"can we consider combining some of these please it might make this file easier to follow. e.g. once you\u0027ve registered all the things have just one task at the end to set_fact?\n\n- name: Set facts for user pass auth_url ...\n  set_fact:\n    tobiko_username: \"{{ username_cmd.stdout }}\"\n    tobiko_password: \"{{ password_cmd.stdout }}\"\n    ...\n    cacheable: true # added by me you might want that?","commit_id":"33c4043970bdffb0b9ef9092daaa99026298cd39"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"60e76a823c2ceb8d6157e64c1cb2943ea0e479e2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - subunit-filters"},{"line_number":9,"context_line":"    state: present"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install stestr"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  package:"},{"line_number":14,"context_line":"    name: \"{{python_package_prefix}}-stestr\""},{"line_number":15,"context_line":"    state: present"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install packages required for create venv"},{"line_number":18,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_3274549c","line":15,"range":{"start_line":11,"start_character":1,"end_line":15,"end_character":18},"updated":"2019-08-28 09:46:04.000000000","message":"It is not needed, as stestr is a dependency of os-testr.","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e12408fec5e2e7410dc9323ed55d74eec30ad62b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - subunit-filters"},{"line_number":9,"context_line":"    state: present"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install stestr"},{"line_number":12,"context_line":"  become: true"},{"line_number":13,"context_line":"  package:"},{"line_number":14,"context_line":"    name: \"{{python_package_prefix}}-stestr\""},{"line_number":15,"context_line":"    state: present"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Install packages required for create venv"},{"line_number":18,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_c625b3c0","line":15,"range":{"start_line":11,"start_character":1,"end_line":15,"end_character":18},"in_reply_to":"7faddb67_3274549c","updated":"2019-09-04 07:51:20.000000000","message":"Done","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"60e76a823c2ceb8d6157e64c1cb2943ea0e479e2","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Get identity api_version"},{"line_number":72,"context_line":"  shell: \u003e"},{"line_number":73,"context_line":"    grep OS_IDENTITY_API_VERSION {{ rc_file }} | awk -F\u0027\u003d\u0027 \u0027{print $2}\u0027"},{"line_number":74,"context_line":"  register: identity_api_version_cmd"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Set identity api_version"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_3299b4cf","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":71},"updated":"2019-08-28 09:46:04.000000000","message":"These values can be easily obtained by doing source stackrc or overcloudrc then do \"{{ lookup(\u0027env\u0027,\u0027OS_USERNAME\u0027) }}\" will give the os_username or other values defined there.","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e12408fec5e2e7410dc9323ed55d74eec30ad62b","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: Get identity api_version"},{"line_number":72,"context_line":"  shell: \u003e"},{"line_number":73,"context_line":"    grep OS_IDENTITY_API_VERSION {{ rc_file }} | awk -F\u0027\u003d\u0027 \u0027{print $2}\u0027"},{"line_number":74,"context_line":"  register: identity_api_version_cmd"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: Set identity api_version"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_861d7b74","line":73,"range":{"start_line":73,"start_character":4,"end_line":73,"end_character":71},"in_reply_to":"7faddb67_3299b4cf","updated":"2019-09-04 07:51:20.000000000","message":"It doesn\u0027t work for me in that way, but I changed this role a bit and now I removed all those get/set config options","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24fc5629d1510bb6a351099f1f16ee0672eb235c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  package:"},{"line_number":23,"context_line":"    state: present"},{"line_number":24,"context_line":"    name: \u003e"},{"line_number":25,"context_line":"        {% if ansible_python.version.major \u003d\u003d 3 %}"},{"line_number":26,"context_line":"        python3-virtualenv"},{"line_number":27,"context_line":"        {% else %}"},{"line_number":28,"context_line":"        python-virtualenv"},{"line_number":29,"context_line":"        {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install pip"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_e723f856","line":28,"range":{"start_line":25,"start_character":14,"end_line":28,"end_character":25},"updated":"2019-09-04 07:53:21.000000000","message":"why not use your fact here?\n\nname: \"{{ python_package_prefix }}-virtualenv\"","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ba56213dca46ff50bf365d35b6ea0d146f502522","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  package:"},{"line_number":23,"context_line":"    state: present"},{"line_number":24,"context_line":"    name: \u003e"},{"line_number":25,"context_line":"        {% if ansible_python.version.major \u003d\u003d 3 %}"},{"line_number":26,"context_line":"        python3-virtualenv"},{"line_number":27,"context_line":"        {% else %}"},{"line_number":28,"context_line":"        python-virtualenv"},{"line_number":29,"context_line":"        {% endif %}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Install pip"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_cd1ffd6d","line":28,"range":{"start_line":25,"start_character":14,"end_line":28,"end_character":25},"in_reply_to":"7faddb67_e723f856","updated":"2019-09-04 10:37:51.000000000","message":"right, changed :)","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24fc5629d1510bb6a351099f1f16ee0672eb235c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  package:"},{"line_number":34,"context_line":"    state: present"},{"line_number":35,"context_line":"    name: \u003e"},{"line_number":36,"context_line":"        {% if ansible_python.version.major \u003d\u003d 3 %}"},{"line_number":37,"context_line":"        python3-pip"},{"line_number":38,"context_line":"        {% else %}"},{"line_number":39,"context_line":"        python-pip"},{"line_number":40,"context_line":"        {% endif %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Copy tobiko to undercloud node"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_871244fc","line":39,"range":{"start_line":36,"start_character":14,"end_line":39,"end_character":14},"updated":"2019-09-04 07:53:21.000000000","message":"same","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ba56213dca46ff50bf365d35b6ea0d146f502522","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  package:"},{"line_number":34,"context_line":"    state: present"},{"line_number":35,"context_line":"    name: \u003e"},{"line_number":36,"context_line":"        {% if ansible_python.version.major \u003d\u003d 3 %}"},{"line_number":37,"context_line":"        python3-pip"},{"line_number":38,"context_line":"        {% else %}"},{"line_number":39,"context_line":"        python-pip"},{"line_number":40,"context_line":"        {% endif %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Copy tobiko to undercloud node"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_4d1d4d71","line":39,"range":{"start_line":36,"start_character":14,"end_line":39,"end_character":14},"in_reply_to":"7faddb67_871244fc","updated":"2019-09-04 10:37:51.000000000","message":"Done","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"92ead502b0283cda3f4cf42cfa21a05c649bb0de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Install packages to generate subunit results"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  package:"},{"line_number":5,"context_line":"    name:"},{"line_number":6,"context_line":"      - \"{{python_package_prefix}}-os-testr\""},{"line_number":7,"context_line":"      - \"{{python_package_prefix}}-subunit\""},{"line_number":8,"context_line":"      - subunit-filters"},{"line_number":9,"context_line":"    state: present"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install packages required for create venv"},{"line_number":12,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":67,"id":"3fa7e38b_92f06069","line":9,"range":{"start_line":2,"start_character":2,"end_line":9,"end_character":18},"updated":"2019-10-11 05:27:28.000000000","message":"We can generate tobiko subunit reports by executing \u0027tox -e report\u0027. Therefore I think this could be removed in the future to keep playbook smaller.","commit_id":"3565c0ec5eaee96a0f9145592fa348c609407125"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e2cb14759ee74fac7d0376da876f86457017bb57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Install packages to generate subunit results"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  package:"},{"line_number":5,"context_line":"    name:"},{"line_number":6,"context_line":"      - \"{{python_package_prefix}}-os-testr\""},{"line_number":7,"context_line":"      - \"{{python_package_prefix}}-subunit\""},{"line_number":8,"context_line":"      - subunit-filters"},{"line_number":9,"context_line":"    state: present"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Install packages required for create venv"},{"line_number":12,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":67,"id":"3fa7e38b_f059708d","line":9,"range":{"start_line":2,"start_character":2,"end_line":9,"end_character":18},"in_reply_to":"3fa7e38b_92f06069","updated":"2019-10-14 13:26:36.000000000","message":"Done","commit_id":"3565c0ec5eaee96a0f9145592fa348c609407125"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36caa0737fc79af92911213cce6584904c9327b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  package:"},{"line_number":5,"context_line":"    name:"},{"line_number":6,"context_line":"      - \"{{python_package_prefix}}-os-testr\""},{"line_number":7,"context_line":"      - \"{{python_package_prefix}}-subunit\""},{"line_number":8,"context_line":"      - subunit-filters"},{"line_number":9,"context_line":"    state: present"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":69,"id":"3fa7e38b_d6297789","line":7,"updated":"2019-11-07 08:34:11.000000000","message":"linting wants spaces here {{ python_package_prefix }}","commit_id":"fabe45bba6ce1956960e1fafbbf7244e0797dbea"}],"roles/validate-tobiko/tasks/run-tobiko.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"24fc5629d1510bb6a351099f1f16ee0672eb235c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    {{ tobiko_dst_dir }}/tools/ci/tox -e {{tobiko_envlist}} {{tobiko_extra_args}} 2\u003e\u00261 {{ timestamper_cmd }} \u003e {{ working_dir }}/{{ tobiko_log_file }};"},{"line_number":6,"context_line":"    {{ tobiko_dst_dir }}/.tox/scenario/bin/tobiko-keystone-credentials \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }};"},{"line_number":7,"context_line":"    cat {{ working_dir }}/.tobiko/tobiko.conf \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }};"},{"line_number":8,"context_line":"  register: tobiko_result"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ tobiko_dst_dir }}\""},{"line_number":11,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_07dc1443","line":8,"range":{"start_line":8,"start_character":12,"end_line":8,"end_character":25},"updated":"2019-09-04 07:53:21.000000000","message":"are you using it somewhere can\u0027t find it referenced here","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ba56213dca46ff50bf365d35b6ea0d146f502522","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    {{ tobiko_dst_dir }}/tools/ci/tox -e {{tobiko_envlist}} {{tobiko_extra_args}} 2\u003e\u00261 {{ timestamper_cmd }} \u003e {{ working_dir }}/{{ tobiko_log_file }};"},{"line_number":6,"context_line":"    {{ tobiko_dst_dir }}/.tox/scenario/bin/tobiko-keystone-credentials \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }};"},{"line_number":7,"context_line":"    cat {{ working_dir }}/.tobiko/tobiko.conf \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }};"},{"line_number":8,"context_line":"  register: tobiko_result"},{"line_number":9,"context_line":"  args:"},{"line_number":10,"context_line":"    chdir: \"{{ tobiko_dst_dir }}\""},{"line_number":11,"context_line":"  ignore_errors: true"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"7faddb67_38285184","line":8,"range":{"start_line":8,"start_character":12,"end_line":8,"end_character":25},"in_reply_to":"7faddb67_07dc1443","updated":"2019-09-04 10:37:51.000000000","message":"No, I\u0027m not using it. Removed.","commit_id":"4363ad277a840b45de38819772188dd4fd38482a"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36caa0737fc79af92911213cce6584904c9327b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Execute Tobiko"},{"line_number":3,"context_line":"  shell: \u003e"},{"line_number":4,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":5,"context_line":"    tools/ci/tox -e {{tobiko_envlist}} {{tobiko_extra_args}} 2\u003e\u00261 {{ timestamper_cmd }} \u003e {{ tobiko_log_dir }}/{{ tobiko_log_file }};"},{"line_number":6,"context_line":"  args:"},{"line_number":7,"context_line":"    chdir: \"{{ working_dir }}/tobiko\""},{"line_number":8,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":69,"id":"3fa7e38b_36380bd3","line":5,"updated":"2019-11-07 08:34:11.000000000","message":"spaces here {{ tobiko_envlist }} and extra _args too","commit_id":"fabe45bba6ce1956960e1fafbbf7244e0797dbea"}],"roles/validate-tobiko/tasks/tobiko-git.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"50082e059df994b225b148f06223439320045d6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cloning tobiko repository"},{"line_number":3,"context_line":"  git:"},{"line_number":4,"context_line":"    repo: \u0027{{ tobiko_repo_url }}\u0027"},{"line_number":5,"context_line":"    dest: \u0027{{ tobiko_dst_dir }}\u0027"},{"line_number":6,"context_line":"    version: \u0027{{ tobiko_version }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"7faddb67_10d313d7","line":3,"updated":"2019-07-31 17:44:20.000000000","message":"this is already an upstream project, meaning you don\u0027t have to clone it. Just make it a required project in zuul config","commit_id":"ccc776b5d753d0d79629dcca382d4bd713614846"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5097105c2845afbb611ac428f44d517481837b0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cloning tobiko repository"},{"line_number":3,"context_line":"  git:"},{"line_number":4,"context_line":"    repo: \u0027{{ tobiko_repo_url }}\u0027"},{"line_number":5,"context_line":"    dest: \u0027{{ tobiko_dst_dir }}\u0027"},{"line_number":6,"context_line":"    version: \u0027{{ tobiko_version }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"7faddb67_445b03f5","line":3,"in_reply_to":"7faddb67_10d313d7","updated":"2019-08-01 07:04:24.000000000","message":"But what if I want to use this role in oooq used locally? Shouldn\u0027t that also work?","commit_id":"ccc776b5d753d0d79629dcca382d4bd713614846"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"efcb372131e7e1d4a38a0dff14f9376b5b6c419d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cloning tobiko repository"},{"line_number":3,"context_line":"  git:"},{"line_number":4,"context_line":"    repo: \u0027{{ tobiko_repo_url }}\u0027"},{"line_number":5,"context_line":"    dest: \u0027{{ tobiko_dst_dir }}\u0027"},{"line_number":6,"context_line":"    version: \u0027{{ tobiko_version }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"7faddb67_f040a937","line":3,"in_reply_to":"7faddb67_445b03f5","updated":"2019-08-01 11:45:58.000000000","message":"Than need to check if repo exists, if not - clone it","commit_id":"ccc776b5d753d0d79629dcca382d4bd713614846"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e83badedab62948ab396c7e67ff5c7f5da31ec2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Cloning tobiko repository"},{"line_number":3,"context_line":"  git:"},{"line_number":4,"context_line":"    repo: \u0027{{ tobiko_repo_url }}\u0027"},{"line_number":5,"context_line":"    dest: \u0027{{ tobiko_dst_dir }}\u0027"},{"line_number":6,"context_line":"    version: \u0027{{ tobiko_version }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"7faddb67_4bf46ef1","line":3,"in_reply_to":"7faddb67_f040a937","updated":"2019-08-01 13:15:36.000000000","message":"Done","commit_id":"ccc776b5d753d0d79629dcca382d4bd713614846"}],"roles/validate-tobiko/tasks/tobiko-results.yml":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"60e76a823c2ceb8d6157e64c1cb2943ea0e479e2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    dest: \"{{ local_working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Generate XML results file"},{"line_number":30,"context_line":"  shell: |"},{"line_number":31,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":32,"context_line":"    subunit2junitxml {{ tobiko_dst_dir }}/testrepository.subunit --output-to {{ working_dir }}/{{ tobiko_log_file }}.xml 2\u003e\u00261 \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Fetch nosetests results"},{"line_number":35,"context_line":"  fetch:"},{"line_number":36,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.xml\""},{"line_number":37,"context_line":"    dest: \"{{ local_working_dir }}/{{tobiko_log_file }}_nosetests.xml\""},{"line_number":38,"context_line":"    flat: true"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_32d0d453","line":38,"range":{"start_line":29,"start_character":0,"end_line":38,"end_character":14},"updated":"2019-08-28 09:46:04.000000000","message":"In CI, we donot store xml and nosetests results, it is not needed here.","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e12408fec5e2e7410dc9323ed55d74eec30ad62b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    dest: \"{{ local_working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Generate XML results file"},{"line_number":30,"context_line":"  shell: |"},{"line_number":31,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":32,"context_line":"    subunit2junitxml {{ tobiko_dst_dir }}/testrepository.subunit --output-to {{ working_dir }}/{{ tobiko_log_file }}.xml 2\u003e\u00261 \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Fetch nosetests results"},{"line_number":35,"context_line":"  fetch:"},{"line_number":36,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.xml\""},{"line_number":37,"context_line":"    dest: \"{{ local_working_dir }}/{{tobiko_log_file }}_nosetests.xml\""},{"line_number":38,"context_line":"    flat: true"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"7faddb67_e82bdd7e","line":38,"range":{"start_line":29,"start_character":0,"end_line":38,"end_character":14},"in_reply_to":"7faddb67_32d0d453","updated":"2019-09-04 07:51:20.000000000","message":"are You sure? I see it e.g. in https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/validate-tempest/tasks/tempest-results.yml#L50\nAnd also without this xml results generation job is passing even if tests fails. I don\u0027t know exactly why it\u0027s like that :)","commit_id":"9f517a2e8db8a3da50f854576585ecd382fa9d0e"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6bb25b7cf61df82262308abdcf1d8f7ed5f50ed1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Define testr facts"},{"line_number":8,"context_line":"  set_fact:"},{"line_number":9,"context_line":"    testr_command: \"{{ testr_dir.stat.exists | ternary(python_cmd + \u0027 -m stestr.cli\u0027, \u0027testr\u0027) }}\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Generate testrepository.subunit results file"},{"line_number":12,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"7faddb67_99fe24ad","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":98},"updated":"2019-09-04 14:59:24.000000000","message":"I think we can directly use stestr here as testr got replaced by stestr from queens release onwards.","commit_id":"631fb8986c9f5208d5d72eef6a26ad93e5646f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ec6914f8c3246bbe4215918df135fe6d1c33679e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Define testr facts"},{"line_number":8,"context_line":"  set_fact:"},{"line_number":9,"context_line":"    testr_command: \"{{ testr_dir.stat.exists | ternary(python_cmd + \u0027 -m stestr.cli\u0027, \u0027testr\u0027) }}\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Generate testrepository.subunit results file"},{"line_number":12,"context_line":"  shell: \u003e"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"7faddb67_222ec5f9","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":98},"in_reply_to":"7faddb67_99fe24ad","updated":"2019-09-05 08:17:57.000000000","message":"Done","commit_id":"631fb8986c9f5208d5d72eef6a26ad93e5646f87"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6bb25b7cf61df82262308abdcf1d8f7ed5f50ed1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    dest: \"{{ local_working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Generate XML results file"},{"line_number":30,"context_line":"  shell: |"},{"line_number":31,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":32,"context_line":"    subunit2junitxml {{ working_dir }}/tobiko/testrepository.subunit --output-to {{ working_dir }}/{{ tobiko_log_file }}.xml 2\u003e\u00261 \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Fetch nosetests results"},{"line_number":35,"context_line":"  fetch:"},{"line_number":36,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.xml\""},{"line_number":37,"context_line":"    dest: \"{{ local_working_dir }}/{{tobiko_log_file }}_nosetests.xml\""},{"line_number":38,"context_line":"    flat: true"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"7faddb67_39b5b0ed","line":38,"range":{"start_line":29,"start_character":0,"end_line":38,"end_character":14},"updated":"2019-09-04 14:59:24.000000000","message":"This part is not needed. we collect xml files in validate_tempest role but it is soon replaced by os_tempest role where we only collect html files.","commit_id":"631fb8986c9f5208d5d72eef6a26ad93e5646f87"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ec6914f8c3246bbe4215918df135fe6d1c33679e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    dest: \"{{ local_working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Generate XML results file"},{"line_number":30,"context_line":"  shell: |"},{"line_number":31,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":32,"context_line":"    subunit2junitxml {{ working_dir }}/tobiko/testrepository.subunit --output-to {{ working_dir }}/{{ tobiko_log_file }}.xml 2\u003e\u00261 \u003e\u003e {{ working_dir }}/{{ tobiko_log_file }}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Fetch nosetests results"},{"line_number":35,"context_line":"  fetch:"},{"line_number":36,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.xml\""},{"line_number":37,"context_line":"    dest: \"{{ local_working_dir }}/{{tobiko_log_file }}_nosetests.xml\""},{"line_number":38,"context_line":"    flat: true"}],"source_content_type":"text/x-yaml","patch_set":56,"id":"7faddb67_e233cd5f","line":38,"range":{"start_line":29,"start_character":0,"end_line":38,"end_character":14},"in_reply_to":"7faddb67_39b5b0ed","updated":"2019-09-05 08:17:57.000000000","message":"Done","commit_id":"631fb8986c9f5208d5d72eef6a26ad93e5646f87"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4658b8824ab6bc2efcd5fbfea9e5d8f89f7f11c8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Generate testrepository.subunit results file"},{"line_number":12,"context_line":"  shell: \u003e"},{"line_number":13,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":14,"context_line":"    {{ testr_command }} last --subunit | subunit-1to2 \u003e {{ working_dir }}/tobiko/testrepository.subunit"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: \"{{ working_dir }}/tobiko\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":58,"id":"5faad753_11664fef","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":53},"updated":"2019-09-06 08:25:50.000000000","message":"subunit -1to2 is not need as subunit file will be already available in v2 format.","commit_id":"221c9349e3cde28968cf53554524c8c958e9e125"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d354cdb9c64e9d25e79146e9918e83ddc0628e4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Generate testrepository.subunit results file"},{"line_number":12,"context_line":"  shell: \u003e"},{"line_number":13,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":14,"context_line":"    {{ testr_command }} last --subunit | subunit-1to2 \u003e {{ working_dir }}/tobiko/testrepository.subunit"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: \"{{ working_dir }}/tobiko\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":58,"id":"5faad753_989fbcb3","line":14,"range":{"start_line":14,"start_character":39,"end_line":14,"end_character":53},"in_reply_to":"5faad753_11664fef","updated":"2019-09-23 06:29:55.000000000","message":"Done","commit_id":"221c9349e3cde28968cf53554524c8c958e9e125"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"c3a2f6f639302f804f48e2eed6089218df5f87dd","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"},{"line_number":25,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":26,"context_line":"    dest: \"{{ local_working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"5faad753_f13a93cb","line":26,"range":{"start_line":26,"start_character":11,"end_line":26,"end_character":35},"updated":"2019-09-06 08:22:12.000000000","message":"We can push it to /var/log/extras instead of local_working_dir","commit_id":"221c9349e3cde28968cf53554524c8c958e9e125"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d354cdb9c64e9d25e79146e9918e83ddc0628e4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"},{"line_number":25,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":26,"context_line":"    dest: \"{{ local_working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"}],"source_content_type":"text/x-yaml","patch_set":58,"id":"5faad753_789a00c6","line":26,"range":{"start_line":26,"start_character":11,"end_line":26,"end_character":35},"in_reply_to":"5faad753_f13a93cb","updated":"2019-09-23 06:29:55.000000000","message":"Done","commit_id":"221c9349e3cde28968cf53554524c8c958e9e125"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"826f54ed525749be23e259f3253ed37302fddc1a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"- name: Generate HTML results file"},{"line_number":19,"context_line":"  shell: |"},{"line_number":20,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":21,"context_line":"    subunit2html {{ working_dir }}/tobiko/testrepository.subunit {{ working_dir }}/{{ tobiko_log_file }}.html"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"5faad753_39953241","line":21,"range":{"start_line":21,"start_character":83,"end_line":21,"end_character":105},"updated":"2019-09-10 12:23:34.000000000","message":"maybe {{ tobiko_log_file_base }} ?","commit_id":"5dc4d7efa94ff1c5d9e5582c2a73f5758f9e5bc3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"952024e83dfdc57e824b6155412d2bfcf9ea0597","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"},{"line_number":25,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":26,"context_line":"    dest: \"/var/log/extras/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Fail if tobiko tests did not succeed"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"5faad753_3c6f6593","line":26,"range":{"start_line":26,"start_character":11,"end_line":26,"end_character":27},"updated":"2019-09-10 08:54:20.000000000","message":"It got failed here Unable to create local directories(/var/log/extras): [Errno 13] Permission denied: \u0027/var/log/extras\u0027","commit_id":"5dc4d7efa94ff1c5d9e5582c2a73f5758f9e5bc3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"d7e8d8335e2e3346576e9215067b0fef66b7b064","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"},{"line_number":25,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":26,"context_line":"    dest: \"/var/log/extras/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Fail if tobiko tests did not succeed"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"5faad753_5cdd8140","line":26,"range":{"start_line":26,"start_character":11,"end_line":26,"end_character":27},"in_reply_to":"5faad753_3c6f6593","updated":"2019-09-10 09:01:34.000000000","message":"Based on discussion with sagi on irc, we need to store the logs in working_dir here and in collect-logs side as done for tempest, https://github.com/openstack/ansible-role-collect-logs/blob/67821d2c4992d129a0b59cbfefab08358f547577/tasks/publish.yml#L89\n\nWe need to copy stackviz and .html both at that place in collect_logs side.","commit_id":"5dc4d7efa94ff1c5d9e5582c2a73f5758f9e5bc3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"99a6f2e56171ea12ef35a2507224aa558465e11a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":21,"context_line":"    subunit2html {{ working_dir }}/tobiko/testrepository.subunit {{ working_dir }}/{{ tobiko_log_file }}.html"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"},{"line_number":25,"context_line":"    src: \"{{ working_dir }}/{{ tobiko_log_file }}.html\""},{"line_number":26,"context_line":"    dest: \"/var/log/extras/{{ tobiko_log_file }}.html\""},{"line_number":27,"context_line":"    flat: true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Fail if tobiko tests did not succeed"},{"line_number":30,"context_line":"  assert:"}],"source_content_type":"text/x-yaml","patch_set":59,"id":"5faad753_3c79a52e","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":14},"updated":"2019-09-10 09:06:12.000000000","message":"Sorry for the noise, it is actually not needed it is taken care by collect_logs https://github.com/openstack/tripleo-ci/blob/master/toci-quickstart/config/collect-logs.yml#L22-L28","commit_id":"5dc4d7efa94ff1c5d9e5582c2a73f5758f9e5bc3"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"92ead502b0283cda3f4cf42cfa21a05c649bb0de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check for .stestr directory"},{"line_number":3,"context_line":"  stat:"},{"line_number":4,"context_line":"    path: \"{{ working_dir }}/tobiko/.stestr\""},{"line_number":5,"context_line":"  register: testr_dir"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Define testr facts"},{"line_number":8,"context_line":"  set_fact:"},{"line_number":9,"context_line":"    testr_command: \"{{ python_cmd }} -m stestr.cli\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Generate testrepository.subunit results file"},{"line_number":12,"context_line":"  shell: \u003e"},{"line_number":13,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":14,"context_line":"    {{ testr_command }} last --subunit \u003e {{ working_dir }}/tobiko/testrepository.subunit"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: \"{{ working_dir }}/tobiko\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Generate HTML results file"},{"line_number":19,"context_line":"  shell: |"},{"line_number":20,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":21,"context_line":"    subunit2html {{ working_dir }}/tobiko/testrepository.subunit {{ working_dir }}/{{ tobiko_log_file }}.html"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":67,"id":"3fa7e38b_1289d0c8","line":21,"range":{"start_line":2,"start_character":0,"end_line":21,"end_character":109},"updated":"2019-10-11 05:27:28.000000000","message":"We can generate HTML and XML results by executing \u0027tox -e report\u0027.\nI suggest to put things together in below way when executing tobiko test cases:\n\n tox -e scenario,report \n\nThis should simplify CI playbooks.","commit_id":"3565c0ec5eaee96a0f9145592fa348c609407125"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e2cb14759ee74fac7d0376da876f86457017bb57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check for .stestr directory"},{"line_number":3,"context_line":"  stat:"},{"line_number":4,"context_line":"    path: \"{{ working_dir }}/tobiko/.stestr\""},{"line_number":5,"context_line":"  register: testr_dir"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Define testr facts"},{"line_number":8,"context_line":"  set_fact:"},{"line_number":9,"context_line":"    testr_command: \"{{ python_cmd }} -m stestr.cli\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Generate testrepository.subunit results file"},{"line_number":12,"context_line":"  shell: \u003e"},{"line_number":13,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":14,"context_line":"    {{ testr_command }} last --subunit \u003e {{ working_dir }}/tobiko/testrepository.subunit"},{"line_number":15,"context_line":"  args:"},{"line_number":16,"context_line":"    chdir: \"{{ working_dir }}/tobiko\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Generate HTML results file"},{"line_number":19,"context_line":"  shell: |"},{"line_number":20,"context_line":"    set -o pipefail \u0026\u0026"},{"line_number":21,"context_line":"    subunit2html {{ working_dir }}/tobiko/testrepository.subunit {{ working_dir }}/{{ tobiko_log_file }}.html"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Fetch HTML results"},{"line_number":24,"context_line":"  fetch:"}],"source_content_type":"text/x-yaml","patch_set":67,"id":"3fa7e38b_cb912954","line":21,"range":{"start_line":2,"start_character":0,"end_line":21,"end_character":109},"in_reply_to":"3fa7e38b_1289d0c8","updated":"2019-10-14 13:26:36.000000000","message":"I think that this can be maybe done as follow-up patch later","commit_id":"3565c0ec5eaee96a0f9145592fa348c609407125"}],"roles/validate-tobiko/templates/tobiko.conf.j2":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"0a008ad86db45cda29a18f77d196a0b6116d1262","unresolved":false,"context_lines":[{"line_number":15,"context_line":"user_domain_name \u003d \"{{ tobiko_user_domain_name }}\""},{"line_number":16,"context_line":"project_domain_name \u003d \"{{ tobiko_project_domain_name }}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[cirros]"},{"line_number":19,"context_line":"image_name \u003d \"{{ tobiko_image_name }}\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[nova]"},{"line_number":22,"context_line":"flavor \u003d \"{{ tobiko_flavor }}\""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"7faddb67_f68397c9","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":38},"updated":"2019-08-05 12:11:06.000000000","message":"This can be removed. Tobiko is able to fetch and create its own images.","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"0a008ad86db45cda29a18f77d196a0b6116d1262","unresolved":false,"context_lines":[{"line_number":19,"context_line":"image_name \u003d \"{{ tobiko_image_name }}\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[nova]"},{"line_number":22,"context_line":"flavor \u003d \"{{ tobiko_flavor }}\""},{"line_number":23,"context_line":"key_file \u003d \"{{ tobiko_key_file_name }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[neutron]"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"7faddb67_b6699f25","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":30},"updated":"2019-08-05 12:11:06.000000000","message":"This is no more required, neither supported.","commit_id":"3f2baac5d60600fd7accb7b7310db04ee6e80808"}]}