)]}'
{"roles/standalone/tasks/main.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"bcb3897d18b9253cb7b01aea1e8ba238b39ce757","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  lineinfile:"},{"line_number":42,"context_line":"    path: \"{{ working_dir }}/containers-prepare-parameters.yaml\""},{"line_number":43,"context_line":"    regexp: \"^      namespace:\""},{"line_number":44,"context_line":"    line: \"      namespace: {{ docker_registry_host }}/{{ docker_registry_namespace }}\""},{"line_number":45,"context_line":"    backup: true"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# update the container tag to match dlrn hash"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bfb3d3c7_ee35b4f8","line":44,"range":{"start_line":44,"start_character":17,"end_line":44,"end_character":26},"updated":"2019-05-20 13:52:51.000000000","message":"you can see this and the others at http://logs.openstack.org/94/659794/1/check/tripleo-ci-centos-7-standalone/ac2cdb4/logs/undercloud/home/zuul/containers-prepare-parameters.yaml.txt.gz and 6 whitespace seems right","commit_id":"f7bbd073162b9eac1be5a02322cf8c52487b1697"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0b17389012b40360caab733ae62189f98e5271fd","unresolved":false,"context_lines":[{"line_number":100,"context_line":"              push_destination: \"{{ local_docker_registry_host }}:8787\""},{"line_number":101,"context_line":"              modify_role: tripleo-modify-image"},{"line_number":102,"context_line":"              modify_append_tag: \"{{ update_containers_append_tag }}\""},{"line_number":103,"context_line":"              {%- if osp_release is not defined %}"},{"line_number":104,"context_line":"              modify_only_with_labels:"},{"line_number":105,"context_line":"              - kolla_version"},{"line_number":106,"context_line":"              {%- endif %}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bfb3d3c7_9b809fc1","line":103,"range":{"start_line":103,"start_character":20,"end_line":103,"end_character":49},"updated":"2019-05-24 08:02:42.000000000","message":"not 100% clear on this condition (and it isn\u0027t in the original)","commit_id":"0e74526d1568ee6fdb39afe308635bb2ace8b8f6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5c8d6f2fb1d88440c7989d272b198803ab5385b4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"              push_destination: \"{{ local_docker_registry_host }}:8787\""},{"line_number":101,"context_line":"              modify_role: tripleo-modify-image"},{"line_number":102,"context_line":"              modify_append_tag: \"{{ update_containers_append_tag }}\""},{"line_number":103,"context_line":"              {% if osp_release is defined -%}"},{"line_number":104,"context_line":"              # no kolla labels are defined"},{"line_number":105,"context_line":"              {% else -%}"},{"line_number":106,"context_line":"              modify_only_with_labels:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_a5ee87b1","line":103,"updated":"2019-05-27 09:27:31.000000000","message":"just noticed the -% \n\nit used to be on the opening tag i don\u0027t recall off hand if this matters (the whitespace strip thing with \u0027-\u0027)\nif we can see the output it would confirm... i think osp_release is a periodic only/from internal sf jobs?","commit_id":"b3a3d0427af94e0ada706bd4f50ae47477a54922"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"5c8d6f2fb1d88440c7989d272b198803ab5385b4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"              {% else -%}"},{"line_number":106,"context_line":"              modify_only_with_labels:"},{"line_number":107,"context_line":"              - kolla_version"},{"line_number":108,"context_line":"              {% endif -%}"},{"line_number":109,"context_line":"              modify_vars:"},{"line_number":110,"context_line":"                tasks_from: yum_update.yml"},{"line_number":111,"context_line":"                yum_repos_dir_path: /etc/yum.repos.d"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb3d3c7_a543e7ae","line":108,"updated":"2019-05-27 09:27:31.000000000","message":"this bit looks ok http://logs.openstack.org/94/659794/11/check/tripleo-ci-centos-7-standalone/b19ccb8/logs/undercloud/home/zuul/containers-prepare-parameters.yaml.txt.gz so perhaps the \u0027-\u0027 is ok on the closing }","commit_id":"b3a3d0427af94e0ada706bd4f50ae47477a54922"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"91a7f193463928420f4089d8452a92eb395bd0b1","unresolved":false,"context_lines":[{"line_number":114,"context_line":"- name: Modify the insecure registry value when using podman"},{"line_number":115,"context_line":"  when:"},{"line_number":116,"context_line":"    - standalone_container_prep_updates"},{"line_number":117,"context_line":"    - osp_release is defined"},{"line_number":118,"context_line":"    - release not in [\u0027newton\u0027, \u0027ocata\u0027, \u0027pike\u0027, \u0027queens\u0027, \u0027rocky\u0027]"},{"line_number":119,"context_line":"  replace:"},{"line_number":120,"context_line":"    path: \"{{ working_dir }}/standalone_parameters.yaml\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bfb3d3c7_41ed06b5","line":117,"range":{"start_line":117,"start_character":6,"end_line":117,"end_character":17},"updated":"2019-05-30 06:59:17.000000000","message":"so is this meant to fire downstream only?\n\nlooking at http://logs.openstack.org/94/659794/19/check/tripleo-ci-centos-7-standalone/0053ac1/logs/undercloud/home/zuul/containers-prepare-parameters.yaml.txt.gz \n\nlgtm but only one wasn\u0027t sure about is if we need that     push_destination: \"192.168.24.1:8787\" \nshould the 8787 have been pruned here (I think not cos of that osp_release)","commit_id":"28fa4f7ef293cf8813336bf38aac3b8aab12146d"},{"author":{"_account_id":9976,"name":"Ronelle Landy","email":"rlandy@redhat.com","username":"rlandy"},"change_message_id":"fe8532e38d1785658e0e2cc4091fbcdf24f2c450","unresolved":false,"context_lines":[{"line_number":114,"context_line":"- name: Modify the insecure registry value when using podman"},{"line_number":115,"context_line":"  when:"},{"line_number":116,"context_line":"    - standalone_container_prep_updates"},{"line_number":117,"context_line":"    - osp_release is defined"},{"line_number":118,"context_line":"    - release not in [\u0027newton\u0027, \u0027ocata\u0027, \u0027pike\u0027, \u0027queens\u0027, \u0027rocky\u0027]"},{"line_number":119,"context_line":"  replace:"},{"line_number":120,"context_line":"    path: \"{{ working_dir }}/standalone_parameters.yaml\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"bfb3d3c7_fd235d54","line":117,"range":{"start_line":117,"start_character":6,"end_line":117,"end_character":17},"in_reply_to":"bfb3d3c7_41ed06b5","updated":"2019-05-31 13:45:43.000000000","message":"It\u0027s a long story ... supposedly https://review.opendev.org/#/c/657961/ fixes something.\nwill have to touch base again on this one on monday","commit_id":"28fa4f7ef293cf8813336bf38aac3b8aab12146d"}]}