)]}'
{"playbooks/multinode-minion.yml":[{"author":{"_account_id":9592,"name":"wes hayutin","email":"whayutin@redhat.com","username":"weshayutin"},"change_message_id":"636ff13ea1e069b099bc18e25db5aad6192813f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"7faddb67_a771b578","line":5,"updated":"2019-07-30 20:46:11.000000000","message":"this is fine for now.. but we need tempest, can come later","commit_id":"89128aed0afc9de1dd345246c4f0eee824bb8055"}],"playbooks/multinode-undercloud-minion.yml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fd5922192b142eee0c56486390fc721e0c816138","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        tasks_from: package_installs"},{"line_number":46,"context_line":"      when: package_installs|default(true)|bool"},{"line_number":47,"context_line":"    - name: Update built packages"},{"line_number":48,"context_line":"      shell: \"{{ ansible_pkg_mgr }} --enablerepo\u003d\u0027gating-repo\u0027 update -y\""},{"line_number":49,"context_line":"      become: true"},{"line_number":50,"context_line":"      when: hostvars[\u0027undercloud\u0027][\u0027compressed_gating_repo\u0027] is defined"},{"line_number":51,"context_line":"    - name: Include hostname tasks"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"7faddb67_a118a975","line":48,"range":{"start_line":48,"start_character":49,"end_line":48,"end_character":61},"updated":"2019-08-01 04:13:55.000000000","message":"why not delorean-current? good to use the variable same var for this. or that is taken care elsewhere?","commit_id":"89128aed0afc9de1dd345246c4f0eee824bb8055"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4b291941822f65eca5bc5d7de805515c85b27389","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        tasks_from: package_installs"},{"line_number":46,"context_line":"      when: package_installs|default(true)|bool"},{"line_number":47,"context_line":"    - name: Update built packages"},{"line_number":48,"context_line":"      shell: \"{{ ansible_pkg_mgr }} --enablerepo\u003d\u0027gating-repo\u0027 update -y\""},{"line_number":49,"context_line":"      become: true"},{"line_number":50,"context_line":"      when: hostvars[\u0027undercloud\u0027][\u0027compressed_gating_repo\u0027] is defined"},{"line_number":51,"context_line":"    - name: Include hostname tasks"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"7faddb67_ebcf5a7c","line":48,"range":{"start_line":48,"start_character":49,"end_line":48,"end_character":61},"in_reply_to":"7faddb67_a118a975","updated":"2019-08-01 13:29:03.000000000","message":"gating-repo is the built packages not dlrn current.  I think i grabbed this from the build packages role in oooq. See tripleo-quickstart/roles/libvirt/setup/undercloud/templates/inject_gating_repo.sh.j2","commit_id":"89128aed0afc9de1dd345246c4f0eee824bb8055"}],"roles/undercloud-minion-deploy/README.md":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"610f63976ac7f1726377878ae92af70d914a1dec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"undercloud-minion-deploy"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"An Ansible role to execute the deployment of the tripleo undercloud minion"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-gfm","patch_set":21,"id":"9fb8cfa7_02efbbe9","line":2,"range":{"start_line":2,"start_character":24,"end_line":2,"end_character":42},"updated":"2019-06-18 20:58:44.000000000","message":"nit: this line extends a lot further than is needed.","commit_id":"0f139da9c6e8fac49e21c039c203b9c93dffad47"}],"roles/undercloud-minion-deploy/defaults/main.yml":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"5756a367f4ce0d6a637453238c5fa81bd2cb284f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"default_minion_roles_data_path: \"{{ minion_templates_path }}/roles_data_minion.yaml\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# We disable selinux when running under CentOS. It\u0027s enabled for RHEL"},{"line_number":44,"context_line":"minion_selinux_enabled: \u003e-"},{"line_number":45,"context_line":"   {% if ansible_distribution \u003d\u003d \u0027CentOS\u0027 -%}"},{"line_number":46,"context_line":"   false"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_b9d5dd1d","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":69},"updated":"2019-07-03 09:42:51.000000000","message":"I am wondering why we treat them differently. I would be inclined to have selinux enabled by default on both, it would ease testing and lower the chances of discovering bugs later.","commit_id":"0f139da9c6e8fac49e21c039c203b9c93dffad47"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"13ed1aa0239e0de6f43b88b257418a81a1089d4b","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"default_minion_roles_data_path: \"{{ minion_templates_path }}/roles_data_minion.yaml\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# We disable selinux when running under CentOS. It\u0027s enabled for RHEL"},{"line_number":44,"context_line":"minion_selinux_enabled: \u003e-"},{"line_number":45,"context_line":"   {% if ansible_distribution \u003d\u003d \u0027CentOS\u0027 -%}"},{"line_number":46,"context_line":"   false"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_0dc94359","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":69},"in_reply_to":"9fb8cfa7_b9d5dd1d","updated":"2019-07-03 13:18:46.000000000","message":"This is an upstream decision because we are downstream from the openstack-selinux package. We do not run selinux enabled upstream.","commit_id":"0f139da9c6e8fac49e21c039c203b9c93dffad47"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"610f63976ac7f1726377878ae92af70d914a1dec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"default_minion_roles_data_path: \"{{ minion_templates_path }}/roles_data_minion.yaml\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# We disable selinux when running under CentOS. It\u0027s enabled for RHEL"},{"line_number":44,"context_line":"minion_selinux_enabled: \u003e-"},{"line_number":45,"context_line":"   {% if ansible_distribution \u003d\u003d \u0027CentOS\u0027 -%}"},{"line_number":46,"context_line":"   false"},{"line_number":47,"context_line":"   {%- else -%}"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_c29f6363","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":22},"updated":"2019-06-18 20:58:44.000000000","message":"this could be simplified with something like \n\n  minion_selinux_enabled: \"{{ (ansible_distribution \u003d\u003d \u0027CentOS\u0027) | bool }}","commit_id":"0f139da9c6e8fac49e21c039c203b9c93dffad47"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"610f63976ac7f1726377878ae92af70d914a1dec","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   true"},{"line_number":49,"context_line":"   {%- endif -%}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"minion_container_cli: \u003e-"},{"line_number":52,"context_line":"   podman"},{"line_number":53,"context_line":"minion_healthcheck_disabled: false"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Define a custom t-h-t installation for UC"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"9fb8cfa7_82a96b91","line":52,"range":{"start_line":51,"start_character":21,"end_line":52,"end_character":9},"updated":"2019-06-18 20:58:44.000000000","message":"there\u0027s probably no need to have this be multiple lines","commit_id":"0f139da9c6e8fac49e21c039c203b9c93dffad47"}],"roles/undercloud-minion-deploy/templates/minion.conf.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"610f63976ac7f1726377878ae92af70d914a1dec","unresolved":false,"context_lines":[{"line_number":101,"context_line":"# portion of the value. (string value)"},{"line_number":102,"context_line":"#local_ip \u003d 192.168.24.50/24"},{"line_number":103,"context_line":"local_ip \u003d {{ minion_local_ip|default("},{"line_number":104,"context_line":"    \u0027%s/%s\u0027 % (undercloud_network_cidr|nthhost(4),"},{"line_number":105,"context_line":"    undercloud_network_cidr.split(\u0027/\u0027).1)) }}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"# MTU to use for the local_interface. (integer value)"},{"line_number":108,"context_line":"{% if minion_local_mtu is defined %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9fb8cfa7_22a8bf75","line":105,"range":{"start_line":104,"start_character":38,"end_line":105,"end_character":40},"updated":"2019-06-18 20:58:44.000000000","message":"I think this could be done using the built-in ipaddr filter. Maybe using the host/prefix argument - https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters_ipaddr.html#getting-information-from-host-prefix-values","commit_id":"0f139da9c6e8fac49e21c039c203b9c93dffad47"}]}