)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"fe0db1a7fa39645930d81aded186e8f8cfe09e87","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-26 22:33:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move os_tempest role var at playbook level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vars used under os_tempest role has lower precedence over"},{"line_number":10,"context_line":"vars used over playbook level leading to cause undefined"},{"line_number":11,"context_line":"var when python_venv_build handler runs leading to flushing"},{"line_number":12,"context_line":"all vars."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Move the os_tempest vars at playbook level fixes the same."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_92baebbd","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":9},"updated":"2019-07-26 18:33:41.000000000","message":"I am not sure this is the fix for your problem. I suspect you are using a set_fact inside the role and I would say, that that is the real bug.\n\nCan you also include link to the problematic code?","commit_id":"e8f410ff728f22b5463c510f17f52e717c3726c5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"740b8449734cc0ca532f3b95af66e29d60155a8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-26 22:33:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move os_tempest role var at playbook level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vars used under os_tempest role has lower precedence over"},{"line_number":10,"context_line":"vars used over playbook level leading to cause undefined"},{"line_number":11,"context_line":"var when python_venv_build handler runs leading to flushing"},{"line_number":12,"context_line":"all vars."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Move the os_tempest vars at playbook level fixes the same."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_d9d080cc","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":9},"in_reply_to":"7faddb67_92baebbd","updated":"2019-07-28 13:10:37.000000000","message":"Actually playbook vars have lower precedence: https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable\n\nso I\u0027d agree with Sorin here, seems like there is set_fact that is lower than role params, but higher than playbook ones.","commit_id":"e8f410ff728f22b5463c510f17f52e717c3726c5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f8779f7f96893cf7ec426ebc7b5cfec65f093f3c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-26 22:33:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move os_tempest role var at playbook level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vars used under os_tempest role has lower precedence over"},{"line_number":10,"context_line":"vars used over playbook level leading to cause undefined"},{"line_number":11,"context_line":"var when python_venv_build handler runs leading to flushing"},{"line_number":12,"context_line":"all vars."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Move the os_tempest vars at playbook level fixes the same."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_b2503960","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":9},"in_reply_to":"7faddb67_92baebbd","updated":"2019-07-29 06:25:15.000000000","message":"Added here is the issue, we are trying to solve http://logs.openstack.org/19/667219/5/check/tripleo-ci-centos-7-standalone/a34fc53/job-output.txt.gz#_2019-07-22_10_35_04_992828 and we also tried set_facts https://review.opendev.org/#/c/672231/ it is breaking osa jobs. As it is suggested to move the var at playbook level instead of role level.","commit_id":"e8f410ff728f22b5463c510f17f52e717c3726c5"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0dfeac5ab5185bce09c8c30571f177a19cfae920","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-26 22:33:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move os_tempest role var at playbook level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vars used under os_tempest role has lower precedence over"},{"line_number":10,"context_line":"vars used over playbook level leading to cause undefined"},{"line_number":11,"context_line":"var when python_venv_build handler runs leading to flushing"},{"line_number":12,"context_line":"all vars."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Move the os_tempest vars at playbook level fixes the same."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_b18585d1","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":9},"in_reply_to":"7faddb67_b2503960","updated":"2019-07-30 07:10:49.000000000","message":"reading the discussion at http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2019-07-26.log.html#t2019-07-26T16:50:35 i think this is not about precedence but that the var is simply out of scope/not defined\n\nChandan all this discussion really just tells me you need to file a bug for this with a proper description of the problem and point to it where you\u0027re putting the vars at the playbook level so that someone doesn\u0027t come and move them again without knowing why they\u0027re there.","commit_id":"e8f410ff728f22b5463c510f17f52e717c3726c5"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f8779f7f96893cf7ec426ebc7b5cfec65f093f3c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-26 22:33:10 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move os_tempest role var at playbook level"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Vars used under os_tempest role has lower precedence over"},{"line_number":10,"context_line":"vars used over playbook level leading to cause undefined"},{"line_number":11,"context_line":"var when python_venv_build handler runs leading to flushing"},{"line_number":12,"context_line":"all vars."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Move the os_tempest vars at playbook level fixes the same."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_32ca091a","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":9},"in_reply_to":"7faddb67_d9d080cc","updated":"2019-07-29 06:25:15.000000000","message":"But we are not using set_facts in os_tempest side, if we used it https://review.opendev.org/#/c/672231/ it looks like a hackish way we decided to move the stuff to var level\nhere is the discussion from OSA channel:http://eavesdrop.openstack.org/irclogs/%23openstack-ansible/%23openstack-ansible.2019-07-26.log.html#t2019-07-26T16:50:35","commit_id":"e8f410ff728f22b5463c510f17f52e717c3726c5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"71276ccc9a845252cfdeb151d8a7f8a4eb87397d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fixes the issue."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1.] https://opendev.org/openstack/ansible-role-python_venv_build/src/branch/master/handlers/main.yml#L16"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Below is the issue happens."},{"line_number":18,"context_line":"```"},{"line_number":19,"context_line":"RUNNING HANDLER [python_venv_build : venv changed]"},{"line_number":20,"context_line":"fatal: [undercloud]: FAILED! \u003d\u003e {}"},{"line_number":21,"context_line":"MSG:"},{"line_number":22,"context_line":"The conditional check \u0027tempest_install_method \u003d\u003d \u0027source\u0027\u0027 failed."},{"line_number":23,"context_line":"The error was: error while evaluating conditional"},{"line_number":24,"context_line":"(tempest_install_method \u003d\u003d \u0027source\u0027): \u0027tempest_install_method\u0027"},{"line_number":25,"context_line":"is undefined"},{"line_number":26,"context_line":"```"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I58082b307cb5b3f9ff908c29c8e24b9b970561de"},{"line_number":29,"context_line":"Signed-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_457a44ba","line":26,"range":{"start_line":16,"start_character":0,"end_line":26,"end_character":3},"updated":"2019-07-30 14:27:15.000000000","message":"I agree with Marios, this belongs to bugs in LP","commit_id":"796be9475d30465be9c96f3d9b491e57eb6f2212"}],"playbooks/multinode-standalone.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0dfeac5ab5185bce09c8c30571f177a19cfae920","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Validate the deployment"},{"line_number":50,"context_line":"  hosts: undercloud"},{"line_number":51,"context_line":"  # Note(chkumar246): Moved the os_tempest related var at task level"},{"line_number":52,"context_line":"  # as python_venv_build handler is triggered once the tempest run"},{"line_number":53,"context_line":"  # successfully finishes and it leads to tempest_install_method"},{"line_number":54,"context_line":"  # undefined variable, moving the var at task level allows the var"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_51f9b17d","line":51,"range":{"start_line":51,"start_character":58,"end_line":51,"end_character":62},"updated":"2019-07-30 07:10:49.000000000","message":"you mean \"playbook level\"\n\nReally you should file a bug and just point to that. This explanation belongs in the bug.","commit_id":"796be9475d30465be9c96f3d9b491e57eb6f2212"}],"playbooks/multinode-validate.yml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"0dfeac5ab5185bce09c8c30571f177a19cfae920","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Validate the deployment"},{"line_number":24,"context_line":"  hosts: undercloud"},{"line_number":25,"context_line":"  # Note(chkumar246): Moved the os_tempest related var at task level"},{"line_number":26,"context_line":"  # as python_venv_build handler is triggered once the tempest run"},{"line_number":27,"context_line":"  # successfully finishes and it leads to tempest_install_method"},{"line_number":28,"context_line":"  # undefined variable, moving the var at task level allows the var"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_f12d3dfd","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":66},"updated":"2019-07-30 07:10:49.000000000","message":"moved to *playbook* level. the point with adding a comment is to avoid confusion. Let\u0027s not add to it with nits :D","commit_id":"796be9475d30465be9c96f3d9b491e57eb6f2212"}]}