)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"74b8aaff7089a4a88ce838955da261e0262cd58d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-01-06 06:11:31 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add undercloud_enable_paunch parameter to standalone jobs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I25a22aacd2b9a675dfaddd651ddfaf6379017ecd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d80ef631","line":8,"updated":"2020-01-06 08:54:46.000000000","message":"cool story bro","commit_id":"971686d2f36dac8ea43b311744a3e5a6e09cc44c"}],"roles/standalone/templates/standalone_config.yaml.j2":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"8f27963b4f22f9780f6990a31ecd01f8dfe9b092","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  ControlPlaneStaticRoutes: []"},{"line_number":7,"context_line":"  Debug: true"},{"line_number":8,"context_line":"{% if undercloud_enable_paunch is defined %}"},{"line_number":9,"context_line":"  EnablePaunch: {{ undercloud_enable_paunch }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"  ConfigDebug: true"},{"line_number":12,"context_line":"  DeploymentUser: {{ undercloud_user }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_78902243","line":9,"updated":"2020-01-06 09:44:21.000000000","message":"do you want to force boolean in case the value is something else (e.g. from a bug) i just mean add \"|bool \"","commit_id":"aad21cf16eb483d5f3dbec8b7537c4ef31483bb2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"4138c9e167a83b559c4c99ac4a16f5e4de0690ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  ControlPlaneStaticRoutes: []"},{"line_number":7,"context_line":"  Debug: true"},{"line_number":8,"context_line":"{% if undercloud_enable_paunch is defined %}"},{"line_number":9,"context_line":"  EnablePaunch: {{ undercloud_enable_paunch }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"  ConfigDebug: true"},{"line_number":12,"context_line":"  DeploymentUser: {{ undercloud_user }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_78b902c9","line":9,"in_reply_to":"3fa7e38b_78902243","updated":"2020-01-06 09:47:35.000000000","message":"No, it should be a string here. \"|bool\" is used in ansible \"when\" conditions","commit_id":"aad21cf16eb483d5f3dbec8b7537c4ef31483bb2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"62aa31d85b1517965db80239591a7aa2dc36ba00","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  ControlPlaneStaticRoutes: []"},{"line_number":7,"context_line":"  Debug: true"},{"line_number":8,"context_line":"{% if undercloud_enable_paunch is defined %}"},{"line_number":9,"context_line":"  EnablePaunch: {{ undercloud_enable_paunch }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"  ConfigDebug: true"},{"line_number":12,"context_line":"  DeploymentUser: {{ undercloud_user }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_98bddeb3","line":9,"in_reply_to":"3fa7e38b_78b902c9","updated":"2020-01-06 09:49:39.000000000","message":"but the Heat type is bolean?./common/deploy-steps.j2:69:  EnablePaunch:\n./common/deploy-steps.j2-70-    default: true\n./common/deploy-steps.j2-71-    description: Whether to run paunch during container deployment tasks.\n./common/deploy-steps.j2-72-    type: boolean\n\nso we need this undercloud_enable_paunch to be a boolean like \u0027true\u0027 or \u0027false","commit_id":"aad21cf16eb483d5f3dbec8b7537c4ef31483bb2"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"32f59a13262098cb10709b975df95e635bfc52cf","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  ControlPlaneStaticRoutes: []"},{"line_number":7,"context_line":"  Debug: true"},{"line_number":8,"context_line":"{% if undercloud_enable_paunch is defined %}"},{"line_number":9,"context_line":"  EnablePaunch: {{ undercloud_enable_paunch }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"  ConfigDebug: true"},{"line_number":12,"context_line":"  DeploymentUser: {{ undercloud_user }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_d8ccb663","line":9,"in_reply_to":"3fa7e38b_98bddeb3","updated":"2020-01-06 09:53:05.000000000","message":"my point is , due to some bug the value of undercloud_enable_paunch is \"foobar\" ... that should fail if we do |bool?","commit_id":"aad21cf16eb483d5f3dbec8b7537c4ef31483bb2"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"248ad2e3945b2e59e670e164a4894c794454bb93","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  ControlPlaneStaticRoutes: []"},{"line_number":7,"context_line":"  Debug: true"},{"line_number":8,"context_line":"{% if undercloud_enable_paunch is defined %}"},{"line_number":9,"context_line":"  EnablePaunch: {{ undercloud_enable_paunch }}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"  ConfigDebug: true"},{"line_number":12,"context_line":"  DeploymentUser: {{ undercloud_user }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_585e8679","line":9,"in_reply_to":"3fa7e38b_d8ccb663","updated":"2020-01-06 10:01:02.000000000","message":"Yes, undercloud_enable_paunch should be either \"true\" or \"false\". It will fail of course if it\u0027s \"foobar\". \"|bool\" is used for ansible \"when\" conditions, it won\u0027t help here. The only way is to not to configure \"foobar\", like in all other cases here: https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/undercloud-deploy/templates/undercloud.conf.j2","commit_id":"aad21cf16eb483d5f3dbec8b7537c4ef31483bb2"}]}
